judges 0.0.20 → 0.0.22

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9e7ff33d6367a36af90626c45f6ba74195f2e5383bf5f6f30c2888e5ba02eb07
-  data.tar.gz: b8032fc55743542a488d478cb4eb4dab78b979c2aec60ad6fbbeca3c53eceb5f
+  metadata.gz: c7b4a80762cb37240925afe0778c87a829f891a4e5a3a3fb7f22ccc3802c1a3a
+  data.tar.gz: 914e85bda9dea1030a06fde8a635d1452ae73c0d3e736e8ef04164cd692df378
 SHA512:
-  metadata.gz: 02cb9fee069f3ed10bfad753df016b20b2e1736a66ad9ab633e309f5ae99d5e8445d92f4e909ac826bf95f6cf8b73f3eb2e07968cd38129738e918dcd8f972aa
-  data.tar.gz: a097276735f3a2f5226061f807c82cb97920aa3ad27e660dc9d7328489dab28692dd0a772a8529a078ffdcc175a145a059b1441206e9f8d9378751ed9b9e3b1c
+  metadata.gz: 2fb32730607a2b122391447f7bd371f9b1d318d4c6be50ae1bf2d3bcd46c80561ac1ebe792824909cfa8f7fbd4edda17404e41b2510b9ab25c750fcb34f836ef
+  data.tar.gz: 6f6fa5d67867c3f0abb8b54e65d59aedbfa607abde5ca1336505001d35c916c8a928a4228393c2d5d22e2a341ed09afb2c199057389a966ce1f07326b7444e13

data/bin/judges

@@ -29,7 +29,7 @@ require 'factbase'
 Encoding.default_external = Encoding::UTF_8
 Encoding.default_internal = Encoding::UTF_8
 
-ver = '0.0.20'
+ver = '0.0.22'
 
 include GLI::App
 
@@ -60,6 +60,8 @@ command :update do |c|
   c.flag([:o, :option], multiple: true, arg_name: '<key=value>')
   c.desc 'Maximum number of update cycles to run'
   c.flag([:'max-cycles'], default_value: 8, type: Integer)
+  c.desc 'Stay quiet even if some judges fail'
+  c.switch([:q, :quiet], default_value: false)
   c.action do |global, options, args|
     require_relative '../lib/judges/commands/update'
     Judges::Update.new(loog).run(options, args)
@@ -88,19 +90,28 @@ desc 'Print the factbase into a human-readable format (YAML, JSON, etc.)'
 command :print do |c|
   c.desc 'Output format (xml, json, or yaml)'
   c.flag([:format], default_value: 'yaml')
-  c.switch([:auto])
+  c.desc 'Generate output name of the file automatically'
+  c.switch([:auto], default_value: false)
   c.action do |global, options, args|
     require_relative '../lib/judges/commands/print'
     Judges::Print.new(loog).run(options, args)
   end
 end
 
+desc 'Inspect the factbase and print all its possible meta-data'
+command :inspect do |c|
+  c.action do |global, options, args|
+    require_relative '../lib/judges/commands/inspect'
+    Judges::Inspect.new(loog).run(options, args)
+  end
+end
+
 desc 'Run automated tests for all judges'
 command :test do |c|
   c.desc 'Name of the test pack to run'
   c.flag([:pack], multiple: true)
-  c.desc 'Fail if no judges tested?'
-  c.flag([:quiet], default_value: false)
+  c.desc 'Stay quiet even if some tests fail or simply no tests executed?'
+  c.switch([:quiet], default_value: false)
   c.action do |global, options, args|
     require_relative '../lib/judges/commands/test'
     Judges::Test.new(loog).run(options, args)

data/features/cli.feature

@@ -17,22 +17,22 @@ Feature: Simple Run
       n = $fb.insert
       n.kind = 'yes!'
     """
-    Then I run bin/judges with "--verbose update -o foo=1 -o bar=2 --max-cycles 3 . simple.fb"
+    Then I run bin/judges with "--verbose update --quiet -o foo=1 -o bar=2 --max-cycles 3 . simple.fb"
     Then Stdout contains "foo → "
     Then Stdout contains "bar → "
-    Then Stdout contains "1 judges processed"
+    Then Stdout contains "1 judge(s) processed"
     Then Stdout contains "Update finished in 3 cycles"
     And Exit code is zero
 
   Scenario: Simple test of a few judges
     Given I run bin/judges with "test ./fixtures"
     Then Stdout contains "👉 Testing"
-    Then Stdout contains "judges tested successfully"
+    Then Stdout contains "judge(s) tested successfully"
     And Exit code is zero
 
   Scenario: Simple test of just one pack
     Given I run bin/judges with "test --pack reward_for_good_bug ./fixtures"
-    Then Stdout contains "judges tested successfully"
+    Then Stdout contains "judge(s) tested successfully"
     And Exit code is zero
 
   Scenario: Simple test of no packs
@@ -64,3 +64,16 @@ Feature: Simple Run
     Then Stdout contains "printed"
     And Exit code is zero
 
+  Scenario: Simple inspect of a small factbase
+    Given I make a temp directory
+    Then I have a "simple/simple_judge.rb" file with content:
+    """
+      return if $fb.size > 2
+      n = $fb.insert
+      n.kind = 'yes!'
+    """
+    Then I run bin/judges with "update . simple.fb"
+    Then I run bin/judges with "inspect simple.fb"
+    Then Stdout contains "Facts: 3"
+    And Exit code is zero
+

data/judges.gemspec

@@ -26,7 +26,7 @@ Gem::Specification.new do |s|
   s.required_rubygems_version = Gem::Requirement.new('>= 0') if s.respond_to? :required_rubygems_version=
   s.required_ruby_version = '>=3.2'
   s.name = 'judges'
-  s.version = '0.0.20'
+  s.version = '0.0.22'
   s.license = 'MIT'
   s.summary = 'Command-Line Tool for a Factbase'
   s.description = '
@@ -42,7 +42,7 @@ Gem::Specification.new do |s|
   s.rdoc_options = ['--charset=UTF-8']
   s.extra_rdoc_files = ['README.md', 'LICENSE.txt']
   s.add_runtime_dependency 'backtrace', '~> 0.3'
-  s.add_runtime_dependency 'factbase', '~>0.0.17'
+  s.add_runtime_dependency 'factbase', '~>0.0.21'
   s.add_runtime_dependency 'gli', '~>2.21'
   s.add_runtime_dependency 'loog', '~>0.2'
   s.add_runtime_dependency 'nokogiri', '~> 1.10'

data/lib/judges/commands/inspect.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+# Copyright (c) 2024 Yegor Bugayenko
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the 'Software'), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in all
+# copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+# SOFTWARE.
+
+require_relative '../../judges'
+require_relative '../../judges/impex'
+
+# Inspect.
+# Author:: Yegor Bugayenko (yegor256@gmail.com)
+# Copyright:: Copyright (c) 2024 Yegor Bugayenko
+# License:: MIT
+class Judges::Inspect
+  def initialize(loog)
+    @loog = loog
+  end
+
+  def run(_opts, args)
+    raise 'At lease one argument required' if args.empty?
+    fb = Judges::Impex.new(@loog, args[0]).import
+    @loog.info("Facts: #{fb.size}")
+  end
+end

data/lib/judges/commands/print.rb

@@ -23,8 +23,7 @@
 require 'fileutils'
 require 'factbase'
 require_relative '../../judges'
-require_relative '../../judges/to_rel'
-require_relative '../../judges/packs'
+require_relative '../../judges/impex'
 
 # Update.
 # Author:: Yegor Bugayenko (yegor256@gmail.com)
@@ -37,17 +36,14 @@ class Judges::Print
 
   def run(opts, args)
     raise 'At lease one argument required' if args.empty?
-    f = args[0]
-    raise "The file is absent: #{f.to_rel}" unless File.exist?(f)
     o = args[1]
+    f = args[0]
+    fb = Judges::Impex.new(@loog, f).import
     if o.nil?
       raise 'Either provide output file name or use --auto' unless opts[:auto]
       o = File.join(File.dirname(f), File.basename(f).gsub(/\.[^.]*$/, ''))
       o = "#{o}.#{opts[:format]}"
     end
-    fb = Factbase.new
-    fb.import(File.binread(f))
-    @loog.info("Factbase imported from #{f.to_rel} (#{File.size(f)} bytes)")
     FileUtils.mkdir_p(File.dirname(o))
     output =
       case opts[:format].downcase

data/lib/judges/commands/test.rb

@@ -59,12 +59,14 @@ class Judges::Test
       end
       done += 1
     end
-    raise 'No judges tested :(' if done.zero? && !opts['quiet']
-    if errors.empty?
-      @loog.info("\nAll #{done} judges tested successfully")
+    if done.zero?
+      raise 'No judges tested :(' unless opts['quiet']
+      @loog.warn("\n👍 No judges tested")
+    elsif errors.empty?
+      @loog.info("\n👍 All #{done} judge(s) tested successfully")
     else
-      @loog.info("\n#{done} judges tested, #{errors.size} of them failed")
-      raise "#{errors.size} tests failed" unless errors.empty?
+      @loog.info("\n❌ #{done} judge(s) tested, #{errors.size} of them failed")
+      raise "#{errors.size} tests failed" unless opts['quiet']
     end
   end
 

data/lib/judges/commands/update.rb

@@ -67,7 +67,7 @@ class Judges::Update
     errors = []
     diff = 0
     done = packs.each_with_index do |p, i|
-      @loog.info("👍 Running #{p.name} (##{i}) at #{p.dir.to_rel}...")
+      @loog.info("👉 Running #{p.name} (##{i}) at #{p.dir.to_rel}...")
       before = fb.size
       begin
         p.run(fb, options)
@@ -76,11 +76,15 @@ class Judges::Update
         errors << p.script
       end
       after = fb.size
-      @loog.info("Pack #{p.dir.to_rel} added #{after - before} facts") if after > before
+      @loog.info("👍 Pack #{p.dir.to_rel} added #{after - before} facts") if after > before
       diff += after - before
     end
-    @loog.info("#{done} judges processed (#{errors.size} errors)")
-    raise "Failed to update correctly (#{errors.size} errors)" unless errors.empty?
+    if errors.empty?
+      @loog.info("👍 #{done} judge(s) processed")
+    else
+      @loog.info("❌ #{done} judge(s) processed with #{errors.size} errors")
+      raise "Failed to update correctly (#{errors.size} errors)" unless opts['quiet']
+    end
     impex.export(fb)
     diff
   end

data/lib/judges/fb/if_absent.rb

@@ -21,14 +21,24 @@
 # SOFTWARE.
 
 require 'judges'
+require 'time'
 
 # Injects a fact if it's absent in the factbase.
 def if_absent(fb)
   attrs = {}
   f = Judges::Accumulator.new(attrs)
   yield f
-  q = attrs.map { |k, v| "(eq #{k} '#{v}')" }.join(' ')
-  return unless fb.query("(and #{q})").each.to_a.empty?
+  q = attrs.map do |k, v|
+    vv = v.to_s
+    if v.is_a?(String)
+      vv = "'#{vv.gsub('"', '\\"').gsub("'", "\\'")}'"
+    elsif v.is_a?(Time)
+      vv = v.iso8601
+    end
+    "(eq #{k} #{vv})"
+  end.join(' ')
+  q = "(and #{q})"
+  return unless fb.query(q).each.to_a.empty?
   n = fb.insert
   attrs.each { |k, v| n.send("#{k}=", v) }
   n

data/test/commands/test_inspect.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+
+# Copyright (c) 2024 Yegor Bugayenko
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the 'Software'), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in all
+# copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+# SOFTWARE.
+
+require 'minitest/autorun'
+require 'loog'
+require 'factbase'
+require_relative '../../lib/judges'
+require_relative '../../lib/judges/commands/inspect'
+
+# Test.
+# Author:: Yegor Bugayenko (yegor256@gmail.com)
+# Copyright:: Copyright (c) 2024 Yegor Bugayenko
+# License:: MIT
+class TestInspect < Minitest::Test
+  def test_simple_inspect
+    Dir.mktmpdir do |d|
+      f = File.join(d, 'base.fb')
+      fb = Factbase.new
+      fb.insert
+      fb.insert
+      File.binwrite(f, fb.export)
+      loog = Loog::Buffer.new
+      Judges::Inspect.new(loog).run({}, [f])
+      assert(loog.to_s.include?('Facts: 2'))
+    end
+  end
+end

data/test/fb/test_if_absent.rb

@@ -23,6 +23,8 @@
 require 'minitest/autorun'
 require 'tmpdir'
 require 'factbase'
+require 'factbase/looged'
+require 'loog'
 require_relative '../../lib/judges'
 require_relative '../../lib/judges/fb/if_absent'
 
@@ -40,6 +42,16 @@ class TestIfAbsent < Minitest::Test
     assert(n.nil?)
   end
 
+  def test_ignores_with_time
+    fb = Factbase.new
+    t = Time.now
+    fb.insert.foo = t
+    n = if_absent(fb) do |f|
+      f.foo = t
+    end
+    assert(n.nil?)
+  end
+
   def test_injects
     fb = Factbase.new
     n = if_absent(fb) do |f|
@@ -47,4 +59,38 @@ class TestIfAbsent < Minitest::Test
     end
     assert_equal(42, n.foo)
   end
+
+  def test_complex_ignores
+    fb = Factbase.new
+    f1 = fb.insert
+    f1.foo = 'hello, "dude"!'
+    f1.abc = 42
+    t = Time.now
+    f1.z = t
+    f1.bar = 3.14
+    n = if_absent(fb) do |f|
+      f.foo = 'hello, "dude"!'
+      f.abc = 42
+      f.z = t
+      f.bar = 3.14
+    end
+    assert(n.nil?)
+  end
+
+  def test_complex_injects
+    fb = Factbase.new
+    f1 = fb.insert
+    f1.foo = 'hello, "dude"!'
+    f1.abc = 42
+    t = Time.now
+    f1.z = t
+    f1.bar = 3.14
+    n = if_absent(fb) do |f|
+      f.foo = 'hello, "dude"!'
+      f.abc = 42
+      f.z = t + 1
+      f.bar = 3.15
+    end
+    assert(!n.nil?)
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: judges
 version: !ruby/object:Gem::Version
-  version: 0.0.20
+  version: 0.0.22
 platform: ruby
 authors:
 - Yegor Bugayenko
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.0.17
+        version: 0.0.21
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.0.17
+        version: 0.0.21
 - !ruby/object:Gem::Dependency
   name: gli
   requirement: !ruby/object:Gem::Requirement
@@ -121,6 +121,7 @@ files:
 - fixtures/reward_for_good_bug/simple-reward.yml
 - judges.gemspec
 - lib/judges.rb
+- lib/judges/commands/inspect.rb
 - lib/judges/commands/join.rb
 - lib/judges/commands/print.rb
 - lib/judges/commands/test.rb
@@ -134,6 +135,7 @@ files:
 - lib/judges/packs.rb
 - lib/judges/to_rel.rb
 - renovate.json
+- test/commands/test_inspect.rb
 - test/commands/test_join.rb
 - test/commands/test_print.rb
 - test/commands/test_test.rb