jsonb_accessor 1.3.3 → 1.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f098f30fabf2c5bbbe39acaecc6487c84516837bb8f55ff1ecfcde0bdda24e2f
-  data.tar.gz: 9dd89e98ec2937007ca3a11794ad3c0b3d48f8510a8f2836e0a1276b9ba8d5e0
+  metadata.gz: b3b40b7c775b9275c1fe7b6f3f3a8c0b7988dcd995da1b5bd594d0c3469ca372
+  data.tar.gz: 68dcf83030c07a537adee9030fd0f209f276e1e80f118c2d3ecc982694be466b
 SHA512:
-  metadata.gz: 2f7ca35afa36d13d4907b7e81ccf9c380c9eba36d7a18c6b6a10a1dcc6e423096fd39ab7c69ef372d9a217a01f31530b271e2f5a72ed482be1faa4dcc43806ea
-  data.tar.gz: 7389bebb7a9f7d6d4fcbde9cecc339f8505ae5cda68a6dbdd0489f10bcb1172919c9bd60d8bddee9be9a1053867ba99eefafce0be7cbf0022a151f9207fac069
+  metadata.gz: 9a136d5a27d25f8ffb29e2f2f06ffb43417b91544836dda70dd40583786512d29d302251c39eb877772e382da5ef4af28afc970a31ae295b5d01933d5f5e33bd
+  data.tar.gz: 411147569acaf3f9052e4ccae17063b3b0eaeb00c2738933a520a635861b054889b31b534b8959ae5d38bc3f5709dc0c3ccc9b20f45cf0f1f066b0aa60469e77

data/.github/workflows/ci.yml

@@ -7,7 +7,21 @@ on:
     branches: ['**']
 
 jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v2
+
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: 2.7.2
+        bundler-cache: true
+    - name: Rubocop
+      run: bundle exec rubocop
+
   tests:
+    needs: lint
     services:
       db:
         image: postgres:9.4

data/CHANGELOG.md

@@ -1,6 +1,11 @@
 # Changelog
 ## [Unreleased]
 
+## [1.3.4] - 2022-02-02
+### Fixed
+
+- Bug fix: Raised ActiveModel::MissingAttributeError when model was initialized without the jsonb_accessor field [#145](https://github.com/madeintandem/jsonb_accessor/issues/145)
+
 ## [1.3.3] - 2022-01-29
 ### Fixed
 

data/lib/jsonb_accessor/attribute_query_methods.rb

@@ -11,13 +11,13 @@ module JsonbAccessor
 
       # <jsonb_attribute>_where scope
       klass.define_singleton_method "#{jsonb_attribute}_where" do |attributes|
-        store_key_attributes = ::JsonbAccessor::QueryHelper.convert_keys_to_store_keys(attributes, all.model.public_send(store_key_mapping_method_name))
+        store_key_attributes = ::JsonbAccessor::Helpers.convert_keys_to_store_keys(attributes, all.model.public_send(store_key_mapping_method_name))
         jsonb_where(jsonb_attribute, store_key_attributes)
       end
 
       # <jsonb_attribute>_where_not scope
       klass.define_singleton_method "#{jsonb_attribute}_where_not" do |attributes|
-        store_key_attributes = ::JsonbAccessor::QueryHelper.convert_keys_to_store_keys(attributes, all.model.public_send(store_key_mapping_method_name))
+        store_key_attributes = ::JsonbAccessor::Helpers.convert_keys_to_store_keys(attributes, all.model.public_send(store_key_mapping_method_name))
         jsonb_where_not(jsonb_attribute, store_key_attributes)
       end
 

data/lib/jsonb_accessor/helpers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module JsonbAccessor
   module Helpers
     module_function
@@ -5,5 +7,17 @@ module JsonbAccessor
     def active_record_default_timezone
       ActiveRecord.try(:default_timezone) || ActiveRecord::Base.default_timezone
     end
+
+    # Replaces all keys in `attributes` that have a defined store_key with the store_key
+    def convert_keys_to_store_keys(attributes, store_key_mapping)
+      attributes.stringify_keys.transform_keys do |key|
+        store_key_mapping[key] || key
+      end
+    end
+
+    # Replaces all keys in `attributes` that have a defined store_key with the named key (alias)
+    def convert_store_keys_to_keys(attributes, store_key_mapping)
+      convert_keys_to_store_keys(attributes, store_key_mapping.invert)
+    end
   end
 end

data/lib/jsonb_accessor/macro.rb

@@ -38,7 +38,7 @@ module JsonbAccessor
         end
 
         # Get store keys to default values mapping
-        store_keys_and_defaults = ::JsonbAccessor::QueryHelper.convert_keys_to_store_keys(names_and_defaults, public_send(store_key_mapping_method_name))
+        store_keys_and_defaults = ::JsonbAccessor::Helpers.convert_keys_to_store_keys(names_and_defaults, public_send(store_key_mapping_method_name))
 
         # Define jsonb_defaults_mapping_for_<jsonb_attribute>
         defaults_mapping_method_name = "jsonb_defaults_mapping_for_#{jsonb_attribute}"
@@ -83,11 +83,11 @@ module JsonbAccessor
             names_to_store_keys = self.class.public_send(store_key_mapping_method_name)
 
             # this is the raw hash we want to save in the jsonb_attribute
-            value_with_store_keys = ::JsonbAccessor::QueryHelper.convert_keys_to_store_keys(value, names_to_store_keys)
+            value_with_store_keys = ::JsonbAccessor::Helpers.convert_keys_to_store_keys(value, names_to_store_keys)
             write_attribute(jsonb_attribute, value_with_store_keys)
 
             # this maps attributes to values
-            value_with_named_keys = ::JsonbAccessor::QueryHelper.convert_store_keys_to_keys(value, names_to_store_keys)
+            value_with_named_keys = ::JsonbAccessor::Helpers.convert_store_keys_to_keys(value, names_to_store_keys)
 
             empty_named_attributes = names_to_store_keys.transform_values { nil }
             empty_named_attributes.merge(value_with_named_keys).each do |name, attribute_value|
@@ -103,7 +103,7 @@ module JsonbAccessor
 
         # Makes sure new objects have the appropriate values in their jsonb fields.
         after_initialize do
-          next unless jsonb_attribute
+          next unless has_attribute? jsonb_attribute
 
           jsonb_values = public_send(jsonb_attribute) || {}
           jsonb_values.each do |store_key, value|

data/lib/jsonb_accessor/query_helper.rb

@@ -57,18 +57,6 @@ module JsonbAccessor
         raise InvalidDirection, "`#{option}` is not a valid direction for ordering, only `asc` and `desc` are accepted" if ORDER_DIRECTIONS.exclude?(option)
       end
 
-      # Replaces all keys in `attributes` that have a defined store_key with the store_key
-      def convert_keys_to_store_keys(attributes, store_key_mapping)
-        attributes.stringify_keys.transform_keys do |key|
-          store_key_mapping[key] || key
-        end
-      end
-
-      # Replaces all keys in `attributes` that have a defined store_key with the named key (alias)
-      def convert_store_keys_to_keys(attributes, store_key_mapping)
-        convert_keys_to_store_keys(attributes, store_key_mapping.invert)
-      end
-
       def number_query_arguments?(arg)
         arg.is_a?(Hash) && arg.keys.map(&:to_s).all? { |key| NUMBER_OPERATORS.include?(key) }
       end

data/lib/jsonb_accessor/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module JsonbAccessor
-  VERSION = "1.3.3"
+  VERSION = "1.3.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: jsonb_accessor
 version: !ruby/object:Gem::Version
-  version: 1.3.3
+  version: 1.3.4
 platform: ruby
 authors:
 - Michael Crismali
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-01-29 00:00:00.000000000 Z
+date: 2022-02-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord