jsonapi_for_rails 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 794bfadafffbe093f0b1db6199da1a91ceaa8ed8
-  data.tar.gz: 84cc03b0fd7b33160d1cc5a4a90c35b0754fa7ca
+  metadata.gz: 3e3b34eaf013306f4520bd8beb8ec87594b0dd32
+  data.tar.gz: 5d4a449ef838869e77ac51dc9ee070728595d644
 SHA512:
-  metadata.gz: 6dc9c92dd8992facc8c92f845cd183da112115c0a878f0ce2f10930b73d7f3dbb04353dec5ef603378726222237cb11a3296f54bb31fc9481313d48d57f033e5
-  data.tar.gz: c971dcd15bc2bebb5cd19c139fbd12d79002fa3a6b7e56d972839324b32931918e250bda38ee969bafc3c5fe34f7ed02ca96e5b8166978a64d172c7b4fe0364c
+  metadata.gz: a423f57386943e320ac84399d33d6bc7e685d6bb5ca25f81644b9e91e2a82732e94dfbaef602f0f584ef0e48c17d30db656d6036e8caba3bde9e10cccf218c8c
+  data.tar.gz: ab6ad71dcc6713779f5a6f40be815d18c2847a241af3011524b743f2a226881d044720891ce9c2fbf2d17a99ae8ad6f8465b82a318503329af7048e4a54313c5

data/README.md

@@ -118,14 +118,14 @@ After populating your database and launching the built-in Rails server with the
 ```bash
 $ # Get the list of articles
 $ curl 'http://localhost:3000/api/v1/articles'
-{"data":[{"type":"articles","id":"184578894"},{"type":"articles","id":"388548390"},{"type":"articles","id":"618037523"},{"type":"articles","id":"994552601"}]}
+{"data":[{"type":"articles","id":"618037523"},{"type":"articles","id":"184578894"},{"type":"articles","id":"388548390"},{"type":"articles","id":"994552601"}]}
 $
 $ # Get an article
-$ curl 'http://localhost:3000/api/v1/articles/184578894'
+$ curl 'http://localhost:3000/api/v1/articles/618037523'
 {"data":{"type":"articles","id":"618037523","attributes":{"title":"UK bank pay and bonuses in the spotlight as results season starts","content":"The pay deals handed to the bosses of Britain’s biggest banks will be in focus this week ...","created_at":"2016-02-26T16:18:39.265Z","updated_at":"2016-02-26T16:18:39.265Z"},"relationships":{"author":{"data":{"type":"authors","id":"1023487079"}}}}}
 $
 $ # Get only the title and author of an article, include the author's name
-$ curl 'http://localhost:3000/api/v1/articles/184578894?filter%5Barticles%5D=title,author;include=author;filter%5Bauthors%5D=name'
+$ curl 'http://localhost:3000/api/v1/articles/618037523?filter%5Barticles%5D=title,author;include=author;filter%5Bauthors%5D=name'
 {"data":{"type":"articles","id":"618037523","attributes":{"title":"UK bank pay and bonuses in the spotlight as results season starts"},"relationships":{"author":{"data":{"type":"authors","id":"1023487079"}}}},"include":[{"data":{"type":"authors","id":"1023487079","attributes":{"name":"Jill ..."},"relationships":{}}}]}
 ```
 

data/lib/jsonapi_for_rails.rb

@@ -1,5 +1,4 @@
-
-# TODO: JSONAPI: id of resource object is a string
+# BUG: convert ids to strings in received data 
 # TODO: JSONAPI: adding optional members to documents ('jsonapi', 'meta')
 # TODO: JSONAPI: return conformant HTTP status codes
 # TODO: JSONAPI: conformant and rich 'errors' member
@@ -10,7 +9,6 @@
 # TODO: JSONAPI: Location header
 
 # TODO: README.md: double-check the installation instructions
-# TODO: README.md: better describe @jsonapi_relationship (what can it contain besides 'definition'?)
 # TODO: README.md: describe @jsonapi_include?
 # TODO: README.md: describe @jsonapi_sparse_fieldsets?
 

data/lib/jsonapi_for_rails/controller.rb

@@ -1,5 +1,6 @@
 require "jsonapi_for_rails/controller/utils/model"
 require "jsonapi_for_rails/controller/utils/render"
+require "jsonapi_for_rails/controller/before_actions/content_negotiation"
 require "jsonapi_for_rails/controller/before_actions/sparse_fieldsets"
 require "jsonapi_for_rails/controller/before_actions/include"
 require "jsonapi_for_rails/controller/before_actions/record"
@@ -21,6 +22,7 @@ module JsonapiForRails::Controller
 
 			include JsonapiForRails::Controller::Utils::Model
 			include JsonapiForRails::Controller::Utils::Render
+			include JsonapiForRails::Controller::BeforeActions::ContentNegotiation
 			include JsonapiForRails::Controller::BeforeActions::SparseFieldsets
 			include JsonapiForRails::Controller::BeforeActions::Include
 			include JsonapiForRails::Controller::BeforeActions::Record

data/lib/jsonapi_for_rails/controller/actions/object.rb

@@ -11,7 +11,6 @@ module JsonapiForRails::Controller
 				# TODO: pagination
 				def index
 					@json = {data: []}
-					@jsonapi_debug=[jsonapi_model_class,jsonapi_model_class.all]
 					jsonapi_model_class.all.each do |record|
 						@json[:data] << {
 							type: record.class.to_s.underscore.pluralize, # TODO: factor out type generation from class

data/lib/jsonapi_for_rails/controller/before_actions/content_negotiation.rb

@@ -0,0 +1,31 @@
+module JsonapiForRails::Controller
+
+	module BeforeActions
+		module ContentNegotiation
+
+			def self.included receiver
+				#$stderr.puts "JsonapiForRails::Controller::RecordFromRequest included into #{receiver}" 
+				receiver.send :include, InstanceMethods
+				run_macros receiver
+			end
+
+			def self.run_macros receiver
+				receiver.instance_exec do 
+					before_action :content_negotiation
+					private :content_negotiation
+				end
+			end
+
+			module InstanceMethods
+				def content_negotiation
+					#$stderr.puts "#{request.headers}" 
+					# TODO: content negotiation
+					return 
+					render_error 401, "Bad request."
+				end
+
+			end
+		end
+	end
+
+end

data/lib/jsonapi_for_rails/version.rb

@@ -1,6 +1,7 @@
 module JsonapiForRails
-  VERSION = '0.1.3'
+  VERSION = '0.1.4'
+  # 0.1.4: gem now requires rails >= 4 instead of 5.0.0.beta2
   # 0.1.3: fix non-string id bug (http://jsonapi.org/format/1.0/#document-resource-object-identification)
-  # 0.1.2: add ruby version dependency to gem
+  # 0.1.2: add ruby 2.0 dependency to gem
   # 0.1.1: fix @jsonapi_relationship[:params] bug, it is now set correctly
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: jsonapi_for_rails
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Doga Armangil
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-26 00:00:00.000000000 Z
+date: 2016-02-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -16,7 +16,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.0.0.beta2
+        version: 4.0.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '5.1'
@@ -26,7 +26,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.0.0.beta2
+        version: 4.0.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '5.1'
@@ -59,6 +59,7 @@ files:
 - lib/jsonapi_for_rails/controller.rb
 - lib/jsonapi_for_rails/controller/actions/object.rb
 - lib/jsonapi_for_rails/controller/actions/relationship.rb
+- lib/jsonapi_for_rails/controller/before_actions/content_negotiation.rb
 - lib/jsonapi_for_rails/controller/before_actions/include.rb
 - lib/jsonapi_for_rails/controller/before_actions/record.rb
 - lib/jsonapi_for_rails/controller/before_actions/relationship.rb