jsonapi_for_rails 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 93a2ddec3ac6ff246183b9687fc7b0bc7252503c
-  data.tar.gz: 20a759301147ae6b652ef7c5ba0d046b9c94c0cc
+  metadata.gz: 794bfadafffbe093f0b1db6199da1a91ceaa8ed8
+  data.tar.gz: 84cc03b0fd7b33160d1cc5a4a90c35b0754fa7ca
 SHA512:
-  metadata.gz: 2d9795ba3d003df4e7a2c403a4d2b7140e74f219eaae1e977c334c43af4b2dec8c4fa994c0697e2427cf852cb3210bcc60443418ce89570024c11e00bad7223a
-  data.tar.gz: beb93088916a4833d04f1996b7879b18223dd4439189a4c2b7cf4414a38dc72297b214ff9b2f0ce567592909a48848bcf4749d4cf7fcc3fd2ae39a3efec28059
+  metadata.gz: 6dc9c92dd8992facc8c92f845cd183da112115c0a878f0ce2f10930b73d7f3dbb04353dec5ef603378726222237cb11a3296f54bb31fc9481313d48d57f033e5
+  data.tar.gz: c971dcd15bc2bebb5cd19c139fbd12d79002fa3a6b7e56d972839324b32931918e250bda38ee969bafc3c5fe34f7ed02ca96e5b8166978a64d172c7b4fe0364c

data/README.md

@@ -118,16 +118,15 @@ After populating your database and launching the built-in Rails server with the
 ```bash
 $ # Get the list of articles
 $ curl 'http://localhost:3000/api/v1/articles'
-{"data":[{"type":"articles","id":184578894},{"type":"articles","id":388548390},{"type":"articles","id":618037523},{"type":"articles","id":994552601}]}
+{"data":[{"type":"articles","id":"184578894"},{"type":"articles","id":"388548390"},{"type":"articles","id":"618037523"},{"type":"articles","id":"994552601"}]}
 $
 $ # Get an article
 $ curl 'http://localhost:3000/api/v1/articles/184578894'
-{"data":{"type":"articles","id":618037523,"attributes":{"title":"UK bank pay and bonuses in the spotlight as results season starts","content":"The pay deals handed to the bosses of Britain’s biggest banks will be in focus ...","created_at":"2016-02-22T16:57:43.401Z","updated_at":"2016-02-22T16:57:43.401Z"},"relationships":{"author":{"data":{"type":"authors","id":1023487079}}}}}
+{"data":{"type":"articles","id":"618037523","attributes":{"title":"UK bank pay and bonuses in the spotlight as results season starts","content":"The pay deals handed to the bosses of Britain’s biggest banks will be in focus this week ...","created_at":"2016-02-26T16:18:39.265Z","updated_at":"2016-02-26T16:18:39.265Z"},"relationships":{"author":{"data":{"type":"authors","id":"1023487079"}}}}}
 $
 $ # Get only the title and author of an article, include the author's name
 $ curl 'http://localhost:3000/api/v1/articles/184578894?filter%5Barticles%5D=title,author;include=author;filter%5Bauthors%5D=name'
-{"data":{"type":"articles","id":618037523,"attributes":{"title":"UK bank pay and bonuses in the spotlight as results season starts"},"relationships":{"author":{"data":{"type":"authors","id":1023487079}}}},"include":[{"data":{"type":"authors","id":1023487079,"attributes":{"name":"..."},"relationships":{}}}]}
-
+{"data":{"type":"articles","id":"618037523","attributes":{"title":"UK bank pay and bonuses in the spotlight as results season starts"},"relationships":{"author":{"data":{"type":"authors","id":"1023487079"}}}},"include":[{"data":{"type":"authors","id":"1023487079","attributes":{"name":"Jill ..."},"relationships":{}}}]}
 ```
 
 ## Modifying the default API behaviour
@@ -215,8 +214,8 @@ class ArticlesController < JsonapiResourcesController
   def relationship_update
     # @jsonapi_relationship[:params] contains the parsed request body.
     # It is available for all relationship actions except relationship_show.
-    # @jsonapi_relationship[:params][:data] is a Hash for relationships 
-    # of type :to_one, and an Array for relationships of type :to_many.
+    # @jsonapi_relationship[:params][:data] behaves like a Hash for relationships of type :to_one,
+    # and as an Array for relationships of type :to_many.
     @jsonapi_relationship # => {:definition=>{...}, :params=>{"data"=>{"type"=>"authors", "id"=>"234455384"}}}
 
     # ...

data/lib/jsonapi_for_rails/controller/actions/object.rb

@@ -11,10 +11,11 @@ module JsonapiForRails::Controller
 				# TODO: pagination
 				def index
 					@json = {data: []}
+					@jsonapi_debug=[jsonapi_model_class,jsonapi_model_class.all]
 					jsonapi_model_class.all.each do |record|
 						@json[:data] << {
 							type: record.class.to_s.underscore.pluralize, # TODO: factor out type generation from class
-							id:   record.id
+							id:   record.id.to_s
 						}
 					end
 					render_json @json

data/lib/jsonapi_for_rails/controller/actions/relationship.rb

@@ -17,13 +17,13 @@ module JsonapiForRails::Controller
 					if @jsonapi_relationship[:definition][:type] == :to_one
 						@json = {
 							type: @jsonapi_relationship[:definition][:receiver][:type],
-							id:   rel.id
+							id:   rel.id.to_s
 						}
 					elsif @jsonapi_relationship[:definition][:type] == :to_many
 						@json = rel.collect do |r|
 							{
 								type: @jsonapi_relationship[:definition][:receiver][:type],
-								id:   r.id
+								id:   r.id.to_s
 							}
 						end
 					end

data/lib/jsonapi_for_rails/controller/before_actions/record.rb

@@ -21,8 +21,6 @@ module JsonapiForRails::Controller
 
 			module InstanceMethods
 				def jsonapi_require_record
-					#$stderr.puts "@jsonapi_sparse_fieldsets: #{@jsonapi_sparse_fieldsets.inspect}" 
-					#$stderr.puts "JsonapiForRails::Controller::RecordFromRequest#jsonapi_require_record called" 
 					if params[:relationship] 
 						# relationship action
 						@jsonapi_record = jsonapi_model_class.find_by_id params["#{jsonapi_model_class_name.underscore}_id"].to_i
@@ -40,7 +38,6 @@ module JsonapiForRails::Controller
 					end
 					#$stderr.puts "@jsonapi_record: #{@jsonapi_record.inspect}" 
 					return if @jsonapi_record
-
 					render_error 401, "Bad request."
 				end
 

data/lib/jsonapi_for_rails/model.rb

@@ -41,7 +41,7 @@ module JsonapiForRails::Model
 							#$stderr.puts "self.#{association.name}: #{record.class}" 
 							relationship[:data] << {
 								type: record.class.to_s.underscore.pluralize, # TODO: factor out type generation from class
-								id:   record.id
+								id:   record.id.to_s
 							}
 						end
 
@@ -58,7 +58,7 @@ module JsonapiForRails::Model
 						if record = self.send(association.name)
 							relationship[:data] = {
 								type: record.class.to_s.underscore.pluralize, # TODO: factor out type generation from class
-								id:   record.id
+								id:   record.id.to_s
 							}
 						end
 					end
@@ -73,7 +73,7 @@ module JsonapiForRails::Model
 =end
 					data: {
 						type:       jsonapi_model_type,
-						id:         self.id,
+						id:         self.id.to_s,
 
 						attributes: attrs,
 

data/lib/jsonapi_for_rails/version.rb

@@ -1,5 +1,6 @@
 module JsonapiForRails
-  VERSION = '0.1.2'
+  VERSION = '0.1.3'
+  # 0.1.3: fix non-string id bug (http://jsonapi.org/format/1.0/#document-resource-object-identification)
   # 0.1.2: add ruby version dependency to gem
   # 0.1.1: fix @jsonapi_relationship[:params] bug, it is now set correctly
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: jsonapi_for_rails
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Doga Armangil