jsonapi.rb 1.6.0 → 1.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dc1e0239230a7a14a008b6344be8857fccd4db574af564a9b49342842fcc316d
-  data.tar.gz: 16615a0a1e0bd8b6f0a84ae9f2adcc16005a16b6413577b3ee945fddb6ce90c5
+  metadata.gz: 07512bb6e4135e51e0f94a3399ec068e7aa53a13d6eb65b44f5c87be8e4310e4
+  data.tar.gz: 128306af20f37d9fb7563a9cbc30f88f68dc3f761783a02eb9db539886c67bc5
 SHA512:
-  metadata.gz: 2c65ee96100a9179205b0f8e220f4f42dc5cd0f03fb8c7c645cb1c70933f848e2e0fe11d600259f2001fe1a9d8760b821c4748009ee3451156e2b07a660df783
-  data.tar.gz: 26c49d61c04f3bc03eaee260137905886a421c31d6bb669c063eb4cca9bea15a77327a07e90eb63ede9bb4b0d5e4b153aa38eb6dd6167c2eeabf10a1d7fb8fd6
+  metadata.gz: 6658f11bc2501360cb8be91a05d14d427102905476cd1e0d2a020b1d9db36ce77857127090dc37f27dfb9292c187f3ad8028ea47ab8b26f06ffe7648276009fe
+  data.tar.gz: 2cfb89517aba924c3282d3f8f65a1281606407c0e11b97159ebab7b58c75dbf02fbf65962793a031b07e87e9e2cd90a31b87f6e5d0d54a91c769c0eed82e7088

data/README.md

@@ -290,6 +290,7 @@ class MyController < ActionController::Base
       render jsonapi: paginated
     end
   end
+
 end
 ```
 
@@ -306,6 +307,17 @@ use the `jsonapi_pagination_meta` method:
   end
 
 ```
+
+If you want to change the default number of items per page or define a custom logic to handle page size, use the
+`jsonapi_page_size` method:
+
+```ruby
+  def jsonapi_page_size(pagination_params)
+    per_page = pagination_params[:size].to_f.to_i
+    per_page = 30 if per_page > 30
+    per_page
+  end
+```
 ### Deserialization
 
 `JSONAPI::Deserialization` provides a helper to transform a `JSONAPI` document

data/lib/jsonapi/active_model_error_serializer.rb

@@ -3,9 +3,6 @@ require 'jsonapi/error_serializer'
 module JSONAPI
   # [ActiveModel::Errors] serializer
   class ActiveModelErrorSerializer < ErrorSerializer
-    set_id :object_id
-    set_type :error
-
     attribute :status do
       '422'
     end

data/lib/jsonapi/error_serializer.rb

@@ -5,7 +5,6 @@ module JSONAPI
   class ErrorSerializer
     include JSONAPI::Serializer
 
-    set_id :object_id
     set_type :error
 
     # Object/Hash attribute helpers.
@@ -15,6 +14,12 @@ module JSONAPI
       end
     end
 
+    # Overwrite the ID extraction method, to skip validations
+    #
+    # @return [NilClass]
+    def self.id_from_record(_record, _params)
+    end
+
     # Remap the root key to `errors`
     #
     # @return [Hash]

data/lib/jsonapi/pagination.rb

@@ -43,6 +43,8 @@ module JSONAPI
       original_url = request.base_url + request.path + '?'
 
       pagination.each do |page_name, number|
+        next if page_name == :records
+
         original_params[:page][:number] = number
         links[page_name] = original_url + CGI.unescape(
           original_params.to_query
@@ -63,7 +65,7 @@ module JSONAPI
       numbers = { current: page }
 
       if resources.respond_to?(:unscope)
-        total = resources.unscope(:limit, :offset, :order).count()
+        total = resources.unscope(:limit, :offset, :order).size
       else
         # Try to fetch the cached size first
         total = resources.instance_variable_get(:@original_size)
@@ -82,6 +84,10 @@ module JSONAPI
         numbers[:last] = last_page
       end
 
+      if total.present?
+        numbers[:records] = total
+      end
+
       numbers
     end
 
@@ -89,16 +95,30 @@ module JSONAPI
     #
     # @return [Array] with the offset, limit and the current page number
     def jsonapi_pagination_params
-      def_per_page = self.class.const_get(:JSONAPI_PAGE_SIZE).to_i
-
       pagination = params[:page].try(:slice, :number, :size) || {}
-      per_page = pagination[:size].to_f.to_i
-      per_page = def_per_page if per_page > def_per_page || per_page < 1
+      per_page = jsonapi_page_size(pagination)
       num = [1, pagination[:number].to_f.to_i].max
 
       [(num - 1) * per_page, per_page, num]
     end
 
+    # Retrieves the default page size
+    #
+    # @param per_page_param [Hash] opts the paginations params
+    # @option opts [String] :number the page number requested
+    # @option opts [String] :size the page size requested
+    #
+    # @return [Integer]
+    def jsonapi_page_size(pagination_params)
+      per_page = pagination_params[:size].to_f.to_i
+
+      return self.class
+              .const_get(:JSONAPI_PAGE_SIZE)
+              .to_i if per_page < 1
+
+      per_page
+    end
+
     # Fallback to Rack's parsed query string when Rails is not available
     #
     # @return [Hash]

data/lib/jsonapi/rails.rb

@@ -55,8 +55,18 @@ module JSONAPI
           model_serializer = JSONAPI::Rails.serializer_class(model, false)
         end
 
-        details = resource.messages
-        details = resource.details if resource.respond_to?(:details)
+        details = {}
+        if ::Rails::VERSION::MAJOR >= 6 && ::Rails::VERSION::MINOR >= 1
+          resource.map do |error|
+            attr = error.attribute
+            details[attr] ||= []
+            details[attr] << error.detail.merge(message: error.message)
+          end
+        elsif resource.respond_to?(:details)
+          details = resource.details
+        else
+          details = resource.messages
+        end
 
         details.each do |error_key, error_hashes|
           error_hashes.each do |error_hash|

data/lib/jsonapi/version.rb

@@ -1,3 +1,3 @@
 module JSONAPI
-  VERSION = '1.6.0'
+  VERSION = '1.7.0'
 end

data/spec/deserialization_spec.rb

@@ -0,0 +1,87 @@
+require 'spec_helper'
+
+RSpec.describe JSONAPI::Deserialization do
+  let(:jsonapi_deserialize) { UsersController.new.method(:jsonapi_deserialize) }
+  let(:document) do
+    {
+      data: {
+        id: 1,
+        type: 'note',
+        attributes: {
+          title: 'Title 1',
+          date: '2015-12-20'
+        },
+        relationships: {
+          author: {
+            data: {
+              type: 'user',
+              id: 2
+            }
+          },
+          second_author: {
+            data: nil
+          },
+          notes: {
+            data: [
+              {
+                type: 'note',
+                id: 3
+              },
+              {
+                type: 'note',
+                id: 4
+              }
+            ]
+          }
+        }
+      }
+    }
+  end
+
+  describe '#jsonapi_deserialize' do
+    it do
+      expect(jsonapi_deserialize.call(document)).to eq(
+        'id' => 1,
+        'date' => '2015-12-20',
+        'title' => 'Title 1',
+        'author_id' => 2,
+        'second_author_id' => nil,
+        'note_ids' => [3, 4]
+      )
+    end
+
+    context 'with `only`' do
+      it do
+        expect(jsonapi_deserialize.call(document, only: :notes)).to eq(
+          'note_ids' => [3, 4]
+        )
+      end
+    end
+
+    context 'with `except`' do
+      it do
+        expect(
+          jsonapi_deserialize.call(document, except: [:date, :title])
+        ).to eq(
+          'id' => 1,
+          'author_id' => 2,
+          'second_author_id' => nil,
+          'note_ids' => [3, 4]
+        )
+      end
+    end
+
+    context 'with `polymorphic`' do
+      it do
+        expect(
+          jsonapi_deserialize.call(
+            document, only: :author, polymorphic: :author
+          )
+        ).to eq(
+          'author_id' => 2,
+          'author_type' => User.name
+        )
+      end
+    end
+  end
+end

data/spec/dummy.rb

@@ -0,0 +1,163 @@
+require 'securerandom'
+require 'active_record'
+require 'action_controller/railtie'
+require 'jsonapi'
+require 'ransack'
+
+Rails.logger = Logger.new(STDOUT)
+Rails.logger.level = ENV['LOG_LEVEL'] || Logger::WARN
+
+JSONAPI::Rails.install!
+
+ActiveRecord::Base.logger = Rails.logger
+ActiveRecord::Base.establish_connection(
+  ENV['DATABASE_URL'] || 'sqlite3::memory:'
+)
+
+ActiveRecord::Schema.define do
+  create_table :users, force: true do |t|
+    t.string :first_name
+    t.string :last_name
+    t.timestamps
+  end
+
+  create_table :notes, force: true do |t|
+    t.string :title
+    t.integer :user_id
+    t.integer :quantity
+    t.timestamps
+  end
+end
+
+class User < ActiveRecord::Base
+  has_many :notes
+end
+
+class Note < ActiveRecord::Base
+  validates_format_of :title, without: /BAD_TITLE/
+  validates_numericality_of :quantity, less_than: 100, if: :quantity?
+  belongs_to :user, required: true
+end
+
+class CustomNoteSerializer
+  include JSONAPI::Serializer
+
+  set_type :note
+  belongs_to :user
+  attributes(:title, :quantity, :created_at, :updated_at)
+end
+
+class UserSerializer
+  include JSONAPI::Serializer
+
+  has_many :notes, serializer: CustomNoteSerializer
+  attributes(:last_name, :created_at, :updated_at)
+
+  attribute :first_name do |object, params|
+    if params[:first_name_upcase]
+      object.first_name.upcase
+    else
+      object.first_name
+    end
+  end
+end
+
+class Dummy < Rails::Application
+  secrets.secret_key_base = '_'
+  config.hosts << 'www.example.com' if config.respond_to?(:hosts)
+
+  routes.draw do
+    scope defaults: { format: :jsonapi } do
+      resources :users, only: [:index]
+      resources :notes, only: [:update]
+    end
+  end
+end
+
+class UsersController < ActionController::Base
+  include JSONAPI::Fetching
+  include JSONAPI::Filtering
+  include JSONAPI::Pagination
+  include JSONAPI::Deserialization
+
+  def index
+    allowed_fields = [
+      :first_name, :last_name, :created_at,
+      :notes_created_at, :notes_quantity
+    ]
+    options = { sort_with_expressions: true }
+
+    jsonapi_filter(User.all, allowed_fields, options) do |filtered|
+      result = filtered.result
+
+      if params[:sort].to_s.include?('notes_quantity')
+        render jsonapi: result.group('id').to_a
+        return
+      end
+
+      result = result.to_a if params[:as_list]
+
+      jsonapi_paginate(result) do |paginated|
+        render jsonapi: paginated
+      end
+    end
+  end
+
+  private
+  def jsonapi_meta(resources)
+    {
+      many: true,
+      pagination: jsonapi_pagination_meta(resources)
+    }
+  end
+
+  def jsonapi_serializer_params
+    {
+      first_name_upcase: params[:upcase]
+    }
+  end
+end
+
+class NotesController < ActionController::Base
+  include JSONAPI::Errors
+  include JSONAPI::Deserialization
+
+  def update
+    raise_error! if params[:id] == 'tada'
+
+    note = Note.find(params[:id])
+
+    if note.update(note_params)
+      render jsonapi: note
+    else
+      note.errors.add(:title, message: 'has typos') if note.errors.key?(:title)
+
+      render jsonapi_errors: note.errors, status: :unprocessable_entity
+    end
+  end
+
+  private
+  def render_jsonapi_internal_server_error(exception)
+    Rails.logger.error(exception)
+    super(exception)
+  end
+
+  def jsonapi_serializer_class(resource, is_collection)
+    JSONAPI::Rails.serializer_class(resource, is_collection)
+  rescue NameError
+    klass = resource.class
+    klass = resource.first.class if is_collection
+    "Custom#{klass.name}Serializer".constantize
+  end
+
+  def note_params
+    # Will trigger required attribute error handling
+    params.require(:data).require(:attributes).require(:title)
+
+    jsonapi_deserialize(params)
+  end
+
+  def jsonapi_meta(resources)
+    { single: true }
+  end
+end

data/spec/errors_spec.rb

@@ -0,0 +1,168 @@
+require 'spec_helper'
+
+RSpec.describe NotesController, type: :request do
+  describe 'PUT /notes/:id' do
+    let(:note) { create_note }
+    let(:note_id) { note.id }
+    let(:user) { note.user }
+    let(:user_id) { user.id }
+    let(:note_params) do
+      {
+        data: {
+          attributes: { title: FFaker::Company.name },
+          relationships: { user: { data: { id: user_id } } }
+        }
+      }
+    end
+    let(:params) { note_params }
+
+    before do
+      put(note_path(note_id), params: params.to_json, headers: jsonapi_headers)
+    end
+
+    it do
+      expect(response).to have_http_status(:ok)
+      expect(response_json['data']).to have_id(note.id.to_s)
+      expect(response_json['meta']).to eq('single' => true)
+    end
+
+    context 'with a missing parameter in the payload' do
+      let(:params) { {} }
+
+      it do
+        expect(response).to have_http_status(:unprocessable_entity)
+        expect(response_json['errors'].size).to eq(1)
+        expect(response_json['errors'][0]['status']).to eq('422')
+        expect(response_json['errors'][0]['title'])
+          .to eq(Rack::Utils::HTTP_STATUS_CODES[422])
+        expect(response_json['errors'][0]['source']).to eq('pointer' => '')
+        expect(response_json['errors'][0]['detail']).to be_nil
+      end
+    end
+
+    context 'with an invalid payload' do
+      let(:params) do
+        payload = note_params.dup
+        payload[:data][:relationships][:user][:data][:id] = nil
+        payload
+      end
+
+      it do
+        expect(response).to have_http_status(:unprocessable_entity)
+        expect(response_json['errors'].size).to eq(1)
+        expect(response_json['errors'][0]['status']).to eq('422')
+        expect(response_json['errors'][0]['code']).to include('blank')
+        expect(response_json['errors'][0]['title'])
+          .to eq(Rack::Utils::HTTP_STATUS_CODES[422])
+        expect(response_json['errors'][0]['source'])
+          .to eq('pointer' => '/data/relationships/user')
+        if Rails::VERSION::MAJOR >= 6 && Rails::VERSION::MINOR >= 1
+          expect(response_json['errors'][0]['detail'])
+            .to eq('User must exist')
+        else
+          expect(response_json['errors'][0]['detail'])
+            .to eq('User can\'t be blank')
+        end
+      end
+
+      context 'required by validations' do
+        let(:params) do
+          payload = note_params.dup
+          payload[:data][:attributes][:title] = 'BAD_TITLE'
+          payload[:data][:attributes][:quantity] = 100 + rand(10)
+          payload
+        end
+
+        it do
+          expect(response).to have_http_status(:unprocessable_entity)
+          expect(response_json['errors'].size).to eq(3)
+          expect(response_json['errors'][0]['status']).to eq('422')
+          expect(response_json['errors'][0]['code']).to include('invalid')
+          expect(response_json['errors'][0]['title'])
+            .to eq(Rack::Utils::HTTP_STATUS_CODES[422])
+          expect(response_json['errors'][0]['source'])
+              .to eq('pointer' => '/data/attributes/title')
+          expect(response_json['errors'][0]['detail'])
+            .to eq('Title is invalid')
+
+          expect(response_json['errors'][1]['status']).to eq('422')
+
+          if Rails::VERSION::MAJOR >= 5
+            expect(response_json['errors'][1]['code']).to eq('invalid')
+          else
+            expect(response_json['errors'][1]['code']).to eq('has_typos')
+          end
+
+          expect(response_json['errors'][1]['title'])
+            .to eq(Rack::Utils::HTTP_STATUS_CODES[422])
+          expect(response_json['errors'][1]['source'])
+            .to eq('pointer' => '/data/attributes/title')
+          expect(response_json['errors'][1]['detail'])
+            .to eq('Title has typos')
+
+          expect(response_json['errors'][2]['status']).to eq('422')
+
+          if Rails::VERSION::MAJOR >= 5
+            expect(response_json['errors'][2]['code']).to eq('less_than')
+          else
+            expect(response_json['errors'][2]['code'])
+              .to eq('must_be_less_than_100')
+          end
+
+          expect(response_json['errors'][2]['title'])
+            .to eq(Rack::Utils::HTTP_STATUS_CODES[422])
+          expect(response_json['errors'][2]['source'])
+            .to eq('pointer' => '/data/attributes/quantity')
+          expect(response_json['errors'][2]['detail'])
+            .to eq('Quantity must be less than 100')
+        end
+      end
+
+      context 'as a param attribute' do
+        let(:params) do
+          payload = note_params.dup
+          payload[:data][:attributes].delete(:title)
+          # To have any attribtues in the payload...
+          payload[:data][:attributes][:created_at] = nil
+          payload
+        end
+
+        it do
+          expect(response).to have_http_status(:unprocessable_entity)
+          expect(response_json['errors'][0]['source'])
+            .to eq('pointer' => '/data/attributes/title')
+        end
+      end
+    end
+
+    context 'with a bad note ID' do
+      let(:user_id) { nil }
+      let(:note_id) { rand(10) }
+
+      it do
+        expect(response).to have_http_status(:not_found)
+        expect(response_json['errors'].size).to eq(1)
+        expect(response_json['errors'][0]['status']).to eq('404')
+        expect(response_json['errors'][0]['title'])
+          .to eq(Rack::Utils::HTTP_STATUS_CODES[404])
+        expect(response_json['errors'][0]['source']).to be_nil
+        expect(response_json['errors'][0]['detail']).to be_nil
+      end
+    end
+
+    context 'with an exception' do
+      let(:user_id) { nil }
+      let(:note_id) { 'tada' }
+
+      it do
+        expect(response).to have_http_status(:internal_server_error)
+        expect(response_json['errors'].size).to eq(1)
+        expect(response_json['errors'][0]['status']).to eq('500')
+        expect(response_json['errors'][0]['title'])
+          .to eq(Rack::Utils::HTTP_STATUS_CODES[500])
+        expect(response_json['errors'][0]['source']).to be_nil
+        expect(response_json['errors'][0]['detail']).to be_nil
+      end
+    end
+  end
+end