jsonapi-serializers 0.6.2 → 0.6.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 22bd1a0e4edb6afa842b9aea4e12083b376b2c3a
-  data.tar.gz: fb1c32bdf48825ffbc32db8078c6daf1c7c31f5d
+  metadata.gz: 6e720f6b16c3cb7ac850907d34061333a89ebc82
+  data.tar.gz: 2702a9fc740389ea33fcecaf09693b66265ec4ff
 SHA512:
-  metadata.gz: 3fb9216808ac7835e95dde7a428bc1af161d4940d72ed67737a864294777894249cbbb405e3e544a6104b798db3d6728dbc1cd163bb29bddf283bf6c438536d2
-  data.tar.gz: fee4e082f317e1cb3486829dbdfad8016834299b39e290e664e27fdd91d0914e7a246ae43ffa0bd875d773013a91bb3f2105d7563dda3e50bb24dcd906c6320c
+  metadata.gz: 9a0fe500512489e94bc37fd9782eb47a0b00caea5cd9af124b8553db8984c1ca7cb16ea28cf3d34420065296b78a68ae0409bcd4c6af1d165a1136986f669320
+  data.tar.gz: b89771e54eb2e45615b6c1c7dfeca693398aec729c27822276842a683cf7f3e5af7f6e4da89f947302983242ca0a69afc3caa387ecf0a3b13af1f03859d21157

data/README.md

@@ -652,6 +652,8 @@ end
 
 ## Release notes
 
+* v0.6.3: Fix support for underscore-formatted attribute names.
+* v0.6.2: Internal style updates and performance fixes.
 * v0.6.1: Spec compliance fix, include intermediate resources on compound documents.
 * v0.6.0: Support for polymorphic collections and inheriting serializer attributes.
 * v0.5.0: Support for explicit serializer discovery.

data/lib/jsonapi-serializers/serializer.rb

@@ -385,7 +385,7 @@ module JSONAPI
             "'#{attribute_name}' is not a valid include.")
         end
 
-        if attribute_name.include?('_')
+        if attribute_name != serializer.format_name(attribute_name)
           expected_name = serializer.format_name(attribute_name)
 
           raise JSONAPI::Serializer::InvalidIncludeError.new(

data/lib/jsonapi-serializers/version.rb

@@ -1,5 +1,5 @@
 module JSONAPI
   module Serializer
-    VERSION = '0.6.2'
+    VERSION = '0.6.3'
   end
 end

data/spec/serializer_spec.rb

@@ -847,4 +847,24 @@ describe JSONAPI::Serializer do
       })
     end
   end
+
+  describe 'include validation' do
+    it 'raises an exception when join character is invalid' do
+      expect do
+        JSONAPI::Serializer.serialize(create(:post), include: 'long_comments');
+      end.to raise_error(JSONAPI::Serializer::InvalidIncludeError)
+
+      expect do
+        JSONAPI::Serializer.serialize(create(:post), include: 'long-comments');
+      end.not_to raise_error
+
+      expect do
+        JSONAPI::Serializer.serialize(create(:underscore_test), include: 'tagged-posts');
+      end.to raise_error(JSONAPI::Serializer::InvalidIncludeError)
+
+      expect do
+        JSONAPI::Serializer.serialize(create(:underscore_test), include: 'tagged_posts');
+      end.not_to raise_error
+    end
+  end
 end

data/spec/support/factory.rb

@@ -36,4 +36,9 @@ FactoryGirl.define do
     sequence(:id) {|n| n }
     sequence(:name) {|n| "User ##{n}"}
   end
+
+  factory :underscore_test, class: MyApp::UnderscoreTest do
+    skip_create
+    sequence(:id) {|n| n }
+  end
 end

data/spec/support/serializers.rb

@@ -32,6 +32,14 @@ module MyApp
     end
   end
 
+  class UnderscoreTest
+    attr_accessor :id
+
+    def tagged_posts
+      []
+    end
+  end
+
   class PostSerializer
     include JSONAPI::Serializer
 
@@ -44,6 +52,16 @@ module MyApp
     has_many :long_comments
   end
 
+  class UnderscoreTestSerializer
+    include JSONAPI::Serializer
+
+    has_many :tagged_posts
+
+    def format_name(attribute_name)
+      attribute_name.to_s.underscore
+    end
+  end
+
   class LongCommentSerializer
     include JSONAPI::Serializer
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: jsonapi-serializers
 version: !ruby/object:Gem::Version
-  version: 0.6.2
+  version: 0.6.3
 platform: ruby
 authors:
 - Mike Fotinakis