jsonapi-resources 0.5.2 → 0.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 50581a29495af11bb597deb7c7ca7369eb084b77
-  data.tar.gz: 07aff054fd599cfa81fd11c3934900cce12f2317
+  metadata.gz: 1484af26137219f05b85088a8ffcdf07c7bfd4d3
+  data.tar.gz: 3b8441b43cab89ec1701343027d9308d8a9c523d
 SHA512:
-  metadata.gz: 626ce6b524027111ef04fed7988313018cb9daa9eda844bf2a05b7cd5b7acf8b45c0dd213aafbeb13dff473a50180037c434a5715092bb624801e3cca1cc5e06
-  data.tar.gz: e08ff693bb02c582ff4685d209c0fee6e7d5fbd0dce21a6b43b614103d4d98ae0c2eba60ae63eafda808d79ef02b10e18faf2d38b81b978e65fd5ec6b8e14328
+  metadata.gz: a900be54a2ba2b6d3d4bba35e845960f50f4fae790a7b89168100419d1bb3451437acfd2700f5cbc309c52432e4980f059fc72eef628e9cbeaa19af7c66d8885
+  data.tar.gz: 9698bf894815ee7b0a261bb7985c0cdf93a33083a1b640728cdbf7ad4850d1daca2ec3d5cfca2abe7635888a3a58e7e4c375f3c58877179ef2a07b6961c85a6d

data/lib/jsonapi/request.rb

@@ -104,7 +104,7 @@ module JSONAPI
     def setup_update_action(params)
       parse_fields(params[:fields])
       parse_include_directives(params[:include])
-      parse_replace_operation(params.require(:data), params.require(:id))
+      parse_replace_operation(params.require(:data), params[:id])
     end
 
     def setup_destroy_action(params)
@@ -563,7 +563,7 @@ module JSONAPI
       end
     end
 
-    def parse_single_replace_operation(data, keys)
+    def parse_single_replace_operation(data, keys, id_key_presence_check_required: true)
       fail JSONAPI::Exceptions::MissingKey.new if data[:id].nil?
 
       type = data[:type]
@@ -572,7 +572,7 @@ module JSONAPI
       end
 
       key = data[:id]
-      unless keys.include?(key)
+      if id_key_presence_check_required && !keys.include?(key)
         fail JSONAPI::Exceptions::KeyNotIncludedInURL.new(key)
       end
 
@@ -596,7 +596,8 @@ module JSONAPI
           parse_single_replace_operation(object_params, keys)
         end
       else
-        parse_single_replace_operation(data, [keys])
+        parse_single_replace_operation(data, [keys],
+                                       id_key_presence_check_required: keys.present?)
       end
 
     rescue JSONAPI::Exceptions::Error => e

data/lib/jsonapi/resources/version.rb

@@ -1,5 +1,5 @@
 module JSONAPI
   module Resources
-    VERSION = '0.5.2'
+    VERSION = '0.5.3'
   end
 end

data/test/controllers/controller_test.rb

@@ -2100,6 +2100,18 @@ class Api::V2::PreferencesControllerTest < ActionController::TestCase
     get :show
     assert_response :success
   end
+
+  def test_update_singleton_resource_without_id
+    set_content_type_header!
+    patch :update,
+      data: {
+        id: "1",
+        type: "preferences",
+        attributes: {
+        }
+      }
+    assert_response :success
+  end
 end
 
 class Api::V1::PostsControllerTest < ActionController::TestCase

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: jsonapi-resources
 version: !ruby/object:Gem::Version
-  version: 0.5.2
+  version: 0.5.3
 platform: ruby
 authors:
 - Dan Gebhardt
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-28 00:00:00.000000000 Z
+date: 2015-07-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler