jsonapi-resources 0.3.3 → 0.4.0

data/test/integration/routes/routes_test.rb

@@ -18,37 +18,37 @@ class RoutesTest < ActionDispatch::IntegrationTest
   end
 
   def test_routing_posts_links_author_show
-    assert_routing({path: '/posts/1/links/author', method: :get},
+    assert_routing({path: '/posts/1/relationships/author', method: :get},
                    {controller: 'posts', action: 'show_association', post_id: '1', association: 'author'})
   end
 
   def test_routing_posts_links_author_destroy
-    assert_routing({path: '/posts/1/links/author', method: :delete},
+    assert_routing({path: '/posts/1/relationships/author', method: :delete},
                    {controller: 'posts', action: 'destroy_association', post_id: '1', association: 'author'})
   end
 
   def test_routing_posts_links_author_update
-    assert_routing({path: '/posts/1/links/author', method: :patch},
+    assert_routing({path: '/posts/1/relationships/author', method: :patch},
                    {controller: 'posts', action: 'update_association', post_id: '1', association: 'author'})
   end
 
   def test_routing_posts_links_tags_show
-    assert_routing({path: '/posts/1/links/tags', method: :get},
+    assert_routing({path: '/posts/1/relationships/tags', method: :get},
                    {controller: 'posts', action: 'show_association', post_id: '1', association: 'tags'})
   end
 
   def test_routing_posts_links_tags_destroy
-    assert_routing({path: '/posts/1/links/tags/1,2', method: :delete},
+    assert_routing({path: '/posts/1/relationships/tags/1,2', method: :delete},
                    {controller: 'posts', action: 'destroy_association', post_id: '1', keys: '1,2', association: 'tags'})
   end
 
   def test_routing_posts_links_tags_create
-    assert_routing({path: '/posts/1/links/tags', method: :post},
+    assert_routing({path: '/posts/1/relationships/tags', method: :post},
                    {controller: 'posts', action: 'create_association', post_id: '1', association: 'tags'})
   end
 
   def test_routing_posts_links_tags_update_acts_as_set
-    assert_routing({path: '/posts/1/links/tags', method: :patch},
+    assert_routing({path: '/posts/1/relationships/tags', method: :patch},
                    {controller: 'posts', action: 'update_association', post_id: '1', association: 'tags'})
   end
 
@@ -64,13 +64,13 @@ class RoutesTest < ActionDispatch::IntegrationTest
   end
 
   def test_routing_v1_posts_links_writer_show
-    assert_routing({path: '/api/v1/posts/1/links/writer', method: :get},
+    assert_routing({path: '/api/v1/posts/1/relationships/writer', method: :get},
                    {controller: 'api/v1/posts', action: 'show_association', post_id: '1', association: 'writer'})
   end
 
   # V2
   def test_routing_v2_posts_links_author_show
-    assert_routing({path: '/api/v2/posts/1/links/author', method: :get},
+    assert_routing({path: '/api/v2/posts/1/relationships/author', method: :get},
                    {controller: 'api/v2/posts', action: 'show_association', post_id: '1', association: 'author'})
   end
 
@@ -93,14 +93,14 @@ class RoutesTest < ActionDispatch::IntegrationTest
 
   def test_routing_v4_isoCurrencies_resources
     assert_routing({path: '/api/v4/isoCurrencies/USD', method: :get},
-                   {action: 'show', controller: 'api/v4/iso_currencies', code: 'USD'})
+                   {action: 'show', controller: 'api/v4/iso_currencies', id: 'USD'})
   end
 
   def test_routing_v4_expenseEntries_resources
     assert_routing({path: '/api/v4/expenseEntries/1', method: :get},
                    {action: 'show', controller: 'api/v4/expense_entries', id: '1'})
 
-    assert_routing({path: '/api/v4/expenseEntries/1/links/isoCurrency', method: :get},
+    assert_routing({path: '/api/v4/expenseEntries/1/relationships/isoCurrency', method: :get},
                    {controller: 'api/v4/expense_entries', action: 'show_association', expense_entry_id: '1', association: 'iso_currency'})
   end
 
@@ -112,14 +112,14 @@ class RoutesTest < ActionDispatch::IntegrationTest
 
   def test_routing_v5_isoCurrencies_resources
     assert_routing({path: '/api/v5/iso-currencies/USD', method: :get},
-                   {action: 'show', controller: 'api/v5/iso_currencies', code: 'USD'})
+                   {action: 'show', controller: 'api/v5/iso_currencies', id: 'USD'})
   end
 
   def test_routing_v5_expenseEntries_resources
     assert_routing({path: '/api/v5/expense-entries/1', method: :get},
                    {action: 'show', controller: 'api/v5/expense_entries', id: '1'})
 
-    assert_routing({path: '/api/v5/expense-entries/1/links/iso-currency', method: :get},
+    assert_routing({path: '/api/v5/expense-entries/1/relationships/iso-currency', method: :get},
                    {controller: 'api/v5/expense_entries', action: 'show_association', expense_entry_id: '1', association: 'iso_currency'})
   end
 
@@ -129,14 +129,14 @@ class RoutesTest < ActionDispatch::IntegrationTest
   end
 
   def test_routing_author_links_posts_create_not_acts_as_set
-    assert_routing({path: '/api/v5/authors/1/links/posts', method: :post},
+    assert_routing({path: '/api/v5/authors/1/relationships/posts', method: :post},
                    {controller: 'api/v5/authors', action: 'create_association', author_id: '1', association: 'posts'})
   end
 
   #primary_key
   def test_routing_primary_key_jsonapi_resources
     assert_routing({path: '/iso_currencies/USD', method: :get},
-                   {action: 'show', controller: 'iso_currencies', code: 'USD'})
+                   {action: 'show', controller: 'iso_currencies', id: 'USD'})
   end
 
   # ToDo: Refute routing
@@ -146,12 +146,12 @@ class RoutesTest < ActionDispatch::IntegrationTest
   # end
 
   # def test_routing_posts_links_author_except_destroy
-  #   assert_routing({ path: '/api/v3/posts/1/links/author', method: :delete },
+  #   assert_routing({ path: '/api/v3/posts/1/relationships/author', method: :delete },
   #                  { controller: 'api/v3/posts', action: 'destroy_association', post_id: '1', association: 'author' })
   # end
   #
   # def test_routing_posts_links_tags_only_create_show
-  #   assert_routing({ path: '/api/v3/posts/1/links/tags/1,2', method: :delete },
+  #   assert_routing({ path: '/api/v3/posts/1/relationships/tags/1,2', method: :delete },
   #                  { controller: 'api/v3/posts', action: 'destroy_association', post_id: '1', keys: '1,2', association: 'tags' })
   # end
 

data/test/test_helper.rb

@@ -57,6 +57,16 @@ if Rails::VERSION::MAJOR >= 4 && Rails::VERSION::MINOR < 1
   end
 end
 
+def count_queries(&block)
+  @query_count = 0
+  ActiveSupport::Notifications.subscribe('sql.active_record') do
+    @query_count = @query_count + 1
+  end
+  yield block
+  ActiveSupport::Notifications.unsubscribe('sql.active_record')
+  @query_count
+end
+
 TestApp.initialize!
 
 require File.expand_path('../fixtures/active_record', __FILE__)
@@ -78,6 +88,7 @@ TestApp.routes.draw do
   jsonapi_resources :moons
   jsonapi_resources :preferences
   jsonapi_resources :facts
+  jsonapi_resources :categories
 
   namespace :api do
     namespace :v1 do
@@ -131,6 +142,8 @@ TestApp.routes.draw do
 
       jsonapi_resources :iso_currencies do
       end
+
+      jsonapi_resources :books
     end
 
     JSONAPI.configuration.route_format = :dasherized_route
@@ -160,6 +173,10 @@ TestApp.routes.draw do
       jsonapi_resources :purchase_orders
       jsonapi_resources :line_items
     end
+
+    namespace :v8 do
+      jsonapi_resources :numeros_telefone
+    end
   end
 end
 
@@ -199,7 +216,7 @@ end
 
 class DateWithTimezoneValueFormatter < JSONAPI::ValueFormatter
   class << self
-    def format(raw_value, context)
+    def format(raw_value)
       raw_value.in_time_zone('Eastern Time (US & Canada)').to_s
     end
   end
@@ -207,7 +224,7 @@ end
 
 class DateValueFormatter < JSONAPI::ValueFormatter
   class << self
-    def format(raw_value, context)
+    def format(raw_value)
       raw_value.strftime('%m/%d/%Y')
     end
   end
@@ -215,12 +232,13 @@ end
 
 class TitleValueFormatter < JSONAPI::ValueFormatter
   class << self
-    def format(raw_value, source)
-      super(raw_value, source).titlecase
+    def format(raw_value)
+      super(raw_value).titlecase
     end
 
-    def unformat(value, context)
+    def unformat(value)
       value.to_s.downcase
     end
   end
 end
+

data/test/unit/jsonapi_request/jsonapi_request_test.rb

@@ -1,5 +1,16 @@
 require File.expand_path('../../../test_helper', __FILE__)
 
+class CatResource < JSONAPI::Resource
+  attribute :id
+  attribute :name
+  attribute :breed
+
+  has_one :mother, class_name: 'Cat'
+  has_one :father, class_name: 'Cat'
+
+  filters :name
+end
+
 class JSONAPIRequestTest < ActiveSupport::TestCase
   def test_parse_includes_underscored
     params = ActionController::Parameters.new(
@@ -149,4 +160,41 @@ class JSONAPIRequestTest < ActiveSupport::TestCase
     refute request.errors.empty?
     assert_equal 'expense_entries is not a valid resource.', request.errors[0].detail
   end
+
+  def test_parse_filters_with_valid_filters
+    setup_request
+    @request.parse_filters({name: 'Whiskers'})
+    assert_equal(@request.filters[:name], 'Whiskers')
+    assert_equal(@request.errors, [])
+  end
+
+  def test_parse_filters_with_non_valid_filter
+    setup_request
+    @request.parse_filters({breed: 'Whiskers'}) # breed is not a set filter
+    assert_equal(@request.filters, {})
+    assert_equal(@request.errors.count, 1)
+    assert_equal(@request.errors.first.title, "Filter not allowed")
+  end
+
+  def test_parse_filters_with_no_filters
+    setup_request
+    @request.parse_filters(nil)
+    assert_equal(@request.filters, {})
+    assert_equal(@request.errors, [])
+  end
+
+  def test_parse_filters_with_invalid_filters_param
+    setup_request
+    @request.parse_filters('noeach') # String does not implement #each
+    assert_equal(@request.filters, {})
+    assert_equal(@request.errors.count, 1)
+    assert_equal(@request.errors.first.title, "Invalid filters syntax")
+  end
+
+  private
+
+  def setup_request
+    @request = JSONAPI::Request.new
+    @request.resource_klass = CatResource
+  end
 end

data/test/unit/operation/operations_processor_test.rb

@@ -1,9 +1,5 @@
 require File.expand_path('../../../test_helper', __FILE__)
 
-require 'jsonapi/operation'
-require 'jsonapi/operation_result'
-require 'jsonapi/operations_processor'
-
 class TestOperationsProcessor < JSONAPI::OperationsProcessor
   before_operation :log_before_operation
 
@@ -68,18 +64,17 @@ class OperationsProcessorTest < Minitest::Test
     count = Planet.count
 
     operations = [
-      JSONAPI::CreateResourceOperation.new(PlanetResource, {attributes: {'name' => 'earth', 'description' => 'The best planet ever.'}})
+      JSONAPI::CreateResourceOperation.new(PlanetResource, data: {attributes: {'name' => 'earth', 'description' => 'The best planet ever.'}})
     ]
 
     request = JSONAPI::Request.new
     request.operations = operations
 
-    results = op.process(request)
+    operation_results = op.process(request)
 
-    assert_kind_of(Array, results)
-    assert_kind_of(JSONAPI::OperationResult, results[0])
-    assert_equal(:created, results[0].code)
-    assert_equal(results.size, 1)
+    assert_kind_of(JSONAPI::OperationResults, operation_results)
+    assert_equal(:created, operation_results.results[0].code)
+    assert_equal(operation_results.results.size, 1)
     assert_equal(Planet.count, count + 1)
   end
 
@@ -89,18 +84,18 @@ class OperationsProcessorTest < Minitest::Test
     count = Planet.count
 
     operations = [
-      JSONAPI::CreateResourceOperation.new(PlanetResource, {attributes: {'name' => 'earth', 'description' => 'The best planet for life.'}}),
-      JSONAPI::CreateResourceOperation.new(PlanetResource, {attributes: {'name' => 'mars', 'description' => 'The red planet.'}}),
-      JSONAPI::CreateResourceOperation.new(PlanetResource, {attributes: {'name' => 'venus', 'description' => 'A very hot planet.'}})
+      JSONAPI::CreateResourceOperation.new(PlanetResource, data: {attributes: {'name' => 'earth', 'description' => 'The best planet for life.'}}),
+      JSONAPI::CreateResourceOperation.new(PlanetResource, data: {attributes: {'name' => 'mars', 'description' => 'The red planet.'}}),
+      JSONAPI::CreateResourceOperation.new(PlanetResource, data: {attributes: {'name' => 'venus', 'description' => 'A very hot planet.'}})
     ]
 
     request = JSONAPI::Request.new
     request.operations = operations
 
-    results = op.process(request)
+    operation_results = op.process(request)
 
-    assert_kind_of(Array, results)
-    assert_equal(results.size, 3)
+    assert_kind_of(JSONAPI::OperationResults, operation_results)
+    assert_equal(operation_results.results.size, 3)
     assert_equal(Planet.count, count + 3)
   end
 
@@ -113,42 +108,63 @@ class OperationsProcessorTest < Minitest::Test
     assert_equal(saturn.planet_type_id, planetoid.id)
 
     operations = [
-      JSONAPI::ReplaceHasOneAssociationOperation.new(PlanetResource, saturn.id, :planet_type, gas_giant.id)
+      JSONAPI::ReplaceHasOneAssociationOperation.new(
+        PlanetResource,
+        {
+          resource_id: saturn.id,
+          association_type: :planet_type,
+          key_value: gas_giant.id
+        }
+      )
     ]
 
     request = JSONAPI::Request.new
     request.operations = operations
 
-    results = op.process(request)
+    operation_results = op.process(request)
 
-    assert_kind_of(Array, results)
-    assert_kind_of(JSONAPI::OperationResult, results[0])
-    assert_equal(:no_content, results[0].code)
+    assert_kind_of(JSONAPI::OperationResults, operation_results)
+    assert_kind_of(JSONAPI::OperationResult, operation_results.results[0])
+    assert_equal(:no_content, operation_results.results[0].code)
 
     saturn.reload
     assert_equal(saturn.planet_type_id, gas_giant.id)
 
     # Remove link
     operations = [
-      JSONAPI::ReplaceHasOneAssociationOperation.new(PlanetResource, saturn.id, :planet_type, nil)
+      JSONAPI::ReplaceHasOneAssociationOperation.new(
+        PlanetResource,
+        {
+          resource_id: saturn.id,
+          association_type: :planet_type,
+          key_value: nil
+        }
+      )
     ]
 
     request = JSONAPI::Request.new
     request.operations = operations
 
-    results = op.process(request)
+    op.process(request)
     saturn.reload
     assert_equal(saturn.planet_type_id, nil)
 
     # Reset
     operations = [
-      JSONAPI::ReplaceHasOneAssociationOperation.new(PlanetResource, saturn.id, :planet_type, 5)
+      JSONAPI::ReplaceHasOneAssociationOperation.new(
+        PlanetResource,
+        {
+          resource_id: saturn.id,
+          association_type: :planet_type,
+          key_value: 5
+        }
+      )
     ]
 
     request = JSONAPI::Request.new
     request.operations = operations
 
-    results = op.process(request)
+    op.process(request)
     saturn.reload
     assert_equal(saturn.planet_type_id, 5)
   end
@@ -169,13 +185,20 @@ class OperationsProcessorTest < Minitest::Test
     betaz.save!
 
     operations = [
-      JSONAPI::CreateHasManyAssociationOperation.new(PlanetTypeResource, gas_giant.id, :planets, [betax.id, betay.id, betaz.id])
+      JSONAPI::CreateHasManyAssociationOperation.new(
+        PlanetTypeResource,
+        {
+          resource_id: gas_giant.id,
+          association_type: :planets,
+          data: [betax.id, betay.id, betaz.id]
+        }
+      )
     ]
 
     request = JSONAPI::Request.new
     request.operations = operations
 
-    results = op.process(request)
+    op.process(request)
 
     betax.reload
     betay.reload
@@ -210,13 +233,20 @@ class OperationsProcessorTest < Minitest::Test
     betaz.save!
 
     operations = [
-      JSONAPI::ReplaceHasManyAssociationOperation.new(PlanetTypeResource, gas_giant.id, :planets, [betax.id, betay.id, betaz.id])
+      JSONAPI::ReplaceHasManyAssociationOperation.new(
+        PlanetTypeResource,
+        {
+          resource_id: gas_giant.id,
+          association_type: :planets,
+          data: [betax.id, betay.id, betaz.id]
+        }
+      )
     ]
 
     request = JSONAPI::Request.new
     request.operations = operations
 
-    results = op.process(request)
+    op.process(request)
 
     betax.reload
     betay.reload
@@ -243,19 +273,25 @@ class OperationsProcessorTest < Minitest::Test
     assert_equal(saturn.name, 'Satern')
 
     operations = [
-      JSONAPI::ReplaceFieldsOperation.new(PlanetResource, 1, {attributes: {'name' => 'saturn'}}),
+      JSONAPI::ReplaceFieldsOperation.new(
+        PlanetResource,
+        {
+          resource_id: 1,
+          data: {attributes: {'name' => 'saturn'}}
+        }
+      )
     ]
 
     request = JSONAPI::Request.new
     request.operations = operations
 
-    results = op.process(request)
+    operation_results = op.process(request)
 
-    assert_kind_of(Array, results)
-    assert_equal(results.size, 1)
+    assert_kind_of(JSONAPI::OperationResults, operation_results)
+    assert_equal(operation_results.results.size, 1)
 
-    assert_kind_of(JSONAPI::OperationResult, results[0])
-    assert_equal(:ok, results[0].code)
+    assert_kind_of(JSONAPI::ResourceOperationResult, operation_results.results[0])
+    assert_equal(:ok, operation_results.results[0].code)
 
     saturn = Planet.find(1)
 
@@ -268,51 +304,203 @@ class OperationsProcessorTest < Minitest::Test
     op = JSONAPI::OperationsProcessor.new
 
     count = Planet.count
-    pluto = Planet.find(2)
-    assert_equal(pluto.name, 'Pluto')
+    makemake = Planet.find(2)
+    assert_equal(makemake.name, 'Makemake')
 
     operations = [
-      JSONAPI::RemoveResourceOperation.new(PlanetResource, 2),
+      JSONAPI::RemoveResourceOperation.new(PlanetResource, resource_id: 2),
     ]
 
     request = JSONAPI::Request.new
     request.operations = operations
 
-    results = op.process(request)
+    operation_results = op.process(request)
 
-    assert_kind_of(Array, results)
-    assert_equal(results.size, 1)
+    assert_kind_of(JSONAPI::OperationResults, operation_results)
+    assert_equal(operation_results.results.size, 1)
 
-    assert_kind_of(JSONAPI::OperationResult, results[0])
-    assert_equal(:no_content, results[0].code)
+    assert_kind_of(JSONAPI::OperationResult, operation_results.results[0])
+    assert_equal(:no_content, operation_results.results[0].code)
     assert_equal(Planet.count, count - 1)
   end
 
   def test_rollback_from_error
-    op = JSONAPI::ActiveRecordOperationsProcessor.new
+    op = ActiveRecordOperationsProcessor.new
 
     count = Planet.count
 
     operations = [
-      JSONAPI::RemoveResourceOperation.new(PlanetResource, 3),
-      JSONAPI::RemoveResourceOperation.new(PlanetResource, 4),
-      JSONAPI::RemoveResourceOperation.new(PlanetResource, 4)
+      JSONAPI::RemoveResourceOperation.new(PlanetResource, resource_id: 3),
+      JSONAPI::RemoveResourceOperation.new(PlanetResource, resource_id: 4),
+      JSONAPI::RemoveResourceOperation.new(PlanetResource, resource_id: 4)
     ]
 
     request = JSONAPI::Request.new
     request.operations = operations
 
-    results = op.process(request)
+    operation_results = op.process(request)
+
+    assert_kind_of(JSONAPI::OperationResults, operation_results)
 
     assert_equal(Planet.count, count)
 
-    assert_kind_of(Array, results)
-    assert_equal(results.size, 3)
+    assert_equal(operation_results.results.size, 3)
 
-    assert_kind_of(JSONAPI::OperationResult, results[0])
-    assert_equal(:no_content, results[0].code)
-    assert_equal(:no_content, results[1].code)
-    assert_equal(404, results[2].code)
+    assert_kind_of(JSONAPI::OperationResult, operation_results.results[0])
+    assert_equal(:no_content, operation_results.results[0].code)
+    assert_equal(:no_content, operation_results.results[1].code)
+    assert_equal(404, operation_results.results[2].code)
   end
 
+  def test_show_operation
+    op = JSONAPI::OperationsProcessor.new
+
+    operations = [
+      JSONAPI::ShowOperation.new(PlanetResource, {id: '1'})
+    ]
+
+    request = JSONAPI::Request.new
+    request.operations = operations
+
+    operation_results = op.process(request)
+
+    assert_kind_of(JSONAPI::OperationResults, operation_results)
+    assert_equal(operation_results.results.size, 1)
+    refute operation_results.has_errors?
+  end
+
+  def test_show_operation_error
+    op = JSONAPI::OperationsProcessor.new
+
+    operations = [
+      JSONAPI::ShowOperation.new(PlanetResource, {id: '145'})
+    ]
+
+    request = JSONAPI::Request.new
+    request.operations = operations
+
+    operation_results = op.process(request)
+
+    assert_kind_of(JSONAPI::OperationResults, operation_results)
+    assert_equal(operation_results.results.size, 1)
+    assert operation_results.has_errors?
+  end
+
+  def test_show_association_operation
+    op = JSONAPI::OperationsProcessor.new
+
+    operations = [
+      JSONAPI::ShowAssociationOperation.new(PlanetResource, {parent_key: '1', association_type: :planet_type})
+    ]
+
+    request = JSONAPI::Request.new
+    request.operations = operations
+
+    operation_results = op.process(request)
+
+    assert_kind_of(JSONAPI::OperationResults, operation_results)
+    assert_equal(operation_results.results.size, 1)
+    refute operation_results.has_errors?
+  end
+
+  def test_show_association_operation_error
+    op = JSONAPI::OperationsProcessor.new
+
+    operations = [
+      JSONAPI::ShowAssociationOperation.new(PlanetResource, {parent_key: '145', association_type: :planet_type})
+    ]
+
+    request = JSONAPI::Request.new
+    request.operations = operations
+
+    operation_results = op.process(request)
+
+    assert_kind_of(JSONAPI::OperationResults, operation_results)
+    assert_equal(operation_results.results.size, 1)
+    assert operation_results.has_errors?
+  end
+
+  def test_show_related_resource_operation
+    op = JSONAPI::OperationsProcessor.new
+
+    operations = [
+      JSONAPI::ShowRelatedResourceOperation.new(PlanetResource,
+                                                {
+                                                  source_klass: PlanetResource,
+                                                  source_id: '1',
+                                                  association_type: :planet_type})
+    ]
+
+    request = JSONAPI::Request.new
+    request.operations = operations
+
+    operation_results = op.process(request)
+
+    assert_kind_of(JSONAPI::OperationResults, operation_results)
+    assert_equal(operation_results.results.size, 1)
+    refute operation_results.has_errors?
+  end
+
+  def test_show_related_resource_operation_error
+    op = JSONAPI::OperationsProcessor.new
+
+    operations = [
+      JSONAPI::ShowRelatedResourceOperation.new(PlanetResource,
+                                                {
+                                                  source_klass: PlanetResource,
+                                                  source_id: '145',
+                                                  association_type: :planet_type})
+    ]
+
+    request = JSONAPI::Request.new
+    request.operations = operations
+
+    operation_results = op.process(request)
+
+    assert_kind_of(JSONAPI::OperationResults, operation_results)
+    assert_equal(operation_results.results.size, 1)
+    assert operation_results.has_errors?
+  end
+
+  def test_show_related_resources_operation
+    op = JSONAPI::OperationsProcessor.new
+
+    operations = [
+      JSONAPI::ShowRelatedResourcesOperation.new(PlanetResource,
+                                                {
+                                                  source_klass: PlanetResource,
+                                                  source_id: '1',
+                                                  association_type: :moons})
+    ]
+
+    request = JSONAPI::Request.new
+    request.operations = operations
+
+    operation_results = op.process(request)
+
+    assert_kind_of(JSONAPI::OperationResults, operation_results)
+    assert_equal(operation_results.results.size, 1)
+    refute operation_results.has_errors?
+  end
+
+  def test_show_related_resources_operation_error
+    op = JSONAPI::OperationsProcessor.new
+
+    operations = [
+      JSONAPI::ShowRelatedResourcesOperation.new(PlanetResource,
+                                                {
+                                                  source_klass: PlanetResource,
+                                                  source_id: '145',
+                                                  association_type: :moons})
+    ]
+
+    request = JSONAPI::Request.new
+    request.operations = operations
+
+    operation_results = op.process(request)
+
+    assert_kind_of(JSONAPI::OperationResults, operation_results)
+    assert_equal(operation_results.results.size, 1)
+    assert operation_results.has_errors?
+  end
 end