jsonapi-resources-matchers 0.6.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 03cf6ea8943f6a9191928662b6566341b283d0e1
-  data.tar.gz: 9e8246871c0fd14664e1b61eccd935f7b73fc31b
+  metadata.gz: 8d5eb7553b4ddb23d720be211d89683f3c4c88bc
+  data.tar.gz: d6a11affc10bff3b80af212f6ca782ea87aff4bd
 SHA512:
-  metadata.gz: d29699e3bd8c0591c11a45255a42b369f7a037159438eb7f564b6829f8bf8e803a8aa9dca0ce8e808d74ec75fa174499a76754adaa18af65d264d7bf5fb07773
-  data.tar.gz: 6041e23d4a5442b4a2d90e0940806fd3e26269137ca95736ae11f162074c5f389c48e8ac070ee004c7c3fd60cc8f4032e6f3edf842acad8ac58e7391c3aa8c82
+  metadata.gz: 46810d777d7bb4c400f86d5991111f0c42c890cb80e3948550838314022f645a1cd0402d41ff3dda885df3eb3dd8b14d9c578d01ddb6084890441255bd5af71c
+  data.tar.gz: 3fa6ff1723de7a92681b15559bcd0620a687c05c33b668a74d774e64201dbf5a561f91244cb7a8e398facbf7dfddb3e756ade38e7c403b72271ae909ec23f57e

data/.travis.yml

@@ -1,4 +1,4 @@
 language: ruby
 rvm:
-  - 2.2.2
-before_install: gem install bundler -v 1.10.5
+  - 2.4.0
+sudo: false

data/CHANGELOG.md

@@ -2,6 +2,13 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## [1.0.0] - 2016-02-28
+### Changed
+- Require jsonapi-resources 0.9.0 and above
+
+### Fixed
+- `have_attribute` and `have_one`, `have_many` matchers: give instructions to the developer when the primary key is not set
+
 ## [0.6.0] - 2016-12-22
 ### Added
 - support for `have_sortable_field`

data/Gemfile

@@ -3,5 +3,5 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in jsonapi-resources-matchers.gemspec
 gemspec
 
-gem 'pry'
+gem 'pry-byebug'
 gem 'sqlite3'

data/jsonapi-resources-matchers.gemspec

@@ -27,7 +27,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "jsonapi-resources", ">= 0.6.0"
+  spec.add_dependency "jsonapi-resources", ">= 0.9.0"
 
   spec.add_development_dependency "bundler", "~> 1.10"
   spec.add_development_dependency "rake", "~> 10.0"

data/lib/jsonapi/resources/matchers.rb

@@ -1,4 +1,5 @@
 require "jsonapi/resources/matchers/version"
+require "jsonapi/resources/matchers/services/check_serialization"
 require "jsonapi/resources/matchers/have_attribute"
 require "jsonapi/resources/matchers/have_creatable_field"
 require "jsonapi/resources/matchers/have_updatable_field"

data/lib/jsonapi/resources/matchers/have_attribute.rb

@@ -12,6 +12,8 @@ module JSONAPI
         def matches?(resource)
           self.resource = resource
 
+          CheckSerialization.(self.resource)
+
           resource_class = resource.class
 
           serialized_hash = JSONAPI::ResourceSerializer.new(resource_class).

data/lib/jsonapi/resources/matchers/relationship.rb

@@ -25,11 +25,16 @@ module JSONAPI
         def matches?(resource)
           self.resource = resource
 
+          is_serializable? &&
           has_key_in_relationships? &&
             matches_class_name? &&
             matches_relation_name?
         end
 
+        def is_serializable?
+          CheckSerialization.(self.resource)
+        end
+
         def has_key_in_relationships?
           serialized_hash = JSONAPI::ResourceSerializer.new(resource.class).
             serialize_to_hash(resource).with_indifferent_access

data/lib/jsonapi/resources/matchers/services/check_serialization.rb

@@ -0,0 +1,20 @@
+module JSONAPI::Resources::Matchers
+  class CheckSerialization
+
+    MESSAGE = [
+      "`:primary_key` is nil.",
+      "In this scenario, jsonapi-resources does not",
+      "include the attributes in order for this matcher to work.",
+      "To get this working, initialize the model with a primary key set.",
+    ].join(" ")
+
+    def self.call(resource)
+      return true if resource.try(:id).present?
+      fail(
+        ArgumentError,
+        MESSAGE.gsub(":primary_key", resource.class._primary_key.to_s)
+      )
+    end
+
+  end
+end

data/lib/jsonapi/resources/matchers/version.rb

@@ -1,7 +1,7 @@
 module JSONAPI
   module Resources
     module Matchers
-      VERSION = "0.6.0"
+      VERSION = "1.0.0"
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: jsonapi-resources-matchers
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 1.0.0
 platform: ruby
 authors:
 - G5
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-12-22 00:00:00.000000000 Z
+date: 2017-02-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: jsonapi-resources
@@ -17,14 +17,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.6.0
+        version: 0.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.6.0
+        version: 0.9.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -112,6 +112,7 @@ files:
 - lib/jsonapi/resources/matchers/have_updatable_field.rb
 - lib/jsonapi/resources/matchers/integrations/rspec.rb
 - lib/jsonapi/resources/matchers/relationship.rb
+- lib/jsonapi/resources/matchers/services/check_serialization.rb
 - lib/jsonapi/resources/matchers/version.rb
 homepage: https://github.com/G5/jsonapi-resources-matchers
 licenses: