json_schema 0.13.2 → 0.13.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b1f24463b2049d196fe0ed73305146600d50c870
-  data.tar.gz: c97c5109678c9786a12219b364640dbe22afd25c
+  metadata.gz: 2f5c2d7106b765e16464b19faf83b114eda8eef2
+  data.tar.gz: 8e726d2b1af63279c75ee00f6da8f6f22828caa4
 SHA512:
-  metadata.gz: dba523a357a759cedd359bfc7a11ba72ab2ab4344f038363ae809ec20008bbfe377435929f93d68c56865c1407f17f952f7e30532893cca28f132891ad66d072
-  data.tar.gz: 60b178db7b14223cb13a37ee7b06879975fd007b6e487261b2ec8e5cbcd6fa97dd0224e326fbfba898e5ae4b8cbbbc0696210df5bba6f2874c2bf5c8ed6ee914
+  metadata.gz: 9dec05abbc55082ef52b87d0b6dac38e4347550a619fe87b033f35b5cff5f0b1e59ad5194b4e5637f7722bda0d64f9bb341e350a9ce642fb9a82c38ee4a960d1
+  data.tar.gz: 076853fdad85d71c7396704c741f6f60a536f7d2f4c078e981c167671507e58827a9e5dff7567d86b54adaf8803f0b04d61082010cfa5899129523e966bfca26

data/lib/json_schema/reference_expander.rb

@@ -185,10 +185,17 @@ module JsonSchema
         resolve_uri(ref_schema, uri)
       # relative
       elsif uri
-        # build an absolute path using the URI of the current schema
-        # TODO: fix this. References don't get URIs which might be an error.
-        schema_uri = ref_schema.uri.chomp("/")
-        resolve_uri(ref_schema, URI.parse(schema_uri + "/" + uri.path))
+        # Build an absolute path using the URI of the current schema.
+        #
+        # Note that this code path will never currently be hit because the
+        # incoming reference schema will never have a URI.
+        if ref_schema.uri
+          schema_uri = ref_schema.uri.chomp("/")
+          resolve_uri(ref_schema, URI.parse(schema_uri + "/" + uri.path))
+        else
+          nil
+        end
+
       # just a JSON Pointer -- resolve against schema root
       else
         resolve_pointer(ref_schema, @schema)

data/test/json_schema/reference_expander_test.rb

@@ -205,6 +205,16 @@ describe JsonSchema::ReferenceExpander do
     assert_includes error_types, :unresolved_pointer
   end
 
+  it "errors on a relative URI that cannot be transformed to an absolute" do
+    pointer("#/properties").merge!(
+      "app" => { "$ref" => "relative#definitions/name" }
+    )
+    refute expand
+    assert_includes error_messages,
+      %{Couldn't resolve references: relative#definitions/name.}
+    assert_includes error_types, :unresolved_references
+  end
+
   it "errors on a reference cycle" do
     pointer("#/properties").merge!(
       "app0" => { "$ref" => "#/properties/app2" },

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: json_schema
 version: !ruby/object:Gem::Version
-  version: 0.13.2
+  version: 0.13.3
 platform: ruby
 authors:
 - Brandur