json_errors 0.3.1 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4c7bb942cf5ede276351ed16f0730c356a901a0892ba4b8d64afb0db71d6f797
-  data.tar.gz: 586832722858d41b3ee436cdac4407428c2a3cf2fb9c3f9fffd1934177ecd189
+  metadata.gz: 82cdcb26c361de8eb6868ce702eeb97fd62ddc669d98518b8ed3334258ba1422
+  data.tar.gz: 93245dc766c1bc2765af83b43c2d25bb897e71b71d9238b58de0a72543e46119
 SHA512:
-  metadata.gz: caa154ab9fed780b387f8d726663455598e2e13ebf9c8fab5126aec955098e62a199c640771892f53bb7c448a86e6c26707a19eb19a0c49ba595415b4ab88414
-  data.tar.gz: 64d0d4bc21882a908aa4b871e3f872ca0164ff577c5ae44c36d6186309751897d8f4a202c72e9bedb051fe527872261bcd77204cfe0225cefe66edbb51422709
+  metadata.gz: dcbe2db6646811d99de69ec3ca988c68d46c1e0631561c9fa34b28df579006a8669927e048ceb5178bb34d74466efe425094dd6550ab9c2b6209b1d8838db00d
+  data.tar.gz: 1d420a644a9d66435105197c4bd69d8c516cf8576a2bc8839322efe18e8d8bac47524144a9da7ed366e9be4943a05155f6be5628d6fbbe89ddc62d42d00c92ad

data/.github/workflows/main.yml

@@ -10,10 +10,10 @@ jobs:
     - name: Set up Ruby
       uses: ruby/setup-ruby@v1
       with:
-        ruby-version: 3.0.1
+        ruby-version: 3.4.1
     - name: Run the default task
       run: |
-        gem install bundler -v 2.2.15
+        gem install bundler -v 2.6.5
         bundle install
         bundle exec rake rubocop
         bundle exec rake

data/.rubocop.yml

@@ -1,6 +1,11 @@
+plugins:
+  - rubocop-rake
+  - rubocop-rspec
+
 AllCops:
   TargetRubyVersion: 3.0
   NewCops: enable
+  SuggestExtensions: false
 
 Layout/LineLength:
   Max: 120
@@ -10,3 +15,27 @@ Metrics/BlockLength:
   Exclude:
     - spec/**/*
     - config/**/*
+
+RSpec/SpecFilePathFormat:
+  Enabled: false
+
+RSpec/VerifiedDoubles:
+  Enabled: false
+
+RSpec/NestedGroups:
+  Enabled: false
+
+RSpec/MultipleExpectations:
+  Enabled: false
+
+RSpec/SubjectStub:
+  Enabled: false
+
+RSpec/MessageSpies:
+  Enabled: false
+
+RSpec/DescribedClass:
+  Enabled: false
+
+RSpec/VerifiedDoubleReference:
+  Enabled: false

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 ## [Unreleased]
 
+## [0.3.2] - 2025-03-04
+
+- bugfix: Validation errors
+
+## [0.3.2] - 2025-03-04
+
+- bugfix: Active record validation errors were never shown
+
 ## [0.3.1] - 2025-02-27
 
 - bugfix: Wrong ActiveRecord error format

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    json_errors (0.3.0)
+    json_errors (0.3.2)
       activesupport (~> 8.0)
 
 GEM

data/json_errors.gemspec

@@ -27,7 +27,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'activesupport', "~> 8.0"
+  spec.add_dependency 'activesupport', '~> 8.0'
 
   # For more information and examples about making a new gem, checkout our
   # guide at: https://bundler.io/guides/creating_gem.html

data/lib/json_errors/config.rb

@@ -10,7 +10,7 @@ module JsonErrors
     attr_accessor :error_dictionary, :custom_codes
 
     def self.missing_config_error_meesage
-      <<~'MSG'
+      <<~MSG
         Configuration is missing. Run the generattor: `bundle exec rails g json_errors::install`
         or create the initializer yourself.
         Check out the README https://github.com/nomtek/JsonErrors/blob/main/README.md

data/lib/json_errors/error/validation_error.rb

@@ -3,11 +3,11 @@
 module JsonErrors
   # Error class for custom payload errors
   class ValidationError < BasicError
-    def initialize(msg, name, record)
+    def initialize(msg, name, model_instance)
       super(msg, name)
-      raise 'Wrong record' unless record.respond_to?(:errors)
+      raise 'Wrong record' unless model_instance.respond_to?(:errors)
 
-      @record = record
+      @model_instance = model_instance
     end
 
     def to_json(_options = nil)
@@ -20,15 +20,19 @@ module JsonErrors
 
     private
 
-    attr_reader :record
+    attr_reader :model_instance
 
     def payload
-      validation_payload = []
-      record.errors.each do |error|
-        validation_payload << { error.attribute => error.message }
+      validation_payload = model_instance.errors.map do |error|
+        {
+          'object' => model_instance.class.to_s,
+          'attribute' => error.attribute,
+          'error_type' => error.type,
+          'message' => error.full_message
+        }
       end
 
-      { record.class.to_s => validation_payload }
+      { 'validation_errors' => validation_payload }
     end
   end
 end

data/lib/json_errors/error.rb

@@ -4,11 +4,13 @@ module JsonErrors
   # Error facade
   class Error
     def self.method_missing(name, *args)
-      message, payload = args
-      return super unless name.in?(codes.keys)
+      error = args.first
+      payload = args.second
+      message = error.message
 
+      return super unless name.in?(codes.keys)
+      return ValidationError.new(message, name, error&.record) if codes[name][:validation_errors] == :active_record
       return BasicError.new(message, name) if payload.nil?
-      return ValidationError.new(message, name, payload&.record) if codes[name][:validation_errors] == :active_record
 
       CustomPayloadError.new(message, name, payload)
     end

data/lib/json_errors/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module JsonErrors
-  VERSION = '0.3.1'
+  VERSION = '0.3.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: json_errors
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.3
 platform: ruby
 authors:
 - Łukasz Pająk
 - Nomtek
 bindir: exe
 cert_chain: []
-date: 2025-02-27 00:00:00.000000000 Z
+date: 2025-03-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport