json 2.18.2 → 2.18.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1c725c4afdd182aa9252219b897ebf6e4e4ded09d84950cb757fefb8e23fb582
-  data.tar.gz: ae073b566faf0998934386dbc58cbbf3a1c9df5f37dac8ef739caa9ec5a426a1
+  metadata.gz: f2f4e92c83082e5be91872a463b47a8520d0f6b7aae8799bab0d012297065685
+  data.tar.gz: 3149e9053445d1ae0397b30bdb95c0f26ed5c56e36506c065e843a37809cd5c5
 SHA512:
-  metadata.gz: dc293a2d227101f5feb1dafd1ac26f97292c0056cfb0b9ee4cf370796b5b80c290096231dfc855f3e282b7cfe552156b46cdc5f99f8c3e9a425ede1dc49c0a04
-  data.tar.gz: b98ec5d804d52c6c3d1c5ccf57a7bf4912528149792fd8442e5db49938b77b6943293a1d2734b00cf7db934ed82a839b61eb1c107a7fd0b3a7663b76315b52f1
+  metadata.gz: b618febef7ab94710d390a2aab3b3af62080feb5f97dbc1217a94dce790cb5b93837bfd7c2f66eecbdb1358844e7c83b404b1124583a87d73e18f5dd28512b72
+  data.tar.gz: 56bed6163cbd092c20fbf4e0ddaf3ecdcf69bc3cc3228ad7407215d9b3aacd8c18b4ddfd0536f23a6d2e19d8fc4ed794b022f987abf44da10bbfef6336c60928

data/CHANGES.md

@@ -2,11 +2,15 @@
 
 ### Unreleased
 
-### 2026-11-02 (2.18.2)
+### 2026-11-13 (2.18.3)
 
-* Backport handling of unescaped control characters preceeded by a backslash from 2.19.3.
+* Backport handling of unescaped control characters preceeded by a backslash from 2.19.2.
   GHSA-cjpr-jw2g-fw99.
 
+### 2026-11-02 (2.18.2)
+
+* Fix a format string injection vulnerability in `JSON.parse(doc, allow_duplicate_key: false)`.
+
 ### 2026-02-03 (2.18.1)
 
 * Fix a potential crash in very specific circumstance if GC triggers during a call to `to_json`

data/ext/json/ext/parser/parser.c

@@ -400,14 +400,9 @@ static void emit_parse_warning(const char *message, JSON_ParserState *state)
 
 #define PARSE_ERROR_FRAGMENT_LEN 32
 
-#ifdef RBIMPL_ATTR_NORETURN
-RBIMPL_ATTR_NORETURN()
-#endif
-static void raise_parse_error(const char *format, JSON_ParserState *state)
+static VALUE build_parse_error_message(const char *format, JSON_ParserState *state, long line, long column)
 {
     unsigned char buffer[PARSE_ERROR_FRAGMENT_LEN + 3];
-    long line, column;
-    cursor_position(state, &line, &column);
 
     const char *ptr = "EOF";
     if (state->cursor && state->cursor < state->end) {
@@ -442,11 +437,23 @@ static void raise_parse_error(const char *format, JSON_ParserState *state)
     VALUE msg = rb_sprintf(format, ptr);
     VALUE message = rb_enc_sprintf(enc_utf8, "%s at line %ld column %ld", RSTRING_PTR(msg), line, column);
     RB_GC_GUARD(msg);
+    return message;
+}
 
+static VALUE parse_error_new(VALUE message, long line, long column)
+{
     VALUE exc = rb_exc_new_str(rb_path2class("JSON::ParserError"), message);
     rb_ivar_set(exc, rb_intern("@line"), LONG2NUM(line));
     rb_ivar_set(exc, rb_intern("@column"), LONG2NUM(column));
-    rb_exc_raise(exc);
+    return exc;
+}
+
+NORETURN(static) void raise_parse_error(const char *format, JSON_ParserState *state)
+{
+    long line, column;
+    cursor_position(state, &line, &column);
+    VALUE message = build_parse_error_message(format, state, line, column);
+    rb_exc_raise(parse_error_new(message, line, column));
 }
 
 #ifdef RBIMPL_ATTR_NORETURN
@@ -888,6 +895,11 @@ static void raise_duplicate_key_error(JSON_ParserState *state, VALUE duplicate_k
         rb_inspect(duplicate_key)
     );
 
+    long line, column;
+    cursor_position(state, &line, &column);
+    rb_str_concat(message, build_parse_error_message("", state, line, column)) ;
+    rb_exc_raise(parse_error_new(message, line, column));
+
     raise_parse_error(RSTRING_PTR(message), state);
     RB_GC_GUARD(message);
 }

data/lib/json/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module JSON
-  VERSION = '2.18.2'
+  VERSION = '2.18.3'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: json
 version: !ruby/object:Gem::Version
-  version: 2.18.2
+  version: 2.18.3
 platform: ruby
 authors:
 - Florian Frank