json-schema-serializer 1.5.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0efb6d3beb44452ee9a2aa14ac89bd465e8c23ecbaf7cb650ff39faeaf22f19d
-  data.tar.gz: f9d35967622b23c02a1a09cfad3c33c3af0f1bf38de295d365732231d0926011
+  metadata.gz: 301107414cad9b1f2e8845d86633a36354e32b9ca7a45bb6611a1b42c4ece2ce
+  data.tar.gz: 7d2c5f7bb39e5d59278073a779abf70979d86870009c6195f764ee37da5c6c5f
 SHA512:
-  metadata.gz: c1905cf229d6fd7c484fb3703eb507a4fb7641c28b840ee2e045b250fd688502b8c09dcb36bb28d191b1d36a7c5772040c0bd10297f6ba533e4d676d191c02a1
-  data.tar.gz: c24cd2d21e573339dd9b861b4f6936753f78ed63d6f7988316608d9315d1322689c3bac080873ee4e54a0327073d89545c77d51576ebd4bc6ebe842ce6fb2b19
+  metadata.gz: 4305c335b4a52abd9631bc11fb93b7268b7d0a235939f86be68dff2f3d8569df3b7908a33e4b9b45417c5f7b7b928a28b334d8feaad91e012079c3670ee512bd
+  data.tar.gz: f7a3ac83d661e4ddd546fae884600e61c1dce9119347ed0a93e3ee574c66c38bb4647a40f0c6f84e295804b3c620864e65c549e1b38e5f69429805fcc9a675a8

data/CHANGELOG.md

@@ -1,5 +1,19 @@
 # CHANGELOG
 
+## 2.0.0
+
+- fix: Non-primitive (arrays, objects, etc.) "default" schemas and injections have strange results.
+    - If you were using a non-primitive (array, object, etc.) "default" schema with injection, it could be a breaking change!
+
+## 1.7.0
+
+- add: `with_context!` api
+- add: `:inject_by_keyword` option
+
+## 1.6.0
+
+- add: inject context
+
 ## 1.5.0
 
 - add: many options

data/README.md

@@ -112,6 +112,178 @@ serializer_injected = JSON::Schema::Serializer.new(
 
 serializer_injected.serialize([1, 2, 3])
 # => {"first"=>1, "count"=>3}
+
+#
+# object injector with context
+#
+
+class BarSerializer
+  def initialize(model, context = nil)
+    @model = model
+    @context = context
+  end
+
+  def id
+    @model[:id]
+  end
+
+  def score
+    @context[@model[:id]]
+  end
+end
+
+inject_context = {
+  1 => 100,
+  2 => 200,
+}
+
+serializer_injected_with_context = JSON::Schema::Serializer.new(
+  {
+    type: :object,
+    inject: :Bar,
+    properties: {
+      id: { type: :integer },
+      score: { type: :integer },
+    },
+  },
+  {
+    inject_key: :inject,
+    injectors: {
+      Bar: BarSerializer,
+    },
+    inject_context: inject_context,
+  },
+)
+
+serializer_injected_with_context.serialize({ id: 1 })
+# => { "id" => 1, "score" => 100 }
+
+#
+# inject in serializer
+#
+
+class ParentSerializer
+  include JSON::Schema::Serializer::WithContext
+
+  def initialize(model, context = nil)
+    @model = model
+    @context = context
+  end
+
+  def id
+    @model[:id]
+  end
+
+  def score
+    @context[:parent_scores][@model[:id]]
+  end
+
+  def child
+    # it can be
+    # with_context(context) { data }
+    # with_context(data, context)
+    # with_context(data: data, context: context)
+    with_context(@context.merge(child_scores: { 1 => 100, 2 => 200 })) do
+      @model[:child]
+    end
+  end
+end
+
+class ChildSerializer
+  def initialize(model, context = nil)
+    @model = model
+    @context = context
+  end
+
+  def id
+    @model[:id]
+  end
+
+  def score
+    @context[:child_scores][@model[:id]]
+  end
+end
+
+serializer_injected_with_context_in_serializer = JSON::Schema::Serializer.new(
+  {
+    type: :object,
+    inject: :Parent,
+    properties: {
+      id: { type: :integer },
+      score: { type: :integer },
+      child: {
+        type: :object,
+        inject: :Child,
+        properties: {
+          id: { type: :integer },
+          score: { type: :integer },
+        },
+      },
+    },
+  },
+  {
+    inject_key: :inject,
+    injectors: {
+      Parent: ParentSerializer,
+      Child: ChildSerializer,
+    },
+    inject_context: { 1 => 10, 2 => 20 },
+  },
+)
+
+serializer_injected_with_context_in_serializer.serialize({ id: 1, child: { id: 2 } })
+# => { "id" => 1, "score" => 10, "child" => { "id" => 2, "score" => 200 } }
+
+#
+# also you can inject context with arraylike data
+#
+
+class ItemsSerializer
+  include JSON::Schema::Serializer::WithContext
+
+  def initialize(models, context = nil)
+    @models = models
+    @context = context
+  end
+
+  def map(&block)
+    context = (@context || {}).merge(scores: {...})
+    @models.map { |model| block.call(with_context(model, context)) }
+    # CAUTION!
+    # not like below!
+    # with_context(@models.map(&block), context)
+    # with_context(context) { @models.map(&block) }
+  end
+end
+
+#
+# inject model can initialize by keywords
+#
+
+class KeywordSerializer
+  def initialize(data:, context: nil)
+    @data = data
+    @context = context
+  end
+
+  ...
+end
+
+serializer_with_keyword_init_inject = JSON::Schema::Serializer.new(
+  {
+    type: :object,
+    inject: :Keyword,
+    properties: { ... },
+  },
+  {
+    inject_key: :inject,
+    injectors: {
+      Keyword: KeywordSerializer,
+      Child: ChildSerializer,
+    },
+    inject_by_keyword: true, # <- keyword_init!
+  },
+)
 ```
 
 ### "additionalProperties"
@@ -173,13 +345,6 @@ serializer2 = JSON::Schema::Serializer.new(schema["properties"]["bar"], {
 
 The initializer.
 
-      # @param schema [any] JSON schema object. The serializer tries schema["type"], schema[:type] and schema.type!
-      # @param options [Hash] options
-      # @option options [Proc] :resolver schema object resolver
-      # @option options [Hashlike<String, Class>] :injectors If schema has inject key, the serializer treats injectors[inject_key].new(data).
-      # @option options [String, Symbol] :inject_key inject key
-      # @option 
-
 #### schema [any]
 
 JSON schema object. The serializer tries schema["type"], schema[:type] and schema.type!
@@ -192,7 +357,7 @@ options
 
 schema object `$ref` resolver
 
-#### options[:input_key_transform] [Proc]
+#### options[:schema_key_transform_for_input] [Proc]
 
 input key transform
 
@@ -202,10 +367,10 @@ new({
   properties: {
     userCount: { type: :integer },
   },
-}, { input_key_transform: ->(name) { name.underscore } }).serialize({ user_count: 1 }) == { "userCount" => 1 }
+}, { schema_key_transform_for_input: ->(name) { name.underscore } }).serialize({ user_count: 1 }) == { "userCount" => 1 }
 ```
 
-#### options[:output_key_transform] [Proc]
+#### options[:schema_key_transform_for_output] [Proc]
 
 output key transform
 
@@ -215,15 +380,21 @@ new({
   properties: {
     userCount: { type: :integer },
   },
-}, { output_key_transform: ->(name) { name.underscore } }).serialize({ userCount: 1 }) == { "user_count" => 1 }
+}, { schema_key_transform_for_output: ->(name) { name.underscore } }).serialize({ userCount: 1 }) == { "user_count" => 1 }
 ```
 
-#### options[:injectors] [Hashlike<String, Class>, Class], options[:inject_key] [String, Symbol]
+#### options[:injectors] [Hashlike<String, Class>, Class], options[:inject_key] [String, Symbol], options[:inject_context] [any], options[:inject_by_keyword] [Boolean]
 
 If schema has inject key, the serializer treats data by `injectors[inject_key].new(data)` (or `injectors.send(inject_key).new(data)`).
 
+And if `inject_context` is present, `injectors[inject_key].new(data, inject_context)` (or `injectors.send(inject_key).new(data, inject_context)`).
+
+And if `inject_by_keyword` is true, `new(data, inject_context)` will be `new(data: data, context: inject_context)`.
+
 See examples in [Usage](#usage).
 
+CAUTION: In many case you should define the `nil?` method in the injector class because Injector always initialized by `Injector.new(obj)` even if obj == nil.
+
 #### options[:null_through] [Boolean]
 
 If data is null, always serialize null.
@@ -282,6 +453,14 @@ Serialize the object data by the schema.
 
 Serialize target object. The serializer tries data["foo"], data[:foo] and data.foo!
 
+## JSON::Schema::Serializer::WithContext API
+
+### #with_context!(data, context), #with_context!(data: data, context: context), #with_context!(context) { data }
+
+If you use `with_context!(data, context)` as the return value of the serializer, then "child" serializer can use that context.
+
+See examples in [Usage](#usage).
+
 ## License
 
 Zlib License

data/json-schema-serializer.gemspec

@@ -28,9 +28,10 @@ Gem::Specification.new do |spec|
   spec.require_paths = %w[lib]
 
   spec.add_development_dependency "bundler", "~> 2.0"
-  spec.add_development_dependency "rake", "~> 10.5"
+  spec.add_development_dependency "rake", "~> 13.0"
   spec.add_development_dependency "rspec", "~> 3.9"
   spec.add_development_dependency "rspec-power_assert", "~> 1.1"
+  spec.add_development_dependency "simplecov", ">= 0.18"
   spec.add_development_dependency "rubocop", "~> 0.76"
   spec.add_development_dependency "rubocop-airbnb", "~> 3"
   spec.add_development_dependency "prettier", ">= 0.16"

data/lib/json/schema/serializer.rb

@@ -5,31 +5,74 @@ require "set"
 module JSON
   class Schema
     class Serializer
-      def initialize(schema, options = nil)
+      def initialize(schema, options = nil) # rubocop:disable Airbnb/OptArgParameters
         @schema = options && options[:resolver] ? options[:resolver].call(schema) : schema
         @options = options || {}
       end
 
       def serialize(data)
-        Walker.walk(@schema, data, true, @options)
+        Walker.walk(@schema, data, true, false, @options)
+      end
+
+      DataWithContext = Struct.new(:data, :context, keyword_init: true)
+
+      module WithContext
+        ARG2_NOT_GIVEN = :__json_schema_serializer_arg2_not_given__
+
+        def with_context!(arg1, arg2 = ARG2_NOT_GIVEN) # rubocop:disable Airbnb/OptArgParameters
+          if block_given?
+            DataWithContext.new(data: yield, context: arg1)
+          elsif arg2 == ARG2_NOT_GIVEN
+            DataWithContext.new(arg1)
+          else
+            DataWithContext.new(data: arg1, context: arg2)
+          end
+        end
       end
 
       class Walker
         class << self
           TimeWithZone = defined?(ActiveSupport::TimeWithZone) ? ActiveSupport::TimeWithZone : nil
 
-          def walk(schema, obj, required, options)
+          def walk(schema, obj, required, using_default, options)
             type = try_hash(schema, :type)
             default = try_hash(schema, :default)
             format = try_hash(schema, :format)
-            obj = default if obj.nil?
+            if obj.nil?
+              using_default = true
+              obj = default
+            end
 
             if options[:inject_key]
               inject_key = try_hash(schema, options[:inject_key])
               injector = try_hash(options[:injectors], inject_key) if inject_key
-              obj = injector.new(obj) if injector
+              if obj.instance_of?(JSON::Schema::Serializer::DataWithContext)
+                options = options.merge(inject_context: obj.context)
+                obj = obj.data
+                if obj.nil?
+                  using_default = true
+                  obj = default
+                end
+              end
+              if injector && !using_default
+                if options[:inject_context]
+                  obj =
+                    if options[:inject_by_keyword]
+                      injector.new(data: obj, context: options[:inject_context])
+                    else
+                      injector.new(obj, options[:inject_context])
+                    end
+                else
+                  obj =
+                    if options[:inject_by_keyword]
+                      injector.new(data: obj)
+                    else
+                      injector.new(obj)
+                    end
+                end
+              end
             end
-            type_coerce(schema, detect_type(type, obj), format, obj, required, options)
+            type_coerce(schema, detect_type(type, obj), format, obj, required, using_default, options)
           end
 
           def detect_type(type, obj)
@@ -112,7 +155,7 @@ module JSON
             end
           end
 
-          def type_coerce(schema, type, format, obj, required, options)
+          def type_coerce(schema, type, format, obj, required, using_default, options)
             return nil if !required && obj.nil?
 
             case type.to_s
@@ -181,7 +224,7 @@ module JSON
               return options[:null_through] ? nil : [] if obj.nil? || !obj.respond_to?(:map)
               return options[:null_through] ? nil : [] if options[:guard_primitive_in_structure] && is_primitive?(obj)
 
-              obj.map { |item| walk(items_schema, item, true, options) }
+              obj.map { |item| walk(items_schema, item, true, using_default, options) }
             when "object"
               return nil if obj.nil? && options[:null_through]
               return options[:null_through] ? nil : {} if options[:guard_primitive_in_structure] && is_primitive?(obj)
@@ -189,13 +232,13 @@ module JSON
               properties_schema = try_hash(schema, :properties)
               additional_properties_schema = try_hash(schema, :additionalProperties)
               required_schema = Set.new(try_hash(schema, :required)&.map(&:to_s))
-              input_key_transform = options[:input_key_transform] # schema key -> input obj key
-              output_key_transform = options[:output_key_transform] # schema key -> out
+              input_key_transform = options[:schema_key_transform_for_input] # schema key -> input obj key
+              output_key_transform = options[:schema_key_transform_for_output] # schema key -> out
               ret =
                 properties_schema.map do |name, property_schema|
                   input_key = input_key_transform ? input_key_transform.call(name.to_s) : name
                   output_key = output_key_transform ? output_key_transform.call(name.to_s) : name.to_s
-                  [output_key, walk(property_schema, try_hash(obj, input_key), required_schema.include?(name.to_s), options)]
+                  [output_key, walk(property_schema, try_hash(obj, input_key), required_schema.include?(name.to_s), using_default, options)]
                 end.to_h
               if additional_properties_schema
                 not_additional_keys_array = properties_schema.keys.map(&:to_s)
@@ -204,7 +247,7 @@ module JSON
                 ret.merge(
                   additional_keys.map do |name|
                     output_key = output_key_transform ? output_key_transform.call(name.to_s) : name.to_s
-                    [output_key, walk(additional_properties_schema, try_hash(obj, name), false, options)]
+                    [output_key, walk(additional_properties_schema, try_hash(obj, name), false, using_default, options)]
                   end.to_h,
                 )
               else
@@ -221,6 +264,9 @@ module JSON
             elsif obj.respond_to?(name)
               obj.send(name)
             end
+          rescue
+            p [name, obj]
+            raise
           end
 
           def is_primitive?(obj)

data/lib/json/schema/serializer/version.rb

@@ -1,7 +1,7 @@
 module JSON
   class Schema
     class Serializer
-      VERSION = "1.5.0".freeze
+      VERSION = "2.0.0".freeze
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: json-schema-serializer
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Narazaka
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-12-03 00:00:00.000000000 Z
+date: 2020-11-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.5'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.5'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -66,6 +66,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.1'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0.18'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0.18'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -181,7 +195,7 @@ metadata:
   homepage_uri: https://github.com/Narazaka/json-schema-serializer
   source_code_uri: https://github.com/Narazaka/json-schema-serializer.git
   changelog_uri: https://github.com/Narazaka/json-schema-serializer/blob/master/CHANGELOG.md
-  documentation_uri: https://www.rubydoc.info/gems/json-schema-serializer/1.5.0
+  documentation_uri: https://www.rubydoc.info/gems/json-schema-serializer/2.0.0
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -197,8 +211,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: JSON Schema based serializer