jslintrb 0.4.0 → 0.5.0

data/CHANGELOG.rdoc

@@ -1,3 +1,8 @@
+=== 0.5.0 / 2010-03-17
+
+* Cleanup wake integration; add opt to avoid new upstream error
+* support plugin dependences
+
 === 0.4.0 / 2010-03-16
 
 * First Hoe version

data/README.rdoc

@@ -25,6 +25,10 @@ The file is JSON-formatted. See the jslint documentation
 (http://www.jslint.com/lint.html#options) for allowed options and an
 example at http://github.com/smparkes/env-js/blob/envjsrb/.jslintrbrc.
 
+== Differences from upstream
+
+JSLint warns against using new to be evaluated soley for side-effects. jslintrb allows this if you set the "newside" option.
+
 == Copyright
 
 jslintrb copyright (c) 2010 Steven Parkes. See LICENSE for details.

data/lib/jslintrb.rb

@@ -1,3 +1,3 @@
 module JSLintRB
-  VERSION = "0.4.0"
+  VERSION = "0.5.0"
 end

data/lib/jslintrb/fulljslint.js

@@ -306,6 +306,8 @@ var JSLINT = (function () {
 // These are the JSLint boolean options.
 
         boolOptions = {
+            newside    : false,
+
             adsafe     : true, // if ADsafe should be enforced
             bitwise    : true, // if bitwise operators should not be allowed
             browser    : true, // if the standard browser globals should be predefined
@@ -2523,7 +2525,7 @@ loop:   for (;;) {
                 warning(
 "Expected an assignment or function call and instead saw an expression.",
                         token);
-            } else if (r.id === '(' && r.left.id === 'new') {
+            } else if (!option.newside && (r.id === '(' && r.left.id === 'new')) {
                 warning("Do not use 'new' for side effects.");
             }
             if (nexttoken.id !== ';') {

data/lib/jslintrb/jslintrb.wk

@@ -8,16 +8,12 @@ class JSLintRb::Plugin < Wake::Plugin
 
   default :regexp => /\.js$/
 
-  def out_of_date? node, flag
-    return true if super
-    return flag
-  end
-
   def watcher
     default = super
     lambda do |path, graph|
       if node = default.call( path, graph )
-        create graph, Node::Virtual.new( node, cls.default[:options][:virtual] ), :from => node, :plugin => self
+        create graph, Node::Virtual.new( graph, node, cls.default[:options][:virtual] ),
+                     :from => node, :plugin => self
       end
     end
   end
@@ -25,27 +21,30 @@ class JSLintRb::Plugin < Wake::Plugin
   def fire_all
     lambda do |nodes|
       succeeded = nodes.inject({}) { |hash, node| hash[node] = true; hash }
-      cmd = "jslintrb #{nodes.map { |node| node.primary_dependence.path }.uniq.join(' ')}"
+      cmd = "jslintrb #{nodes.map { |node| node.primary.path }.uniq.join(' ')}"
       puts cmd
-      status = open("|"+cmd) do |f|
+      now = Time.now();
+      open("|"+cmd) do |f|
         f.each do |line|
           $stderr.puts line
           m = /^([^ ]+) line \d+ character \d+:/.match(line)
           path = m[1] if m
           if path
-            array = nodes.select { |node| node.primary_dependence.path == path }
+            array = nodes.select { |node| node.primary.path == path }
             succeeded[array[0]] = false
           end
         end
       end
+      puts "\nFinished in #{Time.now()-now} seconds"
+      # require 'pp'
+      # pp (succeeded.map { |k,v| [ k.path, v ] })
+      success = true
       succeeded.each do |node, v|
-        FileUtils.mkdir_p Pathname(node.path).dirname
-        open(node.path,"w") do |f|
-          f.truncate 0
-          f.write({:succeded => v}.to_json)
-        end
+        node.succeeded = v
+        success &&= v
+        node.save!
       end
-      return status
+      success
     end
   end
 

metadata

@@ -4,9 +4,9 @@ version: !ruby/object:Gem::Version
   prerelease: false
   segments: 
   - 0
-  - 4
+  - 5
   - 0
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors: 
 - Steven Parkes
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-03-16 00:00:00 -07:00
+date: 2010-03-17 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency