jsl-feedtosis 0.0.3.1 → 0.0.3.2

data/feedtosis.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name = %q{feedtosis}
-  s.version = "0.0.3.1"
+  s.version = "0.0.3.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Justin Leitgeb"]
@@ -16,7 +16,7 @@ Gem::Specification.new do |s|
     "spec/extensions/feed_normalizer/feed_instance_methods_spec.rb", 
     "spec/fixtures/http_headers/wooster.txt", 
     "spec/fixtures/xml/older_wooster.xml", "spec/fixtures/xml/wooster.xml", 
-    "spec/feedtosis/client_spec.rb", "spec/feedtosis_spec.rb", 
+    "spec/feedtosis/client_spec.rb",
     "spec/feedtosis/result_spec.rb",
     "spec/spec_helper.rb"]
   
@@ -26,8 +26,7 @@ Gem::Specification.new do |s|
   s.require_paths = ["lib"]
   s.rubygems_version = %q{1.3.1}
   s.summary = %q{Retrieves feeds using conditional GET and marks entries that you haven't seen before}
-  s.test_files = ["spec/feedtosis_spec.rb", "spec/spec_helper.rb", "spec/feedtosis/client_spec.rb",
-    "spec/feedtosis/result_spec.rb" ]
+  s.test_files = ["spec/spec_helper.rb", "spec/feedtosis/client_spec.rb", "spec/feedtosis/result_spec.rb" ]
 
   s.extra_rdoc_files = [ "README.rdoc" ]
   

data/lib/feedtosis/result.rb

@@ -7,17 +7,8 @@ module Feedtosis
   # these cases, depending on your business logic you may want to inspect the 
   # state of the Curl::Easy object by using methods forwarded to it.
   class Result
-    
-    # Methods which should be delegated to the FeedNormalizer::Feed object.
-    FEED_METHODS = [ :title, :description, :last_updated, :copyright, :authors, 
-      :author, :urls, :url, :image, :generator, :items, :entries, :new_items, 
-      :new_entries, :channel, :ttl, :skip_hours, :skip_days 
-    ] unless defined?(FEED_METHODS)
-    
-    # Precompiled regexp for detecting removing setter methods from collection 
-    # of methods to be delegated to the Curl::Easy object.
-    SETTER_METHOD_RE = /=$/o unless defined?(SETTER_METHOD_RE)
-    
+    extend Forwardable
+        
     def initialize(curl, feed)
       @curl = curl
       @feed = feed
@@ -25,22 +16,17 @@ module Feedtosis
       raise ArgumentError, "Curl object must not be nil" if curl.nil?
     end
     
-    # See what the Curl::Easy object responds to, and send any appropriate
-    # messages its way.  We don't worry about setter methods, since those
-    # aren't really useful to delegate.
-    Curl::Easy.instance_methods(false).reject do |m| 
-      m =~ SETTER_METHOD_RE
-    end.each do |meth|                  # Example method:
-      define_method meth do |*args|     # def title
-        @curl.__send__(meth, *args)     #   @curl.title
-      end                               # end
-    end
+    # See what the Curl::Easy object responds to, and send any appropriate messages its way.  We ignore  
+    # Curl setter methods since those aren't really useful to delegate.
+    def_delegators :@curl, *Curl::Easy.instance_methods(false).reject {|m| m =~ /=$/o }
     
-    # Send methods through to the feed object unless it is nil.  If feed
-    # object is nil, return nil in response to method call.
-    FEED_METHODS.each do |meth|                         # Example method:
+    # Send methods through to the feed object unless it is nil.  If feed object is nil, return nil in response to method call.
+    # Unfortunately we can't just see what the object responds to, since FeedNormalizer uses method_missing.
+    [ :title, :description, :last_updated, :copyright, :authors, :author, :urls, :url, :image, :generator, :items, 
+      :entries, :new_items, :new_entries, :channel, :ttl, :skip_hours, :skip_days 
+    ].each do |meth|                                    # Example method:
       define_method meth do |*args|                     # def author
-        @feed.nil? ? nil : @feed.__send__(meth, *args)  #   @feed.nil? nil : @feed.author
+        @feed.__send__(meth, *args) unless @feed.nil?   #   @feed.author unless @feed.nil?
       end                                               # end
     end    
     

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: jsl-feedtosis
 version: !ruby/object:Gem::Version 
-  version: 0.0.3.1
+  version: 0.0.3.2
 platform: ruby
 authors: 
 - Justin Leitgeb
@@ -76,7 +76,6 @@ files:
 - spec/fixtures/xml/older_wooster.xml
 - spec/fixtures/xml/wooster.xml
 - spec/feedtosis/client_spec.rb
-- spec/feedtosis_spec.rb
 - spec/feedtosis/result_spec.rb
 - spec/spec_helper.rb
 has_rdoc: true
@@ -112,7 +111,6 @@ signing_key:
 specification_version: 2
 summary: Retrieves feeds using conditional GET and marks entries that you haven't seen before
 test_files: 
-- spec/feedtosis_spec.rb
 - spec/spec_helper.rb
 - spec/feedtosis/client_spec.rb
 - spec/feedtosis/result_spec.rb

data/spec/feedtosis_spec.rb

@@ -1,5 +0,0 @@
-require File.join(File.dirname(__FILE__),  'spec_helper')
-
-describe Feedtosis do
-  
-end