jshint_on_rails 1.0.2 → 1.0.3

data/README.markdown

@@ -27,7 +27,7 @@ The default config allows you to:
 
 To start checking your stuff run the following:
 
-    [bundle exec] rake jslint
+    [bundle exec] rake jshint
 
 Then you should see:
 
@@ -60,7 +60,7 @@ If anything is wrong, you will get something like this instead:
 If you want to test specific file or files (just once, without modifying the config), you can pass paths to include
 and/or paths to exclude to the rake task:
 
-    rake jslint paths=public/javascripts/models/*.js,public/javascripts/lib/*.js exclude_paths=public/javascripts/lib/jquery.js
+    rake jshint paths=public/javascripts/models/*.js,public/javascripts/lib/*.js exclude_paths=public/javascripts/lib/jquery.js
 
 
 ## Credits

data/lib/jshint.rb

@@ -2,6 +2,6 @@ require 'jshint/errors'
 require 'jshint/utils'
 require 'jshint/lint'
 
-if defined?(Rails) && Rails::VERSION::MAJOR == 3
+if defined?(Rails) && Rails::VERSION::MAJOR >= 3
   require 'jshint/railtie'
 end

data/lib/jshint/tasks.rb

@@ -5,6 +5,7 @@ desc "Run JSHint check on selected Javascript files"
 task :jshint do
   include_paths = JSHint::Utils.paths_from_command_line('paths')
   exclude_paths = JSHint::Utils.paths_from_command_line('exclude_paths')
+  config_path = JSHint::Utils.path_from_command_line('config_path')
 
   if include_paths && exclude_paths.nil?
     # if you pass paths= on command line but not exclude_paths=, and you have exclude_paths
@@ -13,7 +14,10 @@ task :jshint do
     exclude_paths = []
   end
 
-  lint = JSHint::Lint.new :paths => include_paths, :exclude_paths => exclude_paths
+  options = {:paths => include_paths, :exclude_paths => exclude_paths}
+  options[:config_path] = config_path if config_path
+
+  lint = JSHint::Lint.new options
   lint.run
 end
 

data/lib/jshint/utils.rb

@@ -3,7 +3,7 @@ require 'yaml'
 
 module JSHint
 
-  VERSION = "1.0.2"
+  VERSION = "1.0.3"
   DEFAULT_CONFIG_FILE = File.expand_path(File.dirname(__FILE__) + "/config/jshint.yml")
 
   class << self
@@ -43,6 +43,10 @@ module JSHint
         list.reject { |entry| excluded.any? { |f| File.identical?(f, entry) }}
       end
 
+      def path_from_command_line(field)
+        ENV[field] || ENV[field.upcase]
+      end
+
       def paths_from_command_line(field)
         argument = ENV[field] || ENV[field.upcase]
         argument && argument.split(/,/)

data/spec/utils_spec.rb

@@ -13,50 +13,71 @@ describe JSHint::Utils do
     JSHint.config_path.should == 'some/path'
   end
 
+  describe "path_from_command_line" do
+    it "should extract a path from the command line argument" do
+      ENV['test_arg'] = 'file.js'
+      JSU.path_from_command_line('test_arg').should == 'file.js'
+    end
+
+    it "should work if the argument name is given in uppercase" do
+      ENV['TEST_ARG'] = 'file.js'
+      JSU.path_from_command_line('test_arg').should == 'file.js'
+    end
+
+    it "should return nil if the argument isn't set" do
+      JSU.path_from_command_line('crash').should be_nil
+    end
+
+    after :each do
+      ENV['test_arg'] = nil
+      ENV['TEST_ARG'] = nil
+    end
+  end
+
   describe "paths_from_command_line" do
     it "should extract an array of paths from command line argument" do
       ENV['test_arg'] = 'one,two,three'
       JSU.paths_from_command_line('test_arg').should == ['one', 'two', 'three']
     end
-  
+
     it "should also work if the argument name is given in uppercase" do
       ENV['TEST_ARG'] = 'ruby,python,js'
       JSU.paths_from_command_line('test_arg').should == ['ruby', 'python', 'js']
     end
-  
+
     it "should return nil if the argument isn't set" do
       JSU.paths_from_command_line('crash').should be_nil
     end
-  
+
     after :each do
       ENV['test_arg'] = nil
       ENV['TEST_ARG'] = nil
     end
   end
-  
+
   describe "load_config_file" do
-  
+
     before :all do
       File.open("sample.yml", "w") { |f| f.puts("framework: rails") }
       Dir.mkdir("tmp")
     end
-  
+
     it "should load a YAML file if it can be read" do
       JSU.load_config_file("sample.yml").should == { 'framework' => 'rails' }
     end
-  
+
     it "should return an empty hash if file name is nil" do
       JSU.load_config_file(nil).should == {}
     end
-  
+
     it "should return an empty hash if file doesn't exist" do
       JSU.load_config_file("crack.exe").should == {}
     end
-  
+
     it "should return an empty hash if file is not a file" do
       JSU.load_config_file("tmp").should == {}
     end
-  
+
     it "should return an empty hash if file is not readable" do
       File.should_receive(:readable?).once.with("sample.yml").and_return(false)
       JSU.load_config_file("sample.yml").should == {}

metadata

@@ -1,32 +1,22 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: jshint_on_rails
-version: !ruby/object:Gem::Version 
-  hash: 19
+version: !ruby/object:Gem::Version
+  version: 1.0.3
   prerelease: 
-  segments: 
-  - 1
-  - 0
-  - 2
-  version: 1.0.2
 platform: ruby
-authors: 
+authors:
 - Bruno Gouveia
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2011-08-26 00:00:00 Z
+date: 2013-05-23 00:00:00.000000000 Z
 dependencies: []
-
 description: JSHint wrapped in a Ruby gem for easier use
 email: brunogouveia@buzungo.com.br
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - MIT-LICENSE
 - README.markdown
 - Changelog.markdown
@@ -51,36 +41,28 @@ files:
 - spec/utils_spec.rb
 homepage: http://github.com/bgouveia/jshint_on_rails
 licenses: []
-
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-requirements: 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements:
 - Java JRE (5.0 or later)
 rubyforge_project: 
-rubygems_version: 1.8.8
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
-summary: JSHint is a little more flexible JavaScript checker, wrapped in a Ruby gem for easier use
+summary: JSHint is a little more flexible JavaScript checker, wrapped in a Ruby gem
+  for easier use
 test_files: []
-