jsbundling-rails 0.2.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6b3886c122782f8cee3ae39317eee237ffe67500f2b6e8e4d0e46192d3214c5b
-  data.tar.gz: ede0353d4327d3dff14c7f119271cc40883d76e7bb2fdaf442ba8b508e33961b
+  metadata.gz: 8ce188ae363db40e27c1a8f004caeaf9adf86c0b131fe99a9c77364c489e42bb
+  data.tar.gz: d772728a1e1032449e3d24663c6d5f83386209837351f37ae55606e544fcb199
 SHA512:
-  metadata.gz: 989e1c975ed68bcbb5ed1beb7fdda1b46ec7f8dd764ebf1c0871300541bd651fe74aefd8ac5c4379e347141d7e21553052d03f0ac31e3e580e72d9acabe92daa
-  data.tar.gz: e17204a1e4e953ada58ccead4e26b4f636075592b97f12b0bba0644d55a54431086b1ca944855f679db5c200870869a4a838371517097d873f2b0dfa67fe4858
+  metadata.gz: 6961a70f2ced4686fb65ab8b16a97bd744604e22f7f7aeb23b42f98c13f9f72164b38d741f4710a7d79982166ae4f7923045406826d40281e5927202669c9f5e
+  data.tar.gz: e6d21762f3b86eeef19fdff1b2ddd9d3cba6035673ccb5d94948e377f0c788d25c464e9a1216c68c131908e7536a7dd45a628f374972bfe8d62603cd1be2c1bf

data/README.md

@@ -16,8 +16,9 @@ That's it!
 
 You can configure your bundler options in the `build` script in `package.json` or via the installer-generated `rollup.config.js` for rollup.js or `webpack.config.json` for Webpack (esbuild does not have a default configuration format, and we don't intend to use esbuild as an API in order to hack around it).
 
-If you're already using [`webpacker`](https://github.com/rails/webpacker) and you're wondering if you should migrate to `jsbundling-rails`, have a look at [the high-level comparison](./docs/comparison_with_webpacker.md).
+If you're already using [`webpacker`](https://github.com/rails/webpacker) and you're wondering if you should migrate to `jsbundling-rails`, have a look at [the high-level comparison](./docs/comparison_with_webpacker.md). If you're looking to migrate from webpacker, see the [migration guide](https://github.com/rails/jsbundling-rails/blob/main/docs/switch_from_webpacker.md).
 
+If you want to use webpack features like [code splitting](https://webpack.js.org/guides/code-splitting/) and [hot module reloading](https://webpack.js.org/concepts/hot-module-replacement/), consider using the official fork of `webpacker`, [`shakapacker`](https://github.com/shakacode/shakapacker).
 
 ## Installation
 
@@ -38,7 +39,7 @@ The default build script for esbuild relies on the `app/javascript/*.*` glob pat
 
 ## Why does esbuild overwrite my application.css?
 
-If you [import CSS](https://esbuild.github.io/content-types/#css-from-js) in your application.js while using esbuild, you'll be creating both an `app/assets/builds/application.js` _and_ `app/assets/builds/application.css` file when bundling. The latter can conflict with the `app/assets/builds/application.js` produced by [cssbundling-rails](https://github.com/rails/cssbundling-rails). The solution is to either change the output file for esbuild (and the references for that) or for cssbundling. Both are specified in `package.json`. 
+If you [import CSS](https://esbuild.github.io/content-types/#css-from-js) in your application.js while using esbuild, you'll be creating both an `app/assets/builds/application.js` _and_ `app/assets/builds/application.css` file when bundling. The latter can conflict with the `app/assets/builds/application.css` produced by [cssbundling-rails](https://github.com/rails/cssbundling-rails). The solution is to either change the output file for esbuild (and the references for that) or for cssbundling. Both are specified in `package.json`. 
 
 
 ## License

data/lib/install/dev

@@ -1,9 +1,9 @@
 #!/usr/bin/env bash
 
-if ! command -v foreman &> /dev/null
+if ! gem list --silent --installed foreman
 then
   echo "Installing foreman..."
   gem install foreman
 fi
 
-foreman start -f Procfile.dev
+foreman start -f Procfile.dev "$@"

data/lib/install/esbuild/install.rb

@@ -8,4 +8,5 @@ if (`npx -v`.to_f < 7.1 rescue "Missing")
   say %(Add "scripts": { "build": "#{build_script}" } to your package.json), :green
 else
   run %(npm set-script build "#{build_script}")
+  run %(yarn build)
 end

data/lib/install/rollup/install.rb

@@ -9,4 +9,5 @@ if (`npx -v`.to_f < 7.1 rescue "Missing")
   say %(Add "scripts": { "build": "#{build_script}" } to your package.json), :green
 else
   run %(npm set-script build "#{build_script}")
+  run %(yarn build)
 end

data/lib/install/webpack/install.rb

@@ -9,4 +9,5 @@ if (`npx -v`.to_f < 7.1 rescue "Missing")
   say %(Add "scripts": { "build": "#{build_script}" } to your package.json), :green
 else
   run %(npm set-script build "#{build_script}")
+  run %(yarn build)
 end

data/lib/jsbundling/version.rb

@@ -1,3 +1,3 @@
 module Jsbundling
-  VERSION = "0.2.0"
+  VERSION = "1.0.1"
 end

data/lib/tasks/jsbundling/build.rake

@@ -1,13 +1,15 @@
 namespace :javascript do
   desc "Build your JavaScript bundle"
-  task build: [ "yarn:install" ] do
-    unless system "yarn build"
+  task :build do
+    unless system "yarn install && yarn build"
       raise "jsbundling-rails: Command build failed, ensure yarn is installed and `yarn build` runs without errors"
     end
   end
 end
 
-Rake::Task["assets:precompile"].enhance(["javascript:build"])
+if Rake::Task.task_defined?("assets:precompile")
+  Rake::Task["assets:precompile"].enhance(["javascript:build"])
+end
 
 if Rake::Task.task_defined?("test:prepare")
   Rake::Task["test:prepare"].enhance(["javascript:build"])

data/lib/tasks/jsbundling/clobber.rake

@@ -0,0 +1,10 @@
+namespace :javascript do
+  desc "Remove JavaScript builds"
+  task :clobber do
+    rm_rf Dir["app/assets/builds/[^.]*.js"], verbose: false
+  end
+end
+
+if Rake::Task.task_defined?("assets:clobber")
+  Rake::Task["assets:clobber"].enhance(["javascript:clobber"])
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: jsbundling-rails
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 1.0.1
 platform: ruby
 authors:
 - David Heinemeier Hansson
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-11-15 00:00:00.000000000 Z
+date: 2022-02-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -46,7 +46,7 @@ files:
 - lib/jsbundling/engine.rb
 - lib/jsbundling/version.rb
 - lib/tasks/jsbundling/build.rake
-- lib/tasks/jsbundling/clean.rake
+- lib/tasks/jsbundling/clobber.rake
 - lib/tasks/jsbundling/install.rake
 homepage: https://github.com/rails/jsbundling-rails
 licenses:
@@ -67,7 +67,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.22
+rubygems_version: 3.2.32
 signing_key:
 specification_version: 4
 summary: Bundle and transpile JavaScript in Rails with esbuild, rollup.js, or Webpack.

data/lib/tasks/jsbundling/clean.rake

@@ -1,8 +0,0 @@
-namespace :javascript do
-  desc "Remove JavaScript builds"
-  task :clean do
-    rm_rf Dir["app/assets/builds/[^.]*.js"], verbose: false
-  end
-end
-
-Rake::Task["assets:clean"].enhance(["javascript:clean"])