jsbundling-rails 0.1.4 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7a33dca86c8cca2151366ae5d1d18262cfca426ff330745c2168b621b9e66f2e
-  data.tar.gz: 2ac326bf65dde1b8dbdc1c50d133188c307debab60f92938d790c508c81d7e6c
+  metadata.gz: e53bb1aef74de39d8fdbe9a5f234d0a34d9cc26cc84b708711c0eaadb77f4dcd
+  data.tar.gz: c5b34643c871c1d74f6c763fd6ebea88e305349b70500cc54e1f973cdbb6821f
 SHA512:
-  metadata.gz: d1640ce2af097577e53947e1ac936ec815a67901d33856db90d17da4fa1ee42c412c50c69320de081fb935113e16752ca58f230cf091eb7093cb96c7c891faa0
-  data.tar.gz: 315d928a0f866a1b9152bc2773f3f7168f4bee47726aa111414f43a60947953d511b433b47cbbcc9481062168617fd28c5d5137fe29f294381604fec954092ae
+  metadata.gz: 348217cf1a66e4b84f293102308fae17c48ef09ece24fe2cfbe408bdee570de7766704a82737a892a89d38e034282823ce2ac93ae18207f75ae76555c31c1499
+  data.tar.gz: 94ea08798d3ab189f4bdd89037a4a0fe547a1b27438b1a6127023f8fc3b87c44ae629e7b65871a79f55bc0dec15211d2b01b212acefcd96e0bad998cbb10925a

data/README.md

@@ -8,10 +8,14 @@ When you deploy your application to production, the `javascript:build` task atta
 
 This also happens in testing where the bundler attaches to the `test:prepare` task to ensure the JavaScript has been bundled before testing commences. (Note that this currently only applies to rails `test:*` tasks (like `test:all` or `test:controllers`), not "rails test", as that doesn't load `test:prepare`).
 
+If your testing library of choice does not define a `test:prepare` Rake task, ensure that your test suite runs `javascript:build` to bundle JavaScript before testing commences.
+
 That's it!
 
 You can configure your bundler options in the `build` script in `package.json` or via the installer-generated `rollup.config.js` for rollup.js or `webpack.config.json` for Webpack (esbuild does not have a default configuration format).
 
+If you're already using [`webpacker`](https://github.com/rails/webpacker) and you're wondering if you should migrate to `jsbundling-rails`, have a look at [the high-level comparison](./docs/comparison_with_webpacker.md).
+
 
 ## Installation
 

data/lib/install/install.rb

@@ -1,10 +1,14 @@
 say "Compile into app/assets/builds"
 empty_directory "app/assets/builds"
 keep_file "app/assets/builds"
-append_to_file "app/assets/config/manifest.js", %(//= link_tree ../builds\n)
+
+if (sprockets_manifest_path = Rails.root.join("app/assets/config/manifest.js")).exist?
+  append_to_file sprockets_manifest_path, %(//= link_tree ../builds\n)
+end
 
 if Rails.root.join(".gitignore").exist?
-  append_to_file(".gitignore", %(/app/assets/builds\n!/app/assets/builds/.keep\n))
+  append_to_file(".gitignore", %(\n/app/assets/builds/*\n!/app/assets/builds/.keep\n))
+  append_to_file(".gitignore", %(\n/node_modules\n))
 end
 
 if (app_layout_path = Rails.root.join("app/views/layouts/application.html.erb")).exist?
@@ -28,7 +32,7 @@ unless Rails.root.join("package.json").exist?
 end
 
 if Rails.root.join("Procfile.dev").exist?
-  append_to_file "Procfile.dev", "js: yarn build --watch"
+  append_to_file "Procfile.dev", "js: yarn build --watch\n"
 else
   say "Add default Procfile.dev"
   copy_file "#{__dir__}/Procfile.dev", "Procfile.dev"

data/lib/install/webpack/webpack.config.js

@@ -3,9 +3,11 @@ const webpack = require('webpack')
 
 module.exports = {
   mode: "production",
-  entry: "./app/javascript/application.js",
+  entry: {
+    application: "./app/javascript/application.js"
+  },
   output: {
-    filename: "application.js",
+    filename: "[name].js",
     path: path.resolve(__dirname, "app/assets/builds"),
   },
   plugins: [

data/lib/jsbundling/version.rb

@@ -1,3 +1,3 @@
 module Jsbundling
-  VERSION = "0.1.4"
+  VERSION = "0.1.8"
 end

data/lib/tasks/jsbundling/build.rake

@@ -1,9 +1,16 @@
 namespace :javascript do
   desc "Build your JavaScript bundle"
   task :build do
-    system "yarn install && yarn build"
+    unless system "yarn install && yarn build"
+      raise "jsbundling-rails: Command build failed, ensure yarn is installed and `yarn build` runs without errors"
+    end
   end
 end
 
 Rake::Task["assets:precompile"].enhance(["javascript:build"])
-Rake::Task["test:prepare"].enhance(["javascript:build"])
+
+if Rake::Task.task_defined?("test:prepare")
+  Rake::Task["test:prepare"].enhance(["javascript:build"])
+elsif Rake::Task.task_defined?("db:test:prepare")
+  Rake::Task["db:test:prepare"].enhance(["javascript:build"])
+end

metadata

@@ -1,17 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: jsbundling-rails
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.8
 platform: ruby
 authors:
 - David Heinemeier Hansson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-09-08 00:00:00.000000000 Z
+date: 2021-09-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rails
+  name: railties
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="