jsbundling-rails 0.1.2 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9762e5fde71d683691b621554e6067ac5c0bcb78bd776c7509ad60cc27326f47
-  data.tar.gz: 7e30a0361d250e21bddb58f78c4a384280e8367d1e0a7d4b724fecf4b6291124
+  metadata.gz: e2faa669bdcf9cad7f6b3c3764750ff01ed4f5c1b7deec7700157f00d1c24ffd
+  data.tar.gz: 70b3c1e0341354e9d3c3558c36a744791b341924e30593792ef2890d135a6744
 SHA512:
-  metadata.gz: b96d6b4d31220c27f6ecb109bed9669029721c6f9b0e0e395497f97402c1f229d64211073fb494f7bc743808605b6b61447d7021e2cf6d4c450d0795da27c773
-  data.tar.gz: cf43abe223d0eadd63c4e698bb51eb4544a65a8ea21b9d4cd161b00434dae095eb9625dff7b82bea3823d288a5d60d87c3eb11c2cc74a1bd4437436aa3d2c9ea
+  metadata.gz: b5902ba118b81d7abda630646497ecf2fbbd90f4051da9486d2b5ab6359b05d4055f068b35dd585bf02725e81be6784af340cddcce36994b8032bbace7504462
+  data.tar.gz: ef99f2630a4abea6cfb43a59475ad143ec86e55280591a0ee166798d74974703d3c45e0733b62a4f583dc995087508cdd775833e4a8342423835223e8fab5257

data/README.md

@@ -8,14 +8,18 @@ When you deploy your application to production, the `javascript:build` task atta
 
 This also happens in testing where the bundler attaches to the `test:prepare` task to ensure the JavaScript has been bundled before testing commences. (Note that this currently only applies to rails `test:*` tasks (like `test:all` or `test:controllers`), not "rails test", as that doesn't load `test:prepare`).
 
+If your testing library of choice does not define a `test:prepare` Rake task, ensure that your test suite runs `javascript:build` to bundle JavaScript before testing commences.
+
 That's it!
 
 You can configure your bundler options in the `build` script in `package.json` or via the installer-generated `rollup.config.js` for rollup.js or `webpack.config.json` for Webpack (esbuild does not have a default configuration format).
 
+If you're already using [`webpacker`](https://github.com/rails/webpacker) and you're wondering if you should migrate to `jsbundling-rails`, have a look at [the high-level comparison](./docs/comparison_with_webpacker.md).
+
 
 ## Installation
 
-You must already have node and yarn installed on your system. Then:
+You must already have node and yarn installed on your system. You will also need npx version 7.1.0 or later. Then:
 
 1. Add `jsbundling-rails` to your Gemfile with `gem 'jsbundling-rails'`
 2. Run `./bin/bundle install`

data/lib/install/Procfile.dev

@@ -1,2 +1,2 @@
-web: bin/rails server
+web: bin/rails server -p 3000
 js: yarn build --watch

data/lib/install/install.rb

@@ -1,10 +1,14 @@
 say "Compile into app/assets/builds"
 empty_directory "app/assets/builds"
 keep_file "app/assets/builds"
-append_to_file "app/assets/config/manifest.js", %(//= link_tree ../builds\n)
+
+if (sprockets_manifest_path = Rails.root.join("app/assets/config/manifest.js")).exist?
+  append_to_file sprockets_manifest_path, %(//= link_tree ../builds\n)
+end
 
 if Rails.root.join(".gitignore").exist?
-  append_to_file ".gitignore", %(/app/assets/builds\n)
+  append_to_file(".gitignore", %(\n/app/assets/builds/*\n!/app/assets/builds/.keep\n))
+  append_to_file(".gitignore", %(\n/node_modules\n))
 end
 
 if (app_layout_path = Rails.root.join("app/views/layouts/application.html.erb")).exist?
@@ -28,7 +32,7 @@ unless Rails.root.join("package.json").exist?
 end
 
 if Rails.root.join("Procfile.dev").exist?
-  append_to_file "Procfile.dev", "js: yarn build --watch"
+  append_to_file "Procfile.dev", "js: yarn build --watch\n"
 else
   say "Add default Procfile.dev"
   copy_file "#{__dir__}/Procfile.dev", "Procfile.dev"

data/lib/install/webpack/webpack.config.js

@@ -3,9 +3,11 @@ const webpack = require('webpack')
 
 module.exports = {
   mode: "production",
-  entry: "./app/javascript/application.js",
+  entry: {
+    application: "./app/javascript/application.js"
+  },
   output: {
-    filename: "application.js",
+    filename: "[name].js",
     path: path.resolve(__dirname, "app/assets/builds"),
   },
   plugins: [

data/lib/jsbundling/version.rb

@@ -1,3 +1,3 @@
 module Jsbundling
-  VERSION = "0.1.2"
+  VERSION = "0.1.7"
 end

data/lib/tasks/jsbundling/build.rake

@@ -6,4 +6,9 @@ namespace :javascript do
 end
 
 Rake::Task["assets:precompile"].enhance(["javascript:build"])
-Rake::Task["test:prepare"].enhance(["javascript:build"])
+
+if Rake::Task.task_defined?("test:prepare")
+  Rake::Task["test:prepare"].enhance(["javascript:build"])
+elsif Rake::Task.task_defined?("db:test:prepare")
+  Rake::Task["db:test:prepare"].enhance(["javascript:build"])
+end

metadata

@@ -1,17 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: jsbundling-rails
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.7
 platform: ruby
 authors:
 - David Heinemeier Hansson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-09-08 00:00:00.000000000 Z
+date: 2021-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rails
+  name: railties
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="