js_spec 0.0.1 → 0.1.0

data/lib/js_spec.rb

@@ -1,13 +1,22 @@
 require "rubygems"
 require "rack"
 require "mongrel"
+require "fileutils"
+require "tmpdir"
+require "timeout"
+require "uuid"
 
 dir = File.dirname(__FILE__)
+require "#{dir}/js_spec/resources/runners"
+require "#{dir}/js_spec/resources/runners/firefox_runner"
+
 require "#{dir}/js_spec/server"
-require "#{dir}/js_spec/spec_runner"
-require "#{dir}/js_spec/spec_file_runner"
-require "#{dir}/js_spec/spec_dir_runner"
-require "#{dir}/js_spec/file"
-require "#{dir}/js_spec/dir"
-require "#{dir}/js_spec/web_root"
-require "#{dir}/js_spec/suite_result"
+require "#{dir}/js_spec/rails_server"
+require "#{dir}/js_spec/resources/spec_runner"
+require "#{dir}/js_spec/resources/spec_file_runner"
+require "#{dir}/js_spec/resources/spec_dir_runner"
+require "#{dir}/js_spec/resources/file"
+require "#{dir}/js_spec/resources/dir"
+require "#{dir}/js_spec/resources/web_root"
+require "#{dir}/js_spec/resources/suite"
+require "#{dir}/js_spec/resources/suite_finish"

data/spec/{functional_spec_suite.rb → functional_suite.rb}

@@ -1,4 +1,4 @@
-class JsSpecFunctionalSuite
+class FunctionalSuite
   def run
     dir = File.dirname(__FILE__)
     Dir["#{dir}/functional/**/*_spec.rb"].each do |file|
@@ -7,4 +7,4 @@ class JsSpecFunctionalSuite
   end
 end
 
-JsSpecFunctionalSuite.new.run
+FunctionalSuite.new.run

data/spec/spec_suite.rb

@@ -1,3 +1,3 @@
 dir = File.dirname(__FILE__)
-raise "Failure" unless system(%Q|ruby #{dir}/unit_spec_suite.rb|)
-raise "Failure" unless system(%Q|ruby #{dir}/functional_spec_suite.rb|)
+raise "Failure" unless system(%Q|ruby #{dir}/unit_suite.rb|)
+raise "Failure" unless system(%Q|ruby #{dir}/functional_suite.rb|)

data/spec/unit/rails_server_spec.rb

@@ -0,0 +1,44 @@
+require File.expand_path("#{File.dirname(__FILE__)}/unit_spec_helper")
+
+module JsSpec
+  describe RailsServer do
+    it "subclasses Server" do
+      RailsServer.superclass.should == Server
+    end
+
+    describe ".run" do
+      attr_reader :rails_root
+      before do
+        @rails_root = "/rails/root"
+        Server.instance = nil
+      end
+
+      it "initializes the RailsServer and runs the Mongrel Handler and sets Server.instance to the RailsServer instance" do
+        host = Server::DEFAULT_HOST
+        port = Server::DEFAULT_PORT
+        server_instance = Object.new
+        mock.proxy(RailsServer).new(
+          rails_root,
+          host,
+          port
+        ) do |new_instance|
+          server_instance
+        end
+        mock(Rack::Handler::Mongrel).run(server_instance, {:Host => host, :Port => port})
+
+        RailsServer.run(rails_root)
+        Server.instance.should == server_instance
+      end
+    end
+
+    describe "#initialize" do
+      it "sets the server paths based on the passed in rails root" do
+        rails_root = "/rails/root"
+        server = RailsServer.new(rails_root)
+        server.spec_root_path.should == "#{rails_root}/spec/javascripts"
+        server.implementation_root_path.should == "#{rails_root}/public/javascripts"
+        server.public_path.should == "#{rails_root}/public"
+      end
+    end
+  end
+end

data/spec/unit/{dir_spec.rb → resources/dir_spec.rb}

@@ -1,18 +1,19 @@
-require File.expand_path("#{File.dirname(__FILE__)}/unit_spec_helper")
+require File.expand_path("#{File.dirname(__FILE__)}/../unit_spec_helper")
 
 module JsSpec
-  describe Dir do
+  module Resources
+    describe Dir do
     attr_reader :dir, :absolute_path, :relative_path
 
     describe "in core dir" do
       before do
         @absolute_path = core_path
         @relative_path = "/core"
-        @dir = JsSpec::Dir.new(absolute_path, relative_path)
+        @dir = Resources::Dir.new(absolute_path, relative_path)
       end
 
       describe "#locate when passed a name of a real file" do
-        it "returns a JsSpec::File representing it" do
+        it "returns a Resources::File representing it" do
           file = dir.locate("JSSpec.css")
           file.relative_path.should == "/core/JSSpec.css"
           file.absolute_path.should == "#{core_path}/JSSpec.css"
@@ -24,7 +25,7 @@ module JsSpec
       before do
         @absolute_path = spec_root_path
         @relative_path = "/specs"
-        @dir = JsSpec::Dir.new(absolute_path, relative_path)
+        @dir = Resources::Dir.new(absolute_path, relative_path)
       end
 
       it "has an absolute path" do
@@ -36,7 +37,7 @@ module JsSpec
       end
 
       describe "#locate when passed the name with an extension" do
-        it "when file exists, returns a JsSpec::File representing it" do
+        it "when file exists, returns a Resources::File representing it" do
           file = dir.locate("failing_spec.js")
           file.relative_path.should == "/specs/failing_spec.js"
           file.absolute_path.should == "#{spec_root_path}/failing_spec.js"
@@ -56,7 +57,7 @@ module JsSpec
 
         it "when name corresponds to a subdirectory, returns a DirectoryRunner for the directory" do
           subdir = dir.locate("foo")
-          subdir.should be_an_instance_of(JsSpec::Dir)
+          subdir.should be_an_instance_of(Resources::Dir)
           subdir.should == spec_dir("/foo")
         end
 
@@ -76,7 +77,8 @@ module JsSpec
           globbed_files.should contain_spec_file_with_correct_paths("/foo/failing_spec.js")
           globbed_files.should contain_spec_file_with_correct_paths("/foo/passing_spec.js")
         end
-      end      
+      end
     end
   end
+  end
 end

data/spec/unit/{file_spec.rb → resources/file_spec.rb}

@@ -1,11 +1,12 @@
-require File.expand_path("#{File.dirname(__FILE__)}/unit_spec_helper")
+require File.expand_path("#{File.dirname(__FILE__)}/../unit_spec_helper")
 
 module JsSpec
-  describe File do
+  module Resources
+    describe File do
     attr_reader :file
 
     before do
-      @file = JsSpec::File.new(absolute_path, relative_path)
+      @file = Resources::File.new(absolute_path, relative_path)
     end
 
     def absolute_path
@@ -66,13 +67,18 @@ module JsSpec
 
     describe "==" do
       it "returns true when passed a file with the same absolute and relative paths" do
-        file.should == JsSpec::File.new(absolute_path, relative_path)
+        file.should == Resources::File.new(absolute_path, relative_path)
       end
 
       it "returns false when passed a file with a different absolute or relative path" do
-        file.should_not == JsSpec::File.new(absolute_path, "bogus")
-        file.should_not == JsSpec::File.new("bogus", relative_path)
+        file.should_not == Resources::File.new(absolute_path, "bogus")
+        file.should_not == Resources::File.new("bogus", relative_path)
+      end
+
+      it "when passed a Dir, returns false because File is not a Dir" do
+        file.should_not == Resources::Dir.new(absolute_path, relative_path)
       end
     end
   end
+  end
 end

data/spec/unit/resources/runner_spec.rb

@@ -0,0 +1,24 @@
+require File.expand_path("#{File.dirname(__FILE__)}/../unit_spec_helper")
+
+module JsSpec
+  module Resources
+    describe Runners do
+    attr_reader :runner
+    before do
+      @runner = Runners.new
+    end
+
+    describe "#locate" do
+      it "when passed 'firefox', returns a FirefoxRunner" do
+        runner.locate('firefox').should be_instance_of(Runners::FirefoxRunner)
+      end
+
+      it "when not passed 'firefox', raises an error" do
+        lambda do
+          runner.locate('invalid')
+        end.should raise_error
+      end
+    end
+  end
+  end
+end

data/spec/unit/resources/runners/firefox_runner_spec.rb

@@ -0,0 +1,87 @@
+require File.expand_path("#{File.dirname(__FILE__)}/../../unit_spec_helper")
+
+module JsSpec
+  module Resources
+    describe Runners::FirefoxRunner do
+    attr_reader :runner
+    before do
+      @runner = Runners::FirefoxRunner.new
+    end
+
+    describe "#post" do
+      attr_reader :firefox_profile_path
+      before do
+        dir = ::File.dirname(__FILE__)
+        @firefox_profile_path = ::File.expand_path("#{dir}/../../../../resources/firefox")
+        ::File.should be_directory(firefox_profile_path)
+      end
+
+      it "returns ''" do
+        guid = nil
+        stub.proxy(UUID).new {|guid| guid = guid}
+        stub(runner).system {true}
+        stub(runner).sleep(0.5)
+        stub(runner).sleep {Kernel.sleep}
+
+        post_return_value = nil
+        Thread.start do
+          post_return_value = runner.post
+        end
+        wait_for do
+          Runners::FirefoxRunner.threads[guid]
+        end
+        Runners::FirefoxRunner.resume(guid, 'foobar')
+
+        wait_for do
+          post_return_value == 'foobar'
+        end
+      end
+
+      def wait_for(timeout=5)
+        Timeout.timeout(timeout) do
+          loop do
+            break if yield
+          end
+        end
+      end
+
+      it "copies the firefox profile files to a tmp directory " <<
+        "and creates a profile " <<
+        "and waits for profile to be created " <<
+        "and starts firefox" do
+        stub(runner).sleep
+
+        mock(runner).system("cp -R #{firefox_profile_path} #{runner.profile_dir}").ordered {true}
+        mock(runner).system("firefox -profile #{runner.profile_dir} -chrome chrome://killff/content/kill.html").ordered {true}
+        mock(::File).exists?("#{runner.profile_dir}/parent.lock").ordered {false}
+        mock(runner).sleep(0.5).ordered
+        mock(::File).exists?("#{runner.profile_dir}/parent.lock").ordered {false}
+        mock(runner).system(Regexp.new("firefox -profile #{runner.profile_dir} http://localhost:8080/specs")).ordered {true}
+        stub(runner).callcc
+        runner.post
+      end
+
+      it "calls #copy_profile_files, #create_profile, #wait_for_full_profile_to_be_created, and #start_browser" do
+        stub(runner).system {true}
+        stub(runner).sleep
+        stub(runner).callcc
+
+        mock.proxy(runner).copy_profile_files.ordered
+        mock.proxy(runner).create_profile.ordered
+        mock.proxy(runner).wait_for_full_profile_to_be_created.ordered
+        mock.proxy(runner).start_browser(is_a(String)).ordered
+
+        runner.post
+      end
+    end
+
+    describe "#start_browser" do
+      it "starts a firefox browser in a thread" do
+        mock(Thread).start.yields
+        mock(runner).system("firefox -profile #{runner.profile_dir} http://localhost:8080/specs?guid=foobar").ordered {true}
+        runner.__send__(:start_browser, "foobar")
+      end
+    end
+  end
+  end
+end

data/spec/unit/{spec_dir_runner_spec.rb → resources/spec_dir_runner_spec.rb}

@@ -1,14 +1,15 @@
-require File.expand_path("#{File.dirname(__FILE__)}/unit_spec_helper")
+require File.expand_path("#{File.dirname(__FILE__)}/../unit_spec_helper")
 
 module JsSpec
-  describe SpecDirRunner do
+  module Resources
+    describe SpecDirRunner do
     attr_reader :dir, :runner
 
     before do
       @dir = Dir.new(spec_root_path, '/specs')
       @runner = SpecDirRunner.new(dir)
     end
-    
+
     describe "#spec_files" do
       it "returns a File for each *_spec.js file in the directory" do
         spec_files = runner.spec_files
@@ -38,4 +39,5 @@ module JsSpec
       end
     end
   end
+  end
 end

data/spec/unit/resources/spec_file_runner_spec.rb

@@ -0,0 +1,20 @@
+require File.expand_path("#{File.dirname(__FILE__)}/../unit_spec_helper")
+
+module JsSpec
+  module Resources
+    describe SpecFileRunner, "#spec_files" do
+      attr_reader :absolute_path, :relative_path, :file, :runner
+
+      before do
+        @absolute_path = "#{spec_root_path}/failing_spec.js"
+        @relative_path = "/specs/failing_spec.js"
+        @file = File.new(absolute_path, relative_path)
+        @runner = SpecFileRunner.new(file)
+      end
+
+      it "returns the single File to run in an Array" do
+        runner.spec_files.should == [file]
+      end
+    end
+  end
+end

data/spec/unit/resources/suite_finish_spec.rb

@@ -0,0 +1,42 @@
+require File.expand_path("#{File.dirname(__FILE__)}/../unit_spec_helper")
+
+module JsSpec
+  module Resources
+    describe SuiteFinish do
+    attr_reader :stdout, :suite_finish, :suite
+    before do
+      @stdout = StringIO.new
+      SuiteFinish.const_set(:STDOUT, stdout)
+      @suite = Suite.new('foobar')
+      @suite_finish = SuiteFinish.new(suite)
+    end
+
+    after do
+      SuiteFinish.__send__(:remove_const, :STDOUT)
+    end
+
+    describe ".post" do
+      describe "when the request has no guid" do
+        it "writes the body of the request to stdout" do
+          body = "The text in the POST body"
+          request = Rack::Request.new({'rack.input' => StringIO.new("text=#{body}")})
+          request.body.string.should == "text=#{body}"
+          stub.proxy(Server).request {request}
+
+          suite_finish.post
+          stdout.string.should == "#{body}\n"
+        end
+
+        it "returns an empty string" do
+          body = "The text in the POST body"
+          request = Rack::Request.new({'rack.input' => StringIO.new("text=#{body}")})
+          request.body.string.should == "text=#{body}"
+          stub.proxy(Server).request {request}
+
+          suite_finish.post.should == ""
+        end
+      end
+    end
+  end
+  end
+end

data/spec/unit/resources/suite_spec.rb

@@ -0,0 +1,44 @@
+require File.expand_path("#{File.dirname(__FILE__)}/../unit_spec_helper")
+
+module JsSpec
+  module Resources
+    describe Suite do
+    attr_reader :stdout
+    before do
+      @stdout = StringIO.new
+      Suite.const_set(:STDOUT, stdout)
+    end
+
+    after do
+      Suite.__send__(:remove_const, :STDOUT)
+    end
+
+    describe ".locate" do
+      it "when passed an identifier, returns an instance of Suite with the identifier" do
+        instance = Suite.locate('foobar')
+        instance.class.should == Suite
+        instance.id.should == 'foobar'
+      end
+    end
+
+    describe "#locate" do
+      attr_reader :suite
+      before do
+        @suite = Suite.new('foobar')
+      end
+
+      it "when passed 'finish', returns a SuiteFinish that has access to the suite" do
+        suite_finish = suite.locate('finish')
+        suite_finish.class.should == SuiteFinish
+        suite_finish.suite.should == suite
+      end
+
+      it "when not passed 'finish', raises ArgumentError" do
+        lambda do
+          suite.locate('invalid')
+        end.should raise_error(ArgumentError, "Invalid path: invalid")
+      end
+    end
+  end
+  end
+end

data/spec/unit/resources/web_root_spec.rb

@@ -0,0 +1,55 @@
+require File.expand_path("#{File.dirname(__FILE__)}/../unit_spec_helper")
+
+module JsSpec
+  module Resources
+    describe WebRoot do
+      attr_reader :web_root
+      before(:each) do
+        @web_root = WebRoot.new(public_path)
+      end
+
+      describe "#locate" do
+        it "when passed 'specs', returns a SpecDirRunner representing the specs" do
+          runner = web_root.locate('specs')
+          runner.should == spec_dir
+        end
+
+        it "when passed 'core', returns a Dir representing the JsSpec core directory" do
+          runner = web_root.locate('core')
+          runner.should == Resources::Dir.new(JsSpec::Server.core_path, '/core')
+        end
+
+        it "when passed 'implementations', returns a Dir representing the javascript implementations directory" do
+          runner = web_root.locate('implementations')
+          runner.should == Resources::Dir.new(JsSpec::Server.implementation_root_path, '/implementations')
+        end
+
+        it "when passed 'results', returns a Suite" do
+          runner = web_root.locate('suites')
+          runner.should == Resources::Suite
+        end
+
+        it "when passed 'runners', returns a Runner" do
+          runner = web_root.locate('runners')
+          runner.should be_instance_of(Resources::Runners)
+        end
+
+        it "when passed a directory that is in the public_path, returns a Dir representing that directory" do
+          runner = web_root.locate('stylesheets')
+          runner.should == Resources::Dir.new("#{JsSpec::Server.public_path}/stylesheets", '/stylesheets')
+        end
+
+        it "when passed a file that is in the public_path, returns a File representing that file" do
+          runner = web_root.locate('robots.txt')
+          runner.should == Resources::File.new("#{JsSpec::Server.public_path}/robots.txt", '/robots.txt')
+        end
+
+        it "when not passed 'core' or 'specs', raises an error" do
+          lambda do
+            web_root.locate('invalid')
+          end.should raise_error
+        end
+      end
+    end
+  end
+end

data/spec/unit/server_spec.rb

@@ -29,6 +29,17 @@ module JsSpec
         result = get("/core/JSSpec.js").body
         result.should == ::File.read("#{Server.core_path}/JSSpec.js")
       end
+
+      specify "'/stylesheets/example.css', returns the contents of the file" do
+        result = get("/stylesheets/example.css").body
+        result.should == ::File.read("#{Server.public_path}/stylesheets/example.css")
+      end
+
+      specify "'/invalid/path', shows the full invalid path in the error message" do
+        lambda do
+          get("/invalid/path")
+        end.should raise_error(Exception, Regexp.new("/invalid/path"))
+      end
     end
 
     describe ".run" do
@@ -42,36 +53,48 @@ module JsSpec
         host = Server::DEFAULT_HOST
         port = Server::DEFAULT_PORT
 
-        mock.proxy(Server).new(spec_root_path, implementation_root_path, host, port) do
+        mock.proxy(Server).new(spec_root_path, implementation_root_path, public_path, host, port) do
           server_instance
         end
         mock(Rack::Handler::Mongrel).run(server_instance, {:Host => host, :Port => port})
 
-        Server.run(spec_root_path, implementation_root_path)
+        Server.run(spec_root_path, implementation_root_path, public_path)
       end
 
       it "when passed a custom host and port, sets the host and port to the passed in value" do
         host = 'foobar.com'
         port = 80
 
-        mock.proxy(Server).new(spec_root_path, implementation_root_path, host, port) do
+        mock.proxy(Server).new(spec_root_path, implementation_root_path, public_path, host, port) do
           server_instance
         end
         mock(Rack::Handler::Mongrel).run(server_instance, {:Host => host, :Port => port})
 
-        Server.run(spec_root_path, implementation_root_path, {:Host => host, :Port => port})
+        Server.run(spec_root_path, implementation_root_path, public_path, {:Host => host, :Port => port})
+      end
+    end
+
+    describe ".default_url" do
+      it "returns the default host and port" do
+        Server.default_url.should == "http://#{Server::DEFAULT_HOST}:#{Server::DEFAULT_PORT}"
       end
     end
 
     describe ".spec_root" do
       it "returns the Dir " do
-        Server.spec_root_path.should == ::File.expand_path(spec_root_path)
+        Server.spec_root_path.should == spec_root_path
       end
     end
 
     describe ".spec_root_path" do
       it "returns the absolute path of the specs root directory" do
-        Server.spec_root_path.should == ::File.expand_path(spec_root_path)
+        Server.spec_root_path.should == spec_root_path
+      end
+    end
+
+    describe ".public_path" do
+      it "returns the expanded path of the public path" do
+        Server.public_path.should == public_path
       end
     end
 
@@ -85,14 +108,14 @@ module JsSpec
     describe ".implementation_root_path" do
       it "returns the expanded path to the JsSpec implementations directory" do
         dir = ::File.dirname(__FILE__)
-        Server.implementation_root_path.should == ::File.expand_path(implementation_root_path)
+        Server.implementation_root_path.should == implementation_root_path
       end
     end
 
     describe ".request" do
       it "returns request in progress for the thread" do
         the_request = nil
-        stub.instance_of(WebRoot).locate('somedir') do
+        stub.instance_of(Resources::WebRoot).locate('somedir') do
           the_request = JsSpec::Server.request
           Thread.current[:request].should == the_request
           thread2 = Thread.new do
@@ -120,7 +143,7 @@ module JsSpec
     describe ".response" do
       it "returns response in progress" do
         the_response = nil
-        stub.instance_of(WebRoot).locate('somedir') do
+        stub.instance_of(Resources::WebRoot).locate('somedir') do
           the_response = JsSpec::Server.response
           Thread.current[:response].should == the_response
           thread2 = Thread.new do
@@ -145,11 +168,49 @@ module JsSpec
       end
     end
 
-    describe "#initialize" do
-      it "expands relative paths for #spec_root_path and #implementation_root_path" do
-        server = Server.new("foo", "bar")
-        server.spec_root_path.should == ::File.expand_path("foo")
-        server.implementation_root_path.should == ::File.expand_path("bar")
+    describe "#call" do
+      it "when resource responds with a string, sets the string as the response.body" do
+        somedir_resource = Object.new
+        stub.instance_of(Resources::WebRoot).locate('somedir') do
+          somedir_resource
+        end
+
+        def somedir_resource.get
+          "Somedir String"
+        end
+        response = get('/somedir')
+        response.body.should == "Somedir String"
+      end
+
+      describe "when there is an error" do
+        attr_reader :top_line_of_backtrace
+        before do
+          @top_line_of_backtrace = __LINE__ + 2
+          stub.instance_of(Resources::WebRoot).locate('somedir') do
+            raise "Foobar"
+          end
+        end
+
+        it "shows the full request path in the error message" do
+          lambda do
+            get('/somedir')
+          end.should raise_error(Exception, Regexp.new("/somedir"))
+        end
+
+        it "uses the backtrace from where the original error was raised" do
+          no_error = true
+          begin
+            get('/somedir')
+          rescue Exception => e
+            no_error = false
+            top_of_backtrace = e.backtrace.first.split(":")
+            backtrace_file = ::File.expand_path(top_of_backtrace[0])
+            backtrace_line = Integer(top_of_backtrace[1])
+            backtrace_file.should == __FILE__
+            backtrace_line.should == top_line_of_backtrace
+          end
+          raise "There should have been an error" if no_error
+        end
       end
     end
   end