js-routes 2.4.0 → 2.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 40c089f66c3042418a4b05690dd145fa20d0c61094d5242eb818b54cf8908e0a
-  data.tar.gz: 228996f6fe1b66fd475aecc4372da6d03ff25d06e23c426fdd44b3c608ef16ea
+  metadata.gz: 80c67cfe21ee9772f3912537cec0994797a76128083d495d9963381888e7833c
+  data.tar.gz: b2d63fcf45117749fa00be661b94fcd8a606ac711bdbcfd1bc2699be87d7c407
 SHA512:
-  metadata.gz: 72aaae2f2221a6db8e96d10f3bc410f82f6c9f5f9ff9c03c193bdac42bb332113acf972a9331afde0800dde6cb11128aa94adecee8e365af29cf647fff4c5b06
-  data.tar.gz: 87a8a03ff9d7929d9fc46c8c46fc913c43a6efa1a55b04b3b52476c75533349a6b538eff3fe2a1e306ce4cf198652578b33c0ca2382679f0dbaf5b39b8d25660
+  metadata.gz: abebd07a033d7046989e71b1fc00aad559c1973f9eadaf0f93df25057bd01d1c3cd9bca2447d272c2c56ccef10a9803d6ae81479999be7ed315eefeb7c0211e1
+  data.tar.gz: c000eb635b4b77167cb04df8b3b691528cebe78ce557d8bcab75e95c420e033b79d066e3f8135a7b04f5b899c964512e741b5c0fc0a30c99692d1b2ebb76b883

data/CHANGELOG.md

@@ -2,6 +2,23 @@
 
 ## Pending
 
+## [2.4.1]
+
+### Fix camelCase TypeScript definitions for optional parameters
+
+Fix a bug introduced in 2.4.0 where `camel_case: true` caused TypeScript type definitions to advertise camelCase keys for optional route parameters while the JavaScript runtime still required snake_case. Fixes [#351](https://github.com/railsware/js-routes/issues/351).
+
+Optional parameter names in `.d.ts` output now match what the runtime actually accepts:
+
+```typescript
+// Before (broken): type advertised perPage but runtime required per_page
+itemsPath({ perPage: 20 })   // → "/items?perPage=20"  ✗ (silently wrong)
+itemsPath({ per_page: 20 })  // → "/items/20"          ✓ (worked but type was misleading)
+
+// After (fixed): type and runtime agree on snake_case
+itemsPath({ per_page: 20 })  // → "/items/20"          ✓
+```
+
 ## [2.4.0]
 
 ### Package mode

data/lib/js_routes/instance.rb

@@ -37,10 +37,9 @@ module JsRoutes
       end
 
       unless @configuration.module_type == "NIL"
-        banner + jsr + routes_export
+        banner + routes_js + routes_export
       else
-        # Strip the empty IMPORT_ROUTER statement (comment + semicolon) left after substitution
-        jsr.sub(/\A(\/\/[^\n]+\n)*;\n/, "")
+        routes_js
       end
 
     end
@@ -49,7 +48,7 @@ module JsRoutes
     def package
       raise "Package generation requires module_type: 'PKG'" unless @configuration.pkg?
 
-      jsr
+      routes_js
     end
 
     sig { returns(String) }
@@ -116,7 +115,7 @@ module JsRoutes
     end
 
     sig { returns(String) }
-    def jsr
+    def routes_js
       return pkg_jsr if @configuration.pkg?
 
       if @configuration.dts?
@@ -153,7 +152,6 @@ module JsRoutes
         'SERIALIZER'          => @configuration.serializer || json(nil),
         'MODULE_TYPE'         => json(@configuration.module_type),
         'WRAPPER'             => wrapper_variable,
-        "IMPORT_ROUTER"       => import_router_variable,
         "EMBED_ROUTER"        => embed_router_variable,
       }
     end
@@ -180,9 +178,9 @@ module JsRoutes
     end
 
     sig { returns(String) }
-    def import_router_variable
+    def router_js
       if @configuration.use_package?
-        "import Router from '#{@configuration.package}'"
+        "import Router from '#{@configuration.package}';"
       elsif @configuration.modern?
         read_js(@configuration.router_source_file)
       else
@@ -194,20 +192,21 @@ module JsRoutes
     def wrapper_variable
       case @configuration.module_type
       when 'ESM', 'PKG'
-        'const __jsr = '
+        "#{router_js}const __jsr = "
       when 'NIL'
         namespace = @configuration.namespace
         if namespace
-          if namespace.include?('.')
+          assignment = if namespace.include?('.')
             "#{namespace} = "
           else
             "(typeof window !== 'undefined' ? window : this).#{namespace} = "
           end
+          "#{router_js}#{assignment}"
         else
-          ''
+          router_js
         end
       else
-        ''
+        router_js
       end
     end
 

data/lib/js_routes/route.rb

@@ -92,7 +92,7 @@ module JsRoutes
     def optional_parts_type
       return nil if optional_parts.empty?
       @optional_parts_type ||= T.let(
-        "{" + optional_parts.map {|p| "#{format_param(p)}?: OptionalRouteParameter"}.join(', ') + "}",
+        "{" + optional_parts.map {|p| "#{p}?: OptionalRouteParameter"}.join(', ') + "}",
         T.nilable(String)
       )
     end

data/lib/js_routes/version.rb

@@ -1,4 +1,4 @@
 # typed: strict
 module JsRoutes
-  VERSION = "2.4.0"
+  VERSION = "2.4.1"
 end

data/lib/routes.js

@@ -1,5 +1,3 @@
-// eslint-disable-next-line @typescript-eslint/no-unused-expressions
-RubyVariables.IMPORT_ROUTER;
 RubyVariables.WRAPPER(() => {
     var _a;
     // eslint-disable-next-line @typescript-eslint/no-unused-expressions

data/lib/routes.ts

@@ -23,14 +23,10 @@ declare const RubyVariables: {
   SERIALIZER: Serializer | null;
   ROUTES_OBJECT: RouteHelpers;
   MODULE_TYPE: ModuleType;
-  IMPORT_ROUTER: RouterConstructor;
   EMBED_ROUTER: RouterConstructor;
   WRAPPER: <T>(callback: T) => T;
 };
 
-// eslint-disable-next-line @typescript-eslint/no-unused-expressions
-RubyVariables.IMPORT_ROUTER;
-
 declare const define:
   | undefined
   | (((arg: unknown[], callback: () => unknown) => void) & { amd?: unknown });

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: js-routes
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 2.4.1
 platform: ruby
 authors:
 - Bogdan Gusiev
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-06-11 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -147,12 +146,11 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/railsware/js-routes/issues
-  changelog_uri: https://github.com/railsware/js-routes/blob/v2.4.0/CHANGELOG.md
+  changelog_uri: https://github.com/railsware/js-routes/blob/v2.4.1/CHANGELOG.md
   documentation_uri: https://github.com/railsware/js-routes
-  source_code_uri: https://github.com/railsware/js-routes/tree/v2.4.0
+  source_code_uri: https://github.com/railsware/js-routes/tree/v2.4.1
   rubygems_mfa_required: 'true'
   github_repo: ssh://github.com/railsware/js-routes
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -160,15 +158,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.4.0
+      version: '2.7'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.11
-signing_key:
+rubygems_version: 4.0.10
 specification_version: 4
 summary: Brings Rails named routes to javascript
 test_files: []