js-routes 1.4.3 → 1.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e2c1645c670a1b3417f9bac488213b59772d6e8a
-  data.tar.gz: c24fc47bafda9d30316f217cc056c40a06400b25
+  metadata.gz: ac6b282ffedbbc45d553d26dfc28a36aa02539b3
+  data.tar.gz: a229d137f55ca50b7871b43a0e39564b0824d0ab
 SHA512:
-  metadata.gz: fae588fedc1ead98cd02f9bee3157d33044f788486137ae261195121bd020169f765fa82d14aced99db170a97c78b54c918f000a369c20f881b928acece283f5
-  data.tar.gz: e19c02689bb0c08eaa4ce6a47fb480020f2e00d1fb09daef4ff82593ef7a831fecda97999d817443b42bab8397f50985f239fc693822a0721032ec95621f2540
+  metadata.gz: 620e07c9d22b14a9ae1a5a1008eb3336e4e72d83d29033b8f29fa6a737429661637d4fdb01e21ab42599b8698eae79233153acab6ef3d6c8d17ed359b02f435b
+  data.tar.gz: 7fb670b7f0dd3970681afcc8d33fd96687a5a0ff1f9a4e7b8c4f3deca8e197c2abb889eb0a58afcda0f36c391d86a51c7f27bc33df6d884611350937bf5437e3

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 ## master
 
+* More informative stack trace for ParameterMissing error #235
+
+## v1.4.3
+
+* Proper implementation of the :subdomain option in routes generation
+
 ## v1.4.2
 
 * Added JsRoutes namespace to Engine #230

data/lib/js_routes/version.rb

@@ -1,3 +1,3 @@
 class JsRoutes
-  VERSION = "1.4.3"
+  VERSION = "1.4.4"
 end

data/lib/routes.js

@@ -10,11 +10,33 @@ Based on Rails routes of APP_CLASS
 
   root = typeof exports !== "undefined" && exports !== null ? exports : this;
 
-  ParameterMissing = function(message) {
-    this.message = message;
-  };
+  function ParameterMissing(message, fileName, lineNumber) {
+    var instance = new Error(message, fileName, lineNumber);
+    if(Object.setPrototypeOf) {
+      Object.setPrototypeOf(instance, Object.getPrototypeOf(this));
+    } else {
+      instance.__proto__ = this.__proto__;
+    }
+    if (Error.captureStackTrace) {
+      Error.captureStackTrace(instance, ParameterMissing);
+    }
+    return instance;
+  }
 
-  ParameterMissing.prototype = new Error();
+  ParameterMissing.prototype = Object.create(Error.prototype, {
+    constructor: {
+      value: Error,
+      enumerable: false,
+      writable: true,
+      configurable: true
+    }
+  });
+
+  if (Object.setPrototypeOf){
+    Object.setPrototypeOf(ParameterMissing, Error);
+  } else {
+    ParameterMissing.__proto__ = Error;
+  }
 
   NodeTypes = NODE_TYPES;
 

data/lib/routes.js.coffee

@@ -5,8 +5,27 @@ Based on Rails routes of APP_CLASS
 # root is this
 root = (exports ? this)
 
-ParameterMissing = (@message) -> #
-ParameterMissing:: = new Error()
+ParameterMissing = (message, fileName, lineNumber) ->
+  instance = new Error(message, fileName, lineNumber)
+  if Object.setPrototypeOf
+    Object.setPrototypeOf instance, Object.getPrototypeOf(this)
+  else
+    instance.__proto__ = this.__proto__
+  if Error.captureStackTrace
+    Error.captureStackTrace instance, ParameterMissing
+  instance
+
+ParameterMissing.prototype = Object.create(Error.prototype, constructor:
+  value: Error
+  enumerable: false
+  writable: true
+  configurable: true
+)
+
+if Object.setPrototypeOf
+  Object.setPrototypeOf(ParameterMissing, Error)
+else
+  ParameterMissing.__proto__ = Error
 
 NodeTypes = NODE_TYPES
 SpecialOptionsKey = SPECIAL_OPTIONS_KEY

data/spec/js_routes/rails_routes_compatibility_spec.rb

@@ -25,6 +25,19 @@ describe JsRoutes, "compatibility with Rails"  do
       .to raise_error('Route parameter missing: title')
   end
 
+  it "should produce error stacktraces including function names" do
+     stacktrace = evaljs("
+        (function(){
+          try {
+            Routes.thing_path()
+          } catch(e) {
+            return e.stack;
+          }
+        })()
+      ")
+    expect(stacktrace).to include "thing_path"
+  end
+
   it "should support 0 as a member parameter" do
     expect(evaljs("Routes.inbox_path(0)")).to eq(test_routes.inbox_path(0))
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: js-routes
 version: !ruby/object:Gem::Version
-  version: 1.4.3
+  version: 1.4.4
 platform: ruby
 authors:
 - Bogdan Gusiev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-18 00:00:00.000000000 Z
+date: 2018-05-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties