js-routes 1.4.0 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: da4a6b84210ad4604692606b4ea0e5c79fc9ee7a
-  data.tar.gz: 342a9ab0a4b396aef730e88af2abc782d64db743
+  metadata.gz: 50875d687cd46f55c34450970c84faddd4ff970c
+  data.tar.gz: cb98a4d6b4feb6a3cb60631c22dc8ac4e7638c10
 SHA512:
-  metadata.gz: 34511f3806f9985f569cfca45ead8e4766be104912d851c9e48ffb4ef2b0d25cb0df17d7eeac42c0d681aa847ab72324c4cb4a4046b63d7ad4dfc1ca51ecc915
-  data.tar.gz: 905284b66bb0e6f8889a6fee1bdbbd521012990d0d69186ccd13b651e10d0a0a202e8b34493290fb1cdc94844d31e087d7883907d75ab95fe6f5d8186446c2cb
+  metadata.gz: c49eefb28fc5ad6edb1378b4718397c7996b6f9f7b356a53336c8becfa4d162af71a3dc4606a2fc2a04f958e4b2eec70adbdbcad642e130f662842422edd1357
+  data.tar.gz: 49f4bb3f3988f61e7853d7a392b902212715bd3f537cd9bbf3c51b72f8781ee3c9a9d5d9ded33989be35e2269c948f9274caf0f59bc54bb21f207fce33814a7a

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 ## master
 
+## v1.4.1
+
+* Fixed bug when js-routes is used in envs without window.location #224
+
+
+## v1.4.0
+
 * __breaking change!__ Implemented Routes.config() and Routes.configure instead of Routes.defaults
 
 New methods support 4 options at the moment:
@@ -11,7 +18,7 @@ Routes.configuration(); // =>
   prefix: "",
   default_url_options: {},
   special_options_key: '_options',
-  custom_serializer: function(...) { ... }
+  serializer: function(...) { ... }
 }
 */
 
@@ -19,7 +26,7 @@ Routes.configure({
  prefix: '/app',
  default_url_options: {format: 'json'},
  special_options_key: '_my_options_key',
- custom_serializer: function(...) { ... }
+ serializer: function(...) { ... }
 });
 ```
 

data/lib/js_routes/version.rb

@@ -1,3 +1,3 @@
 class JsRoutes
-  VERSION = "1.4.0"
+  VERSION = "1.4.1"
 end

data/lib/routes.js

@@ -356,14 +356,17 @@ Based on Rails routes of APP_CLASS
       if (typeof route_defaults === 'string') {
         return route_defaults;
       }
+      hostname = route_defaults.host || Utils.current_host();
+      if (!hostname) {
+        return '';
+      }
       protocol = route_defaults.protocol || Utils.current_protocol();
-      hostname = route_defaults.host || window.location.hostname;
       port = route_defaults.port || (!route_defaults.host ? Utils.current_port() : void 0);
       port = port ? ":" + port : '';
       return protocol + "://" + hostname + port;
     },
     has_location: function() {
-      return typeof window !== 'undefined' && typeof window.location !== 'undefined';
+      return (typeof window !== "undefined" && window !== null ? window.location : void 0) != null;
     },
     current_host: function() {
       if (this.has_location()) {

data/lib/routes.js.coffee

@@ -276,16 +276,18 @@ Utils =
 
   route_url: (route_defaults) ->
     return route_defaults if typeof route_defaults == 'string'
+
+    hostname = route_defaults.host || Utils.current_host()
+
+    return '' unless hostname
+
     protocol = route_defaults.protocol || Utils.current_protocol()
-    hostname = route_defaults.host || window.location.hostname
     port = route_defaults.port || (Utils.current_port() unless route_defaults.host)
     port = if port then ":#{port}" else ''
 
     protocol + "://" + hostname + port
 
-
-  has_location: ->
-    typeof window != 'undefined' && typeof window.location != 'undefined'
+  has_location: -> window?.location?
 
   current_host: ->
     if @has_location() then window.location.hostname else null

data/spec/js_routes/options_spec.rb

@@ -425,6 +425,17 @@ describe JsRoutes, "options" do
         end
       end
     end
+
+    context 'when window.location is not present' do
+      context 'without specifying a default host' do
+        let(:_options) { { url_links: true } }
+
+        it 'generates path' do
+          expect(evaljs("Routes.inbox_url(1)")).to eq test_routes.inbox_path(1)
+          expect(evaljs("Routes.new_session_url()")).to eq test_routes.new_session_path
+        end
+      end
+    end
   end
 
   describe "when the compact mode is enabled" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: js-routes
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.1
 platform: ruby
 authors:
 - Bogdan Gusiev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-17 00:00:00.000000000 Z
+date: 2017-09-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -202,7 +202,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.7
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Brings Rails named routes to javascript