js-routes 0.9.3 → 0.9.4

data/.gitignore

@@ -51,3 +51,4 @@ pkg
 .ruby-version
 
 Gemfile.lock
+gemfiles/*.lock

data/.travis.yml

@@ -5,6 +5,9 @@ rvm:
   - jruby-19mode
   - ruby-head
   - jruby-head
+gemfile:
+  - gemfiles/rails32.gemfile
+  - gemfiles/rails40.gemfile
 notifications:
   email:
     - agresso@gmail.com

data/Appraisals

@@ -0,0 +1,10 @@
+appraise "rails32" do
+  gem "rails", "~> 3.2.14"
+  gem "js-routes", :path => "../"
+end
+
+appraise "rails40" do
+  gem "rails", "4.0.0"
+  gem "minitest", "~> 4.0"
+  gem "js-routes", :path => "../"
+end

data/Rakefile

@@ -1,5 +1,4 @@
 # encoding: utf-8
-
 require 'rubygems'
 require 'bundler'
 begin
@@ -12,14 +11,10 @@ end
 require 'bundler/gem_tasks'
 require 'rspec/core'
 require 'rspec/core/rake_task'
+require 'appraisal'
 
-RSpec::Core::RakeTask.new(:spec) do |spec|
-  spec.pattern =  FileList['spec/**/*_spec.rb'].sort_by do|n|
-    # we need to run post_rails_init_spec as the latest
-    # because it cause unrevertable changes to runtime
-    n.include?("post_rails_init_spec") ? 1 : 0
-  end
-end
+RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task :test_all => :appraisal # test all rails
 
+task :default => :spec

data/Readme.md

@@ -61,7 +61,8 @@ Available options:
   * Default: blank
 * `camel_case` (version >= 0.8.8) - Generate camel case route names.
   * Default: false
-* `url_links` (version >= 0.8.9) - Generate additional url links, where url_links value is beginning of url routes (ex: http[s]://example.com).
+* `url_links` (version >= 0.8.9) - Generate `*_url` links (in addition to default `*_path`), where url_links value is beginning of url routes
+  * Example: http[s]://example.com
   * Default: false
 
 You can generate routes files on the application side like this:
@@ -126,7 +127,7 @@ Spork.trap_method(JsRoutes, :generate!)
 There are some alternatives available. Most of them has only basic feature and don't reach the level of quality I accept.
 Advantages of this one are:
 
-* Rails3 support
+* Rails3 & Rails4 support
 * Rich options set
 * Support Rails `#to_param` convention for seo optimized paths
 * Well tested

data/gemfiles/rails32.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "http://rubygems.org"
+
+gem "rails", "~> 3.2.14"
+gem "js-routes", :path=>"../"
+
+gemspec :path=>"../"

data/gemfiles/rails40.gemfile

@@ -0,0 +1,9 @@
+# This file was generated by Appraisal
+
+source "http://rubygems.org"
+
+gem "rails", "4.0.0"
+gem "minitest", "~> 4.0"
+gem "js-routes", :path=>"../"
+
+gemspec :path=>"../"

data/js-routes.gemspec

@@ -23,10 +23,11 @@ Gem::Specification.new do |s|
   s.summary = %q{Brings Rails named routes to javascript}
 
   s.add_runtime_dependency(%q<rails>, [">= 3.2"])
-  s.add_development_dependency(%q<rspec>, ["~> 2.10.0"])
+  s.add_development_dependency(%q<rspec>, [">= 2.14.0"])
   s.add_development_dependency(%q<bundler>, [">= 1.1.0"])
   s.add_development_dependency(%q<guard>, [">= 0"])
   s.add_development_dependency(%q<guard-coffeescript>, [">= 0"])
+  s.add_development_dependency(%q<appraisal>, [">= 0.5.2"])
   if defined?(JRUBY_VERSION)
     s.add_development_dependency(%q<therubyrhino>, [">= 0"])
   else

data/lib/js_routes.rb

@@ -10,26 +10,26 @@ class JsRoutes
   DEFAULT_PATH = File.join('app','assets','javascripts','routes.js')
 
   DEFAULTS = {
-    :namespace => "Routes",
-    :exclude => [],
-    :include => //,
-    :file => DEFAULT_PATH,
-    :prefix => nil,
-    :url_links => nil,
-    :camel_case => false,
-    :default_url_options => {}
+    namespace: "Routes",
+    exclude: [],
+    include: //,
+    file: DEFAULT_PATH,
+    prefix: nil,
+    url_links: nil,
+    camel_case: false,
+    default_url_options: {}
   }
 
   # We encode node symbols as integer to reduce the routes.js file size
   NODE_TYPES = {
-    :GROUP => 1,
-    :CAT => 2,
-    :SYMBOL => 3,
-    :OR => 4,
-    :STAR => 5,
-    :LITERAL => 6,
-    :SLASH => 7,
-    :DOT => 8
+    GROUP: 1,
+    CAT: 2,
+    SYMBOL: 3,
+    OR: 4,
+    STAR: 5,
+    LITERAL: 6,
+    SLASH: 7,
+    DOT: 8
   }
 
   LAST_OPTIONS_KEY = "options".freeze
@@ -71,7 +71,7 @@ class JsRoutes
     # full environment will be available during asset compilation.
     # This is required to ensure routes are loaded.
     def assert_usable_configuration!
-      unless Rails.application.config.assets.initialize_on_precompile
+      if 3 == Rails::VERSION::MAJOR && !Rails.application.config.assets.initialize_on_precompile
         raise("Cannot precompile js-routes unless environment is initialized. Please set config.assets.initialize_on_precompile to true.")
       end
       true
@@ -101,8 +101,8 @@ class JsRoutes
 
   def deprecated_default_format
     if @options.key?(:default_format)
-      warn("default_format option is deprecated. Use default_url_options = {:format => <format>} instead")
-      {:format => @options[:default_format]}
+      warn("default_format option is deprecated. Use default_url_options = { format: <format> } instead")
+      { format: @options[:default_format] }
     else
       {}
     end

data/lib/js_routes/engine.rb

@@ -2,7 +2,7 @@ class JsRoutes
   class Engine < Rails::Engine
     JS_ROUTES_ASSET = 'js-routes'
 
-    initializer 'js-routes.dependent_on_routes', :after => "sprockets.environment" do
+    initializer 'js-routes.dependent_on_routes', after: "sprockets.environment" do
       if Rails.application.assets.respond_to?(:register_preprocessor)
         routes = Rails.root.join('config','routes.rb')
         Rails.application.assets.register_preprocessor 'application/javascript', :'js-routes_dependent_on_routes' do |ctx,data|

data/lib/js_routes/version.rb

@@ -1,3 +1,3 @@
 class JsRoutes
-  VERSION = "0.9.3"
+  VERSION = "0.9.4"
 end

data/lib/tasks/js_routes.rake

@@ -1,6 +1,6 @@
 namespace :js do
   desc "Make a js file that will have functions that will return restful routes/urls."
-  task :routes => :environment do
+  task routes: :environment do
     require "js-routes"
 
     JsRoutes.generate!

data/spec/js_routes/generated_javascript_spec.rb

@@ -20,7 +20,7 @@ describe JsRoutes do
     end
 
     it "routes should be sorted in alphabetical order" do
-      subject.index("book_path").should <= subject.index("inboxes_path")
+      expect(subject.index("book_path")).to be <= subject.index("inboxes_path")
     end
   end
 
@@ -39,7 +39,7 @@ describe JsRoutes do
       if Rails.application.instance_variable_get("@initialized")
         pending
       end
-      File.exists?(name).should be_false
+      expect(File.exists?(name)).to be_false
     end
 
     after(:all) do

data/spec/js_routes/options_spec.rb

@@ -18,11 +18,11 @@ describe JsRoutes, "options" do
     let(:_options) { {:exclude => /^admin_/} }
 
     it "should exclude specified routes from file" do
-      evaljs("Routes.admin_users_path").should be_nil
+      expect(evaljs("Routes.admin_users_path")).to be_nil
     end
 
     it "should not exclude routes not under specified pattern" do
-      evaljs("Routes.inboxes_path()").should_not be_nil
+      expect(evaljs("Routes.inboxes_path()")).not_to be_nil
     end
   end
   context "when include is specified" do
@@ -30,11 +30,11 @@ describe JsRoutes, "options" do
     let(:_options) { {:include => /^admin_/} }
 
     it "should exclude specified routes from file" do
-      evaljs("Routes.admin_users_path()").should_not be_nil
+      expect(evaljs("Routes.admin_users_path()")).not_to be_nil
     end
 
     it "should not exclude routes not under specified pattern" do
-      evaljs("Routes.inboxes_path").should be_nil
+      expect(evaljs("Routes.inboxes_path")).to be_nil
     end
   end
 
@@ -43,12 +43,12 @@ describe JsRoutes, "options" do
     let(:_options) { {:prefix => "/myprefix/" } }
 
     it "should render routing with prefix" do
-        evaljs("Routes.inbox_path(1)").should == "/myprefix#{routes.inbox_path(1)}"
+        expect(evaljs("Routes.inbox_path(1)")).to eq("/myprefix#{routes.inbox_path(1)}")
     end
 
     it "should render routing with prefix set in JavaScript" do
       evaljs("Routes.options.prefix = '/newprefix/'")
-      evaljs("Routes.inbox_path(1)").should == "/newprefix#{routes.inbox_path(1)}"
+      expect(evaljs("Routes.inbox_path(1)")).to eq("/newprefix#{routes.inbox_path(1)}")
     end
 
   end
@@ -58,7 +58,7 @@ describe JsRoutes, "options" do
     let(:_options) { {:prefix => "http://localhost:3000" } }
 
     it "should render routing with prefix" do
-      evaljs("Routes.inbox_path(1)").should == _options[:prefix] + routes.inbox_path(1)
+      expect(evaljs("Routes.inbox_path(1)")).to eq(_options[:prefix] + routes.inbox_path(1))
     end
   end
 
@@ -67,12 +67,12 @@ describe JsRoutes, "options" do
     let(:_options) { {:prefix => "/myprefix" } }
 
     it "should render routing with prefix" do
-      evaljs("Routes.inbox_path(1)").should == "/myprefix#{routes.inbox_path(1)}"
+      expect(evaljs("Routes.inbox_path(1)")).to eq("/myprefix#{routes.inbox_path(1)}")
     end
 
     it "should render routing with prefix set in JavaScript" do
       evaljs("Routes.options.prefix = '/newprefix'")
-      evaljs("Routes.inbox_path(1)").should == "/newprefix#{routes.inbox_path(1)}"
+      expect(evaljs("Routes.inbox_path(1)")).to eq("/newprefix#{routes.inbox_path(1)}")
     end
 
   end
@@ -82,31 +82,31 @@ describe JsRoutes, "options" do
     let(:_warnings) { nil }
 
     it "should render routing with default_format" do
-      evaljs("Routes.inbox_path(1)").should == routes.inbox_path(1, :format => "json")
+      expect(evaljs("Routes.inbox_path(1)")).to eq(routes.inbox_path(1, :format => "json"))
     end
 
     it "should override default_format when spefified implicitly" do
-      evaljs("Routes.inbox_path(1, {format: 'xml'})").should == routes.inbox_path(1, :format => "xml")
+      expect(evaljs("Routes.inbox_path(1, {format: 'xml'})")).to eq(routes.inbox_path(1, :format => "xml"))
     end
 
     it "should override nullify implicitly when specified implicitly" do
-      evaljs("Routes.inbox_path(1, {format: null})").should == routes.inbox_path(1)
+      expect(evaljs("Routes.inbox_path(1, {format: null})")).to eq(routes.inbox_path(1))
     end
 
     it "shouldn't include the format when {:format => false} is specified" do
-      evaljs("Routes.no_format_path()").should == routes.no_format_path
+      expect(evaljs("Routes.no_format_path()")).to eq(routes.no_format_path)
     end
 
     it "shouldn't require the format" do
-      evaljs("Routes.json_only_path()").should == routes.json_only_path(:format => 'json')
+      expect(evaljs("Routes.json_only_path()")).to eq(routes.json_only_path(:format => 'json'))
     end
   end
 
   describe "when namespace option is specified" do
     let(:_options) { {:namespace => "PHM"} }
     it "should use this namespace for routing" do
-      evaljs("window.Routes").should be_nil
-      evaljs("PHM.inbox_path").should_not be_nil
+      expect(evaljs("window.Routes")).to be_nil
+      expect(evaljs("PHM.inbox_path")).not_to be_nil
     end
   end
 
@@ -115,14 +115,14 @@ describe JsRoutes, "options" do
       let(:_presetup) { "window.PHM = {}" }
       let(:_options) { {:namespace => "PHM.Routes"} }
       it "should use this namespace for routing" do
-        evaljs("PHM.Routes.inbox_path").should_not be_nil
+        expect(evaljs("PHM.Routes.inbox_path")).not_to be_nil
       end
     end
 
     context "but undefined on client" do
       let(:_options) { {:namespace => "PHM.Routes"} }
       it "should initialize namespace" do
-        evaljs("window.PHM.Routes.inbox_path").should_not be_nil
+        expect(evaljs("window.PHM.Routes.inbox_path")).not_to be_nil
       end
     end
 
@@ -130,8 +130,8 @@ describe JsRoutes, "options" do
       let(:_presetup) { "window.PHM = { Utils: {} };" }
       let(:_options) { {:namespace => "PHM.Routes"} }
       it "should not overwrite existing parts" do
-        evaljs("window.PHM.Utils").should_not be_nil
-        evaljs("window.PHM.Routes.inbox_path").should_not be_nil
+        expect(evaljs("window.PHM.Utils")).not_to be_nil
+        expect(evaljs("window.PHM.Routes.inbox_path")).not_to be_nil
       end
     end
   end
@@ -140,7 +140,7 @@ describe JsRoutes, "options" do
     context "with optional route parts" do
       let(:_options) { {:default_url_options => {:optional_id => "12", :format => "json"}}}
       it "should use this opions to fill optional parameters" do
-        evaljs("Routes.things_path()").should == routes.things_path(:optional_id => 12, :format => "json")
+        expect(evaljs("Routes.things_path()")).to eq(routes.things_path(:optional_id => 12, :format => "json"))
       end
     end
 
@@ -148,7 +148,7 @@ describe JsRoutes, "options" do
       let(:_options) { {:default_url_options => {:inbox_id => "12"}} }
       it "should use this opions to fill optional parameters" do
         pending
-        evaljs("Routes.inbox_messages_path()").should == routes.inbox_messages_path(:inbox_id => 12)
+        expect(evaljs("Routes.inbox_messages_path()")).to eq(routes.inbox_messages_path(:inbox_id => 12))
       end
     end
   end
@@ -157,18 +157,18 @@ describe JsRoutes, "options" do
     context "with default option" do
       let(:_options) { Hash.new }
       it "should use snake case routes" do
-        evaljs("Routes.inbox_path(1)").should == routes.inbox_path(1)
-        evaljs("Routes.inboxPath").should be_nil
+        expect(evaljs("Routes.inbox_path(1)")).to eq(routes.inbox_path(1))
+        expect(evaljs("Routes.inboxPath")).to be_nil
       end
     end
 
     context "with true" do
       let(:_options) { { :camel_case => true } }
       it "should generate camel case routes" do
-        evaljs("Routes.inbox_path").should be_nil
-        evaljs("Routes.inboxPath").should_not be_nil
-        evaljs("Routes.inboxPath(1)").should == routes.inbox_path(1)
-        evaljs("Routes.inboxMessagesPath(10)").should == routes.inbox_messages_path(:inbox_id => 10)
+        expect(evaljs("Routes.inbox_path")).to be_nil
+        expect(evaljs("Routes.inboxPath")).not_to be_nil
+        expect(evaljs("Routes.inboxPath(1)")).to eq(routes.inbox_path(1))
+        expect(evaljs("Routes.inboxMessagesPath(10)")).to eq(routes.inbox_messages_path(:inbox_id => 10))
       end
     end
   end
@@ -177,19 +177,19 @@ describe JsRoutes, "options" do
     context "with default option" do
       let(:_options) { Hash.new }
       it "should generate only path links" do
-        evaljs("Routes.inbox_path(1)").should == routes.inbox_path(1)
-        evaljs("Routes.inbox_url").should be_nil
+        expect(evaljs("Routes.inbox_path(1)")).to eq(routes.inbox_path(1))
+        expect(evaljs("Routes.inbox_url")).to be_nil
       end
     end
 
     context "with host" do
       let(:_options) { { :url_links => "http://localhost" } }
       it "should generate path and url links" do
-        evaljs("Routes.inbox_path").should_not be_nil
-        evaljs("Routes.inbox_url").should_not be_nil
-        evaljs("Routes.inbox_path(1)").should == routes.inbox_path(1)
-        evaljs("Routes.inbox_url(1)").should == "http://localhost#{routes.inbox_path(1)}"
-        evaljs("Routes.inbox_url(1, { test_key: \"test_val\" })").should == "http://localhost#{routes.inbox_path(1, :test_key => "test_val")}"
+        expect(evaljs("Routes.inbox_path")).not_to be_nil
+        expect(evaljs("Routes.inbox_url")).not_to be_nil
+        expect(evaljs("Routes.inbox_path(1)")).to eq(routes.inbox_path(1))
+        expect(evaljs("Routes.inbox_url(1)")).to eq("http://localhost#{routes.inbox_path(1)}")
+        expect(evaljs("Routes.inbox_url(1, { test_key: \"test_val\" })")).to eq("http://localhost#{routes.inbox_path(1, :test_key => "test_val")}")
       end
     end
 
@@ -202,20 +202,20 @@ describe JsRoutes, "options" do
     context "with host and camel_case" do
       let(:_options) { { :camel_case => true, :url_links => "http://localhost" } }
       it "should generate path and url links" do
-        evaljs("Routes.inboxPath").should_not be_nil
-        evaljs("Routes.inboxUrl").should_not be_nil
-        evaljs("Routes.inboxPath(1)").should == routes.inbox_path(1)
-        evaljs("Routes.inboxUrl(1)").should == "http://localhost#{routes.inbox_path(1)}"
+        expect(evaljs("Routes.inboxPath")).not_to be_nil
+        expect(evaljs("Routes.inboxUrl")).not_to be_nil
+        expect(evaljs("Routes.inboxPath(1)")).to eq(routes.inbox_path(1))
+        expect(evaljs("Routes.inboxUrl(1)")).to eq("http://localhost#{routes.inbox_path(1)}")
       end
     end
 
     context "with host and prefix" do
       let(:_options) { { :prefix => "/api", :url_links => "https://example.com" } }
       it "should generate path and url links" do
-        evaljs("Routes.inbox_path").should_not be_nil
-        evaljs("Routes.inbox_url").should_not be_nil
-        evaljs("Routes.inbox_path(1)").should == "/api#{routes.inbox_path(1)}"
-        evaljs("Routes.inbox_url(1)").should == "https://example.com/api#{routes.inbox_path(1)}"
+        expect(evaljs("Routes.inbox_path")).not_to be_nil
+        expect(evaljs("Routes.inbox_url")).not_to be_nil
+        expect(evaljs("Routes.inbox_path(1)")).to eq("/api#{routes.inbox_path(1)}")
+        expect(evaljs("Routes.inbox_url(1)")).to eq("https://example.com/api#{routes.inbox_path(1)}")
       end
     end
   end

data/spec/js_routes/rails_routes_compatibility_spec.rb

@@ -6,111 +6,114 @@ describe JsRoutes, "compatibility with Rails"  do
     evaljs(JsRoutes.generate({}))
   end
 
-
   it "should generate collection routing" do
-    evaljs("Routes.inboxes_path()").should == routes.inboxes_path()
+    expect(evaljs("Routes.inboxes_path()")).to eq(routes.inboxes_path())
   end
 
   it "should generate member routing" do
-    evaljs("Routes.inbox_path(1)").should == routes.inbox_path(1)
+    expect(evaljs("Routes.inbox_path(1)")).to eq(routes.inbox_path(1))
   end
 
   it "should support 0 as a member parameter" do
-    evaljs("Routes.inbox_path(0)").should == routes.inbox_path(0)
+    expect(evaljs("Routes.inbox_path(0)")).to eq(routes.inbox_path(0))
   end
 
   it "should generate nested routing with one parameter" do
-    evaljs("Routes.inbox_messages_path(1)").should == routes.inbox_messages_path(1)
+    expect(evaljs("Routes.inbox_messages_path(1)")).to eq(routes.inbox_messages_path(1))
   end
 
   it "should generate nested routing" do
-    evaljs("Routes.inbox_message_path(1,2)").should == routes.inbox_message_path(1, 2)
+    expect(evaljs("Routes.inbox_message_path(1,2)")).to eq(routes.inbox_message_path(1, 2))
   end
 
   it "should generate routing with format" do
-    evaljs("Routes.inbox_path(1, {format: 'json'})").should == routes.inbox_path(1, :format => "json")
-  end
-
-  it "should support simple get parameters" do
-    evaljs("Routes.inbox_path(1, {format: 'json', lang: 'ua', q: 'hello'})").should == routes.inbox_path(1, :lang => "ua", :q => "hello", :format => "json")
-  end
-
-  it "should support array get parameters" do
-    evaljs("Routes.inbox_path(1, {hello: ['world', 'mars']})").should == routes.inbox_path(1, :hello => [:world, :mars])
-  end
-
-  it "should support nested get parameters" do
-    evaljs("Routes.inbox_path(1, {format: 'json', env: 'test', search: { category_ids: [2,5], q: 'hello'}})").should ==
-      routes.inbox_path(1, :env => 'test', :search => {:category_ids => [2,5], :q => "hello"}, :format => "json")
-  end
-
-  it "should support null and undefined parameters" do
-    evaljs("Routes.inboxes_path({uri: null, key: undefined})").should == routes.inboxes_path(:uri => nil, :key => nil)
-  end
-
-  it "should escape get parameters" do
-    evaljs("Routes.inboxes_path({uri: 'http://example.com'})").should == routes.inboxes_path(:uri => 'http://example.com')
+    expect(evaljs("Routes.inbox_path(1, {format: 'json'})")).to eq(routes.inbox_path(1, :format => "json"))
   end
 
   it "should support routes with reserved javascript words as parameters" do
-    evaljs("Routes.object_path(1, 2)").should == routes.object_path(1,2)
+    expect(evaljs("Routes.object_path(1, 2)")).to eq(routes.object_path(1,2))
   end
 
   it "should support url anchor given as parameter" do
-    evaljs("Routes.inbox_path(1, {anchor: 'hello'})").should == routes.inbox_path(1, :anchor => "hello")
+    expect(evaljs("Routes.inbox_path(1, {anchor: 'hello'})")).to eq(routes.inbox_path(1, :anchor => "hello"))
   end
 
   it "should support url anchor and get parameters" do
-    evaljs("Routes.inbox_path(1, {expanded: true, anchor: 'hello'})").should == routes.inbox_path(1, :expanded => true, :anchor => "hello")
+    expect(evaljs("Routes.inbox_path(1, {expanded: true, anchor: 'hello'})")).to eq(routes.inbox_path(1, :expanded => true, :anchor => "hello"))
   end
 
   it "should support engine routes" do
-    evaljs("Routes.blog_app_posts_path()").should == blog_routes.posts_path()
+    expect(evaljs("Routes.blog_app_posts_path()")).to eq(blog_routes.posts_path())
   end
 
   it "should support engine routes with parameter" do
-    evaljs("Routes.blog_app_post_path(1)").should == blog_routes.post_path(1)
+    expect(evaljs("Routes.blog_app_post_path(1)")).to eq(blog_routes.post_path(1))
   end
 
   it "shouldn't require the format" do
-    evaljs("Routes.json_only_path({format: 'json'})").should == routes.json_only_path(:format => 'json')
+    expect(evaljs("Routes.json_only_path({format: 'json'})")).to eq(routes.json_only_path(:format => 'json'))
   end
 
   it "should support utf-8 route" do
-    evaljs("Routes.hello_path()").should == routes.hello_path
+    expect(evaljs("Routes.hello_path()")).to eq(routes.hello_path)
   end
 
   it "should support root_path" do
-    evaljs("Routes.root_path()").should == routes.root_path
+    expect(evaljs("Routes.root_path()")).to eq(routes.root_path)
   end
 
+  describe "get paramters" do
+    it "should support simple get parameters" do
+      expect(evaljs("Routes.inbox_path(1, {format: 'json', lang: 'ua', q: 'hello'})")).to eq(routes.inbox_path(1, :lang => "ua", :q => "hello", :format => "json"))
+    end
+
+    it "should support array get parameters" do
+      expect(evaljs("Routes.inbox_path(1, {hello: ['world', 'mars']})")).to eq(routes.inbox_path(1, :hello => [:world, :mars]))
+    end
+
+    it "should support nested get parameters" do
+      expect(evaljs("Routes.inbox_path(1, {format: 'json', env: 'test', search: { category_ids: [2,5], q: 'hello'}})")).to eq(
+        routes.inbox_path(1, :env => 'test', :search => {:category_ids => [2,5], :q => "hello"}, :format => "json")
+      )
+    end
+
+    it "should support null and undefined parameters" do
+      expect(evaljs("Routes.inboxes_path({uri: null, key: undefined})")).to eq(routes.inboxes_path(:uri => nil, :key => nil))
+    end
+
+    it "should escape get parameters" do
+      expect(evaljs("Routes.inboxes_path({uri: 'http://example.com'})")).to eq(routes.inboxes_path(:uri => 'http://example.com'))
+    end
+  end
+
+
   context "routes globbing" do
     it "should be supported as parameters" do
-      evaljs("Routes.book_path('thrillers', 1)").should == routes.book_path('thrillers', 1)
+      expect(evaljs("Routes.book_path('thrillers', 1)")).to eq(routes.book_path('thrillers', 1))
     end
 
     it "should support routes globbing as array" do
-      evaljs("Routes.book_path(['thrillers'], 1)").should == routes.book_path(['thrillers'], 1)
+      expect(evaljs("Routes.book_path(['thrillers'], 1)")).to eq(routes.book_path(['thrillers'], 1))
     end
 
     it "should bee support routes globbing as array" do
-      evaljs("Routes.book_path([1, 2, 3], 1)").should == routes.book_path([1, 2, 3], 1)
+      expect(evaljs("Routes.book_path([1, 2, 3], 1)")).to eq(routes.book_path([1, 2, 3], 1))
     end
 
     it "should bee support routes globbing as hash" do
-      evaljs("Routes.book_path('a_test/b_test/c_test', 1)").should == routes.book_path('a_test/b_test/c_test', 1)
+      expect(evaljs("Routes.book_path('a_test/b_test/c_test', 1)")).to eq(routes.book_path('a_test/b_test/c_test', 1))
     end
 
     it "should support routes globbing as array with optional params" do
-      evaljs("Routes.book_path([1, 2, 3, 5], 1, {c: '1'})").should == routes.book_path([1, 2, 3, 5], 1, { :c => "1" })
+      expect(evaljs("Routes.book_path([1, 2, 3, 5], 1, {c: '1'})")).to eq(routes.book_path([1, 2, 3, 5], 1, { :c => "1" }))
     end
 
     it "should support routes globbing in book_title route as array" do
-      evaljs("Routes.book_title_path('john', ['thrillers', 'comedian'])").should == routes.book_title_path('john', ['thrillers', 'comedian'])
+      expect(evaljs("Routes.book_title_path('john', ['thrillers', 'comedian'])")).to eq(routes.book_title_path('john', ['thrillers', 'comedian']))
     end
 
     it "should support routes globbing in book_title route as array with optional params" do
-      evaljs("Routes.book_title_path('john', ['thrillers', 'comedian'], {some_key: 'some_value'})").should == routes.book_title_path('john', ['thrillers', 'comedian'], {:some_key => 'some_value'})
+      expect(evaljs("Routes.book_title_path('john', ['thrillers', 'comedian'], {some_key: 'some_value'})")).to eq(routes.book_title_path('john', ['thrillers', 'comedian'], {:some_key => 'some_value'}))
     end
   end
 
@@ -123,9 +126,9 @@ describe JsRoutes, "compatibility with Rails"  do
 
     shared_examples_for "serialization" do
       it "should support serialization of objects" do
-        evaljs("window.jQuery.param(#{_value.to_json})").should == _value.to_param
-        evaljs("Routes.inboxes_path(#{_value.to_json})").should == routes.inboxes_path(_value)
-        evaljs("Routes.inbox_path(1, #{_value.to_json})").should == routes.inbox_path(1, _value)
+        expect(evaljs("window.jQuery.param(#{_value.to_json})")).to eq(_value.to_param)
+        expect(evaljs("Routes.inboxes_path(#{_value.to_json})")).to eq(routes.inboxes_path(_value))
+        expect(evaljs("Routes.inbox_path(1, #{_value.to_json})")).to eq(routes.inbox_path(1, _value))
       end
     end
     context "when parameters is a hash" do
@@ -145,33 +148,33 @@ describe JsRoutes, "compatibility with Rails"  do
   context "using optional path fragments" do
     context "including not optional parts" do
       it "should include everything that is not optional" do
-        evaljs("Routes.foo_path()").should == routes.foo_path
+        expect(evaljs("Routes.foo_path()")).to eq(routes.foo_path)
       end
     end
 
     context "but not including them" do
       it "should not include the optional parts" do
-        evaljs("Routes.things_path()").should == routes.things_path
+        expect(evaljs("Routes.things_path()")).to eq(routes.things_path)
       end
 
       it "should not require the optional parts as arguments" do
         #TODO: fix this inconsistence
         pending
-        evaljs("Routes.thing_path(null, 5)").should == routes.thing_path(nil, 5)
+        expect(evaljs("Routes.thing_path(null, 5)")).to eq(routes.thing_path(nil, 5))
       end
 
       it "should treat undefined as non-given optional part" do
-        evaljs("Routes.thing_path(5, {optional_id: undefined})").should == routes.thing_path(5, :optional_id => nil)
+        expect(evaljs("Routes.thing_path(5, {optional_id: undefined})")).to eq(routes.thing_path(5, :optional_id => nil))
       end
 
       it "should treat null as non-given optional part" do
-        evaljs("Routes.thing_path(5, {optional_id: null})").should == routes.thing_path(5, :optional_id => nil)
+        expect(evaljs("Routes.thing_path(5, {optional_id: null})")).to eq(routes.thing_path(5, :optional_id => nil))
       end
     end
 
     context "and including them" do
       it "should include the optional parts" do
-        evaljs("Routes.things_path({optional_id: 5})").should == routes.things_path(:optional_id => 5)
+        expect(evaljs("Routes.things_path({optional_id: 5})")).to eq(routes.things_path(:optional_id => 5))
       end
     end
   end
@@ -179,20 +182,20 @@ describe JsRoutes, "compatibility with Rails"  do
   context "when wrong parameters given" do
 
     it "should throw Exception if not enough parameters" do
-      lambda {
+      expect {
         evaljs("Routes.inbox_path()")
-      }.should raise_error(js_error_class)
+      }.to raise_error(js_error_class)
     end
     it "should throw Exception if required parameter is not defined" do
-      lambda {
+      expect {
         evaljs("Routes.inbox_path(null)")
-      }.should raise_error(js_error_class)
+      }.to raise_error(js_error_class)
     end
 
     it "should throw Exceptions if when there is too many parameters" do
-      lambda {
+      expect {
         evaljs("Routes.inbox_path(1,2)")
-      }.should raise_error(js_error_class)
+      }.to raise_error(js_error_class)
     end
   end
 
@@ -201,7 +204,7 @@ describe JsRoutes, "compatibility with Rails"  do
       evaljs("Array.prototype.indexOf = null")
     end
     it "should still work correctly" do
-      evaljs("Routes.inboxes_path()").should == routes.inboxes_path()
+      expect(evaljs("Routes.inboxes_path()")).to eq(routes.inboxes_path())
     end
   end
 
@@ -210,44 +213,44 @@ describe JsRoutes, "compatibility with Rails"  do
     let(:inbox) {Struct.new(:id, :to_param).new(1,"my")}
 
     it "should use id property of the object in path" do
-      evaljs("Routes.inbox_path({id: 1})").should == routes.inbox_path(1)
+      expect(evaljs("Routes.inbox_path({id: 1})")).to eq(routes.inbox_path(1))
     end
 
     it "should prefer to_param property over id property" do
-      evaljs("Routes.inbox_path({id: 1, to_param: 'my'})").should == routes.inbox_path(inbox)
+      expect(evaljs("Routes.inbox_path({id: 1, to_param: 'my'})")).to eq(routes.inbox_path(inbox))
     end
 
     it "should call to_param if it is a function" do
-      evaljs("Routes.inbox_path({id: 1, to_param: function(){ return 'my';}})").should == routes.inbox_path(inbox)
+      expect(evaljs("Routes.inbox_path({id: 1, to_param: function(){ return 'my';}})")).to eq(routes.inbox_path(inbox))
     end
 
     it "should call id if it is a function" do
-      evaljs("Routes.inbox_path({id: function() { return 1;}})").should == routes.inbox_path(1)
+      expect(evaljs("Routes.inbox_path({id: function() { return 1;}})")).to eq(routes.inbox_path(1))
     end
 
     it "should support options argument" do
-      evaljs(
+      expect(evaljs(
         "Routes.inbox_message_path({id:1, to_param: 'my'}, {id:2}, {custom: true, format: 'json'})"
-      ).should == routes.inbox_message_path(inbox, 2, :custom => true, :format => "json")
+      )).to eq(routes.inbox_message_path(inbox, 2, :custom => true, :format => "json"))
     end
 
     context "when globbing" do
       it "should prefer to_param property over id property" do
-        evaljs("Routes.book_path({id: 1, to_param: 'my'}, 1)").should == routes.book_path(inbox, 1)
+        expect(evaljs("Routes.book_path({id: 1, to_param: 'my'}, 1)")).to eq(routes.book_path(inbox, 1))
       end
 
       it "should call to_param if it is a function" do
-        evaljs("Routes.book_path({id: 1, to_param: function(){ return 'my';}}, 1)").should == routes.book_path(inbox, 1)
+        expect(evaljs("Routes.book_path({id: 1, to_param: function(){ return 'my';}}, 1)")).to eq(routes.book_path(inbox, 1))
       end
 
       it "should call id if it is a function" do
-        evaljs("Routes.book_path({id: function() { return 'technical';}}, 1)").should == routes.book_path('technical', 1)
+        expect(evaljs("Routes.book_path({id: function() { return 'technical';}}, 1)")).to eq(routes.book_path('technical', 1))
       end
 
       it "should support options argument" do
-        evaljs(
+        expect(evaljs(
           "Routes.book_path({id:1, to_param: 'my'}, {id:2}, {custom: true, format: 'json'})"
-        ).should == routes.book_path(inbox, 2, :custom => true, :format => "json")
+        )).to eq(routes.book_path(inbox, 2, :custom => true, :format => "json"))
       end
     end
   end

data/spec/js_routes/{post_rails_init_spec.rb → zzz_last_post_rails_init_spec.rb}

@@ -1,50 +1,48 @@
+
+# we need to run post_rails_init_spec as the latest
+# because it cause unrevertable changes to runtime
+# what is why I added "zzz_last" in the beginning
 require 'spec_helper'
 require "fileutils"
 
 describe "after Rails initialization" do
-  let(:name) {  "#{File.dirname(__FILE__)}/../routes.js" }
+  NAME = "#{File.dirname(__FILE__)}/../routes.js"
 
   before(:all) do
-
-    FileUtils.rm_f(name)
-    JsRoutes.generate!(name)
-
-
+    FileUtils.rm_f(NAME)
+    JsRoutes.generate!(NAME)
     Rails.application.initialize!
   end
 
   after(:all) do
-    FileUtils.rm_f(name)
+    FileUtils.rm_f(NAME)
   end
 
   it "should generate routes file" do
-    File.exists?(name).should be_true
+    expect(File.exists?(NAME)).to be_true
   end
 
   context "JsRoutes::Engine" do
-
-    let(:test_asset_path) {
-      Rails.root.join('app','assets','javascripts','test.js')
-    }
+    TEST_ASSET_PATH = Rails.root.join('app','assets','javascripts','test.js')
 
     before(:all) do
-      File.open(test_asset_path,'w') do |f|
+      File.open(TEST_ASSET_PATH,'w') do |f|
         f.puts "function() {}"
       end
     end
     after(:all) do
-      FileUtils.rm_f(test_asset_path)
+      FileUtils.rm_f(TEST_ASSET_PATH)
     end
 
     it "should have registered a preprocessor" do
       pps = Rails.application.assets.preprocessors
       js_pps = pps['application/javascript']
-      js_pps.map(&:name).should include('Sprockets::Processor (js-routes_dependent_on_routes)')
+      expect(js_pps.map(&:name)).to include('Sprockets::Processor (js-routes_dependent_on_routes)')
     end
 
     context "the preprocessor" do
       before(:each) do
-        ctx.should_receive(:depend_on).with(Rails.root.join('config','routes.rb'))
+        expect(ctx).to receive(:depend_on).with(Rails.root.join('config','routes.rb'))
       end
       let!(:ctx) do
         Sprockets::Context.new(Rails.application.assets,
@@ -55,21 +53,25 @@ describe "after Rails initialization" do
       context "when dealing with js-routes.js" do
 
 
-        context "with Rails 3.1.1" do
+        context "with Rails" do
           context "and initialize on precompile" do
             before(:each) do
               Rails.application.config.assets.initialize_on_precompile = true
             end
             it "should render some javascript" do
-              ctx.evaluate('js-routes.js').should =~ /window\.Routes/
+              expect(ctx.evaluate('js-routes.js')).to match(/window\.Routes/)
             end
           end
           context "and not initialize on precompile" do
             before(:each) do
               Rails.application.config.assets.initialize_on_precompile = false
             end
-            it "should raise an exception" do
-              lambda { ctx.evaluate('js-routes.js') }.should raise_error(/Cannot precompile/)
+            it "should raise an exception if 3 version" do
+              if 3 == Rails::VERSION::MAJOR
+                expect { ctx.evaluate('js-routes.js') }.to raise_error(/Cannot precompile/)
+              else
+                expect(ctx.evaluate('js-routes.js')).to match(/window\.Routes/)
+              end
             end
           end
 
@@ -82,8 +84,8 @@ describe "after Rails initialization" do
       it "should not depend on routes.rb" do
         ctx = Sprockets::Context.new(Rails.application.assets,
                                      'test.js',
-                                     test_asset_path)
-        ctx.should_not_receive(:depend_on)
+                                     TEST_ASSET_PATH)
+        expect(ctx).not_to receive(:depend_on)
         ctx.evaluate('test.js')
       end
     end

data/spec/spec_helper.rb

@@ -15,16 +15,20 @@ else
   JS_LIB_CLASS = V8
 end
 
-def jscontext
-  @context ||= JS_LIB_CLASS::Context.new
+def jscontext(force = false)
+  if force
+    @jscontext = JS_LIB_CLASS::Context.new
+  else
+    @jscontext ||= JS_LIB_CLASS::Context.new
+  end
 end
 
 def js_error_class
   JS_LIB_CLASS::JSError
 end
 
-def evaljs(string)
-  jscontext.eval(string)
+def evaljs(string, force = false)
+  jscontext(force).eval(string)
 end
 
 def routes
@@ -102,11 +106,10 @@ Rails.configuration.active_support.deprecation = :log
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
 
 RSpec.configure do |config|
-
-  config.before(:each) do
-    evaljs("var window = this;")
-    jscontext[:log] = lambda {|context, value| puts value.inspect}
+  config.expect_with :rspec do |c|
+    c.syntax = :expect
   end
+
   config.before(:all) do
     # compile all js files begin
     Dir["#{File.expand_path(File.join(File.dirname(__FILE__), "..", "lib"))}/**/*.coffee"].each do |coffee|
@@ -115,4 +118,9 @@ RSpec.configure do |config|
     # compile all js files end
     draw_routes
   end
+
+  config.before :each do
+    evaljs("var window = this;", true)
+    jscontext[:log] = lambda {|context, value| puts value.inspect}
+  end
 end

metadata

@@ -1,7 +1,8 @@
 --- !ruby/object:Gem::Specification
 name: js-routes
 version: !ruby/object:Gem::Version
-  version: 0.9.3
+  version: 0.9.4
+  prerelease: 
 platform: ruby
 authors:
 - Bogdan Gusiev
@@ -13,99 +14,129 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.2'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: 2.10.0
+        version: 2.14.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: 2.10.0
+        version: 2.14.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 1.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 1.1.0
 - !ruby/object:Gem::Dependency
   name: guard
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: guard-coffeescript
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: appraisal
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 0.5.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 0.5.2
 - !ruby/object:Gem::Dependency
   name: debugger
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: therubyracer
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Generates javascript file that defines all Rails named routes as javascript
@@ -120,12 +151,15 @@ files:
 - .gitignore
 - .rspec
 - .travis.yml
+- Appraisals
 - Gemfile
 - Guardfile
 - LICENSE.txt
 - Rakefile
 - Readme.md
 - app/assets/javascripts/js-routes.js.erb
+- gemfiles/rails32.gemfile
+- gemfiles/rails40.gemfile
 - js-routes.gemspec
 - lib/js-routes.rb
 - lib/js_routes.rb
@@ -136,31 +170,35 @@ files:
 - lib/tasks/js_routes.rake
 - spec/js_routes/generated_javascript_spec.rb
 - spec/js_routes/options_spec.rb
-- spec/js_routes/post_rails_init_spec.rb
 - spec/js_routes/rails_routes_compatibility_spec.rb
+- spec/js_routes/zzz_last_post_rails_init_spec.rb
 - spec/spec_helper.rb
 homepage: http://github.com/railsware/js-routes
 licenses:
 - MIT
-metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -2158756967123699365
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.0
+rubygems_version: 1.8.25
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: Brings Rails named routes to javascript
 test_files: []

checksums.yaml

@@ -1,7 +0,0 @@
----
-SHA1:
-  metadata.gz: be32b22dcc7600a2141329061740f8fe7e9ff6e5
-  data.tar.gz: 64d3981fdf7cb0889ae9005c15821a6ff13b3997
-SHA512:
-  metadata.gz: 50da4f85cb59aaadc6e76cecbee608617a899d22b996c4d99590c2cac89e16981087282cfc56c727939ae40018afb9b3e8eb24baad57c09f915d89ff4a2a07fe
-  data.tar.gz: a503183633ad8570afbaa81124d3337ebc51420313b1d16d6a9d064a592882c1d413b42aa5fc5d13c113ada16a983d554a579efa5e882f2ed23a9d25428fd99d