jruby-lint 0.2.0 → 0.3.0

data/.gitignore

@@ -3,3 +3,4 @@
 Gemfile.lock
 pkg/*
 tmp
+lint-spec-report.html

data/History.txt

@@ -1,3 +1,7 @@
+=== 0.3.0 / 2011-07-04
+
+- html reports
+
 === 0.2.0 / 2011-06-03
 
 - #system('ruby') and #timeout checkers, thanks Matthew Kirk (hexgnu)!

data/README.md

@@ -31,12 +31,15 @@ Here is a list of the current checks implemented:
 - Report behavior difference when using system('ruby'), which launches
   the command in-process in a new copy of the interpreter for speed
 
+## Reports
+
+JRuby-lint supports text and html reports. Run jrlint with the option --html
+to generate an html report with the results.
+
 ## TODO
 
 Here is a list of checks and options we'd like to implement:
 
-- Options to save report off to a file.
-  - Text, HTML formats
 - Add in check for `` to make sure not execing ruby ...
 - Report on more threading and concurrency issues/antipatterns
   - arr.each {|x| arr.delete(x) }

data/lib/jruby/lint/cli.rb

@@ -23,6 +23,18 @@ module JRuby
             @options.eval << v
           end
 
+          opts.on('--text', 'print report as text') do
+            @options.text = true
+          end
+
+          opts.on('--ansi', 'print report as ansi text') do
+            @options.ansi = true
+          end
+
+          opts.on('--html [REPORT_FILE]', 'print report as html file') do |file|
+            @options.html = file || 'jruby-lint.html'
+          end
+
           opts.on_tail("-v", "--version", "Print version and exit") do
             require 'jruby/lint/version'
             puts "JRuby-Lint version #{VERSION}"

data/lib/jruby/lint/finding.rb

@@ -8,6 +8,14 @@ module JRuby::Lint
       super
     end
 
+    def error?
+      tags.include?('error')
+    end
+
+    def warning?
+      tags.include?('warning')
+    end
+
     def to_s
       "#{file}:#{line}: [#{tags.join(', ')}] #{message}"
     end

data/lib/jruby/lint/project.rb

@@ -19,7 +19,7 @@ module JRuby::Lint
 
       @sources = options.files || (options.eval ? [] : Dir['./**/*'])
       load_collectors
-      load_reporters
+      load_reporters(options)
       load_libraries
     end
 
@@ -30,6 +30,7 @@ module JRuby::Lint
         reporters.each {|r| r.report(c.findings)}
         @findings += c.findings
       end
+      reporters.each {|r| r.print_report(@findings) if r.respond_to?(:print_report) }
     end
 
     private
@@ -45,8 +46,11 @@ module JRuby::Lint
       end
     end
 
-    def load_reporters
-      @reporters = [(STDOUT.tty? ? Reporters::ANSIColor : Reporters::Text).new(self, STDOUT)]
+    def load_reporters(options)
+      @reporters = []
+      @reporters << Reporters::Html.new(self, options.html) if options.html
+      @reporters << Reporters::ANSIColor.new(self, STDOUT) if options.ansi || STDOUT.tty?
+      @reporters << Reporters::Text.new(self, STDOUT) if options.text || @reporters.empty?
     end
 
     def load_libraries

data/lib/jruby/lint/reporters.rb

@@ -1,35 +1,7 @@
-require 'term/ansicolor'
-
 module JRuby::Lint
   module Reporters
-    class Text
-      def initialize(project, output)
-        @tags, @output = project.tags, output
-      end
-
-      def report(findings)
-        findings.each do |finding|
-          puts finding unless (@tags & finding.tags).empty?
-        end
-      end
-
-      def puts(finding)
-        @output.puts finding.to_s
-      end
-    end
-
-    class ANSIColor < Text
-      include Term::ANSIColor
-      def puts(finding)
-        msg = if finding.tags.include?("error")
-                red(finding.to_s)
-              elsif finding.tags.include?("warning")
-                yellow(finding.to_s)
-              else
-                finding.to_s
-              end
-        @output.puts msg
-      end
-    end
   end
 end
+
+require 'jruby/lint/reporters/text'
+require 'jruby/lint/reporters/html'

data/lib/jruby/lint/reporters/html.rb

@@ -0,0 +1,27 @@
+module JRuby::Lint
+  module Reporters
+    class Html
+      require 'erb'
+
+      def initialize(project, output)
+        @tags = project.tags
+        @output = output
+        @template = ERB.new(File.read(File.expand_path('../jruby-lint.html.erb', __FILE__)))
+      end
+
+      def report(findings)
+      end
+
+      def print_report(findings)
+        @findings = []
+        findings.each do |finding|
+          @findings << finding unless (@tags & finding.tags).empty?
+        end
+
+        File.open(@output, 'w') do |file|
+          file.write @template.result(binding)
+        end
+      end
+    end
+  end
+end

data/lib/jruby/lint/reporters/jruby-lint.html.erb

@@ -0,0 +1,48 @@
+<html>
+  <head>
+    <title>JRuby-lint diagnostics report</title>
+    <style>
+ul { padding: 0px; }
+li { list-style: none; margin: 0px; padding: 0px; display: list-item; }
+body { font-family: 'Lucida Grande', Verdana, Arial, Sans-Serif; font-size:10.5pt; margin: 0; }
+
+h1 { color: #383838; font-size: 4em; }
+p { color: #383838; font-size: 1.8em; }
+.site { width: 70em; margin: 0 auto; padding: .1em 5em; }
+nav { position: relative; }
+#findings li { position: relative; padding: .5em 1em; margin-top: .3em; }
+#congrats { padding-top: 2em; }
+.message { border-left: 5px solid silver; background: #EEE; }
+.error { border-left: 5px solid #b22222; background: #E6BCB5; }
+.warning { border-left: 5px solid #FF9900; background: #FFFF99; }
+    </style>
+  </head>
+  <body>
+    <a href="http://github.com/jruby/jruby-lint"><img style="position: absolute; top: 0; right: 0; border: 0;" src="https://d3nwyuy0nl342s.cloudfront.net/img/e6bef7a091f5f3138b8cd40bc3e114258dd68ddf/687474703a2f2f73332e616d617a6f6e6177732e636f6d2f6769746875622f726962626f6e732f666f726b6d655f72696768745f7265645f6161303030302e706e67" alt="Fork me on GitHub"></a>
+    <div class="site">
+      <nav>
+        <h1>JRuby diagnostics</h1>
+      </nav>
+      <div id="findings">
+        <% unless @findings.empty? %>
+        <ul>
+          <% @findings.each do |finding| %>
+            <% if finding.error? %>
+              <li class="error"><%= finding %></li>
+            <% elsif finding.warning? %>
+              <li class="warning"><%= finding %></li>
+            <% else %>
+              <li class="message"><%= finding %></li>
+            <% end %>
+          <% end %>
+        </ul>
+        <% else %>
+        <div id="congrats">
+          <p>Congratulations!</p>
+          <p>We didn't find any issue and your application should run just fine with JRuby.</p>
+        </div> <!-- div#congrats -->
+        <% end %>
+      </div> <!-- div#findings -->
+    </div> <!-- div.site -->
+  </body>
+</html>

data/lib/jruby/lint/reporters/text.rb

@@ -0,0 +1,34 @@
+module JRuby::Lint
+  module Reporters
+    class Text
+      def initialize(project, output)
+        @tags, @output = project.tags, output
+      end
+
+      def report(findings)
+        findings.each do |finding|
+          puts finding unless (@tags & finding.tags).empty?
+        end
+      end
+
+      def puts(finding)
+        @output.puts finding.to_s
+      end
+    end
+
+    class ANSIColor < Text
+      require 'term/ansicolor'
+      include Term::ANSIColor
+      def puts(finding)
+        msg = if finding.error?
+                red(finding.to_s)
+              elsif finding.warning?
+                yellow(finding.to_s)
+              else
+                finding.to_s
+              end
+        @output.puts msg
+      end
+    end
+  end
+end

data/lib/jruby/lint/version.rb

@@ -1,5 +1,5 @@
 module JRuby
   module Lint
-    VERSION = "0.2.0"
+    VERSION = "0.3.0"
   end
 end

data/spec/fixtures/C-Extension-Alternatives.html

@@ -8,12 +8,12 @@
   <head>
     <meta charset='utf-8'>
     <meta http-equiv="X-UA-Compatible" content="chrome=1">
-    <script>var NREUMQ=[];NREUMQ.push(["mark","firstbyte",new Date().getTime()]);</script>
+    <script type="text/javascript">var NREUMQ=[];NREUMQ.push(["mark","firstbyte",new Date().getTime()]);</script>
         <title>C Extension Alternatives - GitHub</title>
     <link rel="search" type="application/opensearchdescription+xml" href="/opensearch.xml" title="GitHub" />
     <link rel="fluid-icon" href="https://github.com/fluidicon.png" title="GitHub" />
 
-    <link href="https://d3nwyuy0nl342s.cloudfront.net/709540747571a12d9ee0e981881190bbacde01fe/stylesheets/bundle_github.css" media="screen" rel="stylesheet" type="text/css" />
+    <link href="https://a248.e.akamai.net/assets.github.com/b061594e73bd47cde0b406f0ccd1cee8b0aa96ec/stylesheets/bundle_github.css" media="screen" rel="stylesheet" type="text/css" />
     
 
     <script type="text/javascript">
@@ -22,13 +22,13 @@
     </script>
     <script type="text/javascript" charset="utf-8">
       var GitHub = {
-        assetHost: 'https://d3nwyuy0nl342s.cloudfront.net'
+        assetHost: 'https://a248.e.akamai.net/assets.github.com'
       }
       var github_user = null
       
     </script>
-    <script src="https://d3nwyuy0nl342s.cloudfront.net/javascripts/jquery/jquery-1.4.2.min.js" type="text/javascript"></script>
-    <script src="https://d3nwyuy0nl342s.cloudfront.net/32997e5cd4ce47f6467e629aedf849edcf5a7376/javascripts/bundle_github.js" type="text/javascript"></script>
+    <script src="https://a248.e.akamai.net/assets.github.com/javascripts/jquery/jquery-1.6.1.min.js" type="text/javascript"></script>
+    <script src="https://a248.e.akamai.net/assets.github.com/9a8d4d0be567a85129ca26f93f40eb76dcc8bfbb/javascripts/bundle_github.js" type="text/javascript"></script>
 
 
     
@@ -40,7 +40,7 @@
 
     
   <link href="https://github.com/jruby/jruby/commits/master.atom" rel="alternate" title="Recent Commits to jruby:master" type="application/atom+xml" />
-  <script src="https://d3nwyuy0nl342s.cloudfront.net/a5293f39de14a50f19260ef05b2ae4a145b2cbce/javascripts/bundle_wiki.js" type="text/javascript"></script>
+  <script src="https://a248.e.akamai.net/assets.github.com/9efa4f408d844eccca76d5687e85d5b519597f1f/javascripts/bundle_wiki.js" type="text/javascript"></script>
 
   <script src="/javascripts/other/MathJax/MathJax.js" type="text/javascript">
     if (window.location.protocol == "https:") {
@@ -57,7 +57,7 @@
     <script type="text/javascript">
       GitHub.nameWithOwner = GitHub.nameWithOwner || "jruby/jruby";
       GitHub.currentRef = 'master';
-      GitHub.commitSHA = "f03b829c28c581c661f8916b54978b552cc03ff5";
+      GitHub.commitSHA = "24aad97afc34e25047c06298ea0f2559f90c14d2";
       GitHub.currentPath = '';
       GitHub.masterBranch = "master";
 
@@ -91,16 +91,14 @@
 
     
 
-    
-
     <div class="subnavd" id="main">
       <div id="header" class="true">
         
           <a class="logo boring" href="https://github.com">
             
-            <img alt="github" class="default" height="45" src="https://d3nwyuy0nl342s.cloudfront.net/images/modules/header/logov5.png" />
+            <img alt="github" class="default" height="45" src="https://a248.e.akamai.net/assets.github.com/images/modules/header/logov5.png" />
             <!--[if (gt IE 8)|!(IE)]><!-->
-            <img alt="github" class="hover" height="45" src="https://d3nwyuy0nl342s.cloudfront.net/images/modules/header/logov5-hover.png" />
+            <img alt="github" class="hover" height="45" src="https://a248.e.akamai.net/assets.github.com/images/modules/header/logov5-hover.png" />
             <!--<![endif]-->
           </a>
         
@@ -145,12 +143,12 @@
       
         <li class="for-owner" style="display:none"><a href="/jruby/jruby/admin" class="minibutton btn-admin "><span><span class="icon"></span>Admin</span></a></li>
         <li>
-          <a href="/jruby/jruby/toggle_watch" class="minibutton btn-watch " id="watch_button" onclick="var f = document.createElement('form'); f.style.display = 'none'; this.parentNode.appendChild(f); f.method = 'POST'; f.action = this.href;var s = document.createElement('input'); s.setAttribute('type', 'hidden'); s.setAttribute('name', 'authenticity_token'); s.setAttribute('value', '39136b986bbed8c260a8aa8d9ff8b1c9bd2b9ac8'); f.appendChild(s);f.submit();return false;" style="display:none"><span><span class="icon"></span>Watch</span></a>
-          <a href="/jruby/jruby/toggle_watch" class="minibutton btn-watch " id="unwatch_button" onclick="var f = document.createElement('form'); f.style.display = 'none'; this.parentNode.appendChild(f); f.method = 'POST'; f.action = this.href;var s = document.createElement('input'); s.setAttribute('type', 'hidden'); s.setAttribute('name', 'authenticity_token'); s.setAttribute('value', '39136b986bbed8c260a8aa8d9ff8b1c9bd2b9ac8'); f.appendChild(s);f.submit();return false;" style="display:none"><span><span class="icon"></span>Unwatch</span></a>
+          <a href="/jruby/jruby/toggle_watch" class="minibutton btn-watch " id="watch_button" onclick="var f = document.createElement('form'); f.style.display = 'none'; this.parentNode.appendChild(f); f.method = 'POST'; f.action = this.href;var s = document.createElement('input'); s.setAttribute('type', 'hidden'); s.setAttribute('name', 'authenticity_token'); s.setAttribute('value', 'a12af8eb75d6148a6d430d76ce52736db893dd3d'); f.appendChild(s);f.submit();return false;" style="display:none"><span><span class="icon"></span>Watch</span></a>
+          <a href="/jruby/jruby/toggle_watch" class="minibutton btn-watch " id="unwatch_button" onclick="var f = document.createElement('form'); f.style.display = 'none'; this.parentNode.appendChild(f); f.method = 'POST'; f.action = this.href;var s = document.createElement('input'); s.setAttribute('type', 'hidden'); s.setAttribute('name', 'authenticity_token'); s.setAttribute('value', 'a12af8eb75d6148a6d430d76ce52736db893dd3d'); f.appendChild(s);f.submit();return false;" style="display:none"><span><span class="icon"></span>Unwatch</span></a>
         </li>
         
           
-            <li class="for-notforked" style="display:none"><a href="/jruby/jruby/fork" class="minibutton btn-fork " id="fork_button" onclick="var f = document.createElement('form'); f.style.display = 'none'; this.parentNode.appendChild(f); f.method = 'POST'; f.action = this.href;var s = document.createElement('input'); s.setAttribute('type', 'hidden'); s.setAttribute('name', 'authenticity_token'); s.setAttribute('value', '39136b986bbed8c260a8aa8d9ff8b1c9bd2b9ac8'); f.appendChild(s);f.submit();return false;"><span><span class="icon"></span>Fork</span></a></li>
+            <li class="for-notforked" style="display:none"><a href="/jruby/jruby/fork" class="minibutton btn-fork " id="fork_button" onclick="var f = document.createElement('form'); f.style.display = 'none'; this.parentNode.appendChild(f); f.method = 'POST'; f.action = this.href;var s = document.createElement('input'); s.setAttribute('type', 'hidden'); s.setAttribute('name', 'authenticity_token'); s.setAttribute('value', 'a12af8eb75d6148a6d430d76ce52736db893dd3d'); f.appendChild(s);f.submit();return false;"><span><span class="icon"></span>Fork</span></a></li>
             <li class="for-hasfork" style="display:none"><a href="#" class="minibutton btn-fork " id="your_fork_button"><span><span class="icon"></span>Your Fork</span></a></li>
           
 
@@ -160,8 +158,8 @@
       
       <li class="repostats">
         <ul class="repo-stats">
-          <li class="watchers"><a href="/jruby/jruby/watchers" title="Watchers" class="tooltipped downwards">512</a></li>
-          <li class="forks"><a href="/jruby/jruby/network" title="Forks" class="tooltipped downwards">114</a></li>
+          <li class="watchers"><a href="/jruby/jruby/watchers" title="Watchers" class="tooltipped downwards">551</a></li>
+          <li class="forks"><a href="/jruby/jruby/network" title="Forks" class="tooltipped downwards">125</a></li>
         </ul>
       </li>
     </ul>
@@ -179,10 +177,12 @@
 
     
 
-                <li><a href="/jruby/jruby/wiki" class="selected" highlight="repo_wiki">Wiki (117)</a></li>
+                <li><a href="/jruby/jruby/wiki" class="selected" highlight="repo_wiki">Wiki (118)</a></li>
         
     <li><a href="/jruby/jruby/graphs" highlight="repo_graphs">Graphs</a></li>
 
+    
+
     <li class="contextswitch nochoices">
       <span class="toggle leftwards" >
         <em>Branch:</em>
@@ -287,10 +287,10 @@
 </div>
 <div id="gollum-footer">
   <p id="last-edit">
-        Last edited by headius, <abbr class="relatize" title="2011-05-15 17:25:54">Sun May 15 17:25:54 -0700 2011</abbr>
+        Last edited by headius, <time class="js-relative-date" datetime="2011-05-15T17:25:54-07:00" title="2011-05-15 17:25:54">May 15, 2011</time>
       </p>
   <p id="delete-link">
-    <a href="/jruby/jruby/wiki/C-Extension-Alternatives" onclick="if (confirm('Are you sure you want to delete this page?')) { var f = document.createElement('form'); f.style.display = 'none'; this.parentNode.appendChild(f); f.method = 'POST'; f.action = this.href;var m = document.createElement('input'); m.setAttribute('type', 'hidden'); m.setAttribute('name', '_method'); m.setAttribute('value', 'delete'); f.appendChild(m);var s = document.createElement('input'); s.setAttribute('type', 'hidden'); s.setAttribute('name', 'authenticity_token'); s.setAttribute('value', '39136b986bbed8c260a8aa8d9ff8b1c9bd2b9ac8'); f.appendChild(s);f.submit(); };return false;"><span>Delete this Page</span></a>
+    <a href="/jruby/jruby/wiki/C-Extension-Alternatives" onclick="if (confirm('Are you sure you want to delete this page?')) { var f = document.createElement('form'); f.style.display = 'none'; this.parentNode.appendChild(f); f.method = 'POST'; f.action = this.href;var m = document.createElement('input'); m.setAttribute('type', 'hidden'); m.setAttribute('name', '_method'); m.setAttribute('value', 'delete'); f.appendChild(m);var s = document.createElement('input'); s.setAttribute('type', 'hidden'); s.setAttribute('name', 'authenticity_token'); s.setAttribute('value', 'a12af8eb75d6148a6d430d76ce52736db893dd3d'); f.appendChild(s);f.submit(); };return false;"><span>Delete this Page</span></a>
   </p>
 </div>
 </div>
@@ -306,7 +306,7 @@
         
           <div class="sponsor">
             <a href="http://www.rackspace.com" class="logo">
-              <img alt="Dedicated Server" height="36" src="https://d3nwyuy0nl342s.cloudfront.net/images/modules/footer/rackspace_logo.png?v2" width="38" />
+              <img alt="Dedicated Server" height="36" src="https://a248.e.akamai.net/assets.github.com/images/modules/footer/rackspace_logo.png?v2" width="38" />
             </a>
             Powered by the <a href="http://www.rackspace.com ">Dedicated
             Servers</a> and<br/> <a href="http://www.rackspacecloud.com">Cloud
@@ -327,7 +327,7 @@
           
         </ul>
         <ul class="sosueme">
-          <li class="main">&copy; 2011 <span id="_rrt" title="0.09826s from fe4.rs.github.com">GitHub</span> Inc. All rights reserved.</li>
+          <li class="main">&copy; 2011 <span id="_rrt" title="0.11973s from fe1.rs.github.com">GitHub</span> Inc. All rights reserved.</li>
           <li><a href="/site/terms">Terms of Service</a></li>
           <li><a href="/site/privacy">Privacy</a></li>
           <li><a href="https://github.com/security">Security</a></li>
@@ -335,7 +335,7 @@
       </div>
     </div><!-- /#footer -->
 
-    <script>window._auth_token = "39136b986bbed8c260a8aa8d9ff8b1c9bd2b9ac8"</script>
+    <script>window._auth_token = "a12af8eb75d6148a6d430d76ce52736db893dd3d"</script>
     
 
 <div id="keyboard_shortcuts_pane" class="instapaper_ignore readability-extra" style="display:none">
@@ -599,7 +599,7 @@ As Kanye West said:
 
   <h3>Code Examples in Markdown</h3>
   <div class="col">
-      <p>Syntax highlighting with <a href="http://github.github.com/github-flavored-markdown/" title="GitHub Flavored Markdown">GFM</a></p>
+      <p>Syntax highlighting with <a href="http://github.github.com/github-flavored-markdown/" title="GitHub Flavored Markdown" target="_blank">GFM</a></p>
       <pre>
 ```javascript
 function fancyAlert(arg) {
@@ -646,7 +646,7 @@ I think you should use an
     
     
     
-    <script>(function(){var d=document;var e=d.createElement("script");e.async=true;e.src="https://d1ros97qkrwjf5.cloudfront.net/10/eum/rum.js	";var s=d.getElementsByTagName("script")[0];s.parentNode.insertBefore(e,s);})();NREUMQ.push(["nrf2","beacon-3.newrelic.com","2f94e4d8c2",64799,"dw1bEBZcX1RWRhoBFFUSXRdLQ1JKR11WDxZVFlwLCg==",0,151,new Date().getTime()])</script>
+    <script type="text/javascript">(function(){var d=document;var e=d.createElement("script");e.async=true;e.src="https://d1ros97qkrwjf5.cloudfront.net/14/eum/rum.js	";e.type="text/javascript";var s=d.getElementsByTagName("script")[0];s.parentNode.insertBefore(e,s);})();NREUMQ.push(["nrf2","beacon-1.newrelic.com","2f94e4d8c2",64799,"dw1bEBZcX1RWRhoRD18LGhcMXEQ=",0.0,118,new Date().getTime()])</script>
   </body>
 </html>
 

data/spec/jruby/lint/finding_spec.rb

@@ -28,4 +28,16 @@ describe JRuby::Lint::Finding do
     When { @finding = JRuby::Lint::Finding.new(message, tags, file, line) }
     Then { @finding.tags.should == ["1", "two", "3.0"] }
   end
+
+  context "with error tags" do
+    Given(:tags) { [:error] }
+    When { @finding = JRuby::Lint::Finding.new(message, tags, file, line) }
+    Then { @finding.should be_error }
+  end
+
+  context "with warnings tags" do
+    Given(:tags) { [:warning] }
+    When { @finding = JRuby::Lint::Finding.new(message, tags, file, line) }
+    Then { @finding.should be_warning }
+  end
 end

data/spec/jruby/lint/project_spec.rb

@@ -67,6 +67,11 @@ describe JRuby::Lint::Project do
       end
     end
 
+    When do
+      reporter.stub!(:print_report)
+      reporter.should_receive(:print_report).with([finding])
+    end
+
     When do
       project.collectors.replace [collector]
       project.reporters.replace [reporter]
@@ -74,4 +79,48 @@ describe JRuby::Lint::Project do
 
     Then { project.run }
   end
+
+  context 'loading reporters' do
+    context 'with html option' do
+      Given(:options) { OpenStruct.new(:html => 'report.html') }
+      Given(:project) { in_current_dir { JRuby::Lint::Project.new(options) } }
+      Then { project.reporters.should have(1).reporter }
+      Then { project.reporters.first.should be_an_instance_of(JRuby::Lint::Reporters::Html) }
+    end
+
+    context 'with ansi option' do
+      Given(:options) { OpenStruct.new(:ansi => true) }
+      Given(:project) { in_current_dir { JRuby::Lint::Project.new(options) } }
+      Then { project.reporters.should have(1).reporter }
+      Then { project.reporters.first.should be_an_instance_of(JRuby::Lint::Reporters::ANSIColor) }
+    end
+
+    context 'with text option' do
+      Given(:options) { OpenStruct.new(:text => true) }
+      Given(:project) { in_current_dir { JRuby::Lint::Project.new(options) } }
+      Then { project.reporters.should have(1).reporter }
+      Then { project.reporters.first.should be_an_instance_of(JRuby::Lint::Reporters::Text) }
+    end
+
+    context 'with tty' do
+      Given { STDOUT.stub(:tty?).and_return(true) }
+      Given(:project) { in_current_dir { JRuby::Lint::Project.new } }
+      Then { project.reporters.should have(1).reporter }
+      Then { project.reporters.first.should be_an_instance_of(JRuby::Lint::Reporters::ANSIColor) }
+    end
+
+    context 'without any option' do
+      Given(:project) { in_current_dir { JRuby::Lint::Project.new } }
+      Then { project.reporters.should have(1).reporter }
+      Then { project.reporters.first.should be_an_instance_of(JRuby::Lint::Reporters::Text) }
+    end
+
+    context 'with several options' do
+      Given(:options) { OpenStruct.new(:ansi => true, :html => 'report.html') }
+      Given(:project) { in_current_dir { JRuby::Lint::Project.new(options) } }
+      Then { project.reporters.should have(2).reporter }
+      Then { project.reporters.map(&:class).should include(JRuby::Lint::Reporters::ANSIColor) }
+      Then { project.reporters.map(&:class).should include(JRuby::Lint::Reporters::Html) }
+    end
+  end
 end

data/spec/jruby/lint/reporters_spec.rb

@@ -26,17 +26,38 @@ describe JRuby::Lint::Reporters do
     Given(:reporter) { JRuby::Lint::Reporters::ANSIColor.new(project, output) }
 
     context "shows a finding tagged 'error' in red" do
-      Given(:finding) { double "finding", :to_s => "hello", :tags => %w(error) }
+      Given(:finding) { double "finding", :to_s => "hello", :tags => %w(error), :error? => true }
       Given(:output) { double("output").tap {|o| o.should_receive(:puts).with(red("hello")) } }
 
       Then { reporter.report [finding] }
     end
 
     context "shows a finding tagged 'warning' in yellow" do
-      Given(:finding) { double "finding", :to_s => "hello", :tags => %w(warning) }
+      Given(:finding) { double "finding", :to_s => "hello", :tags => %w(warning), :error? => false, :warning? => true }
       Given(:output) { double("output").tap {|o| o.should_receive(:puts).with(yellow("hello")) } }
 
       Then { reporter.report [finding] }
     end
   end
+
+  context "Html reporter" do
+    Given(:reporter) { JRuby::Lint::Reporters::Html.new(project, 'lint-spec-report.html') }
+
+    context "shows a finding tagged 'error' in red" do
+      Given(:finding) { double "finding", :to_s => "hello", :tags => %w(error), :error? => true }
+      Then { reporter.print_report [finding] }
+      Then { File.read('lint-spec-report.html').should include('<li class="error">hello</li>') }
+    end
+
+    context "shows a finding tagged 'warning' in yellow" do
+      Given(:finding) { double "finding", :to_s => "hello", :tags => %w(warning), :error? => false, :warning? => true }
+      Then { reporter.print_report [finding] }
+      Then { File.read('lint-spec-report.html').should include('<li class="warning">hello</li>') }
+    end
+
+    context "shows a nice message when we don't find any issue" do
+      When { reporter.print_report [] }
+      Then { File.read('lint-spec-report.html').should include('Congratulations!') }
+    end
+  end
 end

metadata

@@ -2,7 +2,7 @@
 name: jruby-lint
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors: 
   - Nick Sieger
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-06-03 00:00:00 -05:00
+date: 2011-07-05 00:00:00 +02:00
 default_executable: 
 dependencies: 
   - !ruby/object:Gem::Dependency 
@@ -136,6 +136,9 @@ files:
   - lib/jruby/lint/libraries.rb
   - lib/jruby/lint/project.rb
   - lib/jruby/lint/reporters.rb
+  - lib/jruby/lint/reporters/html.rb
+  - lib/jruby/lint/reporters/jruby-lint.html.erb
+  - lib/jruby/lint/reporters/text.rb
   - lib/jruby/lint/version.rb
   - spec/fixtures/C-Extension-Alternatives.html
   - spec/jruby/lint/ast_spec.rb