jquery_match_height_rails 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8ca14bfb1e02f4786d10c7168baf29b36f368b03
-  data.tar.gz: 07fd7ca6b23bdddf5d6ca495d84945545960d703
+  metadata.gz: 40c5bf8cbd773fd77d6f2ceb762505bc1e7acd06
+  data.tar.gz: 7e0aaa4f53824b8da48deb63f1502789556d5f33
 SHA512:
-  metadata.gz: ec7412968930619a1309dc6592b4df180dc9b855eb9b4b03e97e9c5a44de57e7e1184300ba7a5d23f24cc7db2685c9b58622eaf2fcb2d485a82fff69aad19dfb
-  data.tar.gz: 37be671d541f82653e61bec0d2c5375fd9cd41e3cae0cf05a42fbc660eb1631afd8f6d9af82ee425b9bc39505540682ba330fda7ed0b02405ce1657c5b657e38
+  metadata.gz: 22b29a298f209c39560b9264ffc1a3995de302cbc56c7e7f5968c7f6dd12408b439b3733e6356e3418489b6cf6d8404b2a699f9282527c106ed9e4984ca942b8
+  data.tar.gz: cf1d424e8edbf05fb3818e19286563a8b3ab0936c2445ae5d91bbdeac36ea9b6bde084d5b332e9458daf333f0acbce2395367566d9024a67b4412ecbabec10b3

data/.gitignore

@@ -7,3 +7,4 @@
 /pkg/
 /spec/reports/
 /tmp/
+*.gem

data/README.md

@@ -1,8 +1,6 @@
-# JqueryMatchHeightRails
+# jQueryMatchHeight - Rails Gem
 
-Welcome to your new gem! In this directory, you'll find the files you need to be able to package up your Ruby library into a gem. Put your Ruby code in the file `lib/jquery_match_height_rails`. To experiment with that code, run `bin/console` for an interactive prompt.
-
-TODO: Delete this and the text above, and describe your gem
+jQueryMatchHeightRails is a rails integration of the popular jQuery plugin by Liam Brummitt. I am merely a constant jQueryMatchHeight user in Rails thinking a Rails Plugin would be good to maintain. Access the main repository for plugin documentation [here](https://github.com/liabru/jquery-match-height).
 
 ## Installation
 
@@ -22,7 +20,13 @@ Or install it yourself as:
 
 ## Usage
 
-TODO: Write usage instructions here
+```js
+//= require jquery_match_height
+
+$(document).ready(function(){
+  $('[data-mh]').matchHeight(false);
+});
+```
 
 ## Development
 
@@ -32,7 +36,7 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/jquery_match_height_rails. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
+Bug reports and pull requests are welcome on GitHub at https://github.com/jdeen/jquery_match_height_rails. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
 
 
 ## License

data/app/assets/javascripts/jquery_match_height.js

@@ -1,5 +1,5 @@
 /**
- * jquery.matchHeight.js v0.5.0
+ * jquery.matchHeight.js v0.5.1
  * http://brm.io/jquery-match-height/
  * License: MIT
  */
@@ -82,8 +82,8 @@
 
                 // handle padding and border correctly (required when not using border-box)
                 if ($that.css('box-sizing') !== 'border-box') {
-                    verticalPadding += parseInt($that.css('border-top-width'), 10) + parseInt($that.css('border-bottom-width'), 10);
-                    verticalPadding += parseInt($that.css('padding-top'), 10) + parseInt($that.css('padding-bottom'), 10);
+                    verticalPadding += _parse($that.css('border-top-width')) + _parse($that.css('border-bottom-width'));
+                    verticalPadding += _parse($that.css('padding-top')) + _parse($that.css('padding-bottom'));
                 }
 
                 // set the height (accounting for padding and border)
@@ -124,7 +124,20 @@
 
     $.fn.matchHeight._groups = [];
 
-    $.fn.matchHeight._update = function() {
+    var previousResizeWidth = -1;
+
+    $.fn.matchHeight._update = function(event) {
+
+        // prevent update if fired from a resize event 
+        // where the viewport width hasn't actually changed
+        // fixes an event looping bug in IE8
+        if (event && event.type === 'resize') {
+            var windowWidth = $(window).width();
+            if (windowWidth === previousResizeWidth)
+                return;
+            previousResizeWidth = windowWidth;
+        }
+
         $.each($.fn.matchHeight._groups, function() {
             $.fn.matchHeight._apply(this.elements, this.byRow);
         });
@@ -138,7 +151,7 @@
     $($.fn.matchHeight._applyDataApi);
 
     // update heights on load and resize events
-    $(window).on('load resize orientationchange', $.fn.matchHeight._update);
+    $(window).bind('load resize orientationchange', $.fn.matchHeight._update);
 
     /*
      *  rows utility function
@@ -155,7 +168,7 @@
         // group elements by their top position
         $elements.each(function() {
             var $that = $(this),
-                top = $that.offset().top - parseInt($that.css('margin-top'), 10),
+                top = $that.offset().top - _parse($that.css('margin-top')),
                 lastRow = rows.length > 0 ? rows[rows.length - 1] : null;
 
             if (lastRow === null) {
@@ -178,4 +191,9 @@
         return rows;
     };
 
+    var _parse = function(value) {
+        // parse value and convert NaN to 0
+        return parseFloat(value) || 0;
+    };
+
 })(jQuery);

data/lib/jquery_match_height_rails/version.rb

@@ -1,3 +1,3 @@
 module JqueryMatchHeightRails
-  VERSION = "0.5.0"
+  VERSION = "0.5.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: jquery_match_height_rails
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Ziyan Junaideen