jquery-turbolinks 2.0.2 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 884dfb21c89689dab011a84b205bed4f3e10819d
-  data.tar.gz: 20933764a2bd7e355ce3b1427c47277cefa01295
+  metadata.gz: 4d5928028de9078ab68d9deadd5e3097645d0cb0
+  data.tar.gz: 3c1b76a837e43f1f2b2269dfe083aa181d42cff8
 SHA512:
-  metadata.gz: 1e6a33f7177118c27c86d32235fcf4330d5e6590beabe13e37dfbe3acf292b7240b42f8b0536ee03453b9712d030d5c06737aed43af6c0186acbd7a778709417
-  data.tar.gz: 6147215131b2eb1f26020feebc678fdeeaf081253c7370d821de15ef315af093a75f5c956bed083d5b3a054348cef89664ab829327caf2d6a5d6866b7471af76
+  metadata.gz: 831d2989cde58293de4de61c390cf200bb87204a271313bc4fce08a2d19b5db3356025d8cd128fad689f16b761a64d743aeab55b412487ae17680ee63c52e2d3
+  data.tar.gz: 5b2ec4937a7a8792189de8120ea72de9a7843c86dfbd5b55857fe7ac780c37767bf8091c0cabdb1177f7eee52e30a582e9af4529bbc01124858e874e12b658f8

data/NOTES.md

@@ -34,7 +34,7 @@ Releasing new versions
 
  * Bump version (see above)
  * Build .js (`rake build`)
- * Release into npm and rubygems (`rake release`)
+ * Release into npm and rubygems (`rake release:all`)
  * Draft release in https://github.com/kossnocorp/jquery.turbolinks/releases
 
 Release it into npm/rubygems using:

data/README.md

@@ -39,6 +39,8 @@ Add it to your JavaScript manifest file, in this order:
 
 And it just works!
 
+**Checkout "[Faster page loads with Turbolinks](https://coderwall.com/p/ypzfdw)" for deeper explanation how to use jQuery Turbolink in real world**.
+
 ## API and Customization
 
 ### $.turbo.use
@@ -57,24 +59,6 @@ either `true` or `false` depending on whether the page is loading.
 
 ## Troubleshooting
 
-### Zurb Foundation
-
-The `$(function(){ $(document).foundation(); });` has to come before the 
-turbolinks gem.
-
-``` js
-//= require jquery
-//= require jquery.turbolinks
-//= require jquery_ujs
-//
-// ... your other scripts here ...
-
-$(function(){ $(document).foundation(); });
-
-//
-//= require turbolinks
-```
-
 ### Events firing twice or more
 
 If you find that some events are being fired multiple times after using jQuery Turbolinks, you may have been binding your `document` events inside a `$(function())` block. For instance, this example below can be a common occurrence and should be avoided:
@@ -93,6 +77,19 @@ You should be binding your events outside a `$(function())` block. This will ens
 $(document).on('click', 'button', function() { ... })
 ```
 
+### Not working with `$(document).on('ready')`
+
+jQuery Turbolinks doesn't support ready events bound via `$(document).on('ready', function)`. Instead, use `$(document).ready(function)` or `$(function)`.
+
+``` javascript
+// BAD: this will not work.
+$(document).on('ready', function () { /* ... */ });
+
+// OK: these two are guaranteed to work.
+$(document).ready(function () { /* ... */ });
+$(function () { /* ... */ });
+```
+
 ## Changelog
 
 This project uses [Semantic Versioning](http://semver.org/) for release numbering.
@@ -110,3 +107,7 @@ Initial idea and code by [@kossnocorp](http://koss.nocorp.me/), with special tha
 [page:load]: https://github.com/rails/turbolinks/#events
 [page:fetch]: https://github.com/rails/turbolinks/#events
 [oldreadme]: https://github.com/kossnocorp/jquery.turbolinks/blob/v1.0.0.rc2/README.md
+
+
+[![Bitdeli Badge](https://d2weczhvl823v0.cloudfront.net/kossnocorp/jquery.turbolinks/trend.png)](https://bitdeli.com/free "Bitdeli Badge")
+

data/lib/jquery-turbolinks/version.rb

@@ -1,3 +1,3 @@
 module JqueryTurbolinks
-  VERSION = '2.0.2'
+  VERSION = '2.1.0'
 end

data/package.json

@@ -1,17 +1,20 @@
 {
   "name": "jquery.turbolinks",
-  "version": "2.0.2",
-  "author": "Sasha Koss <kossnocorp@gmail.com>",
+  "version": "2.1.0",
+  "authors": [
+    "Sasha Koss <kossnocorp@gmail.com>",
+    "Rico Sta. Cruz <hi@ricostacruz.com>"
+  ],
   "description": "jQuery plugin for drop-in fix binded events problem caused by Turbolinks",
 
   "devDependencies": {
     "coffee-script": "~1.7.1",
-    "mocha":         "*",
-    "chai":          "*",
-    "sinon":         "*",
-    "sinon-chai":    "*",
-    "jquery":        "*",
-    "jsdom":         "*"
+    "mocha":         "~1.21.4",
+    "chai":          "~1.9.1",
+    "sinon":         "~1.10.3",
+    "sinon-chai":    "~2.5.0",
+    "jquery":        "~2.1.1",
+    "jsdom":         "~1.0.0-pre.4"
   },
 
   "license": "MIT",

data/spec/jquery.turbolinks_spec.coffee

@@ -1,14 +1,22 @@
-jsdom = require('jsdom').jsdom
-
-global.document = jsdom()
-global.window   = document.createWindow()
-
-require('../src/jquery.turbolinks.coffee')
+before (next) ->
+  require('jsdom').env
+    html: "<!doctype html><html><head><meta charset='utf-8'></head><body></body></html>",
+    done: (errors, window) ->
+      global.window = window
+      global.document = window.document
+      if (errors)
+        errors.forEach(console.error)
+        throw new Error(errors[0].data.error + " (" + errors[0].data.filename + ")")
+      next()
+
+before ->
+  global.$ = require('jquery')
+  global.jQuery = require('jquery')
+  require('../src/jquery.turbolinks.coffee')
 
 chai      = require('chai')
 sinon     = require('sinon')
 sinonChai = require('sinon-chai')
-$         = require('jquery')
 
 chai.should()
 chai.use(sinonChai)
@@ -80,7 +88,7 @@ describe '$ Turbolinks', ->
         $.turbo.use('page:load', 'random_event_name')
         $(document).trigger('page:fetch')
         $.turbo.isReady.should.to.be.true
-        
+
       it 'should bind passed fetch event', ->
         $.turbo.use('page:load', 'page:loading')
         $(document).trigger('page:loading')
@@ -105,6 +113,15 @@ describe '$ Turbolinks', ->
       $(callback2 = sinon.spy())
       callback2.should.have.been.calledOnce
 
+    it 'should call trigger after a subsequent page:fetch and before page:load', ->
+      $(document).trigger('page:fetch')
+      $(document).trigger('page:load')
+      $(callback1 = sinon.spy())
+      callback1.should.have.been.calledOnce
+      $(document).trigger('page:fetch')
+      $(document).trigger('page:load')
+      callback1.should.have.been.calledTwice
+
     it 'should pass $ as the first argument to callbacks', (done) ->
       $ ($$) ->
         $$.fn.should.be.an.object

data/src/jquery.turbolinks.coffee

@@ -10,7 +10,7 @@ $ = window.jQuery or require?('jquery')
 $document = $(document)
 
 $.turbo =
-  version: '2.0.2'
+  version: '2.1.0'
 
   isReady: false
 
@@ -24,8 +24,7 @@ $.turbo =
   addCallback: (callback) ->
     if $.turbo.isReady
       callback($)
-    else
-      $document.on 'turbo:ready', -> callback($)
+    $document.on 'turbo:ready', -> callback($)
 
   onLoad: ->
     $.turbo.isReady = true

data/vendor/assets/javascripts/jquery.turbolinks.js

@@ -16,19 +16,18 @@ Copyright (c) 2012-2013 Sasha Koss & Rico Sta. Cruz
   $document = $(document);
 
   $.turbo = {
-    version: '2.0.2',
+    version: '2.1.0',
     isReady: false,
     use: function(load, fetch) {
       return $document.off('.turbo').on("" + load + ".turbo", this.onLoad).on("" + fetch + ".turbo", this.onFetch);
     },
     addCallback: function(callback) {
       if ($.turbo.isReady) {
-        return callback($);
-      } else {
-        return $document.on('turbo:ready', function() {
-          return callback($);
-        });
+        callback($);
       }
+      return $document.on('turbo:ready', function() {
+        return callback($);
+      });
     },
     onLoad: function() {
       $.turbo.isReady = true;

data/vendor/assets/javascripts/jquery.turbolinks.min.js

@@ -1 +1 @@
-(function(){var r,t;r=window.jQuery||("function"==typeof require?require("jquery"):void 0),t=r(document),r.turbo={version:"2.0.2",isReady:!1,use:function(r,o){return t.off(".turbo").on(""+r+".turbo",this.onLoad).on(""+o+".turbo",this.onFetch)},addCallback:function(o){return r.turbo.isReady?o(r):t.on("turbo:ready",function(){return o(r)})},onLoad:function(){return r.turbo.isReady=!0,t.trigger("turbo:ready")},onFetch:function(){return r.turbo.isReady=!1},register:function(){return r(this.onLoad),r.fn.ready=this.addCallback}},r.turbo.register(),r.turbo.use("page:load","page:fetch")}).call(this);
+(function(){var r,t;r=window.jQuery||("function"==typeof require?require("jquery"):void 0),t=r(document),r.turbo={version:"2.1.0",isReady:!1,use:function(r,o){return t.off(".turbo").on(""+r+".turbo",this.onLoad).on(""+o+".turbo",this.onFetch)},addCallback:function(o){return r.turbo.isReady&&o(r),t.on("turbo:ready",function(){return o(r)})},onLoad:function(){return r.turbo.isReady=!0,t.trigger("turbo:ready")},onFetch:function(){return r.turbo.isReady=!1},register:function(){return r(this.onLoad),r.fn.ready=this.addCallback}},r.turbo.register(),r.turbo.use("page:load","page:fetch")}).call(this);

metadata

@@ -1,41 +1,41 @@
 --- !ruby/object:Gem::Specification
 name: jquery-turbolinks
 version: !ruby/object:Gem::Version
-  version: 2.0.2
+  version: 2.1.0
 platform: ruby
 authors:
 - Sasha Koss
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-12 00:00:00.000000000 Z
+date: 2014-08-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.1.0
 - !ruby/object:Gem::Dependency
   name: turbolinks
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: jQuery plugin for drop-in fix binded events problem caused by Turbolinks
@@ -44,8 +44,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
 - CONTRIBUTING.md
 - Gemfile
 - Guardfile
@@ -72,20 +72,19 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: jquery-turbolinks
-rubygems_version: 2.1.11
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: jQuery plugin for drop-in fix binded events problem caused by Turbolinks
 test_files:
 - spec/jquery.turbolinks_spec.coffee
-has_rdoc: