jp_address 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 3bc473b124d9ac9c7fcd90abbb1ada6b743a25f5
-  data.tar.gz: c8fd47825e82697541a2172d367bdbfac01a8792
+SHA256:
+  metadata.gz: 3a7845f431941b217015f3b2ebb59b4997a76117fe1bbadfd9c4fcc74d7db765
+  data.tar.gz: ce76c24fef5e4340458c5249bae54dab7d47814d159b45456535b888846814f8
 SHA512:
-  metadata.gz: 0de979d76a8c0ff5701b770e81f96ccec3e21b41bcb22f51d4d8f40a586d3b47897b4d0fd3110168b18b1d8c45da49d068850ebd2967469744cae344d9b7d288
-  data.tar.gz: 8a733fff3bb50ab1b73c6e5bdf3b0554d7b331247bc2d989f13ea78a95f4f15a5d2ab7a5a69315b4875fb338a43b99f86a9cf6249a0e253171f2688d07f665f8
+  metadata.gz: e1c235ea4190594e8290f2524ae184cc82bb697b52ed1dc9e9f434891579984aee234817585aa757286690cb2706575f618445ffe0f91302308d29814c69f51b
+  data.tar.gz: 18af90c05ea86dc4a147e4cc5ad89f630043ccb2cae5b359f0255772b1b120bdcc268dc32c02e468a494de119b31c4ca1afcfe4a93cfd75ed3f2bc9d430ba9c4

data/README.rdoc

@@ -1,7 +1,7 @@
 = JpAddress: A Rails plugin for Japan Zipcode API.
 
 == JpAddressとは
-日本郵便の「郵便番号データ」を Rails 4.0 で使用するためのプラグインです。
+日本郵便の「郵便番号データ」を Rails 5.2 で使用するためのプラグインです。
 以下の機能を提供します。
 
 * 郵便局提供の郵便番号データをダウンロードしてＤＢにロードするメソッド。

data/app/controllers/jp_address/zipcodes_controller.rb

@@ -4,7 +4,7 @@ module JpAddress
   class ZipcodesController < ApplicationController
     def search
       @zipcode = Zipcode.find_by(:zip => params[:zip]) || Zipcode.new
-      render text: @zipcode.to_json
+      render plain: @zipcode.to_json
     end
   end
 end

data/lib/jp_address/engine.rb

@@ -4,7 +4,7 @@ module JpAddress
 
     config.generators do |g|
       g.test_framework :rspec, fixture: false
-      g.fixture_replacement :factory_girl, dir: "spec/factories"
+      g.fixture_replacement :factory_bot, dir: "spec/factories"
     end
   end
 end

data/lib/jp_address/version.rb

@@ -1,3 +1,3 @@
 module JpAddress
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/controllers/jp_address/zipcodes_controller_spec.rb

@@ -10,13 +10,13 @@ module JpAddress
         expect(response).to have_http_status(:success)
       end
       it "returns valid data when a vaild zip is passed" do
-        create(:jp_address_zipcode)
-        get :search, zip: '5330033'
+        FactoryBot.create(:jp_address_zipcode)
+        get :search, params: {zip: '5330033'}
         expect(response.body).to match '"zip":"5330033","prefecture":"大阪府","city":"大阪市東淀川区","town":"東中島"'
       end
       it "returns empty data when a invaild zip is passed" do
-        create(:jp_address_zipcode)
-        get :search, zip: '9999999'
+        FactoryBot.create(:jp_address_zipcode)
+        get :search, params: {zip: '9999999'}
         expect(response.body).to match '"id":null,"zip":null,"prefecture":null,"city":null,"town":null'
       end
     end

data/spec/dummy/config/application.rb

@@ -25,8 +25,7 @@ module Dummy
     # config.i18n.load_path += Dir[Rails.root.join('my', 'locales', '*.{rb,yml}').to_s]
     # config.i18n.default_locale = :de
 
-    # Do not swallow errors in after_commit/after_rollback callbacks.
-    config.active_record.raise_in_transactional_callbacks = true
+    config.active_record.sqlite3.represent_boolean_as_integer = true
   end
 end
 

data/spec/dummy/log/test.log

@@ -373,3 +373,167 @@ Completed 200 OK in 1ms (Views: 0.3ms | ActiveRecord: 0.2ms)
               values ('0640820', '北海道', '札幌市中央区', '大通西')
    (0.2ms)  SELECT COUNT(*) FROM "jp_address_zipcodes"
   JpAddress::Zipcode Load (0.2ms)  SELECT  "jp_address_zipcodes".* FROM "jp_address_zipcodes" ORDER BY "jp_address_zipcodes"."id" DESC LIMIT ?  [["LIMIT", 1]]
+   (12.6ms)  delete from jp_address_zipcodes
+   (18.4ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0600000', '北海道', '札幌市中央区', '')
+   (13.0ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0640941', '北海道', '札幌市中央区', '旭ケ丘')
+   (13.7ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0600041', '北海道', '札幌市中央区', '大通東')
+   (12.2ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0600042', '北海道', '札幌市中央区', '大通西')
+   (14.4ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0640820', '北海道', '札幌市中央区', '大通西')
+   (0.1ms)  SELECT COUNT(*) FROM "jp_address_zipcodes"
+  JpAddress::Zipcode Load (0.1ms)  SELECT  "jp_address_zipcodes".* FROM "jp_address_zipcodes" ORDER BY "jp_address_zipcodes"."id" DESC LIMIT ?  [["LIMIT", 1]]
+   (12.3ms)  delete from jp_address_zipcodes
+   (13.1ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0600000', '北海道', '札幌市中央区', '')
+   (17.7ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0640941', '北海道', '札幌市中央区', '旭ケ丘')
+   (12.8ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0600041', '北海道', '札幌市中央区', '大通東')
+   (12.2ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0600042', '北海道', '札幌市中央区', '大通西')
+   (12.5ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0640820', '北海道', '札幌市中央区', '大通西')
+   (0.1ms)  SELECT COUNT(*) FROM "jp_address_zipcodes"
+  JpAddress::Zipcode Load (0.1ms)  SELECT  "jp_address_zipcodes".* FROM "jp_address_zipcodes" ORDER BY "jp_address_zipcodes"."id" DESC LIMIT ?  [["LIMIT", 1]]
+Processing by JpAddress::ZipcodesController#search as HTML
+  JpAddress::Zipcode Load (0.1ms)  SELECT  "jp_address_zipcodes".* FROM "jp_address_zipcodes" WHERE "jp_address_zipcodes"."zip" IS NULL LIMIT ?  [["LIMIT", 1]]
+Completed 500 Internal Server Error in 32ms (ActiveRecord: 1.2ms)
+   (0.1ms)  begin transaction
+  JpAddress::Zipcode Create (1.1ms)  INSERT INTO "jp_address_zipcodes" ("zip", "prefecture", "city", "town") VALUES (?, ?, ?, ?)  [["zip", "5330033"], ["prefecture", "大阪府"], ["city", "大阪市東淀川区"], ["town", "東中島"]]
+   (12.8ms)  commit transaction
+   (0.1ms)  begin transaction
+  JpAddress::Zipcode Create (1.8ms)  INSERT INTO "jp_address_zipcodes" ("zip", "prefecture", "city", "town") VALUES (?, ?, ?, ?)  [["zip", "5330033"], ["prefecture", "大阪府"], ["city", "大阪市東淀川区"], ["town", "東中島"]]
+   (11.6ms)  commit transaction
+   (19.1ms)  delete from jp_address_zipcodes
+   (14.0ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0600000', '北海道', '札幌市中央区', '')
+   (13.4ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0640941', '北海道', '札幌市中央区', '旭ケ丘')
+   (13.6ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0600041', '北海道', '札幌市中央区', '大通東')
+   (14.8ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0600042', '北海道', '札幌市中央区', '大通西')
+   (13.7ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0640820', '北海道', '札幌市中央区', '大通西')
+   (1.1ms)  SELECT COUNT(*) FROM "jp_address_zipcodes"
+  JpAddress::Zipcode Load (0.1ms)  SELECT  "jp_address_zipcodes".* FROM "jp_address_zipcodes" ORDER BY "jp_address_zipcodes"."id" DESC LIMIT ?  [["LIMIT", 1]]
+Processing by JpAddress::ZipcodesController#search as HTML
+  JpAddress::Zipcode Load (0.1ms)  SELECT  "jp_address_zipcodes".* FROM "jp_address_zipcodes" WHERE "jp_address_zipcodes"."zip" IS NULL LIMIT ?  [["LIMIT", 1]]
+  Rendering text template
+  Rendered text template (0.0ms)
+Completed 200 OK in 31ms (Views: 6.8ms | ActiveRecord: 1.6ms)
+   (0.1ms)  begin transaction
+  JpAddress::Zipcode Create (1.3ms)  INSERT INTO "jp_address_zipcodes" ("zip", "prefecture", "city", "town") VALUES (?, ?, ?, ?)  [["zip", "5330033"], ["prefecture", "大阪府"], ["city", "大阪市東淀川区"], ["town", "東中島"]]
+   (17.6ms)  commit transaction
+   (0.1ms)  begin transaction
+  JpAddress::Zipcode Create (1.9ms)  INSERT INTO "jp_address_zipcodes" ("zip", "prefecture", "city", "town") VALUES (?, ?, ?, ?)  [["zip", "5330033"], ["prefecture", "大阪府"], ["city", "大阪市東淀川区"], ["town", "東中島"]]
+   (11.7ms)  commit transaction
+   (13.9ms)  delete from jp_address_zipcodes
+   (12.8ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0600000', '北海道', '札幌市中央区', '')
+   (13.6ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0640941', '北海道', '札幌市中央区', '旭ケ丘')
+   (13.3ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0600041', '北海道', '札幌市中央区', '大通東')
+   (12.8ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0600042', '北海道', '札幌市中央区', '大通西')
+   (13.9ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0640820', '北海道', '札幌市中央区', '大通西')
+   (1.2ms)  SELECT COUNT(*) FROM "jp_address_zipcodes"
+  JpAddress::Zipcode Load (0.2ms)  SELECT  "jp_address_zipcodes".* FROM "jp_address_zipcodes" ORDER BY "jp_address_zipcodes"."id" DESC LIMIT ?  [["LIMIT", 1]]
+Processing by JpAddress::ZipcodesController#search as HTML
+  JpAddress::Zipcode Load (0.1ms)  SELECT  "jp_address_zipcodes".* FROM "jp_address_zipcodes" WHERE "jp_address_zipcodes"."zip" IS NULL LIMIT ?  [["LIMIT", 1]]
+  Rendering text template
+  Rendered text template (0.0ms)
+Completed 200 OK in 33ms (Views: 2.2ms | ActiveRecord: 2.0ms)
+   (0.0ms)  begin transaction
+  JpAddress::Zipcode Create (0.9ms)  INSERT INTO "jp_address_zipcodes" ("zip", "prefecture", "city", "town") VALUES (?, ?, ?, ?)  [["zip", "5330033"], ["prefecture", "大阪府"], ["city", "大阪市東淀川区"], ["town", "東中島"]]
+   (13.4ms)  commit transaction
+   (0.0ms)  begin transaction
+  JpAddress::Zipcode Create (0.9ms)  INSERT INTO "jp_address_zipcodes" ("zip", "prefecture", "city", "town") VALUES (?, ?, ?, ?)  [["zip", "5330033"], ["prefecture", "大阪府"], ["city", "大阪市東淀川区"], ["town", "東中島"]]
+   (11.8ms)  commit transaction
+   (0.1ms)  begin transaction
+  JpAddress::Zipcode Create (1.0ms)  INSERT INTO "jp_address_zipcodes" ("zip", "prefecture", "city", "town") VALUES (?, ?, ?, ?)  [["zip", "5330033"], ["prefecture", "大阪府"], ["city", "大阪市東淀川区"], ["town", "東中島"]]
+   (11.8ms)  commit transaction
+Processing by JpAddress::ZipcodesController#search as HTML
+  Parameters: {"zip"=>"5330033"}
+  JpAddress::Zipcode Load (1.0ms)  SELECT  "jp_address_zipcodes".* FROM "jp_address_zipcodes" WHERE "jp_address_zipcodes"."zip" = ? LIMIT ?  [["zip", "5330033"], ["LIMIT", 1]]
+  Rendering text template
+  Rendered text template (0.0ms)
+Completed 200 OK in 5ms (Views: 1.5ms | ActiveRecord: 1.0ms)
+Processing by JpAddress::ZipcodesController#search as HTML
+  JpAddress::Zipcode Load (0.1ms)  SELECT  "jp_address_zipcodes".* FROM "jp_address_zipcodes" WHERE "jp_address_zipcodes"."zip" IS NULL LIMIT ?  [["LIMIT", 1]]
+  Rendering text template
+  Rendered text template (0.0ms)
+Completed 200 OK in 28ms (Views: 4.9ms | ActiveRecord: 2.4ms)
+   (0.0ms)  begin transaction
+  JpAddress::Zipcode Create (0.9ms)  INSERT INTO "jp_address_zipcodes" ("zip", "prefecture", "city", "town") VALUES (?, ?, ?, ?)  [["zip", "5330033"], ["prefecture", "大阪府"], ["city", "大阪市東淀川区"], ["town", "東中島"]]
+   (11.7ms)  commit transaction
+Processing by JpAddress::ZipcodesController#search as HTML
+  Parameters: {"zip"=>"5330033"}
+  JpAddress::Zipcode Load (0.9ms)  SELECT  "jp_address_zipcodes".* FROM "jp_address_zipcodes" WHERE "jp_address_zipcodes"."zip" = ? LIMIT ?  [["zip", "5330033"], ["LIMIT", 1]]
+  Rendering text template
+  Rendered text template (0.0ms)
+Completed 200 OK in 5ms (Views: 1.4ms | ActiveRecord: 0.9ms)
+   (0.1ms)  begin transaction
+  JpAddress::Zipcode Create (0.8ms)  INSERT INTO "jp_address_zipcodes" ("zip", "prefecture", "city", "town") VALUES (?, ?, ?, ?)  [["zip", "5330033"], ["prefecture", "大阪府"], ["city", "大阪市東淀川区"], ["town", "東中島"]]
+   (12.0ms)  commit transaction
+Processing by JpAddress::ZipcodesController#search as HTML
+  Parameters: {"zip"=>"9999999"}
+  JpAddress::Zipcode Load (0.9ms)  SELECT  "jp_address_zipcodes".* FROM "jp_address_zipcodes" WHERE "jp_address_zipcodes"."zip" = ? LIMIT ?  [["zip", "9999999"], ["LIMIT", 1]]
+  Rendering text template
+  Rendered text template (0.0ms)
+Completed 200 OK in 2ms (Views: 0.5ms | ActiveRecord: 0.9ms)
+   (13.1ms)  delete from jp_address_zipcodes
+   (12.8ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0600000', '北海道', '札幌市中央区', '')
+   (18.9ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0640941', '北海道', '札幌市中央区', '旭ケ丘')
+   (13.9ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0600041', '北海道', '札幌市中央区', '大通東')
+   (13.7ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0600042', '北海道', '札幌市中央区', '大通西')
+   (14.0ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0640820', '北海道', '札幌市中央区', '大通西')
+   (1.1ms)  SELECT COUNT(*) FROM "jp_address_zipcodes"
+  JpAddress::Zipcode Load (0.1ms)  SELECT  "jp_address_zipcodes".* FROM "jp_address_zipcodes" ORDER BY "jp_address_zipcodes"."id" DESC LIMIT ?  [["LIMIT", 1]]
+Processing by JpAddress::ZipcodesController#search as HTML
+  JpAddress::Zipcode Load (0.2ms)  SELECT  "jp_address_zipcodes".* FROM "jp_address_zipcodes" WHERE "jp_address_zipcodes"."zip" IS NULL LIMIT ?  [["LIMIT", 1]]
+  Rendering text template
+  Rendered text template (0.0ms)
+Completed 200 OK in 13ms (Views: 2.7ms | ActiveRecord: 1.1ms)
+   (0.1ms)  begin transaction
+  JpAddress::Zipcode Create (1.0ms)  INSERT INTO "jp_address_zipcodes" ("zip", "prefecture", "city", "town") VALUES (?, ?, ?, ?)  [["zip", "5330033"], ["prefecture", "大阪府"], ["city", "大阪市東淀川区"], ["town", "東中島"]]
+   (11.8ms)  commit transaction
+Processing by JpAddress::ZipcodesController#search as HTML
+  Parameters: {"zip"=>"5330033"}
+  JpAddress::Zipcode Load (1.2ms)  SELECT  "jp_address_zipcodes".* FROM "jp_address_zipcodes" WHERE "jp_address_zipcodes"."zip" = ? LIMIT ?  [["zip", "5330033"], ["LIMIT", 1]]
+  Rendering text template
+  Rendered text template (0.0ms)
+Completed 200 OK in 3ms (Views: 0.2ms | ActiveRecord: 1.2ms)
+   (0.0ms)  begin transaction
+  JpAddress::Zipcode Create (0.9ms)  INSERT INTO "jp_address_zipcodes" ("zip", "prefecture", "city", "town") VALUES (?, ?, ?, ?)  [["zip", "5330033"], ["prefecture", "大阪府"], ["city", "大阪市東淀川区"], ["town", "東中島"]]
+   (11.7ms)  commit transaction
+Processing by JpAddress::ZipcodesController#search as HTML
+  Parameters: {"zip"=>"9999999"}
+  JpAddress::Zipcode Load (1.0ms)  SELECT  "jp_address_zipcodes".* FROM "jp_address_zipcodes" WHERE "jp_address_zipcodes"."zip" = ? LIMIT ?  [["zip", "9999999"], ["LIMIT", 1]]
+  Rendering text template
+  Rendered text template (0.0ms)
+Completed 200 OK in 2ms (Views: 0.2ms | ActiveRecord: 1.0ms)
+   (12.2ms)  delete from jp_address_zipcodes
+   (13.0ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0600000', '北海道', '札幌市中央区', '')
+   (14.3ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0640941', '北海道', '札幌市中央区', '旭ケ丘')
+   (13.3ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0600041', '北海道', '札幌市中央区', '大通東')
+   (12.2ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0600042', '北海道', '札幌市中央区', '大通西')
+   (12.6ms)  insert into jp_address_zipcodes (zip, prefecture, city, town)
+              values ('0640820', '北海道', '札幌市中央区', '大通西')
+   (1.0ms)  SELECT COUNT(*) FROM "jp_address_zipcodes"
+  JpAddress::Zipcode Load (0.1ms)  SELECT  "jp_address_zipcodes".* FROM "jp_address_zipcodes" ORDER BY "jp_address_zipcodes"."id" DESC LIMIT ?  [["LIMIT", 1]]

data/spec/factories/jp_address_zipcodes.rb

@@ -1,10 +1,10 @@
-# Read about factories at https://github.com/thoughtbot/factory_girl
+# Read about factories at https://github.com/thoughtbot/factory_bot
 
-FactoryGirl.define do
-  factory :jp_address_zipcode, :class => 'JpAddress::Zipcode' do
-    zip        "5330033"
-    prefecture "大阪府"
-    city       "大阪市東淀川区"
-    town       "東中島"
+FactoryBot.define do
+  factory :jp_address_zipcode, :class => JpAddress::Zipcode do
+    zip        {"5330033"}
+    prefecture {"大阪府"}
+    city       {"大阪市東淀川区"}
+    town       {"東中島"}
   end
 end

data/spec/rails_helper.rb

@@ -2,11 +2,11 @@ ENV["RAILS_ENV"] ||= 'test'
 require 'spec_helper'
 require File.expand_path("../dummy/config/environment.rb", __FILE__)
 require 'rspec/rails'
-require 'factory_girl_rails'
+require 'factory_bot_rails'
 require 'vcr'
 
 RSpec.configure do |config|
-  config.include FactoryGirl::Syntax::Methods
+  config.include FactoryBot::Syntax::Methods
 end
 VCR.configure do |c|
   c.cassette_library_dir = 'spec/vcr'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: jp_address
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Tadashi K
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-22 00:00:00.000000000 Z
+date: 2019-03-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubyzip
@@ -42,16 +42,16 @@ dependencies:
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.3.6
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.3.6
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
@@ -67,7 +67,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: factory_girl_rails
+  name: factory_bot_rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -235,8 +235,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Simple japan-zipcode-addresses API