journaled 2.0.3 → 2.1.0

data/spec/models/journaled/event_spec.rb

@@ -1,15 +1,15 @@
 require 'rails_helper'
 
 RSpec.describe Journaled::Event do
+  let(:sample_journaled_event_class_name) { 'SomeClassName' }
   let(:sample_journaled_event_class) do
-    SomeClassName = Class.new do
+    Class.new do
       include Journaled::Event
     end
   end
 
-  after do
-    Object.send(:remove_const, :SomeClassName) if defined?(SomeClassName)
-    Object.send(:remove_const, :SomeModule) if defined?(SomeModule)
+  before do
+    stub_const(sample_journaled_event_class_name, sample_journaled_event_class)
   end
 
   let(:sample_journaled_event) { sample_journaled_event_class.new }
@@ -21,10 +21,28 @@ RSpec.describe Journaled::Event do
       allow(Journaled::Writer).to receive(:new).and_return(mock_journaled_writer)
     end
 
-    it 'creates a Journaled::Writer with this event and journals it' do
-      sample_journaled_event.journal!
-      expect(Journaled::Writer).to have_received(:new).with(journaled_event: sample_journaled_event)
-      expect(mock_journaled_writer).to have_received(:journal!)
+    context 'when no app job priority is set' do
+      it 'creates a Journaled::Writer with this event and journals it with the default priority' do
+        sample_journaled_event.journal!
+        expect(Journaled::Writer).to have_received(:new)
+          .with(journaled_event: sample_journaled_event, priority: Journaled::JobPriority::EVENTUAL)
+        expect(mock_journaled_writer).to have_received(:journal!)
+      end
+    end
+
+    context 'when there is an app job priority is set' do
+      around do |example|
+        orig_priority = Journaled.job_priority
+        Journaled.job_priority = 13
+        example.run
+        Journaled.job_priority = orig_priority
+      end
+
+      it 'creates a Journaled::Writer with this event and journals it with the given priority' do
+        sample_journaled_event.journal!
+        expect(Journaled::Writer).to have_received(:new).with(journaled_event: sample_journaled_event, priority: 13)
+        expect(mock_journaled_writer).to have_received(:journal!)
+      end
     end
   end
 
@@ -34,12 +52,7 @@ RSpec.describe Journaled::Event do
     end
 
     context 'when the class is modularized' do
-      let(:sample_journaled_event_class) do
-        SomeModule = Module.new
-        SomeModule::SomeClassName = Class.new do
-          include Journaled::Event
-        end
-      end
+      let(:sample_journaled_event_class_name) { 'SomeModule::SomeClassName' }
 
       it 'returns the underscored version on the class name' do
         expect(sample_journaled_event.journaled_schema_name).to eq 'some_module/some_class_name'
@@ -53,12 +66,7 @@ RSpec.describe Journaled::Event do
     end
 
     context 'when the class is modularized' do
-      let(:sample_journaled_event_class) do
-        SomeModule = Module.new
-        SomeModule::SomeClassName = Class.new do
-          include Journaled::Event
-        end
-      end
+      let(:sample_journaled_event_class_name) { 'SomeModule::SomeClassName' }
 
       it 'returns the underscored version on the class name, with slashes replaced with underscores' do
         expect(sample_journaled_event.event_type).to eq 'some_module_some_class_name'
@@ -102,7 +110,7 @@ RSpec.describe Journaled::Event do
 
     context 'when there are additional attributes specified, but not defined' do
       let(:sample_journaled_event_class) do
-        SomeClassName = Class.new do
+        Class.new do
           include Journaled::Event
 
           journal_attributes :foo
@@ -116,7 +124,7 @@ RSpec.describe Journaled::Event do
 
     context 'when there are additional attributes specified and defined' do
       let(:sample_journaled_event_class) do
-        SomeClassName = Class.new do
+        Class.new do
           include Journaled::Event
 
           journal_attributes :foo, :bar

data/spec/models/journaled/writer_spec.rb

@@ -1,7 +1,7 @@
 require 'rails_helper'
 
 RSpec.describe Journaled::Writer do
-  subject { described_class.new journaled_event: journaled_event }
+  subject { described_class.new journaled_event: journaled_event, priority: Journaled::JobPriority::EVENTUAL }
 
   describe '#initialize' do
     context 'when the Journaled Event does not implement all the necessary methods' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: journaled
 version: !ruby/object:Gem::Version
-  version: 2.0.3
+  version: 2.1.0
 platform: ruby
 authors:
 - Jake Lipson
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-10 00:00:00.000000000 Z
+date: 2019-09-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk-resources
@@ -167,6 +167,34 @@ dependencies:
     - - '='
       - !ruby/object:Gem::Version
         version: 1.3.0
+- !ruby/object:Gem::Dependency
+  name: spring
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: spring-commands-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: timecop
   requirement: !ruby/object:Gem::Requirement
@@ -217,16 +245,17 @@ files:
 - app/models/journaled/change_writer.rb
 - app/models/journaled/delivery.rb
 - app/models/journaled/event.rb
-- app/models/journaled/job_priority.rb
 - app/models/journaled/json_schema_model/validator.rb
 - app/models/journaled/not_truly_exceptional_error.rb
 - app/models/journaled/writer.rb
 - config/initializers/change_protection.rb
 - config/routes.rb
+- config/spring.rb
 - journaled_schemas/base_event.json
 - journaled_schemas/journaled/change.json
 - lib/journaled.rb
 - lib/journaled/engine.rb
+- lib/journaled/job_priority.rb
 - lib/journaled/relation_change_protection.rb
 - lib/journaled/rspec.rb
 - lib/journaled/version.rb
@@ -295,7 +324,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubyforge_project: 
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Journaling for Betterment apps.