journaled 2.0.2 → 2.0.3

data/spec/models/database_change_protection_spec.rb

@@ -1,106 +1,108 @@
 require 'rails_helper'
 
-# rubocop:disable Rails/SkipsModelValidations
-RSpec.describe "Raw database change protection" do
-  let(:journaled_class) do
-    Class.new(Delayed::Job) do
-      include Journaled::Changes
+if Rails::VERSION::MAJOR > 5 || (Rails::VERSION::MAJOR == 5 && Rails::VERSION::MINOR >= 2)
+  # rubocop:disable Rails/SkipsModelValidations
+  RSpec.describe "Raw database change protection" do
+    let(:journaled_class) do
+      Class.new(Delayed::Job) do
+        include Journaled::Changes
 
-      journal_changes_to :locked_at, as: :attempt
+        journal_changes_to :locked_at, as: :attempt
+      end
     end
-  end
 
-  let(:journaled_class_with_no_journaled_columns) do
-    Class.new(Delayed::Job) do
-      include Journaled::Changes
+    let(:journaled_class_with_no_journaled_columns) do
+      Class.new(Delayed::Job) do
+        include Journaled::Changes
+      end
     end
-  end
 
-  describe "the relation" do
-    describe "#update_all" do
-      it "refuses on journaled columns" do
-        expect { journaled_class.update_all(locked_at: nil) }.to raise_error(/aborted by Journaled/)
-      end
+    describe "the relation" do
+      describe "#update_all" do
+        it "refuses on journaled columns" do
+          expect { journaled_class.update_all(locked_at: nil) }.to raise_error(/aborted by Journaled/)
+        end
 
-      it "succeeds on unjournaled columns" do
-        expect { journaled_class.update_all(handler: "") }.not_to raise_error
-      end
+        it "succeeds on unjournaled columns" do
+          expect { journaled_class.update_all(handler: "") }.not_to raise_error
+        end
 
-      it "succeeds when forced on journaled columns" do
-        expect { journaled_class.update_all({ locked_at: nil }, force: true) }.not_to raise_error
+        it "succeeds when forced on journaled columns" do
+          expect { journaled_class.update_all({ locked_at: nil }, force: true) }.not_to raise_error
+        end
       end
-    end
 
-    describe "#delete" do
-      it "refuses if journaled columns exist" do
-        expect { journaled_class.delete(1) }.to raise_error(/aborted by Journaled/)
-      end
+      describe "#delete" do
+        it "refuses if journaled columns exist" do
+          expect { journaled_class.delete(1) }.to raise_error(/aborted by Journaled/)
+        end
 
-      it "succeeds if no journaled columns exist" do
-        expect { journaled_class_with_no_journaled_columns.delete(1) }.not_to raise_error
-      end
+        it "succeeds if no journaled columns exist" do
+          expect { journaled_class_with_no_journaled_columns.delete(1) }.not_to raise_error
+        end
 
-      it "succeeds if journaled columns exist when forced" do
-        expect { journaled_class.delete(1, force: true) }.not_to raise_error
+        it "succeeds if journaled columns exist when forced" do
+          expect { journaled_class.delete(1, force: true) }.not_to raise_error
+        end
       end
-    end
 
-    describe "#delete_all" do
-      it "refuses if journaled columns exist" do
-        expect { journaled_class.delete_all }.to raise_error(/aborted by Journaled/)
-      end
+      describe "#delete_all" do
+        it "refuses if journaled columns exist" do
+          expect { journaled_class.delete_all }.to raise_error(/aborted by Journaled/)
+        end
 
-      it "succeeds if no journaled columns exist" do
-        expect { journaled_class_with_no_journaled_columns.delete_all }.not_to raise_error
-      end
+        it "succeeds if no journaled columns exist" do
+          expect { journaled_class_with_no_journaled_columns.delete_all }.not_to raise_error
+        end
 
-      it "succeeds if journaled columns exist when forced" do
-        expect { journaled_class.delete_all(force: true) }.not_to raise_error
+        it "succeeds if journaled columns exist when forced" do
+          expect { journaled_class.delete_all(force: true) }.not_to raise_error
+        end
       end
     end
-  end
 
-  describe "an instance" do
-    let(:job) do
-      module TestJob
-        def perform
-          "foo"
-        end
+    describe "an instance" do
+      let(:job) do
+        module TestJob
+          def perform
+            "foo"
+          end
 
-        module_function :perform
+          module_function :perform
+        end
       end
-    end
 
-    subject { journaled_class.enqueue(job) }
+      subject { journaled_class.enqueue(job) }
 
-    describe "#update_columns" do
-      it "refuses on journaled columns" do
-        expect { subject.update_columns(locked_at: nil) }.to raise_error(/aborted by Journaled/)
-      end
+      describe "#update_columns" do
+        it "refuses on journaled columns" do
+          expect { subject.update_columns(locked_at: nil) }.to raise_error(/aborted by Journaled/)
+        end
 
-      it "succeeds on unjournaled columns" do
-        expect { subject.update_columns(handler: "") }.not_to raise_error
-      end
+        it "succeeds on unjournaled columns" do
+          expect { subject.update_columns(handler: "") }.not_to raise_error
+        end
 
-      it "succeeds when forced on journaled columns" do
-        expect { subject.update_columns({ locked_at: nil }, force: true) }.not_to raise_error
+        it "succeeds when forced on journaled columns" do
+          expect { subject.update_columns({ locked_at: nil }, force: true) }.not_to raise_error
+        end
       end
-    end
 
-    describe "#delete" do
-      it "refuses if journaled columns exist" do
-        expect { subject.delete }.to raise_error(/aborted by Journaled/)
-      end
+      describe "#delete" do
+        it "refuses if journaled columns exist" do
+          expect { subject.delete }.to raise_error(/aborted by Journaled/)
+        end
 
-      it "succeeds if no journaled columns exist" do
-        instance = journaled_class_with_no_journaled_columns.enqueue(job)
-        expect { instance.delete }.not_to raise_error
-      end
+        it "succeeds if no journaled columns exist" do
+          instance = journaled_class_with_no_journaled_columns.enqueue(job)
+          expect { instance.delete }.not_to raise_error
+        end
 
-      it "succeeds if journaled columns exist when forced" do
-        expect { subject.delete(force: true) }.not_to raise_error
+        it "succeeds if journaled columns exist when forced" do
+          expect { subject.delete(force: true) }.not_to raise_error
+        end
       end
     end
   end
+  # rubocop:enable Rails/SkipsModelValidations
 end
-# rubocop:enable Rails/SkipsModelValidations

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: journaled
 version: !ruby/object:Gem::Version
-  version: 2.0.2
+  version: 2.0.3
 platform: ruby
 authors:
 - Jake Lipson
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-10 00:00:00.000000000 Z
+date: 2019-07-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk-resources
@@ -295,7 +295,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.1
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Journaling for Betterment apps.