josevalim-rails-footnotes 3.4.1 → 3.5.0

data/CHANGELOG

@@ -0,0 +1,54 @@
+== Footnotes v3.5
+  * Added NewRelic RPM footnote (cortesy of kbrock)
+  * Several bug fixes (cortesy of kbrock, ivanoats and kristopher)
+
+== Footnotes v3.4
+  * Rails 2.3 compatible.
+
+== Footnotes v3.3.1
+  * Changed prefix to support %s and %d;
+  * Created gemspec;
+  * Some code refactoring (called eval just once instead of three times).
+
+== Footnotes v3.3
+  * Rails Edge (aka 2.2) compatibility;
+  * Initial Ruby 1.9 compatibility.
+
+== Footnotes v3.2.2
+  * Added trace to QueriesNote;
+  * Fixed incompatibility with Ultrasphinx (thanks to mhartl);
+  * Added W3C compatibility (thanks to tapajos);
+  * Added support to other log mechanisms in LogNote.
+
+== Footnotes v3.2.1
+  * Added some tests;
+  * Redefined Footnotes CSS and Javascripts to use concise names.
+  
+== Footnotes v3.2
+  * Now you can easily add your own notes;
+  * Added numbers to tabs;
+  * Added Queries note;
+  * Added MySQL Query Analyzer.
+
+== Footnotes v3.1
+  * Code refactoring (using modules, except backtracer);
+  * Ability to cherry pick notes;
+  * Working on Rails 2.1.
+
+== Footnotes v3.0
+  * Some code refactoring;
+  * Stylesheets bug fixed: was showing not only css in Stylesheets div;
+  * Logtail fix: working with Rails 2.0 logger and in all OS, since it's Regexp based;
+  * Rails 1.2 (except backtrace) and 2.0 compatible;
+  * RoutingNavigator (based on Rick Olson plugin);
+  * FilterChain.
+
+== Textmate Footnotes v2.0
+Copyright (c) 2006 InquiryLabs, Inc.
+http://inquirylabs.com/
+
+Description:
+  Creates clickable footnotes on each rendered page, as well as clickable
+  links in the backtrace should an error occur in your Rails app. Links take
+  you to the right place inside TextMate.
+  Enable only the TextMate on Macs in development mode

data/README

@@ -1,10 +1,10 @@
 Rails Footnotes
 License: MIT
-Version: 3.4.1
+Version: 3.5
 
 You can also read this README in pretty html at the GitHub project Wiki page
 
-  http://github.com/josevalim/rails-footnotes/wikis/home
+  http://wiki.github.com/josevalim/rails-footnotes
 
 
 Description
@@ -46,6 +46,7 @@ If you are running on Rails 2.2 or Rails 2.1 you should do:
 Where you should replace VERSION_NUMBER for "v3.3.2" for Rails 2.2 and "v3.2.2"
 for Rails 2.1 (without the quotes).
 
+
 Configuration
 -------------
 
@@ -53,7 +54,7 @@ If you are not using Textmate as text editor, in your environment.rb or
 in an initializer do:
 
   if defined?(Footnotes)
-    Footnotes::Filter.prefix = 'txmt://open?url=file://%s&line=%d&column=%d'
+    Footnotes::Filter.prefix = 'txmt://open?url=file://%s&line=%d&column=%d'
   end
 
 Where you are going to choose a prefix compatible with your text editor. The %s is
@@ -127,21 +128,28 @@ Then put in your environment:
   Footnotes::Filter.notes += [:current_user]
 
 
+Colaborators
+------------
+
+* http://github.com/kbrock
+* http://github.com/ivanoats
+* http://github.com/kristopher
+
+
 Bugs and Feedback
 -----------------
 
 If you discover any bugs, please send an e-mail to jose.valim@gmail.com
-If you just want to give some positive feedback or drop a line, that's fine too! =)
+If you just want to give some positive feedback or drop a line, that's fine too!
 
-Copyright (c) 2009 José Valim
-http://www.pagestacker.com/
+Copyright (c) 2009 José Valim (jose.valim@gmail.com)
 http://josevalim.blogspot.com/
 
 
 Version 2.0
 -----------
 
-Until version 2.0, this plugin was created and maintained by:
+Until version 2.0, this plugin was created and maintained by Duane Johnson:
 
-Duane Johnson (duane.johnson@gmail.com)
+Copyright (c) 2006 InquiryLabs, Inc.
 http://blog.inquirylabs.com/

data/lib/rails-footnotes/footnotes.rb

@@ -5,12 +5,17 @@ module Footnotes
     @@klasses = []
 
     # Default link prefix is textmate
-    @@prefix = 'txmt://open?url=file://%s&line=%d&column=%d'
+    @@prefix = 'txmt://open?url=file://%s&line=%d&column=%d'
 
     # Edit notes
     @@notes = [ :controller, :view, :layout, :stylesheets, :javascripts ]
     # Show notes
-    @@notes += [ :session, :cookies, :params, :filters, :routes, :env, :queries, :log, :general ]
+    @@notes += [ :session, :cookies, :params, :filters, :routes, :env, :log, :general ]
+    if defined?(NewRelic)
+      @@notes << :rpm
+    else
+      @@notes << :queries
+    end
 
     # :no_style       => If you don't want the style to be appended to your pages
     # :notes          => Class variable that holds the notes to be processed

data/lib/rails-footnotes/notes/controller_note.rb

@@ -23,7 +23,9 @@ module Footnotes
         # Some controller classes come with the Controller:: module and some don't
         # (anyone know why? -- Duane)
         def controller_filename
-          File.join(File.expand_path(RAILS_ROOT), 'app', 'controllers', "#{@controller.class.to_s.underscore}.rb").sub('/controllers/controllers/', '/controllers/')
+          controller_name=@controller.class.to_s.underscore
+          controller_name='application' if controller_name=='application_controller'
+          File.join(File.expand_path(RAILS_ROOT), 'app', 'controllers', "#{controller_name}.rb").sub('/controllers/controllers/', '/controllers/')
         end
 
         def controller_text

data/lib/rails-footnotes/notes/rpm_note.rb

@@ -0,0 +1,24 @@
+require "#{File.dirname(__FILE__)}/abstract_note"
+
+module Footnotes
+  module Notes
+    class RpmNote < AbstractNote
+      def initialize(controller)
+        @rpm_id=NewRelic::Agent.instance.transaction_sampler.current_sample_id
+      end
+
+      def row
+        :edit
+      end
+
+      def link
+         #{:controller => 'newrelic', :action => 'show_sample_detail', :id => @rpm_id}
+         "/newrelic/show_sample_detail/#{@rpm_id}"
+      end
+      
+      def valid?
+        !NewRelic::Config.instance['skip_developer_route']
+      end
+    end
+  end
+end

data/lib/rails-footnotes/notes/session_note.rb

@@ -4,7 +4,7 @@ module Footnotes
   module Notes
     class SessionNote < AbstractNote
       def initialize(controller)
-        @session = (controller.session.instance_variable_get("@data") || {}).symbolize_keys
+        @session = (controller.session || {}).symbolize_keys
       end
 
       def content
@@ -12,4 +12,4 @@ module Footnotes
       end
     end
   end
-end
+end

data/lib/rails-footnotes/notes/view_note.rb

@@ -17,13 +17,19 @@ module Footnotes
       end
 
       def valid?
-        prefix? && @template && @template.template
+        prefix? && first_render?
       end
 
       protected
+
+        def first_render?
+          @template.instance_variable_get(:@_first_render)
+        end
+
         def filename
-          @template.template.filename
+          @filename ||= @template.instance_variable_get(:@_first_render).filename
         end
+
     end
   end
 end

data/test/footnotes_test.rb

@@ -70,11 +70,11 @@ class FootnotesTest < Test::Unit::TestCase
   end
 
   def test_footnotes_prefix
-    assert_equal 'txmt://open?url=file://%s&line=%d&column=%d', Footnotes::Filter.prefix
-    assert_equal 'txmt://open?url=file://file&line=0&column=0', Footnotes::Filter.prefix('file', 0, 0)
-    assert_equal 'txmt://open?url=file://file&line=10&column=10', Footnotes::Filter.prefix('file', 10, 10)
-    assert_equal 'txmt://open?url=file://file&line=10&column=10', Footnotes::Filter.prefix('file', 10, 10, 10)
-    assert_equal 'txmt://open?url=file://file&line=10&column=10', Footnotes::Filter.prefix('file', '10', '10')
+    assert_equal 'txmt://open?url=file://%s&amp;line=%d&amp;column=%d', Footnotes::Filter.prefix
+    assert_equal 'txmt://open?url=file://file&amp;line=0&amp;column=0', Footnotes::Filter.prefix('file', 0, 0)
+    assert_equal 'txmt://open?url=file://file&amp;line=10&amp;column=10', Footnotes::Filter.prefix('file', 10, 10)
+    assert_equal 'txmt://open?url=file://file&amp;line=10&amp;column=10', Footnotes::Filter.prefix('file', 10, 10, 10)
+    assert_equal 'txmt://open?url=file://file&amp;line=10&amp;column=10', Footnotes::Filter.prefix('file', '10', '10')
   end
 
   def test_notes_are_initialized

data/test/notes/abstract_note_test.rb

@@ -63,7 +63,7 @@ class AbstractNoteTest < Test::Unit::TestCase
   def test_footnotes_prefix
     Footnotes::Filter.prefix = ''
     assert !@note.send(:prefix?)
-    Footnotes::Filter.prefix = 'txmt://open?url=file://%s&line=%d&column=%d'
+    Footnotes::Filter.prefix = 'txmt://open?url=file://%s&amp;line=%d&amp;column=%d'
     assert @note.send(:prefix?)
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: josevalim-rails-footnotes
 version: !ruby/object:Gem::Version 
-  version: 3.4.1
+  version: 3.5.0
 platform: ruby
 authors: 
 - "Jos\xC3\xA9 Valim"
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-02-22 00:00:00 -08:00
+date: 2009-05-01 00:00:00 -07:00
 default_executable: 
 dependencies: []
 
@@ -22,6 +22,7 @@ extensions: []
 extra_rdoc_files: 
 - README
 files: 
+- CHANGELOG
 - MIT-LICENSE
 - README
 - Rakefile
@@ -42,12 +43,10 @@ files:
 - lib/rails-footnotes/notes/params_note.rb
 - lib/rails-footnotes/notes/queries_note.rb
 - lib/rails-footnotes/notes/routes_note.rb
+- lib/rails-footnotes/notes/rpm_note.rb
 - lib/rails-footnotes/notes/session_note.rb
 - lib/rails-footnotes/notes/stylesheets_note.rb
 - lib/rails-footnotes/notes/view_note.rb
-- test/footnotes_test.rb
-- test/test_helper.rb
-- test/notes/abstract_note_test.rb
 has_rdoc: true
 homepage: http://github.com/josevalim/rails-footnotes
 post_install_message: