josephwilk-rsemantic 0.1.1 → 0.1.2

data/History.txt

@@ -1,3 +1,8 @@
+== 0.1.2
+
+= Bugs
+* Fixed problem where LSA was raising errors when trying to reduce dimensions of non-square matrixes. (Joseph Wilk)
+
 == 0.1.1 
 
 = Bugs

data/lib/semantic/transform/lsa_transform.rb

@@ -7,17 +7,14 @@ module Semantic
         def transform(matrix, number_of_dimensions_to_reduce = 1)
           columns = matrix.num_columns
 
-          if dimensions <= columns: #Its a valid reduction
-
+          if number_of_dimensions_to_reduce <= columns: #Its a valid reduction
             u, sigma, vt = matrix.singular_value_decomposition
 
             sigma_prime = reduce_dimensions(number_of_dimensions_to_reduce, sigma)
 
-            #Reconstruct MATRIX' and Save transform
             matrix_prime = u * sigma_prime * vt
-
           else
-            raise Exception, "dimension reduction cannot be greater than %s" % rows
+            raise Exception, "dimension reduction cannot be greater than %s" % columns
           end
           
           matrix_prime
@@ -25,13 +22,20 @@ module Semantic
         
         private
         def reduce_dimensions(number_of_dimensions_to_reduce, matrix)
-          columns = matrix.num_columns
-          for index in ((columns-number_of_dimensions_to_reduce)...columns)
-            matrix[index,index] = 0
+          for diagonal_index in dimensions_to_be_reduced(matrix, number_of_dimensions_to_reduce)
+            matrix[diagonal_index, diagonal_index] = 0
           end
           matrix
         end
         
+        def dimensions_to_be_reduced(matrix, number_of_dimensions_to_reduce)
+          (diagonal_matrix_length(matrix) - number_of_dimensions_to_reduce)...diagonal_matrix_length(matrix)
+        end
+        
+        def diagonal_matrix_length(matrix)
+          matrix.num_columns < matrix.num_rows ? matrix.num_columns : matrix.num_rows
+        end
+        
       end
     end
   end

data/lib/semantic/version.rb

@@ -2,7 +2,7 @@ module Semantic #:nodoc:
   class VERSION #:nodoc:
     MAJOR = 0
     MINOR = 1
-    TINY  = 1
+    TINY  = 2
 
     STRING = [MAJOR, MINOR, TINY].join('.')
   end

data/rsemantic.gemspec

@@ -1,14 +1,14 @@
 Gem::Specification.new do |s|
   s.name = %q{rsemantic}
-  s.version = "0.1.1"
+  s.version = "0.1.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Joseph Wilk"]
-  s.date = %q{2008-11-14}
+  s.date = %q{2008-11-19}
   s.description = %q{A document vector search with flexible matrix transforms. Currently supports Latent semantic analysis and Term frequency - inverse document frequency}
   s.email = ["josephwilk@joesniff.co.uk"]
   s.extra_rdoc_files = ["History.txt", "Manifest.txt", "README.txt", "TODO.txt"]
-  s.files = ["History.txt", "Manifest.txt", "README.txt", "Rakefile", "TODO.txt", "config/hoe.rb", "config/requirements.rb", "gem_tasks/deployment.rake", "gem_tasks/environment.rake", "gem_tasks/examples.rake", "gem_tasks/fix_cr_lf.rake", "gem_tasks/gemspec.rake", "gem_tasks/rspec.rake", "gem_tasks/website.rake", "lib/semantic.rb", "lib/semantic/compare.rb", "lib/semantic/matrix_transformer.rb", "lib/semantic/parser.rb", "lib/semantic/search.rb", "lib/semantic/transform.rb", "lib/semantic/transform/lsa_transform.rb", "lib/semantic/transform/tf_idf_transform.rb", "lib/semantic/vector_space.rb", "lib/semantic/vector_space/builder.rb", "lib/semantic/vector_space/model.rb", "lib/semantic/version.rb", "resources/english.stop", "rsemantic.gemspec", "spec/semantic/compare_spec.rb", "spec/semantic/matrix_transformer_spec.rb", "spec/semantic/parser_spec.rb", "spec/semantic/search_spec.rb", "spec/semantic/transform/lsa_transform_spec.rb", "spec/semantic/transform/tf_idf_transform_spec.rb", "spec/semantic/vector_space/builder_spec.rb", "spec/semantic/vector_space/model_spec.rb", "spec/spec.opts", "spec/spec_helper.rb"]
+  s.files = ["History.txt", "Manifest.txt", "README.txt", "Rakefile", "TODO.txt", "config/hoe.rb", "config/requirements.rb", "coverage/index.html", "coverage/lib-semantic-compare_rb.html", "coverage/lib-semantic-matrix_transformer_rb.html", "coverage/lib-semantic-parser_rb.html", "coverage/lib-semantic-search_rb.html", "coverage/lib-semantic-transform-lsa_transform_rb.html", "coverage/lib-semantic-transform-tf_idf_transform_rb.html", "coverage/lib-semantic-transform_rb.html", "coverage/lib-semantic-vector_space-builder_rb.html", "coverage/lib-semantic-vector_space-model_rb.html", "coverage/lib-semantic-vector_space_rb.html", "coverage/lib-semantic-version_rb.html", "coverage/lib-semantic_rb.html", "gem_tasks/deployment.rake", "gem_tasks/environment.rake", "gem_tasks/examples.rake", "gem_tasks/fix_cr_lf.rake", "gem_tasks/gemspec.rake", "gem_tasks/rspec.rake", "gem_tasks/website.rake", "lib/semantic.rb", "lib/semantic/compare.rb", "lib/semantic/matrix_transformer.rb", "lib/semantic/parser.rb", "lib/semantic/search.rb", "lib/semantic/transform.rb", "lib/semantic/transform/lsa_transform.rb", "lib/semantic/transform/tf_idf_transform.rb", "lib/semantic/vector_space.rb", "lib/semantic/vector_space/builder.rb", "lib/semantic/vector_space/model.rb", "lib/semantic/version.rb", "resources/english.stop", "rsemantic.gemspec", "spec/semantic/compare_spec.rb", "spec/semantic/matrix_transformer_spec.rb", "spec/semantic/parser_spec.rb", "spec/semantic/search_spec.rb", "spec/semantic/transform/lsa_transform_spec.rb", "spec/semantic/transform/tf_idf_transform_spec.rb", "spec/semantic/vector_space/builder_spec.rb", "spec/semantic/vector_space/model_spec.rb", "spec/spec.opts", "spec/spec_helper.rb"]
   s.has_rdoc = true
   s.homepage = %q{http://github.com/josephwilk/rsemantic}
   s.rdoc_options = ["--main", "README.txt"]

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: josephwilk-rsemantic
 version: !ruby/object:Gem::Version 
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors: 
 - Joseph Wilk
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-11-14 00:00:00 -08:00
+date: 2008-11-19 00:00:00 -08:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -68,6 +68,19 @@ files:
 - TODO.txt
 - config/hoe.rb
 - config/requirements.rb
+- coverage/index.html
+- coverage/lib-semantic-compare_rb.html
+- coverage/lib-semantic-matrix_transformer_rb.html
+- coverage/lib-semantic-parser_rb.html
+- coverage/lib-semantic-search_rb.html
+- coverage/lib-semantic-transform-lsa_transform_rb.html
+- coverage/lib-semantic-transform-tf_idf_transform_rb.html
+- coverage/lib-semantic-transform_rb.html
+- coverage/lib-semantic-vector_space-builder_rb.html
+- coverage/lib-semantic-vector_space-model_rb.html
+- coverage/lib-semantic-vector_space_rb.html
+- coverage/lib-semantic-version_rb.html
+- coverage/lib-semantic_rb.html
 - gem_tasks/deployment.rake
 - gem_tasks/environment.rake
 - gem_tasks/examples.rake