jortt 4.2.0 → 5.0.0

data/spec/jortt_spec.rb

@@ -1,9 +1,8 @@
-# encoding: UTF-8
 require 'spec_helper'
 
-describe Jortt do
+describe Jortt, :vcr do
   describe '.client' do
-    subject { described_class.client(app_name: 'name', api_key: 'secret') }
+    subject { described_class.client(ENV['JORTT_CLIENT_ID'], ENV['JORTT_CLIENT_SECRET']) }
     it { should be_instance_of(described_class::Client) }
   end
 end

data/spec/spec_helper.rb

@@ -1,4 +1,9 @@
 require 'simplecov'
+require 'rspec'
+require 'rspec/its'
+require 'webmock/rspec'
+require 'vcr'
+require 'jortt'
 
 SimpleCov.start
 if ENV['CI'] == 'true'
@@ -6,8 +11,17 @@ if ENV['CI'] == 'true'
   SimpleCov.formatter = SimpleCov::Formatter::Codecov
 end
 
-require 'rspec'
-require 'rspec/its'
-require 'webmock/rspec'
+VCR.configure do |c|
+  c.cassette_library_dir = "spec/fixtures/vcr_cassettes"
+  c.hook_into :webmock
+  c.configure_rspec_metadata!
+  c.default_cassette_options = { record: :once }
 
-require 'jortt'
+  c.before_record do |i|
+    i.response.headers.delete('Set-Cookie')
+    i.request.headers.delete('Authorization')
+  end
+end
+
+ENV['JORTT_CLIENT_ID'] ||= 'client-id'
+ENV['JORTT_CLIENT_SECRET'] ||= 'client-secret'

metadata

@@ -1,17 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: jortt
 version: !ruby/object:Gem::Version
-  version: 4.2.0
+  version: 5.0.0
 platform: ruby
 authors:
 - Bob Forma
 - Michael Franken
 - Lars Vonk
 - Stephan van Diepen
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-06-26 00:00:00.000000000 Z
+date: 2020-09-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -28,118 +28,118 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: oauth2
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :development
+        version: 1.4.4
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 1.4.4
 - !ruby/object:Gem::Dependency
-  name: codecov
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.1'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.1'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: codecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0.1'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.4'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.4'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
-  name: rspec-its
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '3.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '3.7'
 - !ruby/object:Gem::Dependency
-  name: webmock
+  name: rspec-its
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.17'
+        version: '1.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.17'
+        version: '1.2'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.24.1
+        version: '3.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.24.1
+        version: '3.3'
 - !ruby/object:Gem::Dependency
-  name: rubocop-rspec
+  name: vcr
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '6.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
-description: 
+        version: '6.0'
+description:
 email:
 - bforma@zilverline.com
 - mfranken@zilverline.com
@@ -150,7 +150,6 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
-- ".rubocop.yml"
 - ".ruby-version"
 - ".travis.yml"
 - Gemfile
@@ -161,12 +160,31 @@ files:
 - lib/jortt.rb
 - lib/jortt/client.rb
 - lib/jortt/client/customers.rb
-- lib/jortt/client/invoice.rb
+- lib/jortt/client/error.rb
 - lib/jortt/client/invoices.rb
+- lib/jortt/client/ledger_accounts.rb
 - lib/jortt/client/version.rb
+- spec/fixtures/vcr_cassettes/Jortt/_client/1_1_1.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client/configured/_customers/1_1_1_1.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client/configured/_invoices/1_1_2_1.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client/configured/_ledger_accounts/1_1_3_1.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client_Customers/_create/faulty_payload/shows_a_nice_error.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client_Customers/_create/valid_payload/creates_the_customer.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client_Customers/_delete/deletes_the_customer.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client_Customers/_direct_debit_mandate/sends_direct_debit_mandate_to_the_customer_or_responds_with_an_error_when_not_possible.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client_Customers/_index/query/returns_the_queried_customers.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client_Customers/_index/without_params/returns_customers.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client_Customers/_show/returns_the_customer.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client_Customers/_update/updates_the_customer.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client_Invoices/_create/creates_the_invoice.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client_Invoices/_download/returns_the_invoice_download_link.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client_Invoices/_index/invoice_status/returns_those_invoices.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client_Invoices/_index/query/returns_the_queried_invoices.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client_Invoices/_show/returns_the_invoice.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client_LedgerAccounts/_index/returns_invoices.yml
 - spec/jortt/client/customers_spec.rb
-- spec/jortt/client/invoice_spec.rb
 - spec/jortt/client/invoices_spec.rb
+- spec/jortt/client/ledger_accounts_spec.rb
 - spec/jortt/client_spec.rb
 - spec/jortt_spec.rb
 - spec/spec_helper.rb
@@ -174,7 +192,7 @@ homepage: https://app.jortt.nl/api-documentatie
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -189,15 +207,32 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.1
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: jortt.nl REST API client
 test_files:
+- spec/fixtures/vcr_cassettes/Jortt/_client/1_1_1.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client/configured/_customers/1_1_1_1.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client/configured/_invoices/1_1_2_1.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client/configured/_ledger_accounts/1_1_3_1.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client_Customers/_create/faulty_payload/shows_a_nice_error.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client_Customers/_create/valid_payload/creates_the_customer.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client_Customers/_delete/deletes_the_customer.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client_Customers/_direct_debit_mandate/sends_direct_debit_mandate_to_the_customer_or_responds_with_an_error_when_not_possible.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client_Customers/_index/query/returns_the_queried_customers.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client_Customers/_index/without_params/returns_customers.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client_Customers/_show/returns_the_customer.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client_Customers/_update/updates_the_customer.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client_Invoices/_create/creates_the_invoice.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client_Invoices/_download/returns_the_invoice_download_link.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client_Invoices/_index/invoice_status/returns_those_invoices.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client_Invoices/_index/query/returns_the_queried_invoices.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client_Invoices/_show/returns_the_invoice.yml
+- spec/fixtures/vcr_cassettes/Jortt_Client_LedgerAccounts/_index/returns_invoices.yml
 - spec/jortt/client/customers_spec.rb
-- spec/jortt/client/invoice_spec.rb
 - spec/jortt/client/invoices_spec.rb
+- spec/jortt/client/ledger_accounts_spec.rb
 - spec/jortt/client_spec.rb
 - spec/jortt_spec.rb
 - spec/spec_helper.rb

data/.rubocop.yml

@@ -1,26 +0,0 @@
-require: rubocop-rspec
-
-Style/AccessModifierIndentation:
-  EnforcedStyle: outdent
-
-Style/AlignParameters:
-  EnforcedStyle: with_fixed_indentation
-
-Style/DotPosition:
-  EnforcedStyle: trailing
-
-Style/TrailingComma:
-  EnforcedStyleForMultiline: comma
-
-Style/EmptyLinesAroundBody:
-  Description: "Keeps track of empty lines around expression bodies."
-  Enabled: false
-
-Style/RegexpLiteral:
-  MaxSlashes: 0
-
-Style/HashSyntax:
-  EnforcedStyle: ruby19
-
-Style/SpaceInsideHashLiteralBraces:
-  EnforcedStyle: no_space

data/lib/jortt/client/invoice.rb

@@ -1,50 +0,0 @@
-# encoding: UTF-8
-require 'rest-client'
-
-module Jortt # :nodoc:
-  class Client # :nodoc:
-
-    ##
-    # Exposes the operations available for a single invoice.
-    #
-    # @see { Jortt::Client.invoice }
-    class Invoice
-
-      def initialize(config, id)
-        @config = config
-        @id = id
-      end
-
-      ##
-      # Sends an Invoice using the POST /invoices/id/:invoice_id/send endpoint.
-      #
-      # @example
-      #   Jortt::Client.invoice(:invoice_id).send(
-      #     mail_data: {
-      #       to: 'ben@jortt.nl', # optional
-      #       subject: 'Thank you for your assignment', # optional
-      #       body: 'I hereby send you the invoice', # optional
-      #     },
-      #     invoice_date: Date.today, # optional
-      #     payment_term: 7, # optional
-      #     language: 'nl', # optional
-      #     send_method: 'email', # optional
-      #   )
-      def send_invoice(payload = {})
-        resource = RestClient::Resource.new(
-          "#{config.base_url}/invoices/id/#{id}/send",
-          user: config.app_name,
-          password: config.api_key,
-        )
-        resource.post(JSON.generate(payload)) do |response|
-          JSON.parse(response.body)
-        end
-      end
-
-    private
-
-      attr_reader :config, :id
-    end
-
-  end
-end

data/spec/jortt/client/invoice_spec.rb

@@ -1,23 +0,0 @@
-# encoding: UTF-8
-require 'spec_helper'
-
-describe Jortt::Client::Invoice do
-  let(:invoice) do
-    described_class.new(
-      double(base_url: 'foo', app_name: 'app', api_key: 'secret'),
-      'bar',
-    )
-  end
-
-  describe '#send_invoice' do
-    let(:request_body) { JSON.generate(mail_data: {to: 'ben@jortt.nl'}) }
-    let(:response_body) { JSON.generate(invoice_number: '2016-001') }
-    subject { invoice.send_invoice(mail_data: {to: 'ben@jortt.nl'}) }
-    before do
-      stub_request(:post, 'http://app:secret@foo/invoices/id/bar/send').
-        with(body: request_body).
-        to_return(status: 200, body: response_body)
-    end
-    it { should eq('invoice_number' => '2016-001') }
-  end
-end