jordi-xml_struct 0.2.0 → 0.2.1

data/WHATSNEW

@@ -1,3 +1,6 @@
+* 0.2.1 (2008-10-13):
+  - Fixed a bug where attributes with dashes would crash the party
+
 * 0.2.0 (2008-10-13):
   - Broke backwards compatibility
   - XMLRecord.new now returns decorated String or Array objects, so that

data/lib/xml_struct.rb

@@ -58,16 +58,24 @@ module XMLStruct
     children[key] = if children[key]
 
       unless obj.respond_to?((plural_key = key.to_s.pluralize).to_sym)
-        obj.instance_eval %{
-          def #{plural_key}; @__children[:#{key.to_s}]; end }
+          begin
+            obj.instance_eval %{
+              def #{plural_key}; @__children[%s|#{key.to_s}|]; end }
+          rescue SyntaxError
+            nil
+          end
       end
 
       children[key] = [ children[key] ] unless children[key].is_a? Array
       children[key] << element
     else
       unless obj.respond_to? key
-        obj.instance_eval %{
-          def #{key.to_s}; @__children[:#{key.to_s}]; end }
+        begin
+          obj.instance_eval %{
+            def #{key.to_s}; @__children[%s|#{key.to_s}|]; end }
+        rescue SyntaxError
+          nil
+        end
       end
 
       element
@@ -85,8 +93,12 @@ module XMLStruct
     attributes[(key = name.to_sym)] = attr_value.squish.extend String
 
     unless obj.respond_to? key
-      obj.instance_eval %{
-        def #{key.to_s}; @__attributes[:#{key.to_s}]; end }
+      begin
+        obj.instance_eval %{
+          def #{key.to_s}; @__attributes[%s|#{key.to_s}|]; end }
+      rescue SyntaxError
+        nil
+      end
     end
 
     obj.instance_variable_set :@__attributes, attributes

data/test/samples/weird_characters.xml

@@ -0,0 +1,2 @@
+<weird attr-with-dashes="lame">
+</weird>

data/test/test_helper.rb

@@ -24,6 +24,7 @@ end
 
 require 'digest/md5'
 { :lorem  => '9062c0f294383435d5b04ce6d67b6d61',
+  :weird_characters => 'cdcbd9b89b261487fa98c11d856f50fe',
   :recipe => '6087ab42049273d123d473093b04ab12' }.each do |file_key, md5|
 
   unless Digest::MD5.hexdigest(xml_file(file_key).read) == md5

data/test/xml_struct_test.rb

@@ -1,5 +1,19 @@
 require File.join(File.dirname(__FILE__), 'test_helper')
 
+describe 'An XML file with weird characters' do
+
+  it 'should not raise exceptions' do
+    should.not.raise(Exception) do
+      @xml = XMLStruct.new xml_file(:weird_characters)
+    end
+  end
+
+  it 'should allow access to attributes with dashes in the name' do
+    XMLStruct.new(
+      xml_file(:weird_characters))['attr-with-dashes'].should == 'lame'
+  end
+end
+
 describe 'The XML Struct module' do
 
   def setup

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: jordi-xml_struct
 version: !ruby/object:Gem::Version 
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors: 
 - Jordi Bunster
@@ -75,6 +75,7 @@ test_files:
 - test/samples
 - test/samples/lorem.xml
 - test/samples/recipe.xml
+- test/samples/weird_characters.xml
 - test/test_helper.rb
 - test/vendor
 - test/vendor/test-spec