johnson 1.1.2 → 1.2.0

data/CHANGELOG.rdoc

@@ -1,3 +1,15 @@
+=== 1.2.0 / 2010-01-25
+
+* Add an API for registering custom conversions.
+* Subclass Runtime, don't delegate.
+* Make builds a bit more robust, especially on Snow Leopard.
+* Handle UTF-8 conversion better. Also, treat JS strings as UTF-16.
+* Add small bits of API doco.
+* Plug tons of root leaks.
+* Make Function.prototype.apply handle Ruby arrays.
+* Remove Rails EJS support, it was a joke to begin with.
+* Whitespace, formatting, and organization cleanups.
+
 === 1.1.2 / 2009-07-29
 
 * Cleaned up building / packaging. Gem installs work again!

data/Manifest.txt

@@ -29,12 +29,13 @@ ext/spidermonkey/runtime.c
 ext/spidermonkey/runtime.h
 ext/spidermonkey/spidermonkey.c
 ext/spidermonkey/spidermonkey.h
-js/johnson/cli.js
-js/johnson/prelude.js
 lib/johnson.rb
 lib/johnson/cli.rb
 lib/johnson/cli/options.rb
 lib/johnson/error.rb
+lib/johnson/js/cli.js
+lib/johnson/js/core.js
+lib/johnson/js/prelude.js
 lib/johnson/nodes.rb
 lib/johnson/nodes/binary_node.rb
 lib/johnson/nodes/for.rb
@@ -45,7 +46,9 @@ lib/johnson/nodes/node.rb
 lib/johnson/nodes/ternary_node.rb
 lib/johnson/parser.rb
 lib/johnson/parser/syntax_error.rb
+lib/johnson/ruby_land_proxy.rb
 lib/johnson/runtime.rb
+lib/johnson/spidermonkey.rb
 lib/johnson/spidermonkey/context.rb
 lib/johnson/spidermonkey/debugger.rb
 lib/johnson/spidermonkey/immutable_node.rb
@@ -53,7 +56,6 @@ lib/johnson/spidermonkey/js_land_proxy.rb
 lib/johnson/spidermonkey/mutable_tree_visitor.rb
 lib/johnson/spidermonkey/ruby_land_proxy.rb
 lib/johnson/spidermonkey/runtime.rb
-lib/johnson/version.rb
 lib/johnson/visitable.rb
 lib/johnson/visitors.rb
 lib/johnson/visitors/dot_visitor.rb
@@ -61,7 +63,6 @@ lib/johnson/visitors/ecma_visitor.rb
 lib/johnson/visitors/enumerating_visitor.rb
 lib/johnson/visitors/sexp_visitor.rb
 lib/johnson/visitors/visitor.rb
-lib/rails/init.rb
 test/helper.rb
 test/johnson/browser_test.rb
 test/johnson/conversions/array_test.rb
@@ -75,6 +76,7 @@ test/johnson/conversions/string_test.rb
 test/johnson/conversions/struct_test.rb
 test/johnson/conversions/symbol_test.rb
 test/johnson/conversions/thread_test.rb
+test/johnson/custom_conversions_test.rb
 test/johnson/error_test.rb
 test/johnson/extensions_test.rb
 test/johnson/nodes/array_literal_test.rb

data/README.rdoc

@@ -1,7 +1,6 @@
 = Johnson
 
 * http://github.com/jbarnette/johnson
-* http://johnson.lighthouseapp.com
 * http://groups.google.com/group/johnson-talk
 
 == Description
@@ -11,7 +10,7 @@ Mozilla SpiderMonkey JavaScript runtime as a C extension.
 
 == Examples
 
-    # FIXME: write some decent examples
+    # FIX: write some decent examples
     require "johnson"
 
     Johnson.evaluate("4 + 4") # => 8
@@ -21,14 +20,9 @@ Mozilla SpiderMonkey JavaScript runtime as a C extension.
 
     $ gem install johnson
 
-=== TODO
-
-* Support more than just Mac OS X / Ruby 1.8.6.
-* Stop freaking segfaulting.
-
 == License
 
-Copyright 2008-2009 John Barnette,
+Copyright 2008-2010 John Barnette,
 Aaron Patterson,
 Yehuda Katz,
 Matthew Draper

data/Rakefile

@@ -1,12 +1,13 @@
 require "rubygems"
 
-gem "hoe", ">= 2.3"
+gem "hoe", "~> 2.3"
 require "hoe"
 
-gem "rake-compiler", ">= 0.6.0"
+gem "rake-compiler", "~> 0.6"
 require "rake/extensiontask"
 
 Hoe.plugin :debugging, :doofus, :git
+Hoe.plugins.delete :rubyforge
 
 Hoe.spec "johnson" do
   developer "John Barnette",   "jbarnette@rubyforge.org"
@@ -14,24 +15,23 @@ Hoe.spec "johnson" do
   developer "Yehuda Katz",     "wycats@gmail.com"
   developer "Matthew Draper",  "matthew@trebex.net"
 
-  self.extra_rdoc_files = FileList["*.rdoc"]
-  self.history_file     = "CHANGELOG.rdoc"
-  self.readme_file      = "README.rdoc"
-  self.test_globs       = %w(test/**/*_test.rb)
+  self.extra_rdoc_files         = FileList["*.rdoc"]
+  self.history_file             = "CHANGELOG.rdoc"
+  self.readme_file              = "README.rdoc"
+  self.test_globs               = %w(test/**/*_test.rb)
+  self.spec_extras[:extensions] = %w(ext/spidermonkey/extconf.rb)
 
-  self.spec_extras = { :extensions => %w(ext/spidermonkey/extconf.rb) }
-
-  extra_dev_deps << ["rake-compiler", ">= 0.6.0"]
+  extra_dev_deps << ["rake-compiler", "~> 0.6"]
 
   clean_globs    << "ext/**/Makefile"
   clean_globs    << "ext/**/*.{o,so,bundle,a,log}"
   clean_globs    << "ext/spidermonkey/immutable_node.c"
-  clean_globs    << "lib/johnson/spidermonkey.bundle"
+  clean_globs    << "lib/johnson/**/*.{bundle,so}"
   clean_globs    << "tmp"
   clean_globs    << "vendor/spidermonkey/**/*.OBJ"
 
   Rake::ExtensionTask.new "spidermonkey", spec do |ext|
-    ext.lib_dir = "lib/johnson"
+    ext.lib_dir = "lib/johnson/spidermonkey"
   end
 end
 

data/bin/johnson

@@ -1,9 +1,7 @@
 #!/usr/bin/env ruby
 
-$:.unshift(File.expand_path(File.join(File.dirname(__FILE__), "..", "lib")))
-
 require "readline"
-require "johnson"
+require "johnson/cli"
 
 RUNTIME = js = Johnson::Runtime.new
 RUNTIME.evaluate(Johnson::CLI::JS)

data/ext/spidermonkey/context.c

@@ -35,9 +35,10 @@ static JSBool branch_callback(JSContext* js, JSScript* UNUSED(script))
 
 /*
  * call-seq:
- *   native_initialize(options={})
+ *   native_initialize(runtime, options)
  *
- * Initializes the native spidermonkey values.
+ * Create the underlying SpiderMonkey context. This must be called
+ * first, and only once. Called by +initialize+ by default.
  */
 static VALUE
 initialize_native(VALUE self, VALUE rb_runtime, VALUE UNUSED(options))

data/ext/spidermonkey/conversions.c

@@ -4,12 +4,21 @@
 
 DEFINE_RUBY_WRAPPER(convert_to_ruby, convert_to_ruby, ARGLIST2(runtime, js_value))
 
-DECLARE_RUBY_WRAPPER(rb_funcall_0, VALUE obj; ID sym; int argc)
-DEFINE_RUBY_WRAPPER(rb_funcall_0, rb_funcall, ARGLIST3(obj, sym, argc))
+DEFINE_RUBY_WRAPPER(convert_js_string_to_ruby, convert_js_string_to_ruby, ARGLIST2(runtime, str))
+
+static VALUE convert_regexp_to_ruby(JohnsonRuntime* runtime, jsval regexp);
+DECLARE_RUBY_WRAPPER(convert_regexp_to_ruby, JohnsonRuntime* runtime; jsval regexp)
+DEFINE_RUBY_WRAPPER(convert_regexp_to_ruby, convert_regexp_to_ruby, ARGLIST2(runtime, regexp))
 
-DECLARE_RUBY_WRAPPER(rb_funcall_2, VALUE obj; ID sym; int argc; VALUE a; VALUE b)
+DEFINE_RUBY_WRAPPER(rb_funcall_0, rb_funcall, ARGLIST3(obj, sym, argc))
+DEFINE_RUBY_WRAPPER(rb_funcall_1, rb_funcall, ARGLIST4(obj, sym, argc, a))
 DEFINE_RUBY_WRAPPER(rb_funcall_2, rb_funcall, ARGLIST5(obj, sym, argc, a, b))
 
+DECLARE_RUBY_WRAPPER(rb_float_new, double v)
+DEFINE_RUBY_WRAPPER(rb_float_new, rb_float_new, ARGLIST1(v))
+
+DEFINE_RUBY_WRAPPER(rb_intern, rb_intern, ARGLIST1(name))
+
 static JSBool convert_float_or_bignum_to_js(JohnsonRuntime* runtime, VALUE float_or_bignum, jsval* retval)
 {
   JSContext * context = johnson_get_current_context(runtime);
@@ -21,7 +30,8 @@ static JSBool convert_symbol_to_js(JohnsonRuntime* runtime, VALUE symbol, jsval*
   JSContext * context = johnson_get_current_context(runtime);
   PREPARE_JROOTS(context, 2);
 
-  VALUE to_s = CALL_RUBY_WRAPPER(rb_funcall_0, symbol, rb_intern("to_s"), 0);
+  VALUE to_s = CALL_RUBY_WRAPPER(rb_funcall_0, symbol, RB_INTERN("to_s"), 0);
+  CALL_RUBY_WRAPPER(rb_string_value, &to_s);
   jsval name = STRING_TO_JSVAL(JS_NewStringCopyN(context, StringValuePtr(to_s), (size_t) StringValueLen(to_s)));
 
   JROOT(name);
@@ -41,8 +51,9 @@ static JSBool convert_regexp_to_js(JohnsonRuntime* runtime, VALUE regexp, jsval*
 {
   JSContext * context = johnson_get_current_context(runtime);
   PREPARE_JROOTS(context, 0);
-  VALUE source = rb_funcall(regexp, rb_intern("source"), 0);
-  jsint options = (jsint)(NUM2INT(rb_funcall(regexp, rb_intern("options"), 0)));
+  VALUE source = rb_funcall(regexp, RB_INTERN("source"), 0);
+  CALL_RUBY_WRAPPER(rb_string_value, &source);
+  jsint options = (jsint)(NUM2INT(rb_funcall(regexp, RB_INTERN("options"), 0)));
 
   JSObject* obj = JS_NewRegExpObject(context,
         StringValuePtr(source),
@@ -102,7 +113,15 @@ JSBool convert_to_js(JohnsonRuntime* runtime, VALUE ruby, jsval* retval)
 
     case T_STRING:
       {
-        JSString* str = JS_NewStringCopyN(context, StringValuePtr(ruby), (size_t) StringValueLen(ruby));
+        CALL_RUBY_WRAPPER(rb_string_value, &ruby);
+        const char * src = StringValuePtr(ruby);
+        const size_t srclen = StringValueLen(ruby);
+        size_t dstlen = 0;
+        JCHECK(JS_DecodeBytes(context, src, srclen, NULL, &dstlen));
+        jschar* dstchars = JS_malloc(context, sizeof(jschar) * (1 + dstlen));
+        JCHECK(dstchars);
+        JCHECK(JS_DecodeBytes(context, src, srclen, dstchars, &dstlen));
+        JSString* str = JS_NewUCString(context, dstchars, dstlen);
         JCHECK(str);
         *retval = STRING_TO_JSVAL(str);
         JRETURN;
@@ -141,7 +160,7 @@ JSBool convert_to_js(JohnsonRuntime* runtime, VALUE ruby, jsval* retval)
       JCHECK(convert_regexp_to_js(runtime, ruby, retval));
       JRETURN;
 
-    case T_DATA: // HEY! keep T_DATA last for fall-through
+    case T_DATA:
       if (ruby_value_is_proxy(ruby))
         JCHECK(unwrap_ruby_land_proxy(runtime, ruby, retval));
       else // If we can't identify the object, just wrap it
@@ -161,9 +180,18 @@ VALUE convert_js_string_to_ruby(JohnsonRuntime* runtime, JSString* str)
   JSContext * context = johnson_get_current_context(runtime);
   PREPARE_RUBY_JROOTS(context, 1);
   JROOT(str);
-  char* bytes = JS_GetStringBytes(str);
-  JCHECK(bytes);
-  JRETURN_RUBY(rb_str_new(bytes, (signed long)JS_GetStringLength(str)));
+  jschar* src = JS_GetStringChars(str);
+  JCHECK(src);
+  size_t srclen = JS_GetStringLength(str);
+  size_t dstlen = 0;
+  JCHECK(JS_EncodeCharacters(context, src, srclen, NULL, &dstlen));
+  char* dst = JS_malloc(context, sizeof(char) * (1 + dstlen));
+  JCHECK(dst);
+  JCHECK(JS_EncodeCharacters(context, src, srclen, dst, &dstlen));
+  // This will leak dst if rb_str_new raises
+  VALUE ruby_str = rb_str_new(dst, dstlen);
+  JS_free(context, dst);
+  JRETURN_RUBY(ruby_str);
 }
 
 static VALUE convert_regexp_to_ruby(JohnsonRuntime* runtime, jsval regexp)
@@ -173,26 +201,27 @@ static VALUE convert_regexp_to_ruby(JohnsonRuntime* runtime, jsval regexp)
   JROOT(regexp);
   JSRegExp* re = (JSRegExp*)JS_GetPrivate(context, JSVAL_TO_OBJECT(regexp));
 
-  JRETURN_RUBY(CALL_RUBY_WRAPPER(rb_funcall_2, rb_cRegexp, rb_intern("new"), 2,
-    convert_js_string_to_ruby(runtime, re->source),
+  JRETURN_RUBY(RB_FUNCALL_2(rb_cRegexp, RB_INTERN("new"),
+    CONVERT_JS_STRING_TO_RUBY(runtime, re->source),
     INT2NUM((long)re->flags)));
 }
 
-static bool js_value_is_regexp(JohnsonRuntime* runtime, jsval maybe_regexp)
+static JSBool js_value_is_regexp(JohnsonRuntime* runtime, jsval maybe_regexp, bool* is_regexp)
 {
   JSContext * context = johnson_get_current_context(runtime);
-  PREPARE_RUBY_JROOTS(context, 1);
+  PREPARE_JROOTS(context, 1);
   JROOT(maybe_regexp);
   JSBool result = JS_InstanceOf(context, JSVAL_TO_OBJECT(maybe_regexp), &js_RegExpClass, NULL);
-  JRETURN_RUBY(result ? true : false);
+  *is_regexp = (result ? true : false);
+  JRETURN;
 }
 
-static bool js_value_is_symbol(JohnsonRuntime* runtime, jsval maybe_symbol)
+static JSBool js_value_is_symbol(JohnsonRuntime* runtime, jsval maybe_symbol, bool* is_symbol)
 {
   jsval nsJohnson, cSymbol;
   JSContext * context = johnson_get_current_context(runtime);
 
-  PREPARE_RUBY_JROOTS(context, 3);
+  PREPARE_JROOTS(context, 3);
   JROOT(maybe_symbol);
 
   JCHECK(JS_GetProperty(context, runtime->global, "Johnson", &nsJohnson));
@@ -208,7 +237,8 @@ static bool js_value_is_symbol(JohnsonRuntime* runtime, jsval maybe_symbol)
   JSBool is_a_symbol;
   JCHECK(JS_HasInstance(context, JSVAL_TO_OBJECT(cSymbol), maybe_symbol, &is_a_symbol));
 
-  JRETURN_RUBY(is_a_symbol != JS_FALSE);
+  *is_symbol = (is_a_symbol != JS_FALSE);
+  JRETURN;
 }
 
 VALUE convert_to_ruby(JohnsonRuntime* runtime, jsval js)
@@ -229,29 +259,33 @@ VALUE convert_to_ruby(JohnsonRuntime* runtime, jsval js)
     case JSTYPE_OBJECT:
       if (OBJECT_TO_JSVAL(runtime->global) == js)
         // global gets special treatment, since the Prelude might not be loaded
-        JRETURN_RUBY(make_ruby_land_proxy(runtime, js, "GlobalProxy"));
+        JRETURN_RUBY(CALL_RUBY_WRAPPER(make_ruby_land_proxy, runtime, js, "GlobalProxy"));
       
       // this conditional requires the Prelude
-      if (js_value_is_symbol(runtime, js))
-        JRETURN_RUBY(ID2SYM(rb_intern(JS_GetStringBytes(JS_ValueToString(context, js)))));
+      bool is_symbol = false;
+      JCHECK(js_value_is_symbol(runtime, js, &is_symbol));
+      if (is_symbol)
+        JRETURN_RUBY(ID2SYM(RB_INTERN(JS_GetStringBytes(JS_ValueToString(context, js)))));
     
       if (js_value_is_proxy(runtime, js))
         JRETURN_RUBY(unwrap_js_land_proxy(runtime, js));
 
-      if (js_value_is_regexp(runtime, js))
-        JRETURN_RUBY(convert_regexp_to_ruby(runtime, js));
+      bool is_regexp = false;
+      JCHECK(js_value_is_regexp(runtime, js, &is_regexp));
+      if (is_regexp)
+        JRETURN_RUBY(CALL_RUBY_WRAPPER(convert_regexp_to_ruby, runtime, js));
     
-      JRETURN_RUBY(make_ruby_land_proxy(runtime, js, "RubyLandProxy"));
+      JRETURN_RUBY(CALL_RUBY_WRAPPER(make_ruby_land_proxy, runtime, js, LEAKY_ROOT_NAME("RubyLandProxy", JS_GetStringBytes(JS_ValueToString(context, js)))));
         
     case JSTYPE_BOOLEAN:
       JRETURN_RUBY(JSVAL_TRUE == js ? Qtrue : Qfalse);
       
     case JSTYPE_STRING:
-      JRETURN_RUBY(convert_js_string_to_ruby(runtime, JSVAL_TO_STRING(js)));
+      JRETURN_RUBY(CONVERT_JS_STRING_TO_RUBY(runtime, JSVAL_TO_STRING(js)));
       
     case JSTYPE_NUMBER:
       if (JSVAL_IS_INT(js)) JRETURN_RUBY(INT2FIX(JSVAL_TO_INT(js)));
-      else JRETURN_RUBY(rb_float_new(*JSVAL_TO_DOUBLE(js)));
+      else JRETURN_RUBY(CALL_RUBY_WRAPPER(rb_float_new, *JSVAL_TO_DOUBLE(js)));
 
     default:
       JERROR("unknown js type in switch");

data/ext/spidermonkey/conversions.h

@@ -8,6 +8,19 @@
 DECLARE_RUBY_WRAPPER(convert_to_ruby, JohnsonRuntime* runtime; jsval js_value)
 #define CONVERT_TO_RUBY(runtime, js) CALL_RUBY_WRAPPER(convert_to_ruby, runtime, js)
 
+DECLARE_RUBY_WRAPPER(convert_js_string_to_ruby, JohnsonRuntime* runtime; JSString* str)
+#define CONVERT_JS_STRING_TO_RUBY(runtime, js) CALL_RUBY_WRAPPER(convert_js_string_to_ruby, runtime, js)
+
+DECLARE_RUBY_WRAPPER(rb_funcall_0, VALUE obj; ID sym; int argc)
+#define RB_FUNCALL_0(obj, sym) CALL_RUBY_WRAPPER(rb_funcall_0, obj, sym, 0)
+DECLARE_RUBY_WRAPPER(rb_funcall_1, VALUE obj; ID sym; int argc; VALUE a)
+#define RB_FUNCALL_1(obj, sym, a) CALL_RUBY_WRAPPER(rb_funcall_1, obj, sym, 1, a)
+DECLARE_RUBY_WRAPPER(rb_funcall_2, VALUE obj; ID sym; int argc; VALUE a; VALUE b)
+#define RB_FUNCALL_2(obj, sym, a, b) CALL_RUBY_WRAPPER(rb_funcall_2, obj, sym, 2, a, b)
+
+DECLARE_RUBY_WRAPPER(rb_intern, const char* name)
+#define RB_INTERN(name) CALL_RUBY_WRAPPER(rb_intern, name)
+
 JSBool convert_to_js(JohnsonRuntime* runtime, VALUE ruby, jsval* retval);
 VALUE convert_to_ruby(JohnsonRuntime* runtime, jsval js);
 VALUE convert_js_string_to_ruby(JohnsonRuntime* runtime, JSString* str);

data/ext/spidermonkey/debugger.c

@@ -3,6 +3,14 @@
 #include "conversions.h"
 #include "immutable_node.h"
 
+static VALUE debugger_class = Qnil;
+
+bool ruby_value_is_debugger(VALUE maybe_debugger)
+{
+  VALUE klass = CLASS_OF(maybe_debugger);
+  return (klass == debugger_class);
+}
+
 /*
  * call-seq:
  *   frame_pc(context, frame)
@@ -217,10 +225,10 @@ void init_Johnson_SpiderMonkey_Debugger(VALUE spidermonkey)
   */
 
   /* This is the debugging hooks used with SpiderMonkey. */
-  VALUE debugger = rb_define_class_under(spidermonkey, "Debugger", rb_cObject);
-  rb_define_private_method(debugger, "frame_pc", frame_pc, 2);
-  rb_define_private_method(debugger, "line_number", line_number, 3);
-  rb_define_private_method(debugger, "file_name", file_name, 2);
+  debugger_class = rb_define_class_under(spidermonkey, "Debugger", rb_cObject);
+  rb_define_private_method(debugger_class, "frame_pc", frame_pc, 2);
+  rb_define_private_method(debugger_class, "line_number", line_number, 3);
+  rb_define_private_method(debugger_class, "file_name", file_name, 2);
 
-  rb_define_alloc_func(debugger, allocate);
+  rb_define_alloc_func(debugger_class, allocate);
 }

data/ext/spidermonkey/debugger.h

@@ -5,5 +5,6 @@
 #include "jsdbgapi.h"
 
 void init_Johnson_SpiderMonkey_Debugger(VALUE spidermonkey);
+bool ruby_value_is_debugger(VALUE maybe_debugger);
 
 #endif

data/ext/spidermonkey/extconf.rb

@@ -1,5 +1,4 @@
-# this needs to happen before mkmf is required
-ENV["ARCHFLAGS"] = "-arch #{`uname -p` =~ /powerpc/ ? 'ppc' : 'i386'}"
+ENV["RC_ARCHS"] = "" if RUBY_PLATFORM =~ /darwin/
 
 require "find"
 require "mkmf"
@@ -30,4 +29,4 @@ dir_config "johnson/spidermonkey"
 find_header "jsautocfg.h", File.dirname(libjs)
 find_header "jsapi.h", spidermonkey_dir
 
-create_makefile "johnson/spidermonkey"
+create_makefile "johnson/spidermonkey/spidermonkey"

data/ext/spidermonkey/jroot.h

@@ -148,15 +148,18 @@
 #define JERROR(format, args...) \
   do \
   { \
-    REMOVE_JROOTS; \
     char _jroot_msg[_JROOT_ERRSIZE]; \
     snprintf(_jroot_msg, _JROOT_ERRSIZE, (format) , ## args); \
     if (_jroot_ruby) \
+    { \
+      REMOVE_JROOTS; \
       rb_raise(rb_eRuntimeError,  _jroot_msg); \
+    } \
     else \
     { \
       JSString* _jroot_err_str = JS_NewStringCopyZ(_jroot_context, _jroot_msg); \
       if (_jroot_err_str) JS_SetPendingException(_jroot_context, STRING_TO_JSVAL(_jroot_err_str)); \
+      REMOVE_JROOTS; \
       return JS_FALSE; \
     } \
   } while(0)
@@ -179,6 +182,13 @@
     name ## _args * _data = (name ## _args *)(FIX2LONG(magic) << 2); \
     return func(arglist); \
   }
+#define DEFINE_VOID_RUBY_WRAPPER(name, func, arglist) \
+  VALUE name ## _invoke(VALUE magic) \
+  { \
+    name ## _args * _data = (name ## _args *)(FIX2LONG(magic) << 2); \
+    func(arglist); \
+    return Qnil; \
+  }
 #define RUBY_WRAPPER_ARG(name, args...) ({ name ## _args _x = { args }; LONG2FIX((long)(&_x) >> 2); })
 #define RUBY_WRAPPER(name) name ## _invoke
 #define CALL_RUBY_WRAPPER(name, args...) JPROTECT(RUBY_WRAPPER(name), RUBY_WRAPPER_ARG(name, args))