johnsbrn-has_permission 0.1.4 → 0.2.0

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
-:patch: 4
+:patch: 0
 :major: 0
-:minor: 1
+:minor: 2

data/lib/active_record/has/permission.rb

@@ -53,7 +53,7 @@ module ActiveRecord
         def with_permission(user)
           self.class.permission_class.new :user => user, :object => self
         end
-        
+      
       end
       
     end

data/lib/permission/base.rb

@@ -24,6 +24,42 @@ module Permission
       object.send(method, *args)
     end
   
+    def update_attribute(name, value)
+      if can_write?(name)
+        object.update_attribute(name, value)
+      else
+        raise PermissionException.new "#{user} does not have permission to access #{name} on #{object}"
+      end
+    end
+    
+    def update_attributes(attributes)
+      object.update_attributes(attributes.reject{|key,value| !can_write?(key) })
+    end
+    
+    def read_attribute(attr_name)
+      if can_read?(attr_name)
+        object.read_attribute(attr_name)
+      else
+        raise PermissionException.new "#{user} does not have permission to access #{attr_name} on #{object}"
+      end
+    end
+    
+    def write_attribute(attr_name, value)
+      if can_write?(attr_name)
+        object.write_attribute(attr_name, value)
+      else
+        raise PermissionException.new "#{user} does not have permission to access #{attr_name} on #{object}"
+      end
+    end
+    
+    def can_read?(attr_name)
+      true
+    end
+    
+    def can_write?(attr_name)
+      true
+    end
+    
     protected
   
     def check_roles(user, roles, object)

data/test/has_permission_test.rb

@@ -34,6 +34,37 @@ class HasPermissionTest < Test::Unit::TestCase
       assert @model.with_permission(nil).eql?(@model)
     end
     
+    should "throw PermissionException for attribute that does not allow reading" do
+      assert_raise PermissionException do
+        @model.with_permission(nil).read_attribute(:no_access)
+      end
+    end
+    
+    should "allow access for readable attribute" do
+      @model.with_permission(nil).read_attribute(:read_access)
+    end
+    
+    should "throw PermissionException for attribute that does not allow writing" do
+      assert_raise PermissionException do
+        @model.with_permission(nil).write_attribute(:no_access, "test")
+      end
+    end
+    
+    should "allow access for writeable attribute" do
+      @model.with_permission(nil).write_attribute(:write_access, "test")
+    end
+    
+    should "only allow writeable attribute for update attributes" do
+      @model.expects(:update_attributes).with(:write_access => "test")
+      @model.with_permission(nil).update_attributes(:no_access => "test", :write_access => "test")
+    end
+    
+    should "only allow writeable attribute for update attribute" do
+      assert_raise PermissionException do
+        @model.with_permission(nil).update_attribute(:no_access, "test")
+      end
+    end
+    
   end
 
   context "model class" do
@@ -63,4 +94,5 @@ class HasPermissionTest < Test::Unit::TestCase
   end
   
   # TODO need to test proxy associations somehow
+  
 end

data/test/test_helper.rb

@@ -13,6 +13,14 @@ class Model
   
   has_permission
   
+  def read_attribute(attr_name)
+    "test"
+  end
+  
+  def write_attribute(attr_name, value)
+    value
+  end
+  
   def some_method
     "no permission"
   end
@@ -35,6 +43,22 @@ end
 module Permission
   class ModelPermission < Permission::Base
   
+    def can_read?(attr_name)
+      case attr_name
+        when :read_access : true
+        when :no_access : false
+        else true
+      end
+    end
+    
+    def can_write?(attr_name)
+      case attr_name
+        when :write_access : true
+        when :no_access : false
+        else true
+      end
+    end
+    
     def some_method
       "with permission"
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: johnsbrn-has_permission
 version: !ruby/object:Gem::Version 
-  version: 0.1.4
+  version: 0.2.0
 platform: ruby
 authors: 
 - Brian Johnson
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-01-26 00:00:00 -08:00
+date: 2009-02-26 00:00:00 -08:00
 default_executable: 
 dependencies: []