joblin 0.1.11 → 0.2.0

data/spec/lazy_access_spec.rb

@@ -0,0 +1,76 @@
+require 'spec_helper'
+
+# A real ActiveRecord subclass so dump/locate see a genuine GlobalID.
+class LazyAccessTestTask < Joblin::BackgroundTask
+  def perform; end
+end
+
+RSpec.describe Joblin::LazyAccess do
+  let(:record) { LazyAccessTestTask.create! }
+  let(:gid) { record.to_gid.to_s }
+
+  describe ".dump" do
+    it "converts record values to gid strings and records them in the marker" do
+      dumped = described_class.dump({ "user" => record, "n" => 5 })
+
+      expect(dumped["user"]).to eq(gid)
+      expect(dumped["n"]).to eq(5)
+      expect(dumped["_joblin_"]).to eq({ "gid_keys" => ["user"] })
+    end
+
+    it "does NOT mark a plain string that merely looks like a gid" do
+      dumped = described_class.dump({ "note" => "gid://app/Whatever/1" })
+
+      expect(dumped["note"]).to eq("gid://app/Whatever/1")
+      expect(dumped).not_to have_key("_joblin_")
+    end
+
+    it "omits the marker entirely when there are no record values" do
+      expect(described_class.dump({ "a" => 1 })).to eq({ "a" => 1 })
+    end
+  end
+
+  describe ".load" do
+    it "does not locate anything eagerly and only resolves marked keys on access" do
+      dumped = described_class.dump({ "user" => record, "note" => "gid://app/Whatever/1" })
+
+      expect(GlobalID::Locator).to receive(:locate).once.and_return(record)
+
+      h = described_class.load(dumped)
+      # Unmarked gid-looking string is returned verbatim (no locate).
+      expect(h["note"]).to eq("gid://app/Whatever/1")
+      # Marked key resolves to the record.
+      expect(h["user"]).to eq(record)
+    end
+
+    it "hides the marker key from enumeration" do
+      dumped = described_class.dump({ "user" => record, "n" => 5 })
+      h = described_class.load(dumped)
+
+      expect(h.keys).to match_array(%w[user n])
+      expect(h.to_h).not_to have_key("_joblin_")
+    end
+  end
+
+  describe "round-trip" do
+    it "preserves gid marking when a loaded value is re-dumped without being accessed" do
+      dumped = described_class.dump({ "user" => record })
+      loaded = described_class.load(dumped)
+
+      # Re-dump without ever reading loaded["user"].
+      redumped = described_class.dump(loaded)
+
+      expect(redumped["user"]).to eq(gid)
+      expect(redumped["_joblin_"]).to eq({ "gid_keys" => ["user"] })
+    end
+  end
+
+  describe "Array access (regression for multi-arg [])" do
+    it "supports two-arg and range slicing" do
+      arr = described_class.load([10, 20, 30, 40])
+      expect(arr[1, 2]).to eq([20, 30])
+      expect(arr[1..2]).to eq([20, 30])
+      expect(arr[0]).to eq(10)
+    end
+  end
+end

data/spec/models/api_access_spec.rb

@@ -0,0 +1,57 @@
+require 'spec_helper'
+
+# Defined with real `class` statements so the constant is named when
+# allow_api_access! runs (the registry keys off `name`).
+class ApiAllowedTask < Joblin::BackgroundTask
+  allow_api_access!
+  def perform; end
+end
+
+class ApiNotAllowedTask < Joblin::BackgroundTask
+  def perform; end
+end
+
+RSpec.describe Joblin::BackgroundTask::ApiAccess, type: :model do
+  describe '.allow_api_access!' do
+    it 'registers the class by name in api_accessible_types' do
+      expect(Joblin::BackgroundTask.api_accessible_types['ApiAllowedTask']).to eq(ApiAllowedTask)
+    end
+
+    it 'does not register a class that never opted in' do
+      expect(Joblin::BackgroundTask.api_accessible_types).not_to have_key('ApiNotAllowedTask')
+    end
+  end
+
+  describe '.build_from_api type resolution' do
+    it 'builds a registered type named in params[:type]' do
+      task = Joblin::BackgroundTask.build_from_api({ type: 'ApiAllowedTask' })
+      expect(task).to be_an_instance_of(ApiAllowedTask)
+    end
+
+    it 'raises RecordNotFound for a real class that never opted in' do
+      # ApiNotAllowedTask exists and would constantize fine — but it isn't in
+      # the registry, so it must not be buildable.
+      expect do
+        Joblin::BackgroundTask.build_from_api({ type: 'ApiNotAllowedTask' })
+      end.to raise_error(ActiveRecord::RecordNotFound)
+    end
+
+    it 'raises RecordNotFound for an unknown/hostile type without constantizing it' do
+      expect(String).not_to receive(:safe_constantize)
+      expect do
+        Joblin::BackgroundTask.build_from_api({ type: 'Kernel' })
+      end.to raise_error(ActiveRecord::RecordNotFound)
+    end
+
+    it 'raises RecordNotFound when params[:type] is missing' do
+      expect do
+        Joblin::BackgroundTask.build_from_api({})
+      end.to raise_error(ActiveRecord::RecordNotFound)
+    end
+
+    it 'ignores params[:type] when called on a concrete subclass' do
+      task = ApiAllowedTask.build_from_api({ type: 'Nonexistent' })
+      expect(task).to be_an_instance_of(ApiAllowedTask)
+    end
+  end
+end

data/spec/uniqueness/on_conflict/reject_spec.rb

@@ -0,0 +1,42 @@
+require 'uniqueness/spec_helper'
+require 'sidekiq/api'
+
+RSpec.describe Joblin::Uniqueness::OnConflict::Reject do
+  include_context "on_conflict specs"
+  include_examples "OnConflict is compatible with", %i[while_executing]
+  include_examples "OnConflict is incompatible with", %i[until_executing until_executed until_and_while_executing until_expired]
+
+  let(:sidekiq_message) do
+    { 'class' => 'TestWorker', 'jid' => 'j1', 'queue' => 'default', 'args' => [] }
+  end
+
+  # Reject only supports Sidekiq-backed jobs, so override the shared plain
+  # LockContext with a SidekiqLockContext carrying a job payload.
+  let(:lock_context) do
+    Joblin::Uniqueness::Compat::Sidekiq::SidekiqLockContext.new(
+      { jid: 'j1', queue: 'default', job_clazz: 'TestWorker' },
+      job_instance: sidekiq_message,
+    )
+  end
+
+  it "kills the duplicate job via the DeadSet" do
+    dead_set = instance_double(Sidekiq::DeadSet)
+    expect(Sidekiq::DeadSet).to receive(:new).and_return(dead_set)
+    # DeadSet#kill accepts options on every supported Sidekiq (arity -2), so we
+    # always pass notify_failure: false to avoid firing death handlers for the
+    # rejected duplicate.
+    expect(dead_set).to receive(:kill).with(JSON.dump(sidekiq_message), notify_failure: false)
+
+    on_conflict.call
+  end
+
+  it "logs an error and does not touch the DeadSet for non-Sidekiq contexts" do
+    plain_ctx = Joblin::Uniqueness::LockContext.new({ jid: 'j1', queue: 'default', job_clazz: 'TestWorker' })
+    strategy = described_class.new(plain_ctx)
+
+    expect(Sidekiq::DeadSet).not_to receive(:new)
+    expect(Joblin::Uniqueness.logger).to receive(:error)
+
+    strategy.call
+  end
+end

data/spec/uniqueness/strategy/until_expired_spec.rb

@@ -13,6 +13,13 @@ RSpec.describe Joblin::Uniqueness::Strategy::UntilExpired do
   end
 
   describe "#on_perform" do
+    it "runs the job body" do
+      process_one.on_enqueue {}
+      ran = false
+      process_one.on_perform { ran = true }
+      expect(ran).to be(true)
+    end
+
     it "does not unlock after processing" do
       process_one.on_enqueue {}
       process_one.on_perform {}

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: joblin
 version: !ruby/object:Gem::Version
-  version: 0.1.11
+  version: 0.2.0
 platform: ruby
 authors:
 - Ethan Knapp
@@ -157,6 +157,7 @@ files:
 - app/models/joblin/concerns/job_working_dirs.rb
 - db/migrate/20250903184852_create_joblin_background_tasks.rb
 - db/migrate/20250916184852_add_results_to_joblin_background_tasks.rb
+- db/migrate/20260709120000_add_indexes_to_joblin_background_tasks.rb
 - joblin.gemspec
 - lib/joblin.rb
 - lib/joblin/batching/batch.rb
@@ -239,6 +240,8 @@ files:
 - spec/internal/db/schema.rb
 - spec/internal/log/test.log
 - spec/internal/public/favicon.ico
+- spec/lazy_access_spec.rb
+- spec/models/api_access_spec.rb
 - spec/models/background_task_spec.rb
 - spec/spec_helper.rb
 - spec/uniqueness/compat/active_job_spec.rb
@@ -246,6 +249,7 @@ files:
 - spec/uniqueness/lock_context_spec.rb
 - spec/uniqueness/on_conflict/log_spec.rb
 - spec/uniqueness/on_conflict/raise_spec.rb
+- spec/uniqueness/on_conflict/reject_spec.rb
 - spec/uniqueness/on_conflict/reschedule_spec.rb
 - spec/uniqueness/on_conflict_spec.rb
 - spec/uniqueness/spec_helper.rb
@@ -304,6 +308,8 @@ test_files:
 - spec/internal/db/schema.rb
 - spec/internal/log/test.log
 - spec/internal/public/favicon.ico
+- spec/lazy_access_spec.rb
+- spec/models/api_access_spec.rb
 - spec/models/background_task_spec.rb
 - spec/spec_helper.rb
 - spec/uniqueness/compat/active_job_spec.rb
@@ -311,6 +317,7 @@ test_files:
 - spec/uniqueness/lock_context_spec.rb
 - spec/uniqueness/on_conflict/log_spec.rb
 - spec/uniqueness/on_conflict/raise_spec.rb
+- spec/uniqueness/on_conflict/reject_spec.rb
 - spec/uniqueness/on_conflict/reschedule_spec.rb
 - spec/uniqueness/on_conflict_spec.rb
 - spec/uniqueness/spec_helper.rb