jobify 0.1.1 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 68c0e9df1850d8df3ffd79918d74a14b8c5269b1e546107af418b04770032e42
-  data.tar.gz: e1414b2383e972103a9808401a077fc05eead62d35661f99339cb857a9e5052b
+  metadata.gz: 8c34bf93e6019d918312706b17ed0503044d2dc4ea16de824702223afa879d49
+  data.tar.gz: 2328a20bc2654f9053d85694d062bda712762d00100747f0a68166436df56729
 SHA512:
-  metadata.gz: a9fce3c64c0b07da031c0c8cc47394920b272f5dc96a1a8e0bd0e3d9bc3b5f3217eecc04fbaf19a1ee69b77cb594bcddadc617e781140065f9f4b2d4c0e340b2
-  data.tar.gz: f9d835f57374eec52d20902055ad5fc21cadcf58d8b0bff107a206912b19213f28ba676086e510334b745bb2960250a290781d267135da8d5ec3a1017f28d5d1
+  metadata.gz: 5ed50a875bdff43a912fa392cc852c4f80ddc43c10d453037ecc5c64c1407a93d83a23f3ae078d27a6ba63d8588ef3d2c5bdc3dd148a5e190e0e19020c577ce5
+  data.tar.gz: 9dd6f7b8765756f3ec85979e75564254970ac8851b42d23431b8434f24a79d5114a6bb61aa181b230d6889c2d4aa906cecb9c2fd349c5d878586d97fb63f79a3

data/.rubocop.yml

@@ -1,5 +1,7 @@
 AllCops:
   TargetRubyVersion: 2.6
+  NewCops: enable
+  SuggestExtensions: false
   Exclude:
     - 'test/*'
 

data/.ruby-version

@@ -0,0 +1 @@
+2.7.6

data/CHANGELOG.md

@@ -8,3 +8,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [0.1.0] - 2022-10-25
 - Initial release
+
+## [0.2.0] - 2022-10-27
+- Add support for my_method?
+- Add support for my_method! 
+- Allow POROs with same-name class and instance methods to jobify class methods
+
+## [0.3.0] - 2022-11-13
+- Add support for private methods

data/Gemfile

@@ -6,7 +6,3 @@ source "https://rubygems.org"
 gemspec
 
 gem "rake", "~> 13.0"
-
-gem "minitest", "~> 5.0"
-
-gem "rubocop", "~> 1.21"

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    jobify (0.1.0)
+    jobify (0.3.0)
       activejob
       activesupport
 
@@ -31,14 +31,14 @@ GEM
     rake (13.0.6)
     regexp_parser (2.6.0)
     rexml (3.2.5)
-    rubocop (1.37.0)
+    rubocop (1.38.0)
       json (~> 2.3)
       parallel (~> 1.10)
       parser (>= 3.1.2.1)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.22.0, < 2.0)
+      rubocop-ast (>= 1.23.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 3.0)
     rubocop-ast (1.23.0)
@@ -50,6 +50,7 @@ GEM
 
 PLATFORMS
   x86_64-darwin-20
+  x86_64-darwin-21
   x86_64-linux
 
 DEPENDENCIES
@@ -59,4 +60,4 @@ DEPENDENCIES
   rubocop (~> 1.21)
 
 BUNDLED WITH
-   2.3.14
+   2.3.18

data/jobify.gemspec

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+require_relative "lib/jobify/version"
+
+Gem::Specification.new do |spec|
+  spec.name = "jobify"
+  spec.version = Jobify::VERSION
+  spec.authors = ["Søren Houen"]
+  spec.email = ["s@houen.net"]
+
+  spec.summary = "Turn any method into a background job (`jobify :hello_world` generates `def perform_hello_world_later`"
+  spec.homepage = "https://github.com/houen/jobify"
+
+  spec.license = "MIT"
+  spec.required_ruby_version = ">= 2.6.0"
+
+  spec.metadata["allowed_push_host"] = "https://rubygems.org"
+
+  spec.metadata["homepage_uri"] = spec.homepage
+  spec.metadata["source_code_uri"] = "https://github.com/houen/jobify"
+  spec.metadata["changelog_uri"] = "https://github.com/houen/jobify/CHANGELOG.md"
+
+  # Specify which files should be added to the gem when it is released.
+  # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
+  spec.files = Dir.chdir(__dir__) do
+    `git ls-files -z`.split("\x0").reject do |f|
+      (f == __FILE__) || f.match(%r{\A(?:(?:bin|test|spec|features)/|\.(?:git|travis|circleci)|appveyor)})
+    end
+  end
+  spec.bindir = "exe"
+  spec.executables = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
+  spec.require_paths = ["lib"]
+
+  # Uncomment to register a new dependency of your gem
+  spec.add_dependency "activejob"
+  spec.add_dependency "activesupport"
+  
+  spec.add_development_dependency "minitest", "~> 5.0"
+  spec.add_development_dependency "rubocop", "~> 1.21"
+
+  # For more information and examples about making a new gem, check out our
+  # guide at: https://bundler.io/guides/creating_gem.html
+  spec.metadata["rubygems_mfa_required"] = "true"
+end

data/lib/jobify/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Jobify
-  VERSION = "0.1.1"
+  VERSION = "0.3.0"
 end

data/lib/jobify.rb

@@ -17,33 +17,43 @@ module Jobify
 
   included do
     @jobified_methods = {
-      instance: {},
+      instance:  {},
       singleton: {}
     }
 
-    def self.jobify(method_name, job_method_name: "perform_#{method_name}_later")
+    def self.jobify(method_name, job_method_name: nil)
       raise "method name cannot be blank" if method_name.blank?
 
-      method_name = method_name.to_s
+      method_name     = method_name.to_s
+      job_method_name = job_method_name(method_name, job_method_name)
 
-      if method_defined?(method_name) && !@jobified_methods[:instance][method_name]
+      if has_class_method?(method_name) && !@jobified_methods[:singleton][method_name]
+        # Class methods are jobified first,
+        # so that class methods can be jobified by POROs with same-name instance methods
+        params = method(method_name).parameters
+        _define_job_class(method_name, job_method_name, params, singleton_method: true)
+        @jobified_methods[:singleton][method_name] = true
+      elsif has_instance_method?(method_name) && !@jobified_methods[:instance][method_name]
         # Instance method
         params = instance_method(method_name).parameters
-        _define_job_class(method_name, job_method_name, params, false)
+        _define_job_class(method_name, job_method_name, params, singleton_method: false)
         @jobified_methods[:instance][method_name] = true
-      elsif respond_to?(method_name) && !@jobified_methods[:singleton][method_name]
-        # Singleton method (Class method)
-        params = method(method_name).parameters
-        _define_job_class(method_name, job_method_name, params, true)
-        @jobified_methods[:singleton][method_name] = true
       end
     end
 
-    def self._define_job_class(method_name, job_method_name, params, singleton_method)
-      job_class_name = singleton_method ? "JobifyClassMethod_#{method_name}_Job" : "JobifyInstanceMethod_#{method_name}_Job"
-      parent_class = defined?(ApplicationJob) ? ApplicationJob : ActiveJob::Base
-      job_class    = Class.new(parent_class)
-      caller_class = self
+    def self.job_method_name(method_name, job_method_name)
+      return method_name unless job_method_name.nil?
+      return "perform_#{method_name[0..-2]}_later?" if method_name.end_with?('?')
+      return "perform_#{method_name[0..-2]}_later!" if method_name.end_with?('!')
+      "perform_#{method_name}_later"
+    end
+
+    def self._define_job_class(method_name, job_method_name, params, singleton_method:)
+      method_name_for_class_constant = method_name.gsub('?', '_question_').gsub('!', '_bang_')
+      job_class_name                 = singleton_method ? "JobifyClassMethod_#{method_name_for_class_constant}_Job" : "JobifyInstanceMethod_#{method_name_for_class_constant}_Job"
+      parent_class                   = defined?(ApplicationJob) ? ApplicationJob : ActiveJob::Base
+      job_class                      = Class.new(parent_class)
+      caller_class                   = self
       const_set(job_class_name, job_class)
 
       # Define perform method on job class
@@ -59,9 +69,9 @@ module Jobify
     def self.singleton__define_job_perform_method(job_class, caller_class, method_name)
       job_class.define_method(:perform) do |*args, **kw_args|
         if kw_args.empty?
-          caller_class.public_send(method_name, *args)
+          caller_class.send(method_name, *args)
         else
-          caller_class.public_send(method_name, *args, **kw_args)
+          caller_class.send(method_name, *args, **kw_args)
         end
       end
     end
@@ -88,7 +98,7 @@ module Jobify
         raise "Something has gone wrong. Record id is required" unless id
 
         record = caller_class.find(id)
-        record.public_send(method_name, *args, **kw_args)
+        record.send(method_name, *args, **kw_args)
       end
     end
 
@@ -129,5 +139,14 @@ module Jobify
     def ensure_all_args_present!(req_args, args)
       self.class.ensure_all_args_present!(req_args, args)
     end
+
+    def self.has_class_method?(method_name)
+      respond_to?(method_name, true)
+    end
+
+    def self.has_instance_method?(method_name)
+      method_defined?(method_name) || private_method_defined?(method_name)
+    end
+
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: jobify
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.3.0
 platform: ruby
 authors:
 - Søren Houen
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-10-26 00:00:00.000000000 Z
+date: 2022-11-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob
@@ -38,6 +38,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.21'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.21'
 description:
 email:
 - s@houen.net
@@ -46,12 +74,14 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".rubocop.yml"
+- ".ruby-version"
 - CHANGELOG.md
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile
+- jobify.gemspec
 - lib/jobify.rb
 - lib/jobify/version.rb
 - sig/jobify.rbs
@@ -63,6 +93,7 @@ metadata:
   homepage_uri: https://github.com/houen/jobify
   source_code_uri: https://github.com/houen/jobify
   changelog_uri: https://github.com/houen/jobify/CHANGELOG.md
+  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -78,7 +109,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.32
+rubygems_version: 3.1.6
 signing_key:
 specification_version: 4
 summary: Turn any method into a background job (`jobify :hello_world` generates `def