jobify 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: aa64c39d98c548e4f10f34c979871bf027a20f551b9b17d4c6961ea4288a7896
-  data.tar.gz: 784be3e225ff0a7405d315d799bb8b8d30e612fd5bc8a8b0fb765302c6099cd0
+  metadata.gz: befabb328f9f8f32e568d4042eea00aa168159e586a8b536ebe461fd534cc356
+  data.tar.gz: 6e5a56168fd43ce015f2859108ea51f57440c3b71422c5ff6d2f4c56e290cbc8
 SHA512:
-  metadata.gz: f04966afa10e6d96dd9dbf6cb728d654c46bf3041bfbca4048dde85eb134894288b5e57a3642ff114f67a820fa8189853b97f692bc22a6ce4b7901a8d43ea84e
-  data.tar.gz: a6a86a55a01e7c465722ae779b9e6466c579a4731c074635d821b73ebbde7dc2ed453e0d52269149aa8d79561a08e8c3143905ff6e900986681913d7348fbaef
+  metadata.gz: 5f14cc62d1e8cf7aa53635d1ce346cd10b4a1949d959295489b9e0a86d461fed9165f42ed36965292356fa93d8bd7c1f7bbb7652cca8daca76ace6d5e38386cd
+  data.tar.gz: 3928441745d55e247e45c398b14688d8926dd49d1c3e01fb4ff972e3346b3e489ec367ad47cef8e6e1f60e7095067184cd5dc35139e0b535642d1ad9582fcdc8

data/.rubocop.yml

@@ -1,5 +1,7 @@
 AllCops:
   TargetRubyVersion: 2.6
+  NewCops: enable
+  SuggestExtensions: false
   Exclude:
     - 'test/*'
 

data/CHANGELOG.md

@@ -8,3 +8,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [0.1.0] - 2022-10-25
 - Initial release
+
+## [0.2.0] - 2022-10-27
+- Add support for my_method?
+- Add support for my_method! 
+- Allow POROs with same-name class and instance methods to jobify class methods

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    jobify (0.1.0)
+    jobify (0.2.0)
       activejob
       activesupport
 

data/jobify.gemspec

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+require_relative "lib/jobify/version"
+
+Gem::Specification.new do |spec|
+  spec.name = "jobify"
+  spec.version = Jobify::VERSION
+  spec.authors = ["Søren Houen"]
+  spec.email = ["s@houen.net"]
+
+  spec.summary = "Turn any method into a background job (`jobify :hello_world` generates `def perform_hello_world_later`"
+  spec.homepage = "https://github.com/houen/jobify"
+
+  spec.license = "MIT"
+  spec.required_ruby_version = ">= 2.6.0"
+
+  spec.metadata["allowed_push_host"] = "https://rubygems.org"
+
+  spec.metadata["homepage_uri"] = spec.homepage
+  spec.metadata["source_code_uri"] = "https://github.com/houen/jobify"
+  spec.metadata["changelog_uri"] = "https://github.com/houen/jobify/CHANGELOG.md"
+
+  # Specify which files should be added to the gem when it is released.
+  # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
+  spec.files = Dir.chdir(__dir__) do
+    `git ls-files -z`.split("\x0").reject do |f|
+      (f == __FILE__) || f.match(%r{\A(?:(?:bin|test|spec|features)/|\.(?:git|travis|circleci)|appveyor)})
+    end
+  end
+  spec.bindir = "exe"
+  spec.executables = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
+  spec.require_paths = ["lib"]
+
+  # Uncomment to register a new dependency of your gem
+  spec.add_dependency "activejob"
+  spec.add_dependency "activesupport"
+
+  # For more information and examples about making a new gem, check out our
+  # guide at: https://bundler.io/guides/creating_gem.html
+  spec.metadata["rubygems_mfa_required"] = "true"
+end

data/lib/jobify/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Jobify
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

data/lib/jobify.rb

@@ -17,33 +17,43 @@ module Jobify
 
   included do
     @jobified_methods = {
-      instance: {},
+      instance:  {},
       singleton: {}
     }
 
-    def self.jobify(method_name, job_method_name: "perform_#{method_name}_later")
+    def self.jobify(method_name, job_method_name: nil)
       raise "method name cannot be blank" if method_name.blank?
 
-      method_name = method_name.to_s
+      method_name     = method_name.to_s
+      job_method_name = job_method_name(method_name, job_method_name)
 
-      if method_defined?(method_name) && !@jobified_methods[:instance][method_name]
+      if respond_to?(method_name) && !@jobified_methods[:singleton][method_name]
+        # Class methods are jobified first,
+        # so that class methods can be jobified by POROs with same-name instance methods
+        params = method(method_name).parameters
+        _define_job_class(method_name, job_method_name, params, singleton_method: true)
+        @jobified_methods[:singleton][method_name] = true
+      elsif method_defined?(method_name) && !@jobified_methods[:instance][method_name]
         # Instance method
         params = instance_method(method_name).parameters
-        _define_job_class(method_name, job_method_name, params, false)
+        _define_job_class(method_name, job_method_name, params, singleton_method: false)
         @jobified_methods[:instance][method_name] = true
-      elsif respond_to?(method_name) && !@jobified_methods[:singleton][method_name]
-        # Singleton method (Class method)
-        params = method(method_name).parameters
-        _define_job_class(method_name, job_method_name, params, true)
-        @jobified_methods[:singleton][method_name] = true
       end
     end
 
-    def self._define_job_class(method_name, job_method_name, params, singleton_method)
-      job_class_name = singleton_method ? "JobifyClassMethod_#{method_name}_Job" : "JobifyInstanceMethod_#{method_name}_Job"
-      parent_class = defined?(ApplicationJob) ? ApplicationJob : ActiveJob::Base
-      job_class    = Class.new(parent_class)
-      caller_class = self
+    def self.job_method_name(method_name, job_method_name)
+      return method_name unless job_method_name.nil?
+      return "perform_#{method_name[0..-2]}_later?" if method_name.end_with?('?')
+      return "perform_#{method_name[0..-2]}_later!" if method_name.end_with?('!')
+      "perform_#{method_name}_later"
+    end
+
+    def self._define_job_class(method_name, job_method_name, params, singleton_method:)
+      method_name_for_class_constant = method_name.gsub('?', '_question_').gsub('!', '_bang_')
+      job_class_name                 = singleton_method ? "JobifyClassMethod_#{method_name_for_class_constant}_Job" : "JobifyInstanceMethod_#{method_name_for_class_constant}_Job"
+      parent_class                   = defined?(ApplicationJob) ? ApplicationJob : ActiveJob::Base
+      job_class                      = Class.new(parent_class)
+      caller_class                   = self
       const_set(job_class_name, job_class)
 
       # Define perform method on job class

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: jobify
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Søren Houen
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-10-26 00:00:00.000000000 Z
+date: 2022-10-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob
@@ -52,6 +52,7 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- jobify.gemspec
 - lib/jobify.rb
 - lib/jobify/version.rb
 - sig/jobify.rbs
@@ -63,6 +64,7 @@ metadata:
   homepage_uri: https://github.com/houen/jobify
   source_code_uri: https://github.com/houen/jobify
   changelog_uri: https://github.com/houen/jobify/CHANGELOG.md
+  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -82,5 +84,5 @@ rubygems_version: 3.2.32
 signing_key:
 specification_version: 4
 summary: Turn any method into a background job (`jobify :hello_world` generates `def
-  hello_world_job`
+  perform_hello_world_later`
 test_files: []