jobba 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5188a37939c0f9b306f0d98e01dfb9abf6ef3a31
-  data.tar.gz: 9cc2a58ff46d55c13aa25bec9e98b395916fd13b
+  metadata.gz: f867ae880d3339b25e987267ac135429ee2fb80e
+  data.tar.gz: 3882b0e610200fe6b2c119dc46efe37261dea455
 SHA512:
-  metadata.gz: 8f6d7780ac4361ba25a5f73f4a1df1746c6954e947497fcb6e1f97d6b9d5c360d891835fd12cb2f09f52c557d9abc304a881b5fd3e40131c3ad7521a812d1a6a
-  data.tar.gz: e7fec3fbfd1e73496816907efbc28723daa1d148180b1cda7e71ec47ec176a5cbf4280be40491b751ed59a86a7fe35d7736a146b902dfe3a9a85851c90fcf8b9
+  metadata.gz: 369cddf40dd02571641bd114043f8f70f74ba6b0803d191893a79f7375c40bfaa8114436fbabcbc95986d231491d4f86979af90564e8b284608f7cdad46b5553
+  data.tar.gz: 966e2fc051cd4d8c5f5c9a2abebb4286aa9960cfad46d77ca52bdbe06351bf92945963c1c3d7d0cf9694b3fe6b84ccfe7b0610cef169a125dbbfb1aaa251cbe4

data/README.md

@@ -1,5 +1,6 @@
 # jobba
 
+[![Gem Version](https://badge.fury.io/rb/jobba.svg)](http://badge.fury.io/rb/jobba)
 [![Build Status](https://travis-ci.org/openstax/jobba.svg?branch=master)](https://travis-ci.org/openstax/jobba)
 [![Code Climate](https://codeclimate.com/github/openstax/jobba/badges/gpa.svg)](https://codeclimate.com/github/openstax/jobba)
 
@@ -145,6 +146,8 @@ my_status.save({a: 'blah', b: [1,2,3]})
 my_status.save("some string")
 ```
 
+Note that if you `save` a hash with symbol keys it will be converted to string keys.  In fact, any argument passed in to `save` will be converted to JSON and parsed back so that the `data` attribute returns the same thing regardless of if `data` is retrieved immediately after being set or after being loaded from Redis.
+
 ## Setting Job Name and Arguments
 
 If you want to be able to query for all statuses for a certain kind of job, you can set the job's name in the status:

data/lib/jobba/status.rb

@@ -128,7 +128,8 @@ module Jobba
     # end
 
     def save(data)
-      set(data: data)
+      normalized_data = JSON.parse(data.to_json, quirks_mode: true)
+      set(data: normalized_data)
     end
 
     def delete
@@ -193,16 +194,12 @@ module Jobba
 
       @json_encoded_attrs = attrs[:raw]
 
-      if !@json_encoded_attrs.nil? && !@json_encoded_attrs.empty?
-        @json_encoded_attrs['data'] ||= "{}"
-        @json_encoded_attrs['job_args'] ||= "{}"
-      else
+      if @json_encoded_attrs.nil? || @json_encoded_attrs.empty?
         @id       = attrs[:id]       || attrs['id']       || SecureRandom.uuid
         @state    = attrs[:state]    || attrs['state']    || State::UNKNOWN
         @progress = attrs[:progress] || attrs['progress'] || 0
         @errors   = attrs[:errors]   || attrs['errors']   || []
         @data     = attrs[:data]     || attrs['data']     || {}
-        @job_args = OpenStruct.new # TODO need this and the above job args init?
 
         if attrs[:persist]
           redis.multi do
@@ -249,9 +246,7 @@ module Jobba
 
     def set_hash_in_redis(hash)
       redis_key_value_array =
-        hash.to_a
-            .collect{|kv_array| [kv_array[0], kv_array[1].to_json]}
-            .flatten(1)
+        hash.to_a.flat_map{|kv_array| [kv_array[0], kv_array[1].to_json]}
 
       Jobba.redis.hmset(job_key, *redis_key_value_array)
     end

data/lib/jobba/version.rb

@@ -1,3 +1,3 @@
 module Jobba
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: jobba
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - JP Slavinsky