job_notifier 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c8937d5be6261a37e48eb27ab905ad9b93eb196c
-  data.tar.gz: b72d27da476103948cc7da671edbd3c5deb583ff
+  metadata.gz: e2d266e944b8ab6515fa0fbc7f09e7e014114f9f
+  data.tar.gz: 647d49a7ea0f74b637b986c13d244160c1a6a495
 SHA512:
-  metadata.gz: 3570373e7c9bd76cc1508e6a494f7429d00fee041e33a4cc37a1c6a1843d481b3095b96afde0272e7c572774e4c1b8e808a58a5b7aefcdc06fa8f499d95dd065
-  data.tar.gz: f7fd01921da169626cf55b57149dfcabe68b5010210e7b5e064a6644eda05db5539451773f81fa87651c12607834095f85dfb0104918ba477acf619b8bd0cf21
+  metadata.gz: 1ed5a51e7747e06e25e68baaeb877caefa6c069e7c8974324bad70d885043782fc67af6bc3ec9a49eb03536f6e6919ade51402ac9f41af53c478731a43ef792e
+  data.tar.gz: 0e0c35136b45e10b8d1544b47aab38567b707e3eaf748f424b0c14b77eb5d418132ca342ad325862e8cfd56b4700c56f0d0a497206153adcf26f4d0e1c140108

data/CHANGELOG.md

@@ -2,6 +2,12 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+### v1.1.1
+
+#### Fixed
+
+- Use silencer gem to ensure ActiveRecord's log is silenced too.
+
 ### v1.1.0
 
 #### Added

data/Gemfile.lock

@@ -1,10 +1,11 @@
 PATH
   remote: .
   specs:
-    job_notifier (1.1.0)
+    job_notifier (1.1.1)
       colorize (~> 0.7, >= 0.7.7)
       enumerize (~> 1.0.0, ~> 1.0)
       rails (~> 4.2, >= 4.2.0)
+      silencer (= 1.0.0.rc3)
 
 GEM
   remote: https://rubygems.org/
@@ -123,6 +124,7 @@ GEM
       rspec-mocks (~> 3.4.0)
       rspec-support (~> 3.4.0)
     rspec-support (3.4.1)
+    silencer (1.0.0.rc3)
     slop (3.6.0)
     sprockets (3.6.3)
       concurrent-ruby (~> 1.0)

data/job_notifier.gemspec

@@ -20,6 +20,7 @@ Gem::Specification.new do |s|
   s.add_dependency "rails", "~> 4.2", ">= 4.2.0"
   s.add_dependency "enumerize", "~> 1.0", "~> 1.0.0"
   s.add_dependency "colorize", "~> 0.7", ">= 0.7.7"
+  s.add_dependency "silencer", "1.0.0.rc3"
 
   s.add_development_dependency "pry"
   s.add_development_dependency "sqlite3"

data/lib/job_notifier/engine.rb

@@ -20,7 +20,9 @@ module JobNotifier
         helper(JobNotifier::ApplicationHelper)
       end
 
-      Rails.application.middleware.swap(Rails::Rack::Logger, JobNotifier::Logger)
+      Rails.application.middleware.swap(
+        Rails::Rack::Logger, Silencer::Logger, silence: [%r{\/job_notifier\/\w+\/jobs\/\w+.json}])
+      Rails.application.middleware.insert_before(Silencer::Logger, JobNotifier::Logger)
     end
   end
 end

data/lib/job_notifier/logger.rb

@@ -1,23 +1,19 @@
 module JobNotifier
-  class Logger < Rails::Rack::Logger
-    def initialize(app, opts = {})
+  class Logger
+    def initialize(app)
       @app = app
-      @opts = opts
-      super
     end
 
     def call(env)
-      if env["PATH_INFO"] =~ %r{\/job_notifier\/\w+\/jobs\/\w+.json}
-        Rails.logger.silence do
-          response = @app.call(env)
-          log_jobs_info(response[2])
-          return response
-        end
-      end
-
-      super(env)
+      response = @app.call(env)
+      status = response[0]
+      return response if status != 200
+      log_jobs_info(response[2]) if env["PATH_INFO"] =~ %r{\/\w+\/jobs\/\w+.json}
+      response
     end
 
+    private
+
     def log_jobs_info(response)
       response.each do |resp|
         next if resp.blank?
@@ -28,7 +24,7 @@ module JobNotifier
     end
 
     def build_log_msg(result)
-      msg = ["[#{DateTime.now.strftime('%Y-%m-%d %H:%M:%S')}] UNNOTIFIED JOBS".light_blue]
+      msg = ["[#{DateTime.now.strftime('%Y-%m-%d %H:%M:%S')}] JOBS".light_blue]
       grouped_jobs = result.group_by { |job| job["status"].to_sym }
       load_job_status_msg(grouped_jobs, msg, :pending, :yellow)
       load_job_status_msg(grouped_jobs, msg, :finished, :green)

data/lib/job_notifier/version.rb

@@ -1,3 +1,3 @@
 module JobNotifier
-  VERSION = "1.1.0"
+  VERSION = "1.1.1"
 end

data/lib/job_notifier.rb

@@ -1,6 +1,7 @@
 require "job_notifier/engine"
 require "enumerize"
 require "colorize"
+require "silencer"
 
 module JobNotifier
   extend self

data/spec/dummy/log/development.log

@@ -369597,3 +369597,38 @@ Started GET "/assets/application.self-00f52a752e66e73821cdcccac85802deae74aaa390
    (0.1ms)  begin transaction
   SQL (0.4ms)  INSERT INTO "job_notifier_jobs" ("identifier", "status", "created_at", "updated_at") VALUES (?, ?, ?, ?)  [["identifier", "47d959691e12f7fd6f32d1030f848819"], ["status", "failed"], ["created_at", "2016-07-17 02:39:37.110001"], ["updated_at", "2016-07-17 02:39:37.110001"]]
    (1.5ms)  commit transaction
+
+
+Started GET "/" for ::1 at 2016-07-16 23:55:00 -0300
+Processing by HomeController#index as HTML
+  JobNotifier::Job Load (0.2ms)  SELECT  "job_notifier_jobs".* FROM "job_notifier_jobs" WHERE "job_notifier_jobs"."identifier" = ? LIMIT 1  [["identifier", "47d959691e12f7fd6f32d1030f848819"]]
+  Rendered home/index.html.erb within layouts/application (1.3ms)
+Completed 200 OK in 240ms (Views: 190.1ms | ActiveRecord: 1.7ms)
+
+
+Started GET "/assets/application.self-e80e8f2318043e8af94dddc2adad5a4f09739a8ebb323b3ab31cd71d45fd9113.css?body=1" for ::1 at 2016-07-16 23:55:01 -0300
+
+
+Started GET "/assets/application.self-00f52a752e66e73821cdcccac85802deae74aaa390c44b49cf7569827f45aecb.js?body=1" for ::1 at 2016-07-16 23:55:01 -0300
+
+
+Started GET "/assets/job_notifier/notifier.self-aac4f869560ebd6c31292b7adb578f3b459fd7744c6f63f699a318ab39fa7f9c.js?body=1" for ::1 at 2016-07-16 23:55:01 -0300
+
+
+Started GET "/" for ::1 at 2016-07-16 23:55:10 -0300
+Processing by HomeController#index as HTML
+  JobNotifier::Job Load (0.1ms)  SELECT  "job_notifier_jobs".* FROM "job_notifier_jobs" WHERE "job_notifier_jobs"."identifier" = ? LIMIT 1  [["identifier", "47d959691e12f7fd6f32d1030f848819"]]
+  Rendered home/index.html.erb within layouts/application (0.1ms)
+Completed 200 OK in 12ms (Views: 11.1ms | ActiveRecord: 0.1ms)
+
+
+Started GET "/assets/application.self-00f52a752e66e73821cdcccac85802deae74aaa390c44b49cf7569827f45aecb.js?body=1" for ::1 at 2016-07-16 23:55:11 -0300
+
+
+Started GET "/assets/application.self-e80e8f2318043e8af94dddc2adad5a4f09739a8ebb323b3ab31cd71d45fd9113.css?body=1" for ::1 at 2016-07-16 23:55:11 -0300
+
+
+Started GET "/assets/job_notifier/notifier.self-aac4f869560ebd6c31292b7adb578f3b459fd7744c6f63f699a318ab39fa7f9c.js?body=1" for ::1 at 2016-07-16 23:55:11 -0300
+   (0.1ms)  begin transaction
+  SQL (1.3ms)  INSERT INTO "job_notifier_jobs" ("identifier", "status", "created_at", "updated_at") VALUES (?, ?, ?, ?)  [["identifier", "47d959691e12f7fd6f32d1030f848819"], ["status", "pending"], ["created_at", "2016-07-17 15:05:51.134740"], ["updated_at", "2016-07-17 15:05:51.134740"]]
+   (0.6ms)  commit transaction