job_notifier 1.1.0 → 1.1.1

data/spec/lib/job_notifier/adapters_spec.rb

@@ -6,8 +6,10 @@ RSpec.describe JobNotifier::Adapters do
   end
 
   describe "#get_adapter_path" do
-    it { expect(subject.get_adapter_path("notifier").to_s).to match(
-      "app/assets/javascripts/job_notifier/notifier.js") }
+    it do
+      expect(subject.get_adapter_path("notifier").to_s).to match(
+        "app/assets/javascripts/job_notifier/notifier.js")
+    end
 
     it "raises error with invalid adapter" do
       expect { subject.get_adapter_path("invalid") } .to raise_error(

data/spec/lib/job_notifier/logger_spec.rb

@@ -0,0 +1,79 @@
+require "rails_helper"
+
+RSpec.describe JobNotifier::Logger do
+  describe "#call" do
+    let(:status) { 200 }
+    let(:result) do
+      [
+        [
+          { "status" => "pending" },
+          { "status" => "pending" },
+          { "status" => "finished" },
+          { "status" => "failed" }
+        ].to_json.to_s
+      ]
+    end
+    let(:response) { [status, nil, result] }
+
+    let(:env) { { "PATH_INFO" => "/job_notifier/XXX/jobs/pending.json" } }
+    let(:app) { double(:app, call: response) }
+
+    let(:logger) { described_class.new(app) }
+
+    before { allow(DateTime).to receive(:now).and_return("1984-06-04 10:00:00".to_datetime) }
+
+    RSpec.shared_examples "invalid candidate for logging" do
+      it "does not write log info" do
+        allow(logger).to receive(:log_jobs_info)
+        logger.call(env)
+        expect(logger).not_to have_received(:log_jobs_info)
+      end
+
+      it { expect(logger.call(env)).to eq(response) }
+    end
+
+    RSpec.shared_examples "invalid request result" do
+      it "calls logger with result" do
+        allow(logger).to receive(:log_jobs_info)
+        logger.call(env)
+        expect(logger).to have_received(:log_jobs_info).with(result)
+      end
+
+      it "does not build log msg" do
+        allow(logger).to receive(:build_log_msg)
+        logger.call(env)
+        expect(logger).not_to have_received(:build_log_msg)
+      end
+
+      it { expect(logger.call(env)).to eq(response) }
+    end
+
+    context "with other than 200 status" do
+      let(:status) { 500 }
+      it_behaves_like("invalid candidate for logging")
+    end
+
+    context "with invalid path info" do
+      let(:env) { { "PATH_INFO" => "/invalid/path" }  }
+      it_behaves_like("invalid candidate for logging")
+    end
+
+    context "with blank result" do
+      let(:result) { [""] }
+      it_behaves_like("invalid request result")
+    end
+
+    context "with empty array result" do
+      let(:result) { ["[]"] }
+      it_behaves_like("invalid request result")
+    end
+
+    it "prints log" do
+      out = "\e[0;94;49m[1984-06-04 10:00:00] JOBS\e[0m  \e[0;33;49mPending: 2\e[0m  \
+\e[0;32;49mFinished: 1\e[0m  \e[0;31;49mFailed: 1\e[0m\n"
+      expect { logger.call(env) }.to output(out).to_stdout
+    end
+
+    it { expect(logger.call(env)).to eq(response) }
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: job_notifier
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Platanus
@@ -72,6 +72,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.7.7
+- !ruby/object:Gem::Dependency
+  name: silencer
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.0.0.rc3
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.0.0.rc3
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -539,10 +553,10 @@ files:
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/zOXm0fB3RP5lEZn8K0XLe2Fb2FA_lBFW82FCmFjpvpY.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/zQ/zQTqJeOz-Koa7PhvVTyhn-cid6B6Ws-h8MHTOrRpW70.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/zyjOXS82e6TASMmjcGsoBMiZ3uxt7D8DLxVHPvajMDU.cache
-- spec/dummy/tmp/pids/server.pid
 - spec/factories/job_notifier_jobs.rb
 - spec/lib/job_notifier/adapters_spec.rb
 - spec/lib/job_notifier/identifier_spec.rb
+- spec/lib/job_notifier/logger_spec.rb
 - spec/lib/job_notifier/notifier_spec.rb
 - spec/models/job_notifier/job_spec.rb
 - spec/rails_helper.rb
@@ -939,10 +953,10 @@ test_files:
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/zOXm0fB3RP5lEZn8K0XLe2Fb2FA_lBFW82FCmFjpvpY.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/zQ/zQTqJeOz-Koa7PhvVTyhn-cid6B6Ws-h8MHTOrRpW70.cache
 - spec/dummy/tmp/cache/assets/sprockets/v3.0/zyjOXS82e6TASMmjcGsoBMiZ3uxt7D8DLxVHPvajMDU.cache
-- spec/dummy/tmp/pids/server.pid
 - spec/factories/job_notifier_jobs.rb
 - spec/lib/job_notifier/adapters_spec.rb
 - spec/lib/job_notifier/identifier_spec.rb
+- spec/lib/job_notifier/logger_spec.rb
 - spec/lib/job_notifier/notifier_spec.rb
 - spec/models/job_notifier/job_spec.rb
 - spec/rails_helper.rb

data/spec/dummy/tmp/pids/server.pid

@@ -1 +0,0 @@
-52012