job-workflow 0.6.0 → 0.6.2

data/lib/job_workflow/monitoring/dag_layout.rb

@@ -3,6 +3,10 @@
 module JobWorkflow
   module Monitoring
     class DagLayout
+      # @rbs @nodes: Array[Hash[Symbol, untyped]]
+      # @rbs @edges: Array[Hash[Symbol, untyped]]
+      # @rbs @node_positions: Hash[Symbol, Hash[Symbol, Integer]]
+
       NODE_WIDTH = 224
       NODE_HEIGHT = 84
       COLUMN_GAP = 56

data/lib/job_workflow/monitoring/execution_view_model.rb

@@ -3,6 +3,10 @@
 module JobWorkflow
   module Monitoring
     class ExecutionViewModel
+      # @rbs @tasks: Array[Hash[Symbol, untyped]]
+      # @rbs @failed_task_name: Symbol?
+      # @rbs @dag_layout: Hash[Symbol, untyped]
+
       attr_reader :job_id #: String
       attr_reader :queue_name #: String?
       attr_reader :status #: WorkflowStatus
@@ -87,16 +91,17 @@ module JobWorkflow
       #:  (Symbol, Array[TaskOutput], Array[TaskJobStatus]) -> Symbol
       def task_status(task_name, task_outputs, task_job_statuses)
         return :failed if task_job_statuses.any?(&:failed?)
-        return :succeeded if completed_task?(task_outputs, task_job_statuses)
+        return :succeeded if completed_task?(task_name, task_outputs, task_job_statuses)
         return :running if task_running?(task_name, task_job_statuses)
 
         :pending
       end
 
-      #:  (Array[TaskOutput], Array[TaskJobStatus]) -> bool
-      def completed_task?(task_outputs, task_job_statuses)
+      #:  (Symbol, Array[TaskOutput], Array[TaskJobStatus]) -> bool
+      def completed_task?(task_name, task_outputs, task_job_statuses)
         return true if !running? && task_outputs.any?
         return task_job_statuses.all?(&:succeeded?) if task_job_statuses.any?
+        return true if status.completed_task_names.include?(task_name)
 
         task_outputs.any?
       end
@@ -141,12 +146,7 @@ module JobWorkflow
       end
 
       #:  (Symbol) -> [Array[TaskOutput], Array[TaskJobStatus]]
-      def task_state(task_name)
-        [
-          status.output.fetch_all(task_name:),
-          status.job_status.fetch_all(task_name:)
-        ]
-      end
+      def task_state(task_name) = [status.output.fetch_all(task_name:), status.job_status.fetch_all(task_name:)]
 
       #:  (Task) -> Hash[Symbol, untyped]
       def task_configuration(task)
@@ -227,8 +227,8 @@ module JobWorkflow
       def each_progress(task_outputs, task_job_statuses)
         {
           total: [task_outputs.size, task_job_statuses.size].max,
-          succeeded: task_job_statuses.count(&:succeeded?),
-          failed: task_job_statuses.count(&:failed?),
+          succeeded: task_job_statuses.count { |task_job_status| task_job_status.succeeded? }, # rubocop:disable Style/SymbolProc
+          failed: task_job_statuses.count { |task_job_status| task_job_status.failed? }, # rubocop:disable Style/SymbolProc
           pending: task_job_statuses.count { |task_status| task_status.status == :pending },
           running: task_job_statuses.count { |task_status| task_status.status == :running }
         }

data/lib/job_workflow/monitoring.rb

@@ -10,6 +10,9 @@ require_relative "monitoring/execution_registry"
 
 module JobWorkflow
   module Monitoring
+    # @rbs!
+    #   def self.base_controller_class: () -> untyped
+
     mattr_accessor :base_controller_class
 
     class << self
@@ -18,7 +21,7 @@ module JobWorkflow
         WorkflowRegistry.all.map { |job_class| WorkflowDefinition.new(job_class:) }
       end
 
-      #:  (String?, Symbol?) -> String?
+      #:  (String?, ?status: Symbol?) -> String?
       def mission_control_job_path(job_id, status: nil)
         return if job_id.nil?
 

data/lib/job_workflow/queue_adapters/null_adapter.rb

@@ -4,10 +4,15 @@ module JobWorkflow
   module QueueAdapters
     # rubocop:disable Naming/PredicateMethod
     class NullAdapter < Abstract
+      # @rbs @paused_queues: Set[String]
+      # @rbs @queue_jobs: Hash[String, Array[untyped]]
+      # @rbs @stored_jobs: Hash[String, Hash[String, untyped]]
+
       #:  () -> void
       def initialize_adapter!; end
 
-      def initialize # rubocop:disable Lint/MissingSuper
+      #:  () -> void
+      def initialize
         @paused_queues = Set.new #: Set[String]
         @queue_jobs = {} #: Hash[String, Array[untyped]]
         @stored_jobs = {} #: Hash[String, Hash[String, untyped]]

data/lib/job_workflow/sub_task_job.rb

@@ -33,7 +33,8 @@ module JobWorkflow
     def perform(arguments)
       payload = arguments.symbolize_keys
       self._context = build_context(payload)
-      Runner.new(context: _context).run
+      context = _context || (raise "context is not set.")
+      Runner.new(context:).run
     end
 
     #:  () -> Output
@@ -73,7 +74,7 @@ module JobWorkflow
              ._update_arguments(payload.except(:job_workflow_context))
     end
 
-    #:  (job_class_name: String) -> Workflow
+    #:  (String job_class_name) -> Workflow
     def resolve_workflow(job_class_name)
       job_class = JobWorkflow::DSL._included_classes.to_a.reverse.find { |klass| klass.name == job_class_name }
       job_class ||= job_class_name.safe_constantize

data/lib/job_workflow/task_graph.rb

@@ -2,6 +2,8 @@
 
 module JobWorkflow
   class TaskGraph
+    # @rbs @tasks: Hash[Symbol, Task]
+
     include TSort #[Task]
     include Enumerable #[Task]
 

data/lib/job_workflow/task_output.rb

@@ -9,7 +9,9 @@ module JobWorkflow
     class << self
       #:  (task: Task, each_index: Integer, data: Hash[Symbol, untyped]) -> TaskOutput
       def from_task(task:, data:, each_index:)
-        normalized_data = task.output.to_h { |output_def| [output_def.name, nil] }
+        normalized_data = task.output.to_h do |output_def|
+          [output_def.name, nil] #: [Symbol, nil]
+        end
         normalized_data.merge!(data.slice(*normalized_data.keys))
         new(task_name: task.task_name, each_index:, data: normalized_data)
       end

data/lib/job_workflow/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module JobWorkflow
-  VERSION = "0.6.0" # : String
+  VERSION = "0.6.2" # : String
 end

data/lib/job_workflow/workflow.rb

@@ -2,6 +2,11 @@
 
 module JobWorkflow
   class Workflow
+    # @rbs @task_graph: TaskGraph
+    # @rbs @argument_defs: Hash[Symbol, ArgumentDef]
+    # @rbs @hook_registry: HookRegistry
+    # @rbs @schedules: Hash[Symbol, Schedule]
+
     attr_reader :dry_run_config #: DryRunConfig
 
     #:  () -> void
@@ -70,7 +75,9 @@ module JobWorkflow
 
     #:  () -> Hash[Symbol, untyped]
     def build_arguments_hash
-      arguments.to_h { |def_obj| [def_obj.name, def_obj.default] }
+      arguments.to_h do |def_obj|
+        [def_obj.name, def_obj.default] #: [Symbol, untyped]
+      end
     end
   end
 end

data/lib/job_workflow/workflow_status.rb

@@ -10,6 +10,7 @@ module JobWorkflow
     attr_reader :context #: Context
     attr_reader :job_class_name #: String
     attr_reader :status #: status_type
+    attr_reader :completed_task_names #: Array[Symbol]
 
     class << self
       #:  (String) -> WorkflowStatus
@@ -36,11 +37,22 @@ module JobWorkflow
         workflow = job_class._workflow
         context = context_from_job_data(data, workflow)
 
-        new(context:, job_class_name:, status: data["status"])
+        new(
+          context:,
+          job_class_name:,
+          status: data["status"],
+          completed_task_names: completed_task_names_from_job_data(data)
+        )
       end
 
       private
 
+      #:  (Hash[String, untyped]) -> Array[Symbol]
+      def completed_task_names_from_job_data(data)
+        task_names = Array(data.dig("continuation", "completed")) #: Array[String]
+        task_names.map { |task_name| task_name.to_sym } # rubocop:disable Style/SymbolProc
+      end
+
       #:  (Hash[String, untyped], Workflow) -> Context
       def context_from_job_data(data, workflow)
         context_data = data["job_workflow_context"] || data["arguments"]&.first&.dig("job_workflow_context")
@@ -64,11 +76,17 @@ module JobWorkflow
       end
     end
 
-    #:  (context: Context, job_class_name: String, status: status_type) -> void
-    def initialize(context:, job_class_name:, status:)
+    #:  (
+    #      context: Context,
+    #      job_class_name: String,
+    #      status: status_type,
+    #      ?completed_task_names: Array[Symbol]
+    #    ) -> void
+    def initialize(context:, job_class_name:, status:, completed_task_names: [])
       @context = context #: Context
       @job_class_name = job_class_name #: String
       @status = status #: Symbol
+      @completed_task_names = completed_task_names
     end
 
     #:  () -> Symbol?

data/rbs_collection.lock.yaml

@@ -1,12 +1,36 @@
 ---
 path: ".gem_rbs_collection"
 gems:
+- name: actionpack
+  version: '7.2'
+  source:
+    type: git
+    name: ruby/gem_rbs_collection
+    revision: 2443035126922ee49f775a0edb0b705896fef7c6
+    remote: https://github.com/ruby/gem_rbs_collection.git
+    repo_dir: gems
+- name: actionview
+  version: '6.0'
+  source:
+    type: git
+    name: ruby/gem_rbs_collection
+    revision: 2443035126922ee49f775a0edb0b705896fef7c6
+    remote: https://github.com/ruby/gem_rbs_collection.git
+    repo_dir: gems
 - name: activejob
   version: '6.0'
   source:
     type: git
     name: ruby/gem_rbs_collection
-    revision: 81fa8bd0617286078617a62b6a3229cebfd4af23
+    revision: 2443035126922ee49f775a0edb0b705896fef7c6
+    remote: https://github.com/ruby/gem_rbs_collection.git
+    repo_dir: gems
+- name: activemodel
+  version: '7.1'
+  source:
+    type: git
+    name: ruby/gem_rbs_collection
+    revision: 2443035126922ee49f775a0edb0b705896fef7c6
     remote: https://github.com/ruby/gem_rbs_collection.git
     repo_dir: gems
 - name: activerecord
@@ -14,7 +38,7 @@ gems:
   source:
     type: git
     name: ruby/gem_rbs_collection
-    revision: 81fa8bd0617286078617a62b6a3229cebfd4af23
+    revision: 2443035126922ee49f775a0edb0b705896fef7c6
     remote: https://github.com/ruby/gem_rbs_collection.git
     repo_dir: gems
 - name: activesupport
@@ -22,7 +46,7 @@ gems:
   source:
     type: git
     name: ruby/gem_rbs_collection
-    revision: 81fa8bd0617286078617a62b6a3229cebfd4af23
+    revision: 2443035126922ee49f775a0edb0b705896fef7c6
     remote: https://github.com/ruby/gem_rbs_collection.git
     repo_dir: gems
 - name: base64
@@ -30,11 +54,15 @@ gems:
   source:
     type: rubygems
 - name: bigdecimal
-  version: '4.0'
+  version: 4.1.2
+  source:
+    type: rubygems
+- name: cgi
+  version: '0.5'
   source:
     type: git
     name: ruby/gem_rbs_collection
-    revision: 81fa8bd0617286078617a62b6a3229cebfd4af23
+    revision: 2443035126922ee49f775a0edb0b705896fef7c6
     remote: https://github.com/ruby/gem_rbs_collection.git
     repo_dir: gems
 - name: concurrent-ruby
@@ -42,7 +70,7 @@ gems:
   source:
     type: git
     name: ruby/gem_rbs_collection
-    revision: 81fa8bd0617286078617a62b6a3229cebfd4af23
+    revision: 2443035126922ee49f775a0edb0b705896fef7c6
     remote: https://github.com/ruby/gem_rbs_collection.git
     repo_dir: gems
 - name: connection_pool
@@ -50,7 +78,7 @@ gems:
   source:
     type: git
     name: ruby/gem_rbs_collection
-    revision: 81fa8bd0617286078617a62b6a3229cebfd4af23
+    revision: 2443035126922ee49f775a0edb0b705896fef7c6
     remote: https://github.com/ruby/gem_rbs_collection.git
     repo_dir: gems
 - name: date
@@ -74,7 +102,7 @@ gems:
   source:
     type: git
     name: ruby/gem_rbs_collection
-    revision: 81fa8bd0617286078617a62b6a3229cebfd4af23
+    revision: 2443035126922ee49f775a0edb0b705896fef7c6
     remote: https://github.com/ruby/gem_rbs_collection.git
     repo_dir: gems
 - name: i18n
@@ -82,7 +110,7 @@ gems:
   source:
     type: git
     name: ruby/gem_rbs_collection
-    revision: 81fa8bd0617286078617a62b6a3229cebfd4af23
+    revision: 2443035126922ee49f775a0edb0b705896fef7c6
     remote: https://github.com/ruby/gem_rbs_collection.git
     repo_dir: gems
 - name: json
@@ -90,15 +118,19 @@ gems:
   source:
     type: stdlib
 - name: logger
-  version: '0'
+  version: '1.7'
   source:
-    type: stdlib
+    type: git
+    name: ruby/gem_rbs_collection
+    revision: 2443035126922ee49f775a0edb0b705896fef7c6
+    remote: https://github.com/ruby/gem_rbs_collection.git
+    repo_dir: gems
 - name: minitest
   version: '5.25'
   source:
     type: git
     name: ruby/gem_rbs_collection
-    revision: 81fa8bd0617286078617a62b6a3229cebfd4af23
+    revision: 2443035126922ee49f775a0edb0b705896fef7c6
     remote: https://github.com/ruby/gem_rbs_collection.git
     repo_dir: gems
 - name: monitor
@@ -118,9 +150,21 @@ gems:
   source:
     type: stdlib
 - name: prism
-  version: 1.7.0
+  version: 1.9.0
   source:
     type: rubygems
+- name: rack
+  version: '2.2'
+  source:
+    type: git
+    name: ruby/gem_rbs_collection
+    revision: 2443035126922ee49f775a0edb0b705896fef7c6
+    remote: https://github.com/ruby/gem_rbs_collection.git
+    repo_dir: gems
+- name: random-formatter
+  version: '0'
+  source:
+    type: stdlib
 - name: securerandom
   version: '0'
   source:
@@ -138,13 +182,17 @@ gems:
   source:
     type: git
     name: ruby/gem_rbs_collection
-    revision: 81fa8bd0617286078617a62b6a3229cebfd4af23
+    revision: 2443035126922ee49f775a0edb0b705896fef7c6
     remote: https://github.com/ruby/gem_rbs_collection.git
     repo_dir: gems
 - name: stringio
   version: '0'
   source:
     type: stdlib
+- name: tempfile
+  version: '0'
+  source:
+    type: stdlib
 - name: time
   version: '0'
   source:
@@ -153,6 +201,10 @@ gems:
   version: '0'
   source:
     type: stdlib
+- name: tmpdir
+  version: '0'
+  source:
+    type: stdlib
 - name: tsort
   version: '0'
   source:
@@ -162,7 +214,7 @@ gems:
   source:
     type: git
     name: ruby/gem_rbs_collection
-    revision: 81fa8bd0617286078617a62b6a3229cebfd4af23
+    revision: 2443035126922ee49f775a0edb0b705896fef7c6
     remote: https://github.com/ruby/gem_rbs_collection.git
     repo_dir: gems
 - name: uri

data/rbs_collection.yaml

@@ -10,5 +10,9 @@ path: .gem_rbs_collection
 
 gems:
   - name: net-http
+  - name: actionpack
+  - name: actionview
+  - name: rack
   - name: activerecord
+  - name: activemodel
   - name: tsort

data/sig/generated/controllers/job_workflow/monitoring/application_controller.rbs

@@ -0,0 +1,11 @@
+# Generated from app/controllers/job_workflow/monitoring/application_controller.rb with RBS::Inline
+
+module JobWorkflow
+  module Monitoring
+    # Resolve the host app controller at load time so engine controllers inherit
+    # the app's existing authentication and access control hooks.
+    # @rbs inherits ActionController::Base
+    class ApplicationController < ActionController::Base
+    end
+  end
+end

data/sig/generated/controllers/job_workflow/monitoring/executions_controller.rbs

@@ -0,0 +1,21 @@
+# Generated from app/controllers/job_workflow/monitoring/executions_controller.rb with RBS::Inline
+
+module JobWorkflow
+  module Monitoring
+    class ExecutionsController < ApplicationController
+      @workflow: singleton(DSL)
+
+      @page: ExecutionPage
+
+      @executions: Array[ExecutionViewModel]
+
+      @execution: ExecutionViewModel
+
+      # :  () -> void
+      def index: () -> void
+
+      # :  () -> void
+      def show: () -> void
+    end
+  end
+end

data/sig/generated/controllers/job_workflow/monitoring/workflows_controller.rbs

@@ -0,0 +1,12 @@
+# Generated from app/controllers/job_workflow/monitoring/workflows_controller.rb with RBS::Inline
+
+module JobWorkflow
+  module Monitoring
+    class WorkflowsController < ApplicationController
+      @workflows: Array[WorkflowDefinition]
+
+      # :  () -> void
+      def index: () -> void
+    end
+  end
+end

data/sig/generated/job_workflow/auto_scaling/executor.rbs

@@ -3,6 +3,8 @@
 module JobWorkflow
   module AutoScaling
     class Executor
+      @adapter: Adapter::_InstanceMethods
+
       # :  (Configuration) -> void
       def initialize: (Configuration) -> void
 

data/sig/generated/job_workflow/dsl.rbs

@@ -2,6 +2,8 @@
 
 module JobWorkflow
   module DSL
+    @_context: Context?
+
     extend ActiveSupport::Concern
 
     include ActiveJob::Continuable
@@ -16,6 +18,8 @@ module JobWorkflow
 
     def queue_name: () -> String
 
+    def arguments: () -> Array[untyped]
+
     def set: (Hash[Symbol, untyped]) -> self
 
     def step: (Symbol, ?start: ActiveJob::Continuation::_Succ, ?isolated: bool) -> void

data/sig/generated/job_workflow/instrumentation/opentelemetry_subscriber.rbs

@@ -70,7 +70,8 @@ module JobWorkflow
       # :  (Hash[Symbol, untyped]) -> Array[untyped?]
       def extract_otel_info: (Hash[Symbol, untyped]) -> Array[untyped?]
 
-      def start_span: (untyped name, untyped payload) -> untyped
+      # :  (String, Hash[Symbol, untyped]) -> untyped
+      def start_span: (String, Hash[Symbol, untyped]) -> untyped
 
       # :  (untyped) -> untyped
       def attach_span_context: (untyped) -> untyped

data/sig/generated/job_workflow/logger.rbs

@@ -14,8 +14,7 @@ module JobWorkflow
   #   JobWorkflow.logger.formatter = JobWorkflow::Logger::JsonFormatter.new(log_tags: [:request_id])
   #   ```
   module Logger
-    # :  (ActiveSupport::Logger) -> void
-    attr_writer logger: untyped
+    attr_writer logger: ActiveSupport::Logger
 
     # :  () -> ActiveSupport::Logger
     def logger: () -> ActiveSupport::Logger

data/sig/generated/job_workflow/monitoring/dag_layout.rbs

@@ -3,6 +3,12 @@
 module JobWorkflow
   module Monitoring
     class DagLayout
+      @node_positions: Hash[Symbol, Hash[Symbol, Integer]]
+
+      @edges: Array[Hash[Symbol, untyped]]
+
+      @nodes: Array[Hash[Symbol, untyped]]
+
       NODE_WIDTH: ::Integer
 
       NODE_HEIGHT: ::Integer

data/sig/generated/job_workflow/monitoring/execution_view_model.rbs

@@ -3,6 +3,12 @@
 module JobWorkflow
   module Monitoring
     class ExecutionViewModel
+      @dag_layout: Hash[Symbol, untyped]
+
+      @failed_task_name: Symbol?
+
+      @tasks: Array[Hash[Symbol, untyped]]
+
       attr_reader job_id: String
 
       attr_reader queue_name: String?
@@ -50,8 +56,8 @@ module JobWorkflow
       # :  (Symbol, Array[TaskOutput], Array[TaskJobStatus]) -> Symbol
       def task_status: (Symbol, Array[TaskOutput], Array[TaskJobStatus]) -> Symbol
 
-      # :  (Array[TaskOutput], Array[TaskJobStatus]) -> bool
-      def completed_task?: (Array[TaskOutput], Array[TaskJobStatus]) -> bool
+      # :  (Symbol, Array[TaskOutput], Array[TaskJobStatus]) -> bool
+      def completed_task?: (Symbol, Array[TaskOutput], Array[TaskJobStatus]) -> bool
 
       # :  (Symbol, Array[TaskJobStatus]) -> bool
       def task_running?: (Symbol, Array[TaskJobStatus]) -> bool

data/sig/generated/job_workflow/monitoring.rbs

@@ -2,11 +2,13 @@
 
 module JobWorkflow
   module Monitoring
+    def self.base_controller_class: () -> untyped
+
     # :  () -> Array[WorkflowDefinition]
     def self.workflows: () -> Array[WorkflowDefinition]
 
-    # :  (String?, Symbol?) -> String?
-    def self.mission_control_job_path: (String?, Symbol?) -> String?
+    # :  (String?, ?status: Symbol?) -> String?
+    def self.mission_control_job_path: (String?, ?status: Symbol?) -> String?
 
     # :  () -> String
     def self.resolved_base_controller_class: () -> String

data/sig/generated/job_workflow/queue_adapters/null_adapter.rbs

@@ -4,10 +4,17 @@ module JobWorkflow
   module QueueAdapters
     # rubocop:disable Naming/PredicateMethod
     class NullAdapter < Abstract
+      @stored_jobs: Hash[String, Hash[String, untyped]]
+
+      @queue_jobs: Hash[String, Array[untyped]]
+
+      @paused_queues: Set[String]
+
       # :  () -> void
       def initialize_adapter!: () -> void
 
-      def initialize: () -> untyped
+      # :  () -> void
+      def initialize: () -> void
 
       # :  () -> bool
       def semaphore_available?: () -> bool

data/sig/generated/job_workflow/sub_task_job.rbs

@@ -31,8 +31,8 @@ module JobWorkflow
     # :  (Hash[Symbol, untyped]) -> Context
     def build_context: (Hash[Symbol, untyped]) -> Context
 
-    # :  (job_class_name: String) -> Workflow
-    def resolve_workflow: (job_class_name: String) -> Workflow
+    # :  (String job_class_name) -> Workflow
+    def resolve_workflow: (String job_class_name) -> Workflow
 
     # :  (Hash[Symbol, untyped]) -> Hash[String, untyped]
     def extract_context_data: (Hash[Symbol, untyped]) -> Hash[String, untyped]

data/sig/generated/job_workflow/task_graph.rbs

@@ -2,6 +2,8 @@
 
 module JobWorkflow
   class TaskGraph
+    @tasks: Hash[Symbol, Task]
+
     include TSort[Task]
 
     include Enumerable[Task]

data/sig/generated/job_workflow/workflow.rbs

@@ -2,6 +2,14 @@
 
 module JobWorkflow
   class Workflow
+    @schedules: Hash[Symbol, Schedule]
+
+    @hook_registry: HookRegistry
+
+    @argument_defs: Hash[Symbol, ArgumentDef]
+
+    @task_graph: TaskGraph
+
     attr_reader dry_run_config: DryRunConfig
 
     # :  () -> void