jnunemaker-httparty 0.2.10 → 0.3.0

data/lib/httparty/request.rb

@@ -1,7 +1,7 @@
 require 'uri'
 
 module HTTParty
-  class Request    
+  class Request #:nodoc:
     SupportedHTTPMethods = [Net::HTTP::Get, Net::HTTP::Post, Net::HTTP::Put, Net::HTTP::Delete]
     
     attr_accessor :http_method, :path, :options
@@ -21,7 +21,12 @@ module HTTParty
     
     def uri
       new_uri = path.relative? ? URI.parse("#{options[:base_uri]}#{path}") : path
-      new_uri.query = query_string(new_uri)
+      
+      # avoid double query string on redirects [#12]
+      unless @redirect
+        new_uri.query = query_string(new_uri)
+      end
+      
       new_uri
     end
     
@@ -30,13 +35,13 @@ module HTTParty
     end
     
     def perform
-      validate!
+      validate
       setup_raw_request
-      handle_response!(get_response)
+      handle_response(get_response)
     end
 
     private
-      def http #:nodoc:
+      def http
         http = Net::HTTP.new(uri.host, uri.port, options[:http_proxyaddr], options[:http_proxyport])
         http.use_ssl = (uri.port == 443)
         http.verify_mode = OpenSSL::SSL::VERIFY_NONE
@@ -64,13 +69,13 @@ module HTTParty
         http.request(@raw_request)
       end
 
-      def get_response #:nodoc:
+      def get_response
         response = perform_actual_request
         options[:format] ||= format_from_mimetype(response['content-type'])
         response
       end
       
-      def query_string(uri) #:nodoc:
+      def query_string(uri)
         query_string_parts = []
         query_string_parts << uri.query unless uri.query.blank?
 
@@ -85,11 +90,12 @@ module HTTParty
       end
       
       # Raises exception Net::XXX (http error code) if an http error occured
-      def handle_response!(response) #:nodoc:
+      def handle_response(response)
         case response
           when Net::HTTPRedirection
             options[:limit] -= 1
             self.path = response['location']
+            @redirect = true
             perform
           else
             parsed_response = parse_response(response.body)
@@ -97,13 +103,13 @@ module HTTParty
           end
       end
       
-      def parse_response(body) #:nodoc:
+      def parse_response(body)
         return nil if body.nil? or body.empty?
         case format
           when :xml
-            ToHashParser.from_xml(body)
+            HTTParty::Parsers::XML.parse(body)
           when :json
-            JSON.parse(body)
+            HTTParty::Parsers::JSON.decode(body)
           else
             body
           end
@@ -111,12 +117,12 @@ module HTTParty
   
       # Uses the HTTP Content-Type header to determine the format of the response
       # It compares the MIME type returned to the types stored in the AllowedFormats hash
-      def format_from_mimetype(mimetype) #:nodoc:
+      def format_from_mimetype(mimetype)
         return nil if mimetype.nil?
         AllowedFormats.each { |k, v| return v if mimetype.include?(k) }
       end
       
-      def validate! #:nodoc:
+      def validate
         raise HTTParty::RedirectionTooDeep, 'HTTP redirects too deep' if options[:limit].to_i <= 0
         raise ArgumentError, 'only get, post, put and delete methods are supported' unless SupportedHTTPMethods.include?(http_method)
         raise ArgumentError, ':headers must be a hash' if options[:headers] && !options[:headers].is_a?(Hash)

data/lib/httparty/response.rb

@@ -1,8 +1,9 @@
 module HTTParty
-  class Response < BlankSlate
+  class Response < BlankSlate #:nodoc:
     attr_accessor :body, :code, :headers
+    attr_reader :delegate
 
-    def initialize(delegate, body, code, headers)
+    def initialize(delegate, body, code, headers={})
       @delegate = delegate
       @body = body
       @code = code

data/lib/httparty/version.rb

@@ -1,3 +1,3 @@
-module HTTParty
-  Version = '0.2.10'
+module HTTParty #:nodoc:
+  Version = '0.3.0'
 end

data/spec/hash_spec.rb

@@ -0,0 +1,44 @@
+require File.dirname(__FILE__) + '/spec_helper'
+
+describe Hash, "to_xml_attributes" do
+  before do
+    @hash = { :one => "ONE", "two" => "TWO" }
+  end
+
+  it "should turn the hash into xml attributes" do
+    attrs = @hash.to_xml_attributes
+    attrs.should match(/one="ONE"/m)
+    attrs.should match(/two="TWO"/m)
+  end
+
+  it 'should preserve _ in hash keys' do
+    attrs = {
+      :some_long_attribute => "with short value",
+      :crash               => :burn,
+      :merb                => "uses extlib"
+    }.to_xml_attributes
+
+    attrs.should =~ /some_long_attribute="with short value"/
+    attrs.should =~ /merb="uses extlib"/
+    attrs.should =~ /crash="burn"/
+  end
+end
+
+
+describe Hash, 'to_params' do
+  {
+    { "foo" => "bar", "baz" => "bat" } => "foo=bar&baz=bat",
+    { "foo" => [ "bar", "baz" ] } => "foo[]=bar&foo[]=baz",
+    { "foo" => [ {"bar" => "1"}, {"bar" => 2} ] } => "foo[][bar]=1&foo[][bar]=2",
+    { "foo" => { "bar" => [ {"baz" => 1}, {"baz" => "2"}  ] } } => "foo[bar][][baz]=1&foo[bar][][baz]=2",
+    { "foo" => {"1" => "bar", "2" => "baz"} } => "foo[1]=bar&foo[2]=baz"
+  }.each do |hash, params|
+    it "should covert hash: #{hash.inspect} to params: #{params.inspect}" do
+      hash.to_params.split('&').sort.should == params.split('&').sort
+    end
+  end
+
+  it 'should not leave a trailing &' do
+    { :name => 'Bob', :address => { :street => '111 Ruby Ave.', :city => 'Ruby Central', :phones => ['111-111-1111', '222-222-2222'] } }.to_params.should_not match(/&$/)
+  end
+end

data/spec/httparty/parsers/json_spec.rb

@@ -0,0 +1,41 @@
+require File.join(File.dirname(__FILE__), '..', '..', 'spec_helper')
+
+describe HTTParty::Parsers::JSON do
+  TESTS = {
+    %q({"returnTo":{"\/categories":"\/"}})        => {"returnTo" => {"/categories" => "/"}},
+    %q({returnTo:{"\/categories":"\/"}})          => {"returnTo" => {"/categories" => "/"}},
+    %q({"return\\"To\\":":{"\/categories":"\/"}}) => {"return\"To\":" => {"/categories" => "/"}},
+    %q({"returnTo":{"\/categories":1}})          => {"returnTo" => {"/categories" => 1}},
+    %({"returnTo":[1,"a"]})                    => {"returnTo" => [1, "a"]},
+    %({"returnTo":[1,"\\"a\\",", "b"]})        => {"returnTo" => [1, "\"a\",", "b"]},
+    %({a: "'", "b": "5,000"})                  => {"a" => "'", "b" => "5,000"},
+    %({a: "a's, b's and c's", "b": "5,000"})   => {"a" => "a's, b's and c's", "b" => "5,000"},
+    %({a: "2007-01-01"})                       => {'a' => Date.new(2007, 1, 1)}, 
+    %({a: "2007-01-01 01:12:34 Z"})            => {'a' => Time.utc(2007, 1, 1, 1, 12, 34)}, 
+    # no time zone
+    %({a: "2007-01-01 01:12:34"})              => {'a' => "2007-01-01 01:12:34"}, 
+    %([])    => [],
+    %({})    => {},
+    %(1)     => 1,
+    %("")    => "",
+    %("\\"") => "\"",
+    %(null)  => nil,
+    %(true)  => true,
+    %(false) => false,
+    %q("http:\/\/test.host\/posts\/1") => "http://test.host/posts/1"
+  }
+  
+  TESTS.each do |json, expected|
+    it "should decode json (#{json})" do
+      lambda {
+        HTTParty::Parsers::JSON.decode(json).should == expected
+      }.should_not raise_error
+    end
+  end
+  
+  it "should raise error for failed decoding" do
+    lambda {
+      HTTParty::Parsers::JSON.decode(%({: 1}))
+    }.should raise_error(HTTParty::Parsers::JSON::ParseError)
+  end
+end

data/spec/httparty/parsers/xml_spec.rb

@@ -0,0 +1,445 @@
+require File.join(File.dirname(__FILE__), '..', '..', 'spec_helper')
+
+require "date"
+require 'bigdecimal'
+
+describe HTTParty::Parsers::XML, "#parse" do
+  it "should transform a simple tag with content" do
+    xml = "<tag>This is the contents</tag>"
+    HTTParty::Parsers::XML.parse(xml).should == { 'tag' => 'This is the contents' }
+  end
+
+  it "should work with cdata tags" do
+    xml = <<-END
+      <tag>
+      <![CDATA[
+        text inside cdata
+      ]]>
+      </tag>
+    END
+    HTTParty::Parsers::XML.parse(xml)["tag"].strip.should == "text inside cdata"
+  end
+
+  it "should transform a simple tag with attributes" do
+    xml = "<tag attr1='1' attr2='2'></tag>"
+    hash = { 'tag' => { 'attr1' => '1', 'attr2' => '2' } }
+    HTTParty::Parsers::XML.parse(xml).should == hash
+  end
+
+  it "should transform repeating siblings into an array" do
+    xml =<<-XML
+      <opt>
+        <user login="grep" fullname="Gary R Epstein" />
+        <user login="stty" fullname="Simon T Tyson" />
+      </opt>
+    XML
+
+    HTTParty::Parsers::XML.parse(xml)['opt']['user'].should be_an_instance_of(Array)
+
+    hash = {
+      'opt' => {
+        'user' => [{
+          'login'    => 'grep',
+          'fullname' => 'Gary R Epstein'
+        },{
+          'login'    => 'stty',
+          'fullname' => 'Simon T Tyson'
+        }]
+      }
+    }
+
+    HTTParty::Parsers::XML.parse(xml).should == hash
+  end
+
+  it "should not transform non-repeating siblings into an array" do
+    xml =<<-XML
+      <opt>
+        <user login="grep" fullname="Gary R Epstein" />
+      </opt>
+    XML
+
+    HTTParty::Parsers::XML.parse(xml)['opt']['user'].should be_an_instance_of(Hash)
+
+    hash = {
+      'opt' => {
+        'user' => {
+          'login' => 'grep',
+          'fullname' => 'Gary R Epstein'
+        }
+      }
+    }
+
+    HTTParty::Parsers::XML.parse(xml).should == hash
+  end
+
+  it "should typecast an integer" do
+    xml = "<tag type='integer'>10</tag>"
+    HTTParty::Parsers::XML.parse(xml)['tag'].should == 10
+  end
+
+  it "should typecast a true boolean" do
+    xml = "<tag type='boolean'>true</tag>"
+    HTTParty::Parsers::XML.parse(xml)['tag'].should be_true
+  end
+
+  it "should typecast a false boolean" do
+    ["false"].each do |w|
+      HTTParty::Parsers::XML.parse("<tag type='boolean'>#{w}</tag>")['tag'].should be_false
+    end
+  end
+
+  it "should typecast a datetime" do
+    xml = "<tag type='datetime'>2007-12-31 10:32</tag>"
+    HTTParty::Parsers::XML.parse(xml)['tag'].should == Time.parse( '2007-12-31 10:32' ).utc
+  end
+
+  it "should typecast a date" do
+    xml = "<tag type='date'>2007-12-31</tag>"
+    HTTParty::Parsers::XML.parse(xml)['tag'].should == Date.parse('2007-12-31')
+  end
+
+  it "should unescape html entities" do
+    values = {
+      "<" => "&lt;",
+      ">" => "&gt;",
+      '"' => "&quot;",
+      "'" => "&apos;",
+      "&" => "&amp;"
+    }
+    values.each do |k,v|
+      xml = "<tag>Some content #{v}</tag>"
+      HTTParty::Parsers::XML.parse(xml)['tag'].should match(Regexp.new(k))
+    end
+  end
+
+  it "should undasherize keys as tags" do
+    xml = "<tag-1>Stuff</tag-1>"
+    HTTParty::Parsers::XML.parse(xml).keys.should include( 'tag_1' )
+  end
+
+  it "should undasherize keys as attributes" do
+    xml = "<tag1 attr-1='1'></tag1>"
+    HTTParty::Parsers::XML.parse(xml)['tag1'].keys.should include( 'attr_1')
+  end
+
+  it "should undasherize keys as tags and attributes" do
+    xml = "<tag-1 attr-1='1'></tag-1>"
+    HTTParty::Parsers::XML.parse(xml).keys.should include( 'tag_1' )
+    HTTParty::Parsers::XML.parse(xml)['tag_1'].keys.should include( 'attr_1')
+  end
+
+  it "should render nested content correctly" do
+    xml = "<root><tag1>Tag1 Content <em><strong>This is strong</strong></em></tag1></root>"
+    HTTParty::Parsers::XML.parse(xml)['root']['tag1'].should == "Tag1 Content <em><strong>This is strong</strong></em>"
+  end
+
+  it "should render nested content with split text nodes correctly" do
+    xml = "<root>Tag1 Content<em>Stuff</em> Hi There</root>"
+    HTTParty::Parsers::XML.parse(xml)['root'].should == "Tag1 Content<em>Stuff</em> Hi There"
+  end
+
+  it "should ignore attributes when a child is a text node" do
+    xml = "<root attr1='1'>Stuff</root>"
+    HTTParty::Parsers::XML.parse(xml).should == { "root" => "Stuff" }
+  end
+
+  it "should ignore attributes when any child is a text node" do
+    xml = "<root attr1='1'>Stuff <em>in italics</em></root>"
+    HTTParty::Parsers::XML.parse(xml).should == { "root" => "Stuff <em>in italics</em>" }
+  end
+
+  it "should correctly transform multiple children" do
+    xml = <<-XML
+    <user gender='m'>
+      <age type='integer'>35</age>
+      <name>Home Simpson</name>
+      <dob type='date'>1988-01-01</dob>
+      <joined-at type='datetime'>2000-04-28 23:01</joined-at>
+      <is-cool type='boolean'>true</is-cool>
+    </user>
+    XML
+
+    hash =  {
+      "user" => {
+        "gender"    => "m",
+        "age"       => 35,
+        "name"      => "Home Simpson",
+        "dob"       => Date.parse('1988-01-01'),
+        "joined_at" => Time.parse("2000-04-28 23:01"),
+        "is_cool"   => true
+      }
+    }
+
+    HTTParty::Parsers::XML.parse(xml).should == hash
+  end
+
+  it "should properly handle nil values (ActiveSupport Compatible)" do
+    topic_xml = <<-EOT
+      <topic>
+        <title></title>
+        <id type="integer"></id>
+        <approved type="boolean"></approved>
+        <written-on type="date"></written-on>
+        <viewed-at type="datetime"></viewed-at>
+        <content type="yaml"></content>
+        <parent-id></parent-id>
+      </topic>
+    EOT
+
+    expected_topic_hash = {
+      'title'      => nil,
+      'id'         => nil,
+      'approved'   => nil,
+      'written_on' => nil,
+      'viewed_at'  => nil,
+      'content'    => nil,
+      'parent_id'  => nil
+    }
+    HTTParty::Parsers::XML.parse(topic_xml)["topic"].should == expected_topic_hash
+  end
+
+  it "should handle a single record from xml (ActiveSupport Compatible)" do
+    topic_xml = <<-EOT
+      <topic>
+        <title>The First Topic</title>
+        <author-name>David</author-name>
+        <id type="integer">1</id>
+        <approved type="boolean"> true </approved>
+        <replies-count type="integer">0</replies-count>
+        <replies-close-in type="integer">2592000000</replies-close-in>
+        <written-on type="date">2003-07-16</written-on>
+        <viewed-at type="datetime">2003-07-16T09:28:00+0000</viewed-at>
+        <content type="yaml">--- \n1: should be an integer\n:message: Have a nice day\narray: \n- should-have-dashes: true\n  should_have_underscores: true\n</content>
+        <author-email-address>david@loudthinking.com</author-email-address>
+        <parent-id></parent-id>
+        <ad-revenue type="decimal">1.5</ad-revenue>
+        <optimum-viewing-angle type="float">135</optimum-viewing-angle>
+        <resident type="symbol">yes</resident>
+      </topic>
+    EOT
+
+    expected_topic_hash = {
+      'title' => "The First Topic",
+      'author_name' => "David",
+      'id' => 1,
+      'approved' => true,
+      'replies_count' => 0,
+      'replies_close_in' => 2592000000,
+      'written_on' => Date.new(2003, 7, 16),
+      'viewed_at' => Time.utc(2003, 7, 16, 9, 28),
+      # Changed this line where the key is :message.  The yaml specifies this as a symbol, and who am I to change what you specify
+      # The line in ActiveSupport is
+      # 'content' => { 'message' => "Have a nice day", 1 => "should be an integer", "array" => [{ "should-have-dashes" => true, "should_have_underscores" => true }] },
+      'content' => { :message => "Have a nice day", 1 => "should be an integer", "array" => [{ "should-have-dashes" => true, "should_have_underscores" => true }] },
+      'author_email_address' => "david@loudthinking.com",
+      'parent_id' => nil,
+      'ad_revenue' => BigDecimal("1.50"),
+      'optimum_viewing_angle' => 135.0,
+      'resident' => :yes
+    }
+
+    HTTParty::Parsers::XML.parse(topic_xml)["topic"].each do |k,v|
+      v.should == expected_topic_hash[k]
+    end
+  end
+
+  it "should handle multiple records (ActiveSupport Compatible)" do
+    topics_xml = <<-EOT
+      <topics type="array">
+        <topic>
+          <title>The First Topic</title>
+          <author-name>David</author-name>
+          <id type="integer">1</id>
+          <approved type="boolean">false</approved>
+          <replies-count type="integer">0</replies-count>
+          <replies-close-in type="integer">2592000000</replies-close-in>
+          <written-on type="date">2003-07-16</written-on>
+          <viewed-at type="datetime">2003-07-16T09:28:00+0000</viewed-at>
+          <content>Have a nice day</content>
+          <author-email-address>david@loudthinking.com</author-email-address>
+          <parent-id nil="true"></parent-id>
+        </topic>
+        <topic>
+          <title>The Second Topic</title>
+          <author-name>Jason</author-name>
+          <id type="integer">1</id>
+          <approved type="boolean">false</approved>
+          <replies-count type="integer">0</replies-count>
+          <replies-close-in type="integer">2592000000</replies-close-in>
+          <written-on type="date">2003-07-16</written-on>
+          <viewed-at type="datetime">2003-07-16T09:28:00+0000</viewed-at>
+          <content>Have a nice day</content>
+          <author-email-address>david@loudthinking.com</author-email-address>
+          <parent-id></parent-id>
+        </topic>
+      </topics>
+    EOT
+
+    expected_topic_hash = {
+      'title' => "The First Topic",
+      'author_name' => "David",
+      'id' => 1,
+      'approved' => false,
+      'replies_count' => 0,
+      'replies_close_in' => 2592000000,
+      'written_on' => Date.new(2003, 7, 16),
+      'viewed_at' => Time.utc(2003, 7, 16, 9, 28),
+      'content' => "Have a nice day",
+      'author_email_address' => "david@loudthinking.com",
+      'parent_id' => nil
+    }
+    # puts HTTParty::Parsers::XML.parse(topics_xml)['topics'].first.inspect
+    HTTParty::Parsers::XML.parse(topics_xml)["topics"].first.each do |k,v|
+      v.should == expected_topic_hash[k]
+    end
+  end
+
+  it "should handle a single record from_xml with attributes other than type (ActiveSupport Compatible)" do
+    topic_xml = <<-EOT
+    <rsp stat="ok">
+      <photos page="1" pages="1" perpage="100" total="16">
+        <photo id="175756086" owner="55569174@N00" secret="0279bf37a1" server="76" title="Colored Pencil PhotoBooth Fun" ispublic="1" isfriend="0" isfamily="0"/>
+      </photos>
+    </rsp>
+    EOT
+
+    expected_topic_hash = {
+      'id' => "175756086",
+      'owner' => "55569174@N00",
+      'secret' => "0279bf37a1",
+      'server' => "76",
+      'title' => "Colored Pencil PhotoBooth Fun",
+      'ispublic' => "1",
+      'isfriend' => "0",
+      'isfamily' => "0",
+    }
+    HTTParty::Parsers::XML.parse(topic_xml)["rsp"]["photos"]["photo"].each do |k,v|
+      v.should == expected_topic_hash[k]
+    end
+  end
+
+  it "should handle an emtpy array (ActiveSupport Compatible)" do
+    blog_xml = <<-XML
+      <blog>
+        <posts type="array"></posts>
+      </blog>
+    XML
+    expected_blog_hash = {"blog" => {"posts" => []}}
+    HTTParty::Parsers::XML.parse(blog_xml).should == expected_blog_hash
+  end
+
+  it "should handle empty array with whitespace from xml (ActiveSupport Compatible)" do
+    blog_xml = <<-XML
+      <blog>
+        <posts type="array">
+        </posts>
+      </blog>
+    XML
+    expected_blog_hash = {"blog" => {"posts" => []}}
+    HTTParty::Parsers::XML.parse(blog_xml).should == expected_blog_hash
+  end
+
+  it "should handle array with one entry from_xml (ActiveSupport Compatible)" do
+    blog_xml = <<-XML
+      <blog>
+        <posts type="array">
+          <post>a post</post>
+        </posts>
+      </blog>
+    XML
+    expected_blog_hash = {"blog" => {"posts" => ["a post"]}}
+    HTTParty::Parsers::XML.parse(blog_xml).should == expected_blog_hash
+  end
+
+  it "should handle array with multiple entries from xml (ActiveSupport Compatible)" do
+    blog_xml = <<-XML
+      <blog>
+        <posts type="array">
+          <post>a post</post>
+          <post>another post</post>
+        </posts>
+      </blog>
+    XML
+    expected_blog_hash = {"blog" => {"posts" => ["a post", "another post"]}}
+    HTTParty::Parsers::XML.parse(blog_xml).should == expected_blog_hash
+  end
+
+  it "should handle file types (ActiveSupport Compatible)" do
+    blog_xml = <<-XML
+      <blog>
+        <logo type="file" name="logo.png" content_type="image/png">
+        </logo>
+      </blog>
+    XML
+    hash = HTTParty::Parsers::XML.parse(blog_xml)
+    hash.should have_key('blog')
+    hash['blog'].should have_key('logo')
+
+    file = hash['blog']['logo']
+    file.original_filename.should == 'logo.png'
+    file.content_type.should == 'image/png'
+  end
+
+  it "should handle file from xml with defaults (ActiveSupport Compatible)" do
+    blog_xml = <<-XML
+      <blog>
+        <logo type="file">
+        </logo>
+      </blog>
+    XML
+    file = HTTParty::Parsers::XML.parse(blog_xml)['blog']['logo']
+    file.original_filename.should == 'untitled'
+    file.content_type.should == 'application/octet-stream'
+  end
+
+  it "should handle xsd like types from xml (ActiveSupport Compatible)" do
+    bacon_xml = <<-EOT
+    <bacon>
+      <weight type="double">0.5</weight>
+      <price type="decimal">12.50</price>
+      <chunky type="boolean"> 1 </chunky>
+      <expires-at type="dateTime">2007-12-25T12:34:56+0000</expires-at>
+      <notes type="string"></notes>
+      <illustration type="base64Binary">YmFiZS5wbmc=</illustration>
+    </bacon>
+    EOT
+
+    expected_bacon_hash = {
+      'weight' => 0.5,
+      'chunky' => true,
+      'price' => BigDecimal("12.50"),
+      'expires_at' => Time.utc(2007,12,25,12,34,56),
+      'notes' => "",
+      'illustration' => "babe.png"
+    }
+
+    HTTParty::Parsers::XML.parse(bacon_xml)["bacon"].should == expected_bacon_hash
+  end
+
+  it "should let type trickle through when unknown (ActiveSupport Compatible)" do
+    product_xml = <<-EOT
+    <product>
+      <weight type="double">0.5</weight>
+      <image type="ProductImage"><filename>image.gif</filename></image>
+
+    </product>
+    EOT
+
+    expected_product_hash = {
+      'weight' => 0.5,
+      'image' => {'type' => 'ProductImage', 'filename' => 'image.gif' },
+    }
+
+    HTTParty::Parsers::XML.parse(product_xml)["product"].should == expected_product_hash
+  end
+
+  it "should handle unescaping from xml (ActiveResource Compatible)" do
+    xml_string = '<person><bare-string>First &amp; Last Name</bare-string><pre-escaped-string>First &amp;amp; Last Name</pre-escaped-string></person>'
+    expected_hash = {
+      'bare_string'        => 'First & Last Name',
+      'pre_escaped_string' => 'First &amp; Last Name'
+    }
+
+    HTTParty::Parsers::XML.parse(xml_string)['person'].should == expected_hash
+  end
+end