jit_preloader 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9209e8e03dd7ebf7543435a61c98452f229b98ad
-  data.tar.gz: 608e6a970d068893eb71fcc3ebba489e77663cd7
+  metadata.gz: 8dd36dd4639cc012aff19a8afdfb6bee699cdd1c
+  data.tar.gz: 41d7e22054a231edba2dc80ce3d19ac16e57cef9
 SHA512:
-  metadata.gz: a88b2f6b198e0b72dd6e8bbaf68cc9b0a9397cadd6bc4e76f39ede7b959873a9ad185af56fb2681cf60a412b5b87b92c9fe6daf175f4ac4f7e98ede9b4c2e639
-  data.tar.gz: f8b58d50d67bb629b068d388f67571e0be8de13934982d1c708fcfa8ea079f10c60ded555c09cdbc2f422e426ab38ae62865c4a144fda00ce91cea47ac5c5446
+  metadata.gz: 9cb4b5385ab0e3e7a321ac759372dbd6bd715141b89b92c82773c40f547bef92311bdfa365ad43a7b5d544c8983962f769d39a02949476fa660da305b59792d8
+  data.tar.gz: 5f24a4834a8bff484cdb849702ad71b62ddc10289134dbc1f6ad9431644015244a4ab252a6ddb74ac9d91ed47b9e1963af3cf2041fcd305e3eff0493cf1477b5

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    jit_preloader (0.0.1)
+    jit_preloader (0.0.3)
       activerecord (~> 4.2)
       activesupport
 

data/lib/jit_preloader/preloader.rb

@@ -19,5 +19,19 @@ module JitPreloader
       preload records_with_association, association
     end
 
+    # We do not want the jit_preloader to be dumpable
+    # If you dump a ActiveRecord::Base object that has a jit_preloader instance variable
+    # you will also end up dumping all of the records the preloader has reference to. 
+    # Imagine getting N objects from a query and dumping each one of those into a cache
+    # each object would dump N+1 objects which means you'll end up storing O(N^2) memory. Thats no good.
+    # So instead, we will just nullify the jit_preloader on load
+    def _dump(level)
+      ""
+    end
+
+    def self._load(args)
+      nil
+    end
+
   end
 end

data/lib/jit_preloader/version.rb

@@ -1,3 +1,3 @@
 module JitPreloader
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/lib/jit_preloader/preloader_spec.rb

@@ -38,6 +38,19 @@ RSpec.describe JitPreloader::Preloader do
     ->(event, data){ source_map[data[:source]] << data[:association] }
   end
 
+  context "when we marshal dump the active record object" do
+    it "nullifes the jit_preloader reference" do
+      contacts = Contact.jit_preload.to_a
+      reloaded_contacts = contacts.collect{|r| Marshal.load(Marshal.dump(r)) }
+      contacts.each do |c|
+        expect(c.jit_preloader).to_not be_nil
+      end
+      reloaded_contacts.each do |c|
+        expect(c.jit_preloader).to be_nil
+      end
+    end
+  end
+
   context "when the preloader is globally enabled" do
     around do |example|
       JitPreloader.globally_enabled = true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: jit_preloader
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Kyle d'Oliveira
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-03 00:00:00.000000000 Z
+date: 2016-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord