jirametrics 2.31 → 3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e5d255e03d686d0bf827ab0cd09191777b9586574971d6e274704a85df1059a6
-  data.tar.gz: 60fbf1432b7399186a5e854ef58e83ee59ae96b5bee859371b09f992b4854db7
+  metadata.gz: 8411199c48209ed18008a509523bcd28c7d22c1145b492137ac5219972f35245
+  data.tar.gz: 3074f95dfc4b401408e615d71b957f5e5626514a6172de5855ec80a15a9bc82a
 SHA512:
-  metadata.gz: 79003fc0ab19a3253e9611c74e5d5772b7e0cf17250ec668c9c21cf871056020fa1d6af979387b4e76395b47a687e300b288555d0709c9fa50a7c227d359dbe2
-  data.tar.gz: 7587f1a620a1015f174bfa5b2b2e31251f3b0c0e2be0a688aa31e1da423bdefa2deaab7a8d40c4e3a8fd54f8c495a3b43db1a0ad231feab6624d8cf74b08adff
+  metadata.gz: 1b7dc5f5abea1401da94464b80cb8b346f503055d5df92bac596af7c48b3021d4deb641af804710186a964f4d750b6d03a542cb9236c852b12e174887ba2def9
+  data.tar.gz: d9b6de864972518ae2a3ab91c92fc4eba3d411232b252afb31c041ea9575cfa1cebee4085211d0d1eb091335240da5a13038622765dc0ef3fd8c73f874ee4222

data/lib/jirametrics/aggregate_config.rb

@@ -39,43 +39,18 @@ class AggregateConfig
   end
 
   def include_issues_from project_name
-    project = @project_config.exporter.project_configs.find { |p| p.name == project_name }
-    if project.nil?
-      file_system.warning "Aggregated project #{@project_config.name.inspect} is attempting to load " \
-        "project #{project_name.inspect} but it can't be found. Is it disabled?"
-      return
-    end
-
-    @project_config.jira_url = project.jira_url if @project_config.jira_url.nil?
-    unless @project_config.jira_url == project.jira_url
-      raise 'Not allowed to aggregate projects from different Jira instances: ' \
-        "#{@project_config.jira_url.inspect} and #{project.jira_url.inspect}. For project #{project_name}"
-    end
+    project = find_included_project project_name
+    return if project.nil?
 
     @included_projects << project
-    if project.file_configs.empty?
-      issues = project.issues
-    else
-      issues = project.file_configs.first.issues
-      if project.file_configs.size > 1
-        log 'More than one file section is defined. For the aggregated view, we always use ' \
-          'the first file section'
-      end
-    end
-
+    issues = issues_for project
     if issues.nil?
       file_system.warning "No issues found for #{project_name}"
       return
     end
 
     @project_config.add_issues issues
-
-    # Bring fix versions over
-    project.fix_versions.each do |fix_version|
-      unless @project_config.fix_versions.find { |fv| fv.id == fix_version.id }
-        @project_config.fix_versions << fix_version
-      end
-    end
+    merge_fix_versions_from project
   end
 
   def find_time_range projects:
@@ -94,6 +69,44 @@ class AggregateConfig
 
   private
 
+  # Resolve the named project and confirm it can be aggregated. Returns nil (with a warning) when the
+  # project can't be found; raises when it lives on a different Jira instance than the ones already
+  # included. The first included project's URL seeds the aggregate's URL.
+  def find_included_project project_name
+    project = @project_config.exporter.project_configs.find { |p| p.name == project_name }
+    if project.nil?
+      file_system.warning "Aggregated project #{@project_config.name.inspect} is attempting to load " \
+        "project #{project_name.inspect} but it can't be found. Is it disabled?"
+      return nil
+    end
+
+    @project_config.jira_url = project.jira_url if @project_config.jira_url.nil?
+    unless @project_config.jira_url == project.jira_url
+      raise 'Not allowed to aggregate projects from different Jira instances: ' \
+        "#{@project_config.jira_url.inspect} and #{project.jira_url.inspect}. For project #{project_name}"
+    end
+
+    project
+  end
+
+  def issues_for project
+    return project.issues if project.file_configs.empty?
+
+    if project.file_configs.size > 1
+      file_system.warning 'More than one file section is defined. For the aggregated view, we always use ' \
+        'the first file section'
+    end
+    project.file_configs.first.issues
+  end
+
+  def merge_fix_versions_from project
+    project.fix_versions.each do |fix_version|
+      next if @project_config.fix_versions.find { |fv| fv.id == fix_version.id }
+
+      @project_config.fix_versions << fix_version
+    end
+  end
+
   def file_system
     @project_config.exporter.file_system
   end

data/lib/jirametrics/aging_work_bar_chart.rb

@@ -102,10 +102,10 @@ class AgingWorkBarChart < ChartBase
 
   def select_aging_issues issues:
     issues.select do |issue|
-      started_time, stopped_time = issue.started_stopped_times
-      next false unless started_time && stopped_time.nil?
+      cycletime = issue.board.cycletime
+      next false unless cycletime.in_progress?(issue)
 
-      age = (date_range.end - started_time.to_date).to_i + 1
+      age = cycletime.age(issue, today: date_range.end)
       !(@age_cutoff && @age_cutoff >= age)
     end
   end
@@ -200,20 +200,21 @@ class AgingWorkBarChart < ChartBase
         next
       end
 
-      if change.time >= issue_start_time
-        color = settings['blocked_color'] || '--blocked-color'
-        color = settings['stalled_color'] || '--stalled-color' if starting_change.stalled?
-
-        results << BarChartRange.new(
-          start: starting_change.time, stop: change.time, color: CssVariable[color], title: starting_change.reasons
-        )
-      end
-
+      results << blocked_stalled_range(starting_change, change) if change.time >= issue_start_time
       starting_change = change
     end
     results
   end
 
+  def blocked_stalled_range starting_change, change
+    color = '--blocked-color'
+    color = '--stalled-color' if starting_change.stalled?
+
+    BarChartRange.new(
+      start: starting_change.time, stop: change.time, color: CssVariable[color], title: starting_change.reasons
+    )
+  end
+
   def collect_priority_ranges issue:
     expedited_priority_names = settings['expedited_priority_names']
 
@@ -251,44 +252,55 @@ class AgingWorkBarChart < ChartBase
     issue.changes.each do |change|
       next unless change.sprint?
 
-      removed_sprint_ids = change.old_value_id - change.value_id
-      added_sprint_ids = change.value_id - change.old_value_id
-
-      removed_sprint_ids.each do |id|
-        data = open_sprints.delete(id)
-        next unless data
-
-        completed = data[:sprint].completed_time
-        stop = completed ? [change.time, completed].min : change.time
-        results << BarChartRange.new(
-          start: data[:start_time], stop: stop,
-          color: CssVariable['--sprint-color'], title: data[:sprint].name
-        )
-      end
-
-      added_sprint_ids.each do |id|
-        sprint = issue.board.sprints.find { |s| s.id == id }
-        next unless sprint
-        next if sprint.future?
-
-        start_time = [sprint.start_time, change.time].max
-        open_sprints[id] = { start_time: start_time, sprint: sprint }
-      end
+      close_removed_sprints(change, open_sprints, results)
+      open_added_sprints(change, issue, open_sprints)
     end
 
+    # Anything still open at the end runs to the sprint's completion, or the end of the range if it's
+    # still active.
     open_sprints.each_value do |data|
       next if data[:sprint].future?
 
-      stop = data[:sprint].completed_time || time_range.end
-      results << BarChartRange.new(
-        start: data[:start_time], stop: stop,
-        color: CssVariable['--sprint-color'], title: data[:sprint].name
-      )
+      results << sprint_range(data, data[:sprint].completed_time || time_range.end)
     end
 
     results
   end
 
+  # For each sprint this change leaves, close its open range. The range stops when the issue left, or
+  # when the sprint completed if that came first.
+  def close_removed_sprints change, open_sprints, results
+    removed_sprint_ids = change.old_value_id - change.value_id
+    removed_sprint_ids.each do |id|
+      data = open_sprints.delete(id)
+      next unless data
+
+      completed = data[:sprint].completed_time
+      stop = completed ? [change.time, completed].min : change.time
+      results << sprint_range(data, stop)
+    end
+  end
+
+  # For each sprint this change joins (that exists and has already started), open a range. It starts
+  # when the issue joined, or when the sprint began if the issue was added beforehand.
+  def open_added_sprints change, issue, open_sprints
+    added_sprint_ids = change.value_id - change.old_value_id
+    added_sprint_ids.each do |id|
+      sprint = issue.board.sprints.find { |s| s.id == id }
+      next unless sprint
+      next if sprint.future?
+
+      start_time = [sprint.start_time, change.time].max
+      open_sprints[id] = { start_time: start_time, sprint: sprint }
+    end
+  end
+
+  def sprint_range data, stop
+    BarChartRange.new(
+      start: data[:start_time], stop: stop, color: CssVariable['--sprint-color'], title: data[:sprint].name
+    )
+  end
+
   def create_range_for_priority previous_change:, stop_time:, expedited_priority_names:
     expedited = expedited_priority_names.include?(previous_change.value)
     title = "Priority: #{previous_change.value}"

data/lib/jirametrics/aging_work_in_progress_chart.rb

@@ -65,6 +65,7 @@ class AgingWorkInProgressChart < ChartBase
     wrap_and_render(binding, __FILE__)
   end
 
+  # Boolean positional is the config-block DSL's public API (show_all_columns false).
   def show_all_columns show = true # rubocop:disable Style/OptionalBooleanParameter
     @show_all_columns = show
   end
@@ -83,60 +84,58 @@ class AgingWorkInProgressChart < ChartBase
   end
 
   def make_data_sets
-    aging_issues = @issues.select do |issue|
-      board = issue.board
-      board.id == @board_id && board.cycletime.in_progress?(issue)
-    end
+    aging_issues = @issues.select { |issue| aging_issue_on_board? issue }
 
-    @max_age = 20
     rules_to_issues = group_issues aging_issues
-    data_sets = rules_to_issues.keys.collect do |rules|
-      {
-        'type' => 'line',
-        'label' => rules.label,
-        'data' => rules_to_issues[rules].filter_map do |issue|
-            age = issue.board.cycletime.age(issue, today: date_range.end)
-            column = column_for issue: issue
-            next if column.nil?
-
-            @max_age = age if age > @max_age
-
-            {
-              'y' => age,
-              'x' => column.name,
-              'title' => ["#{issue.key} : #{issue.summary} (#{label_days age})"]
-            }
-          end,
-        'fill' => false,
-        'showLine' => false,
-        'backgroundColor' => rules.color
-      }
-    end
+    data_sets = rules_to_issues.keys.collect { |rules| line_data_set(rules, rules_to_issues[rules]) }
+    # The y-axis is scaled to the oldest item, but never shorter than 20 days.
+    @max_age = data_sets.flat_map { |set| set['data'].collect { |point| point['y'] } }.push(20).max
 
     calculator = BoardMovementCalculator.new board: @all_boards[@board_id], issues: issues, today: date_range.end
-
     column_indexes_to_remove = trim_board_columns data_sets: data_sets, calculator: calculator
-
     @row_index_offset = data_sets.size
 
+    append_bar_data_sets data_sets, calculator, column_indexes_to_remove
+    data_sets
+  end
+
+  def aging_issue_on_board? issue
+    issue.board.id == @board_id && issue.board.cycletime.in_progress?(issue)
+  end
+
+  def line_data_set rules, issues
+    {
+      'type' => 'line',
+      'label' => rules.label,
+      'data' => aging_datapoints(issues),
+      'fill' => false,
+      'showLine' => false,
+      'backgroundColor' => rules.color
+    }
+  end
+
+  # One {x: column, y: age, title} point per issue that's currently visible on the board.
+  def aging_datapoints issues
+    issues.filter_map do |issue|
+      age = issue.board.cycletime.age(issue, today: date_range.end)
+      column = column_for issue: issue
+      next if column.nil?
+
+      { 'y' => age, 'x' => column.name, 'title' => ["#{issue.key} : #{issue.summary} (#{label_days age})"] }
+    end
+  end
+
+  def append_bar_data_sets data_sets, calculator, column_indexes_to_remove
     bar_data = []
     calculator.stacked_age_data_for(percentages: @percentiles.keys).each do |percentage, data|
       column_indexes_to_remove.reverse_each { |index| data.delete_at index }
-      color = @percentiles[percentage]
-
       data_sets << {
-        'type' => 'bar',
-        'label' => "#{percentage}%",
-        'barPercentage' => 1.0,
-        'categoryPercentage' => 1.0,
-        'backgroundColor' => color,
-        'data' => data
+        'type' => 'bar', 'label' => "#{percentage}%", 'barPercentage' => 1.0, 'categoryPercentage' => 1.0,
+        'backgroundColor' => @percentiles[percentage], 'data' => data
       }
       bar_data << data
     end
     @bar_data = adjust_bar_data bar_data
-
-    data_sets
   end
 
   def adjust_bar_data input
@@ -174,29 +173,13 @@ class AgingWorkInProgressChart < ChartBase
   def trim_board_columns data_sets:, calculator:
     return [] if @show_all_columns
 
-    columns_with_aging_items = data_sets.flat_map do |set|
-      set['data'].filter_map { |d| d['x'] if d.is_a? Hash }
-    end.uniq
-
     # @fake_column is always the last element and is handled separately.
     real_column_count = @board_columns.size - 1
-
-    # The last visible column always has artificially inflated age_data because
-    # ages_of_issues_when_leaving_column uses `today` as end_date when there is no
-    # next column. Exclude it from the right-boundary search so it is only kept when
-    # it has current aging items (handled by the last_aging fallback below).
-    age_data = calculator.age_data_for(percentage: 100)
-    last_data = (0...(real_column_count - 1)).to_a.reverse.find { |i| !age_data[i].zero? }
-
-    in_current = ->(i) { columns_with_aging_items.include?(@board_columns[i].name) }
-    first_aging = (0...real_column_count).find(&in_current)
-    last_aging  = (0...real_column_count).to_a.reverse.find(&in_current)
-
-    # Combine: include any column with age_data (up to but not including the last visible
-    # column) and any column with current aging items.
-    first_data = (0...real_column_count).find { |i| !age_data[i].zero? }
-    left_bound  = [first_data, first_aging].compact.min
-    right_bound = [last_data, last_aging].compact.max
+    left_bound, right_bound = column_trim_bounds(
+      aging_columns: aging_column_names(data_sets),
+      age_data: calculator.age_data_for(percentage: 100),
+      real_column_count: real_column_count
+    )
 
     indexes_to_remove =
       if left_bound && right_bound
@@ -209,6 +192,28 @@ class AgingWorkInProgressChart < ChartBase
     indexes_to_remove
   end
 
+  # The distinct column names that currently have aging items on the chart.
+  def aging_column_names data_sets
+    data_sets.flat_map do |set|
+      set['data'].filter_map { |d| d['x'] if d.is_a? Hash }
+    end.uniq
+  end
+
+  # The [left, right] column indexes to keep, combining columns with current aging items and columns
+  # with historical age data. The last visible column is excluded from the right-boundary history search
+  # because ages_of_issues_when_leaving_column inflates its age_data (it uses `today` as the end date
+  # when there's no next column), so it's kept only when it has a current aging item.
+  def column_trim_bounds aging_columns:, age_data:, real_column_count:
+    in_current = ->(i) { aging_columns.include?(@board_columns[i].name) }
+    first_aging = (0...real_column_count).find(&in_current)
+    last_aging  = (0...real_column_count).to_a.reverse.find(&in_current)
+
+    first_data = (0...real_column_count).find { |i| !age_data[i].zero? }
+    last_data  = (0...(real_column_count - 1)).to_a.reverse.find { |i| !age_data[i].zero? }
+
+    [[first_data, first_aging].compact.min, [last_data, last_aging].compact.max]
+  end
+
   def column_for issue:
     @board_columns.find do |board_column|
       board_column.status_ids.include? issue.status.id

data/lib/jirametrics/aging_work_table.rb

@@ -58,16 +58,19 @@ class AgingWorkTable < ChartBase
   end
 
   def select_aging_issues
-    aging_issues = @issues.select do |issue|
-      started, stopped = issue.started_stopped_times
-      next false if started.nil? || stopped
-      next true if issue.blocked_on_date?(@today, end_time: time_range.end) || issue.expedited?
-
-      age = (@today - started.to_date).to_i + 1
-      age > @age_cutoff
-    end
+    aging_issues = @issues.select { |issue| aging_issue? issue }
     @any_scrum_boards = aging_issues.any? { |issue| issue.board.scrum? }
-    aging_issues.sort { |a, b| b.board.cycletime.age(b, today: @today) <=> a.board.cycletime.age(a, today: @today) }
+    aging_issues.sort_by { |issue| -issue.board.cycletime.age(issue, today: @today) }
+  end
+
+  # An issue is "aging" if it's in progress and either flagged as needing attention (blocked or
+  # expedited) or older than the configured cutoff.
+  def aging_issue? issue
+    cycletime = issue.board.cycletime
+    return false unless cycletime.in_progress?(issue)
+    return true if issue.blocked_on_date?(@today, end_time: time_range.end) || issue.expedited?
+
+    cycletime.age(issue, today: @today) > @age_cutoff
   end
 
   def expedited_text issue
@@ -121,36 +124,36 @@ class AgingWorkTable < ChartBase
   end
 
   def dates_text issue
-    date = date_range.end
-    due = issue.due_date
+    days_remaining, error = @calculators[issue.board.id].forecasted_days_remaining_and_message(
+      issue: issue, today: @today
+    )
     message = nil
+    message, error = due_date_status(issue, days_remaining, error) unless error
 
-    calculator = @calculators[issue.board.id]
-    days_remaining, error = calculator.forecasted_days_remaining_and_message issue: issue, today: @today
-
-    unless error
-      if due
-        if due < date
-          message = "Due: <b>#{due}</b> (#{label_days (@today - due).to_i} ago)"
-          error = 'Overdue'
-        elsif due == date
-          message = 'Due: <b>today</b>'
-        else
-          error = 'Due date at risk' if date_range.end + days_remaining > due
-          message = "Due: <b>#{due}</b> (#{label_days (due - @today).to_i})"
-        end
-      else
-        "#{label_days days_remaining} left."
-      end
+    forecast_line days_remaining, error, message
+  end
+
+  # Returns [message, error] describing where the due date sits relative to today and the forecast:
+  # overdue, due today, or a future date that may be at risk. Only called when the forecast succeeded.
+  def due_date_status issue, days_remaining, error
+    due = issue.due_date
+    return [nil, error] unless due
+
+    date = date_range.end
+    if due < date
+      ["Due: <b>#{due}</b> (#{label_days (@today - due).to_i} ago)", 'Overdue']
+    elsif due == date
+      ['Due: <b>today</b>', error]
+    else
+      at_risk = date_range.end + days_remaining > due
+      ["Due: <b>#{due}</b> (#{label_days (due - @today).to_i})", at_risk ? 'Due date at risk' : error]
     end
+  end
 
+  def forecast_line days_remaining, error, message
     text = +''
     text << "<span title='#{error}' style='color: red'>ⓘ </span>" if error
-    if days_remaining
-      text << "#{label_days days_remaining} left"
-    else
-      text << 'Unable to forecast'
-    end
+    text << (days_remaining ? "#{label_days days_remaining} left" : 'Unable to forecast')
     text << ' | ' << message if message
     text
   end

data/lib/jirametrics/anonymizer.rb

@@ -19,7 +19,10 @@ class Anonymizer < ChartBase
   def run
     anonymize_issue_keys_and_titles
     anonymize_column_names
-    # anonymize_issue_statuses
+    # Status names are deliberately left alone. They show up throughout the reports (hover text, aging
+    # tables, the board columns themselves), so scrubbing them to tokens would make those displays
+    # useless -- you'd lose the workflow story that makes the report worth reading. If a client's status
+    # vocabulary is itself confidential, rename the statuses in Jira rather than anonymizing here.
     anonymize_board_names
     anonymize_labels_and_components
     anonymize_sprints
@@ -35,31 +38,19 @@ class Anonymizer < ChartBase
     # cautious and try five times.
     5.times do |i|
       return RandomWord.phrases.next.tr('_', ' ')
-    rescue # rubocop:disable Style/RescueStandardError We don't care what exception was thrown.
+    rescue # rubocop:disable Style/RescueStandardError
       @file_system.log "Random word blew up on attempt #{i + 1}"
     end
   end
 
   def anonymize_issue_keys_and_titles issues: @issues
     counter = 0
-    seen_author_raws = {}
+    seen_author_raws = {}.compare_by_identity
     issues.each do |issue|
-      new_key = "ANON-#{counter += 1}"
-
-      issue.raw['key'] = new_key
-      issue.raw['fields']['summary'] = random_phrase
-      issue.raw['fields']['description'] = nil
-      issue.raw['fields']['assignee']['displayName'] = random_name unless issue.raw['fields']['assignee'].nil?
-
-      anonymize_author_raw(issue.raw['fields']['creator'], seen_author_raws)
-
-      issue.changes.each do |change|
-        anonymize_author_raw(change.author_raw, seen_author_raws)
-        if change.comment? || change.description?
-          change.value = nil
-          change.old_value = nil
-        end
-      end
+      issue.raw['key'] = "ANON-#{counter += 1}"
+      anonymize_issue_summary_fields issue
+      anonymize_author_raw issue.raw['fields']['creator'], seen_author_raws
+      anonymize_change_content issue, seen_author_raws
 
       issue.issue_links.each do |link|
         other_issue = link.other_issue
@@ -71,6 +62,24 @@ class Anonymizer < ChartBase
     end
   end
 
+  def anonymize_issue_summary_fields issue
+    issue.raw['fields']['summary'] = random_phrase
+    issue.raw['fields']['description'] = nil
+    return if issue.raw['fields']['assignee'].nil?
+
+    issue.raw['fields']['assignee']['displayName'] = random_name
+  end
+
+  def anonymize_change_content issue, seen_author_raws
+    issue.changes.each do |change|
+      anonymize_author_raw change.author_raw, seen_author_raws
+      next unless change.comment? || change.description?
+
+      change.value = nil
+      change.old_value = nil
+    end
+  end
+
   def anonymize_labels_and_components
     @issues.each do |issue|
       issue.raw['fields']['labels'] = []
@@ -110,7 +119,7 @@ class Anonymizer < ChartBase
 
   def anonymize_server_url
     @all_boards.each_value do |board|
-      board.raw['self'] = board.raw['self']&.sub(/^https?:\/\/[^\/]+/, 'https://anon.example.com')
+      board.raw['self'] = board.raw['self']&.sub(%r{^https?://[^/]+}, 'https://anon.example.com')
     end
   end
 
@@ -126,70 +135,6 @@ class Anonymizer < ChartBase
     end
   end
 
-  def build_status_name_hash
-    next_status = 'a'
-    status_name_hash = {}
-    @issues.each do |issue|
-      issue.changes.each do |change|
-        next unless change.status?
-
-        # TODO: Do old value too
-        status_key = change.value
-        if status_name_hash[status_key].nil?
-          status_name_hash[status_key] = "status-#{next_status}"
-          next_status = next_status.next
-        end
-      end
-    end
-
-    @possible_statuses.each do |status|
-      status_key = status.name
-      if status_name_hash[status_key].nil?
-        status_name_hash[status_key] = "status-#{next_status}"
-        next_status = next_status.next
-      end
-    end
-
-    status_name_hash
-  end
-
-  def anonymize_issue_statuses
-    @file_system.log 'Anonymizing issue statuses and status categories'
-    status_name_hash = build_status_name_hash
-
-    @issues.each do |issue|
-      # This is where we create URL's from
-      issue.raw['self'] = nil
-
-      issue.changes.each do |change|
-        next unless change.status?
-
-        status_key = change.value
-        anonymized_value = status_name_hash[status_key]
-        raise "status_name_hash[#{status_key.inspect} is nil" if anonymized_value.nil?
-
-        change.value = anonymized_value
-
-        next if change.old_value.nil?
-
-        status_key = change.old_value
-        anonymized_value = status_name_hash[status_key]
-        raise "status_name_hash[#{status_key.inspect} is nil" if anonymized_value.nil?
-
-        change.old_value = anonymized_value
-      end
-    end
-
-    @possible_statuses.each do |status|
-      status_key = status.name
-      if status_name_hash[status_key].nil?
-        raise "Can't find status_key #{status_key.inspect} in #{status_name_hash.inspect}"
-      end
-
-      status.name = status_name_hash[status_key] unless status_name_hash[status_key].nil?
-    end
-  end
-
   def shift_all_dates date_adjustment: @date_adjustment
     adjustment_in_seconds = 60 * 60 * 24 * date_adjustment
     @file_system.log "Shifting all dates by #{label_days date_adjustment}"
@@ -250,9 +195,9 @@ class Anonymizer < ChartBase
 
   def anonymize_author_raw author_raw, seen
     return unless author_raw
-    return if seen[author_raw.object_id]
+    return if seen[author_raw]
 
-    seen[author_raw.object_id] = true
+    seen[author_raw] = true
     name = random_name
     author_raw['displayName'] = name
     author_raw['name'] = name