jirametrics 2.31 → 3.0

data/lib/jirametrics/flow_efficiency_scatterplot.rb

@@ -7,7 +7,8 @@ class FlowEfficiencyScatterplot < ChartBase
 
   attr_accessor :possible_statuses
 
-  def initialize block
+  # Long only because of the inline description_text heredoc and one-time setup; splitting wouldn't help.
+  def initialize block # rubocop:disable Metrics/MethodLength
     super()
 
     header_text 'Flow Efficiency'
@@ -63,7 +64,8 @@ class FlowEfficiencyScatterplot < ChartBase
     end
 
     if data_sets.empty?
-      return "<h1 class='foldable'>#{@header_text}</h1><div>No data matched the selected criteria. Nothing to show.</div>"
+      return "<h1 class='foldable'>#{@header_text}</h1>" \
+        '<div>No data matched the selected criteria. Nothing to show.</div>'
     end
 
     wrap_and_render(binding, __FILE__)

data/lib/jirametrics/github_gateway.rb

@@ -139,14 +139,18 @@ class GithubGateway
       # fallback fetches the complete set rather than us caching a partial answer.
       next if commits['totalCount'] && commits['totalCount'] > nodes.size
 
-      messages_by_number[number] = nodes.flat_map do |node|
-        commit = node['commit'] || {}
-        [commit['messageHeadline'], commit['messageBody']].compact
-      end
+      messages_by_number[number] = commit_messages_from(nodes)
     end
     messages_by_number
   end
 
+  def commit_messages_from nodes
+    nodes.flat_map do |node|
+      commit = node['commit'] || {}
+      [commit['messageHeadline'], commit['messageBody']].compact
+    end
+  end
+
   def owner_and_name
     # @repo may be a full URL (https://github.com/owner/name.git) or an owner/name slug.
     @repo.sub(%r{\Ahttps?://[^/]+/}, '').delete_suffix('.git').split('/', 2)
@@ -195,6 +199,11 @@ class GithubGateway
       unless status.success?
         error_message = "  GitHub CLI command failed for #{@repo} " \
                         "(attempt #{attempts}/#{MAX_RETRIES}): #{stderr.strip}"
+        # stderr is a String (from Open3.capture3), so this include? is String#include? — a substring
+        # match ("does the error text contain this phrase?"), not Array membership. Style/ArrayIntersect
+        # can't tell the two apart; its `.intersect?(stderr)` rewrite would be an exact-equality check
+        # that never matches, silently killing the retry-on-transient-error logic.
+        # rubocop:disable Style/ArrayIntersect
         if attempts < MAX_RETRIES && TRANSIENT_ERROR_PATTERNS.any? { |pattern| stderr.include?(pattern) }
           delay = 2**attempts
           @file_system.log error_message
@@ -202,15 +211,20 @@ class GithubGateway
           sleep delay
           next
         end
+        # rubocop:enable Style/ArrayIntersect
         @file_system.warning error_message
         raise "GitHub CLI command failed for #{@repo}: #{stderr}"
       end
 
-      result = JSON.parse(stdout)
-      if result.nil? || (result.is_a?(Array) && result.empty?)
-        @file_system.warning "No data was found in GitHub for #{@repo}. Is that what you expected?"
-      end
-      return result
+      return parse_command_result(stdout)
+    end
+  end
+
+  def parse_command_result stdout
+    result = JSON.parse(stdout)
+    if result.nil? || (result.is_a?(Array) && result.empty?)
+      @file_system.warning "No data was found in GitHub for #{@repo}. Is that what you expected?"
     end
+    result
   end
 end

data/lib/jirametrics/groupable_issue_chart.rb

@@ -4,6 +4,9 @@ require 'jirametrics/rules'
 require 'jirametrics/grouping_rules'
 
 module GroupableIssueChart
+  attr_accessor :issue_hints, :issue_periods
+  attr_reader :group_by_block
+
   def init_configuration_block user_provided_block, &default_block
     instance_eval(&user_provided_block)
     instance_eval(&default_block) unless @group_by_block

data/lib/jirametrics/html/index.css

@@ -74,6 +74,10 @@
   --sprint-burndown-sprint-color-6: #56B4E9;  /* Okabe-Ito sky blue */
   --sprint-burndown-sprint-color-7: #F0E442;  /* Okabe-Ito yellow */
 
+  --cfd-triangle-color: #333333;                          /* dark triangle on light background */
+  --cfd-arrival-rate-line-color: rgba(255,138,101,0.85);  /* orange */
+  --cfd-departure-rate-line-color: rgba(128,203,196,0.85);  /* teal */
+
   --sprint-color: #56B4E9;  /* Okabe-Ito sky blue */
 
   --daily-view-selected-issue-background: lightgray;
@@ -253,6 +257,7 @@ html[data-theme="dark"] {
   --expedited-chart-dot-expedite-started-color: #E69F00;
   --expedited-chart-dot-expedite-stopped-color: #2DCB9A;
   --sprint-burndown-sprint-color-1: #56B4E9;  /* sky blue */
+  --cfd-triangle-color: #ffffff;  /* light triangle on dark background */
   --sprint-burndown-sprint-color-3: #2DCB9A;  /* lighter bluish green */
   --sprint-burndown-sprint-color-4: #CC79A7;  /* reddish purple (vermilion → orange conflicts with color-2) */
   --sprint-burndown-sprint-color-5: #F0E442;  /* yellow */
@@ -407,6 +412,7 @@ html[data-theme="light"] {
     --expedited-chart-dot-expedite-stopped-color: #2DCB9A;
 
     --sprint-burndown-sprint-color-1: #56B4E9;  /* sky blue */
+    --cfd-triangle-color: #ffffff;  /* light triangle on dark background */
     --sprint-burndown-sprint-color-3: #2DCB9A;  /* lighter bluish green */
     --sprint-burndown-sprint-color-4: #CC79A7;  /* reddish purple (vermilion → orange conflicts with color-2) */
     --sprint-burndown-sprint-color-5: #F0E442;  /* yellow */

data/lib/jirametrics/html_report_config.rb

@@ -8,23 +8,6 @@ class HtmlReportConfig < HtmlGenerator
 
   attr_reader :file_config, :sections, :charts
 
-  def self.define_chart name:, classname:, deprecated_warning: nil, deprecated_date: nil
-    lines = []
-    lines << "def #{name} &block"
-    lines << '  block = ->(_) {} unless block'
-    if deprecated_warning
-      lines << "  file_system.deprecated date: #{deprecated_date.inspect}, message: #{deprecated_warning.inspect}"
-    end
-    lines << "  execute_chart #{classname}.new(block)"
-    lines << 'end'
-    module_eval lines.join("\n"), __FILE__, __LINE__
-  end
-
-  define_chart name: 'daily_wip_by_type', classname: 'DailyWipChart',
-    deprecated_warning: 'This is the same as daily_wip_chart. Please use that one', deprecated_date: '2024-05-23'
-  define_chart name: 'story_point_accuracy_chart', classname: 'EstimateAccuracyChart',
-    deprecated_warning: 'Renamed to estimate_accuracy_chart. Please use that one', deprecated_date: '2024-05-23'
-
   def initialize file_config:, block:
     super()
     @file_config = file_config
@@ -55,10 +38,7 @@ class HtmlReportConfig < HtmlGenerator
   end
 
   def execute_chart_per_board klass:, block:, board_id:
-    all_boards = @file_config.project_config.all_boards
-    ids = board_id ? [board_id] : issues.collect { |i| i.board.id }.uniq
-    ids = ids.sort_by { |id| all_boards[id]&.name || '' }
-    ids.each_with_index do |id, index|
+    board_ids(board_id).each_with_index do |id, index|
       execute_chart(klass.new(block)) do |chart|
         chart.board_id = id
         # We're showing the description only on the first one in order to reduce noise on the report
@@ -67,6 +47,14 @@ class HtmlReportConfig < HtmlGenerator
     end
   end
 
+  # The boards to draw this chart for, sorted by name: just the requested one, or every board the
+  # issues touch.
+  def board_ids board_id
+    all_boards = @file_config.project_config.all_boards
+    ids = board_id ? [board_id] : issues.collect { |issue| issue.board.id }.uniq
+    ids.sort_by { |id| all_boards[id]&.name || '' }
+  end
+
   def respond_to_missing? name, include_private = false
     class_name = name.to_s.split('_').map(&:capitalize).join
     !resolve_chart_class(class_name).nil? || super
@@ -200,12 +188,4 @@ class HtmlReportConfig < HtmlGenerator
       </section>
     HTML
   end
-
-  def discard_changes_before status_becomes: nil, &block
-    file_system.deprecated(
-      date: '2025-01-09',
-      message: 'discard_changes_before is now only supported at the project level'
-    )
-    file_config.project_config.discard_changes_before status_becomes: status_becomes, &block
-  end
 end