jirametrics 2.6 → 2.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 749f92d4329a18999bf8954aee5b41955047ef263d7a37fe766b2233d697a8c9
-  data.tar.gz: f174b2241d23a3d7a9ff34b20093ff0716406197563df4b7f4f6447773fc7a51
+  metadata.gz: d5bb71d8f3c6ab4cf1fa17ad93ad1c00ba1b8381c196bc15a054095a5a91917a
+  data.tar.gz: 790abb0404719d6b55d833ad76d34121875997f3ec3967f69f5d467fae203752
 SHA512:
-  metadata.gz: f89eb6c1a9655163d91b19d9f5b92f79a7d714e6b45fe53e972248f20c5d788a356e6d5be0cbfe24a70665381bf0a7a28ce898b0e31cef9c4c3349d8ce335558
-  data.tar.gz: b95ee06e9b3ef78aba0635aa634fa56082da2aa8bfa759f7e38be2eb2b6889a04a23e99dc8aa9a021391d8db4fe797247fb2b9379c5801fc2c5ec7a3bc3ff103
+  metadata.gz: f71c2ae123a13435a1147ceaadf7f10364a6cdf1421b4f8491633936189e3744e58da4d99be6c43c6e8034d5f27afc470498532157ac15a7d4459a0399f6fc12
+  data.tar.gz: f33eb0ea450d6002b09d84311823fc20847327bb78dca5fa218c3f724a23f02d49f4ef0183e9dc02499e0eea1f5916147396538751192974926e1c197f4f0bb5

data/lib/jirametrics/aggregate_config.rb

@@ -62,7 +62,12 @@ class AggregateConfig
           'the first file section'
       end
     end
-    @project_config.add_issues issues
+
+    if issues.nil?
+      log "No issues found for #{project_name}"
+    else
+      @project_config.add_issues issues
+    end
   end
 
   def find_time_range projects:

data/lib/jirametrics/aging_work_bar_chart.rb

@@ -53,8 +53,8 @@ class AgingWorkBarChart < ChartBase
     percentage_line_x = date_range.end - calculate_percent_line if percentage
 
     if aging_issues.empty?
-      @description_text = "<p>There is no aging work</p>"
-      return render_top_text(binding) #if aging_issues.empty?
+      @description_text = '<p>There is no aging work</p>'
+      return render_top_text(binding)
     end
 
     wrap_and_render(binding, __FILE__)
@@ -62,7 +62,7 @@ class AgingWorkBarChart < ChartBase
 
   def data_sets_for_one_issue issue:, today:
     cycletime = issue.board.cycletime
-    issue_start_time = cycletime.started_time(issue)
+    issue_start_time, _stopped_time = cycletime.started_stopped_times(issue)
     issue_start_date = issue_start_time.to_date
     issue_label = "[#{label_days cycletime.age(issue, today: today)}] #{issue.key}: #{issue.summary}"[0..60]
     [
@@ -92,8 +92,8 @@ class AgingWorkBarChart < ChartBase
 
   def select_aging_issues issues:
     issues.select do |issue|
-      cycletime = issue.board.cycletime
-      cycletime.started_time(issue) && cycletime.stopped_time(issue).nil?
+      started_time, stopped_time = issue.board.cycletime.started_stopped_times(issue)
+      started_time && stopped_time.nil?
     end
   end
 
@@ -107,7 +107,7 @@ class AgingWorkBarChart < ChartBase
   def status_data_sets issue:, label:, today:
     cycletime = issue.board.cycletime
 
-    issue_started_time = cycletime.started_time(issue)
+    issue_started_time, _issue_stopped_time = cycletime.started_stopped_times(issue)
 
     previous_start = nil
     previous_status = nil

data/lib/jirametrics/aging_work_in_progress_chart.rb

@@ -114,7 +114,7 @@ class AgingWorkInProgressChart < ChartBase
   def ages_of_issues_that_crossed_column_boundary issues:, status_ids:
     issues.filter_map do |issue|
       stop = issue.first_time_in_status(*status_ids)
-      start = issue.board.cycletime.started_time(issue)
+      start, = issue.board.cycletime.started_stopped_times(issue)
 
       # Skip if either it hasn't crossed the boundary or we can't tell when it started.
       next if stop.nil? || start.nil?

data/lib/jirametrics/aging_work_table.rb

@@ -36,16 +36,15 @@ class AgingWorkTable < ChartBase
 
   def expedited_but_not_started
     @issues.select do |issue|
-      cycletime = issue.board.cycletime
-      cycletime.started_time(issue).nil? && cycletime.stopped_time(issue).nil? && issue.expedited?
+      started_time, stopped_time = issue.board.cycletime.started_stopped_times(issue)
+      started_time.nil? && stopped_time.nil? && issue.expedited?
     end.sort_by(&:created)
   end
 
   def select_aging_issues
     aging_issues = @issues.select do |issue|
       cycletime = issue.board.cycletime
-      started = cycletime.started_time(issue)
-      stopped = cycletime.stopped_time(issue)
+      started, stopped = cycletime.started_stopped_times(issue)
       next false if started.nil? || stopped
       next true if issue.blocked_on_date?(@today, end_time: time_range.end) || issue.expedited?
 
@@ -64,7 +63,7 @@ class AgingWorkTable < ChartBase
   end
 
   def blocked_text issue
-    started_time = issue.board.cycletime.started_time(issue)
+    started_time, _stopped_time = issue.board.cycletime.started_stopped_times(issue)
     return nil if started_time.nil?
 
     current = issue.blocked_stalled_changes(end_time: time_range.end)[-1]

data/lib/jirametrics/blocked_stalled_change.rb

@@ -47,7 +47,7 @@ class BlockedStalledChange
   end
 
   def inspect
-    text = +"BlockedStalledChange(time: '#{@time}', "
+    text = "BlockedStalledChange(time: '#{@time}', "
     if active?
       text << 'Active'
     else

data/lib/jirametrics/board.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class Board
-  attr_reader :visible_columns, :raw, :possible_statuses, :sprints, :backlog_statuses
+  attr_reader :visible_columns, :raw, :possible_statuses, :sprints, :board_type
   attr_accessor :cycletime, :project_config
 
   def initialize raw:, possible_statuses: StatusCollection.new
@@ -15,24 +15,26 @@ class Board
     # For a Kanban board, the first column here will always be called 'Backlog' and will NOT be
     # visible on the board. If the board is configured to have a kanban backlog then it will have
     # statuses matched to it and otherwise, there will be no statuses.
-    if kanban?
-      @backlog_statuses = @possible_statuses.expand_statuses(status_ids_from_column columns[0]) do |unknown_status|
-        # There is a status defined as being 'backlog' that is no longer being returned in statuses.
-        # We used to display a warning for this but honestly, there is nothing that anyone can do about it
-        # so now we just quietly ignore it.
-      end
-      columns = columns[1..]
-    else
-      # We currently don't know how to get the backlog status for a Scrum board
-      @backlog_statuses = []
-    end
+    columns = columns[1..] if kanban?
 
+    @backlog_statuses = []
     @visible_columns = columns.filter_map do |column|
       # It's possible for a column to be defined without any statuses and in this case, it won't be visible.
       BoardColumn.new column unless status_ids_from_column(column).empty?
     end
   end
 
+  def backlog_statuses
+    if @backlog_statuses.empty? && kanban?
+      status_ids = status_ids_from_column raw['columnConfig']['columns'].first
+      @backlog_statuses = @possible_statuses.expand_statuses(status_ids) do |unknown_status|
+        # If a status is returned here that is no longer in the system then there's nothing useful
+        # we can do about it. Ignore it.
+      end
+    end
+    @backlog_statuses
+  end
+
   def server_url_prefix
     raise "Cannot parse self: #{@raw['self'].inspect}" unless @raw['self'] =~ /^(https?:\/\/.+)\/rest\//
 

data/lib/jirametrics/chart_base.rb

@@ -25,6 +25,14 @@ class ChartBase
     @aggregated_project
   end
 
+  def html_directory
+    pathname = Pathname.new(File.realpath(__FILE__))
+    # basename = pathname.basename.to_s
+    # raise "Unexpected filename #{basename.inspect}" unless basename.match?(/^(.+)\.rb$/)
+
+    "#{pathname.dirname}/html"
+  end
+
   def render caller_binding, file
     pathname = Pathname.new(File.realpath(file))
     basename = pathname.basename.to_s
@@ -33,8 +41,8 @@ class ChartBase
     # Insert a incrementing chart_id so that all the chart names on the page are unique
     caller_binding.eval "chart_id='chart#{next_id}'" # chart_id=chart3
 
-    @html_directory = "#{pathname.dirname}/html"
-    erb = ERB.new file_system.load "#{@html_directory}/#{$1}.erb"
+    # @html_directory = "#{pathname.dirname}/html"
+    erb = ERB.new file_system.load "#{html_directory}/#{$1}.erb"
     erb.result(caller_binding)
   end
 
@@ -100,7 +108,7 @@ class ChartBase
     issues_id = next_id
 
     issue_descriptions.sort! { |a, b| a[0].key_as_i <=> b[0].key_as_i }
-    erb = ERB.new file_system.load "#{@html_directory}/collapsible_issues_panel.erb"
+    erb = ERB.new file_system.load File.join(html_directory, 'collapsible_issues_panel.erb')
     erb.result(binding)
   end
 
@@ -144,8 +152,7 @@ class ChartBase
   def completed_issues_in_range include_unstarted: false
     issues.select do |issue|
       cycletime = issue.board.cycletime
-      stopped_time = cycletime.stopped_time(issue)
-      started_time = cycletime.started_time(issue)
+      started_time, stopped_time = cycletime.started_stopped_times(issue)
 
       stopped_time &&
         date_range.include?(stopped_time.to_date) && # Remove outside range
@@ -179,7 +186,7 @@ class ChartBase
   def format_status name_or_id, board:, is_category: false
     begin
       statuses = board.possible_statuses.expand_statuses([name_or_id])
-    rescue StatusNotFoundError => e
+    rescue StatusNotFoundError
       return "<span style='color: red'>#{name_or_id}</span>"
     end
 
@@ -189,10 +196,9 @@ class ChartBase
     visibility = ''
     if is_category == false && board.visible_columns.none? { |column| column.status_ids.include? status.id }
       visibility = icon_span(
-      title: "Not visible: The status #{status.name.inspect} is not mapped to any column and will not be visible",
-      icon: ' 👀'
-    )
-
+        title: "Not visible: The status #{status.name.inspect} is not mapped to any column and will not be visible",
+        icon: ' 👀'
+      )
     end
     text = is_category ? status.category_name : status.name
     "<span title='Category: #{status.category_name}'>#{color_block color.name} #{text}</span>#{visibility}"

data/lib/jirametrics/cycletime_config.rb

@@ -26,31 +26,50 @@ class CycleTimeConfig
   end
 
   def in_progress? issue
-    started_time(issue) && stopped_time(issue).nil?
+    started_time, stopped_time = started_stopped_times(issue)
+    started_time && stopped_time.nil?
   end
 
   def done? issue
-    stopped_time(issue)
+    started_stopped_times(issue).last
   end
 
   def started_time issue
-    @start_at.call(issue)
+    deprecated date: '2024-10-16', message: 'Use started_stopped_times() instead'
+    started_stopped_times(issue).first
   end
 
   def stopped_time issue
-    @stop_at.call(issue)
+    deprecated date: '2024-10-16', message: 'Use started_stopped_times() instead'
+    started_stopped_times(issue).last
+  end
+
+  def started_stopped_times issue
+    started = @start_at.call(issue)
+    stopped = @stop_at.call(issue)
+
+    # In the case where started and stopped are exactly the same time, we pretend that
+    # it just stopped and never started. This allows us to have logic like 'in or right of'
+    # for the start and not have it conflict.
+    started = nil if started == stopped
+
+    [started, stopped]
+  end
+
+  def started_stopped_dates issue
+    started_time, stopped_time = started_stopped_times(issue)
+    [started_time&.to_date, stopped_time&.to_date]
   end
 
   def cycletime issue
-    start = started_time(issue)
-    stop = stopped_time(issue)
+    start, stop = started_stopped_times(issue)
     return nil if start.nil? || stop.nil?
 
     (stop.to_date - start.to_date).to_i + 1
   end
 
   def age issue, today: nil
-    start = started_time(issue)
+    start = started_stopped_times(issue).first
     stop = today || @today || Date.today
     return nil if start.nil? || stop.nil?
 

data/lib/jirametrics/cycletime_histogram.rb

@@ -30,7 +30,7 @@ class CycletimeHistogram < ChartBase
     stopped_issues = completed_issues_in_range include_unstarted: true
 
     # For the histogram, we only want to consider items that have both a start and a stop time.
-    histogram_issues = stopped_issues.select { |issue| issue.board.cycletime.started_time(issue) }
+    histogram_issues = stopped_issues.select { |issue| issue.board.cycletime.started_stopped_times(issue).first }
     rules_to_issues = group_issues histogram_issues
 
     data_sets = rules_to_issues.keys.collect do |rules|

data/lib/jirametrics/cycletime_scatterplot.rb

@@ -24,7 +24,7 @@ class CycletimeScatterplot < ChartBase
         predict that most work of this type will complete in <%= overall_percent_line %> days or
         less. The other lines reflect the 85% line for that respective type of work.
       </div>
-      #{ describe_non_working_days }
+      #{describe_non_working_days}
     HTML
 
     init_configuration_block block do
@@ -53,10 +53,7 @@ class CycletimeScatterplot < ChartBase
   def create_datasets completed_issues
     data_sets = []
 
-    groups = group_issues completed_issues
-
-    groups.each_key do |rules|
-      completed_issues_by_type = groups[rules]
+    group_issues(completed_issues).each do |rules, completed_issues_by_type|
       label = rules.label
       color = rules.color
       percent_line = calculate_percent_line completed_issues_by_type
@@ -117,7 +114,7 @@ class CycletimeScatterplot < ChartBase
 
     {
       y: cycle_time,
-      x: chart_format(issue.board.cycletime.stopped_time(issue)),
+      x: chart_format(issue.board.cycletime.started_stopped_times(issue).last),
       title: ["#{issue.key} : #{issue.summary} (#{label_days(cycle_time)})"]
     }
   end

data/lib/jirametrics/daily_wip_by_age_chart.rb

@@ -4,7 +4,7 @@ require 'jirametrics/daily_wip_chart'
 
 class DailyWipByAgeChart < DailyWipChart
   def initialize block
-    super(block)
+    super
 
     add_trend_line line_color: '--aging-work-in-progress-by-age-trend-line-color', group_labels: [
       'Less than a day',
@@ -49,9 +49,7 @@ class DailyWipByAgeChart < DailyWipChart
   end
 
   def default_grouping_rules issue:, rules:
-    cycletime = issue.board.cycletime
-    started = cycletime.started_time(issue)&.to_date
-    stopped = cycletime.stopped_time(issue)&.to_date
+    started, stopped = issue.board.cycletime.started_stopped_dates(issue)
 
     rules.issue_hint = "(age: #{label_days (rules.current_date - started + 1).to_i})" if started
 

data/lib/jirametrics/daily_wip_by_blocked_stalled_chart.rb

@@ -39,8 +39,8 @@ class DailyWipByBlockedStalledChart < DailyWipChart
   end
 
   def default_grouping_rules issue:, rules:
-    started = issue.board.cycletime.started_time(issue)
-    stopped_date = issue.board.cycletime.stopped_time(issue)&.to_date
+    started, stopped = issue.board.cycletime.started_stopped_times(issue)
+    stopped_date = stopped&.to_date
 
     date = rules.current_date
     change = issue.blocked_stalled_by_date(date_range: date..date, chart_end_time: time_range.end)[date]

data/lib/jirametrics/daily_wip_by_parent_chart.rb

@@ -3,10 +3,6 @@
 require 'jirametrics/daily_wip_chart'
 
 class DailyWipByParentChart < DailyWipChart
-  def initialize block
-    super(block)
-  end
-
   def default_header_text
     'Daily WIP, grouped by the parent ticket (Epic, Feature, etc)'
   end

data/lib/jirametrics/daily_wip_chart.rb

@@ -6,7 +6,7 @@ class DailyGroupingRules < GroupingRules
   attr_accessor :current_date, :group_priority, :issue_hint
 
   def initialize
-    super()
+    super
     @group_priority = 0
   end
 end
@@ -22,10 +22,10 @@ class DailyWipChart < ChartBase
 
     instance_eval(&block) if block
 
-    unless @group_by_block
-      grouping_rules do |issue, rules|
-        default_grouping_rules issue: issue, rules: rules
-      end
+    return if @group_by_block
+
+    grouping_rules do |issue, rules|
+      default_grouping_rules issue: issue, rules: rules
     end
   end
 
@@ -66,9 +66,7 @@ class DailyWipChart < ChartBase
     hash = {}
 
     @issues.each do |issue|
-      cycletime = issue.board.cycletime
-      start = cycletime.started_time(issue)&.to_date
-      stop = cycletime.stopped_time(issue)&.to_date
+      start, stop = issue.board.cycletime.started_stopped_dates(issue)
       next if start.nil? && stop.nil?
 
       # If it stopped but never started then assume it started at creation so the data points
@@ -158,7 +156,7 @@ class DailyWipChart < ChartBase
 
     {
       type: 'line',
-      label: "Trendline",
+      label: 'Trendline',
       data: data_points,
       fill: false,
       borderWidth: 1,

data/lib/jirametrics/data_quality_report.rb

@@ -48,6 +48,7 @@ class DataQualityReport < ChartBase
       scan_for_issues_not_created_in_a_backlog_status entry: entry, backlog_statuses: backlog_statuses
       scan_for_stopped_before_started entry: entry
       scan_for_issues_not_started_with_subtasks_that_have entry: entry
+      scan_for_incomplete_subtasks_when_issue_done entry: entry
       scan_for_discarded_data entry: entry
     end
 
@@ -56,7 +57,25 @@ class DataQualityReport < ChartBase
     entries_with_problems = entries_with_problems()
     return '' if entries_with_problems.empty?
 
-    wrap_and_render(binding, __FILE__)
+    caller_binding = binding
+    result = +''
+    result << render_top_text(caller_binding)
+
+    result << '<ul class="quality_report">'
+    result << render_problem_type(:discarded_changes)
+    result << render_problem_type(:completed_but_not_started)
+    result << render_problem_type(:status_changes_after_done)
+    result << render_problem_type(:backwards_through_status_categories)
+    result << render_problem_type(:backwords_through_statuses)
+    result << render_problem_type(:status_not_on_board)
+    result << render_problem_type(:created_in_wrong_status)
+    result << render_problem_type(:stopped_before_started)
+    result << render_problem_type(:issue_not_started_but_subtasks_have)
+    result << render_problem_type(:incomplete_subtasks_when_issue_done)
+    result << render_problem_type(:issue_on_multiple_boards)
+    result << '</ul>'
+
+    result
   end
 
   def problems_for key
@@ -69,6 +88,18 @@ class DataQualityReport < ChartBase
     result
   end
 
+  def render_problem_type problem_key
+    problems = problems_for problem_key
+    return '' if problems.empty?
+
+    <<-HTML
+      <li>
+        #{__send__ :"render_#{problem_key}", problems}
+        #{collapsible_issues_panel problems}
+      </li>
+    HTML
+  end
+
   # Return a format that's easier to assert against
   def testable_entries
     format = '%Y-%m-%d %H:%M:%S %z'
@@ -87,9 +118,7 @@ class DataQualityReport < ChartBase
 
   def initialize_entries
     @entries = @issues.filter_map do |issue|
-      cycletime = issue.board.cycletime
-      started = cycletime.started_time(issue)
-      stopped = cycletime.stopped_time(issue)
+      started, stopped = issue.board.cycletime.started_stopped_times(issue)
       next if stopped && stopped < time_range.begin
       next if started && started > time_range.end
 
@@ -223,14 +252,13 @@ class DataQualityReport < ChartBase
 
     started_subtasks = []
     entry.issue.subtasks.each do |subtask|
-      started_subtasks << subtask if subtask.board.cycletime.started_time(subtask)
+      started_subtasks << subtask if subtask.board.cycletime.started_stopped_times(subtask).first
     end
 
     return if started_subtasks.empty?
 
     subtask_labels = started_subtasks.collect do |subtask|
-      "Started subtask: #{link_to_issue(subtask)} (#{format_status subtask.status.name, board: entry.issue.board}) " \
-        "#{subtask.summary[..50].inspect}"
+      subtask_label(subtask)
     end
     entry.report(
       problem_key: :issue_not_started_but_subtasks_have,
@@ -238,6 +266,47 @@ class DataQualityReport < ChartBase
     )
   end
 
+  def subtask_label subtask
+    "<img src='#{subtask.type_icon_url}' /> #{link_to_issue(subtask)} #{subtask.summary[..50].inspect}"
+  end
+
+  def time_as_english(from_time, to_time)
+    delta = (to_time - from_time).to_i
+    return "#{delta} seconds" if delta < 60
+
+    delta /= 60
+    return "#{delta} minutes" if delta < 60
+
+    delta /= 60
+    return "#{delta} hours" if delta < 24
+
+    delta /= 24
+    "#{delta} days"
+  end
+
+  def scan_for_incomplete_subtasks_when_issue_done entry:
+    return unless entry.stopped
+
+    subtask_labels = entry.issue.subtasks.filter_map do |subtask|
+      subtask_started, subtask_stopped = subtask.board.cycletime.started_stopped_times(subtask)
+
+      if !subtask_started && !subtask_stopped
+        "#{subtask_label subtask} (Not even started)"
+      elsif !subtask_stopped
+        "#{subtask_label subtask} (Still not done)"
+      elsif subtask_stopped > entry.stopped
+        "#{subtask_label subtask} (Closed #{time_as_english entry.stopped, subtask_stopped} later)"
+      end
+    end
+
+    return if subtask_labels.empty?
+
+    entry.report(
+      problem_key: :incomplete_subtasks_when_issue_done,
+      detail: subtask_labels.join('<br />')
+    )
+  end
+
   def label_issues number
     return '1 item' if number == 1
 
@@ -278,4 +347,94 @@ class DataQualityReport < ChartBase
       )
     end
   end
+
+  def render_discarded_changes problems
+    <<-HTML
+      #{label_issues problems.size} have had information discarded. This configuration is set
+      to "reset the clock" if an item is moved back to the backlog after it's been started. This hides important
+      information and makes the data less accurate. <b>Moving items back to the backlog is strongly discouraged.</b>      HTML
+    HTML
+  end
+
+  def render_completed_but_not_started problems
+    percentage_work_included = ((issues.size - problems.size).to_f / issues.size * 100).to_i
+    html = <<-HTML
+      #{label_issues problems.size} were discarded from all charts using cycletime (scatterplot, histogram, etc)
+      as we couldn't determine when they started.
+    HTML
+    if percentage_work_included < 85
+      html << <<-HTML
+        Consider whether looking at only #{percentage_work_included}% of the total data points is enough
+        to come to any reasonable conclusions. See <a href="https://en.wikipedia.org/wiki/Survivorship_bias">
+        Survivorship Bias</a>.
+      HTML
+    end
+    html
+  end
+
+  def render_status_changes_after_done problems
+    <<-HTML
+      #{label_issues problems.size} had a status change after being identified as done. We should question
+      whether they were really done at that point or if we stopped the clock too early.
+    HTML
+  end
+
+  def render_backwards_through_status_categories problems
+    <<-HTML
+      #{label_issues problems.size} moved backwards across the board, <b>crossing status categories</b>.
+      This will almost certainly have impacted timings as the end times are often taken at status category
+      boundaries. You should assume that any timing measurements for this item are wrong.
+    HTML
+  end
+
+  def render_backwords_through_statuses problems
+    <<-HTML
+      #{label_issues problems.size} moved backwards across the board. Depending where we have set the
+      start and end points, this may give us incorrect timing data. Note that these items did not cross
+      a status category and may not have affected metrics.
+    HTML
+  end
+
+  def render_status_not_on_board problems
+    <<-HTML
+      #{label_issues problems.size} were not visible on the board for some period of time. This may impact
+      timings as the work was likely to have been forgotten if it wasn't visible.
+    HTML
+  end
+
+  def render_created_in_wrong_status problems
+    <<-HTML
+      #{label_issues problems.size} were created in a status not designated as Backlog. This will impact
+      the measurement of start times and will therefore impact whether it's shown as in progress or not.
+    HTML
+  end
+
+  def render_stopped_before_started problems
+    <<-HTML
+      #{label_issues problems.size} were stopped before they were started and this will play havoc with
+      any cycletime or WIP calculations. The most common case for this is when an item gets closed and
+      then moved back into an in-progress status.
+    HTML
+  end
+
+  def render_issue_not_started_but_subtasks_have problems
+    <<-HTML
+      #{label_issues problems.size} still showing 'not started' while sub-tasks underneath them have
+      started. This is almost always a mistake; if we're working on subtasks, the top level item should
+      also have started.
+    HTML
+  end
+
+  def render_incomplete_subtasks_when_issue_done problems
+    <<-HTML
+      #{label_issues problems.size} issues were marked as done while subtasks were still not done.
+    HTML
+  end
+
+  def render_issue_on_multiple_boards problems
+    <<-HTML
+      For #{label_issues problems.size}, we have an issue that shows up on more than one board. This
+      could result in more data points showing up on a chart then there really should be.
+    HTML
+  end
 end

data/lib/jirametrics/dependency_chart.rb

@@ -183,9 +183,8 @@ class DependencyChart < ChartBase
       return stdout.read
     end
   rescue # rubocop:disable Style/RescueStandardError
-    message = "Unable to execute the command 'dot' which is part of graphviz. " \
-      'Ensure that graphviz is installed and that dot is in your path.'
-    puts message
+    message = 'Unable to generate the dependency chart because graphviz could not be found in the path.'
+    file_system.log message, also_write_to_stderr: true
     message
   end
 
@@ -229,7 +228,7 @@ class DependencyChart < ChartBase
       elsif is_done
         line2 << 'Done'
       else
-        started_at = issue.board.cycletime.started_time(issue)
+        started_at = issue.board.cycletime.started_stopped_times(issue).first
         if started_at.nil?
           line2 << 'Not started'
         else

data/lib/jirametrics/discard_changes_before.rb

@@ -31,7 +31,7 @@ module DiscardChangesBefore
     discard_changes_before_hook issues_cutoff_times
 
     issues_cutoff_times.each do |issue, cutoff_time|
-      issue.changes.reject! { |change| change.status? && change.time <= cutoff_time && change.artificial? == false }
+      issue.discard_changes_before cutoff_time
     end
   end
 end