jira-ruby 0.1.9 → 0.1.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a91329011e2ccf157d07936d501a70beb8ce35e2
-  data.tar.gz: d1dbd212719b220640475549e59e78a5d861d048
+  metadata.gz: cc4f6eb059f491b8aeaf07b2ee453aa9eee6687b
+  data.tar.gz: 29f02ed0e3c66b1a06d71342cf7e04574d282c94
 SHA512:
-  metadata.gz: c1eb6f1379630c0899d7ea4cc60ed8c2ddf1addef20ee8efc0d2a9d0d9881d5a746634e4e4774cab7fdbe9d13a8426b4530a2111dde82dedc8d1e308474b5437
-  data.tar.gz: 5a3f281268b3203d4cb7480b78523b65d2aa381d9b21c9f3882eb7f255d8dff59936bd752e50c5084463cdc76497049ed6e52bd163394a289f1c2efef95a6d14
+  metadata.gz: 0f176491a5f2ff1558d883f0ac6e5d5b92b2f9aac29a2b6183720e09bfd3ec8a7ae96a12e257f4c92e9f293ddbfc2828287c019dc38a45fb194ac0bcd01d2937
+  data.tar.gz: e3b7707569609d99b6431bc20c9f8def378f15286b161e40d51941b9199343ef930a0ad10bee27c80f24dc7b3596f9da5d3ff752c143d1e13f4fdbc02a628406

data/lib/jira/http_client.rb

@@ -1,5 +1,6 @@
 require 'json'
 require 'net/https'
+require 'cgi/cookie'
 
 module JIRA
   class HttpClient < RequestClient
@@ -13,13 +14,16 @@ module JIRA
 
     def initialize(options)
       @options = DEFAULT_OPTIONS.merge(options)
+      @cookies = {}
     end
 
     def make_request(http_method, path, body='', headers={})
       request = Net::HTTP.const_get(http_method.to_s.capitalize).new(path, headers)
       request.body = body unless body.nil?
+      add_cookies(request) if options[:use_cookies]
       request.basic_auth(@options[:username], @options[:password])
       response = basic_auth_http_conn.request(request)
+      store_cookies(response) if options[:use_cookies]
       response
     end
 
@@ -42,5 +46,24 @@ module JIRA
     def uri
       uri = URI.parse(@options[:site])
     end
+
+    private
+
+    def store_cookies(response)
+      cookies = response.get_fields('set-cookie')
+      if cookies
+        cookies.each do |cookie|
+          data = CGI::Cookie.parse(cookie)
+          data.delete('Path')
+          @cookies.merge!(data)
+        end
+      end
+    end
+
+    def add_cookies(request)
+      cookie_array = @cookies.values.map { |cookie| cookie.to_s }
+      request.add_field('Cookie', cookie_array.join('; ')) if cookie_array.any?
+      request
+    end
   end
 end

data/lib/jira/version.rb

@@ -1,3 +1,3 @@
 module JIRA
-  VERSION = "0.1.9"
-end
+  VERSION = "0.1.10"
+end

data/spec/jira/http_client_spec.rb

@@ -7,12 +7,23 @@ describe JIRA::HttpClient do
     JIRA::HttpClient.new(options)
   end
 
+  let(:basic_cookie_client) do
+    options = JIRA::Client::DEFAULT_OPTIONS.merge(JIRA::HttpClient::DEFAULT_OPTIONS).merge(:use_cookies => true)
+    JIRA::HttpClient.new(options)
+  end
+
   let(:response) do
     response = double("response")
     response.stub(:kind_of?).with(Net::HTTPSuccess).and_return(true)
     response
   end
 
+  let(:cookie_response) do
+    response = double("response")
+    response.stub(:kind_of?).with(Net::HTTPSuccess).and_return(true)
+    response
+  end
+
   it "creates an instance of Net:HTTP for a basic auth client" do
     basic_client.basic_auth_http_conn.class.should == Net::HTTP
   end
@@ -36,6 +47,27 @@ describe JIRA::HttpClient do
     end
   end
 
+  it "gets and sets cookies" do
+    body = ''
+    headers = double()
+    basic_auth_http_conn = double()
+    request = double()
+    basic_cookie_client.stub(:basic_auth_http_conn => basic_auth_http_conn)
+    request.should_receive(:basic_auth).with(basic_cookie_client.options[:username], basic_cookie_client.options[:password]).exactly(5).times.and_return(request)
+    cookie_response.should_receive(:get_fields).with('set-cookie').exactly(5).times
+    basic_auth_http_conn.should_receive(:request).exactly(5).times.with(request).and_return(cookie_response)
+    [:delete, :get, :head].each do |method|
+      Net::HTTP.const_get(method.to_s.capitalize).should_receive(:new).with('/path', headers).and_return(request)
+      basic_cookie_client.make_request(method, '/path', nil, headers).should == cookie_response
+    end
+    [:post, :put].each do |method|
+      Net::HTTP.const_get(method.to_s.capitalize).should_receive(:new).with('/path', headers).and_return(request)
+      request.should_receive(:body=).with(body).and_return(request)
+      basic_cookie_client.make_request(method, '/path', body, headers).should == cookie_response
+    end
+  end
+
+
   it "performs a basic http client request" do
     body = nil
     headers = double()

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: jira-ruby
 version: !ruby/object:Gem::Version
-  version: 0.1.9
+  version: 0.1.10
 platform: ruby
 authors:
 - SUMO Heavy Industries
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-25 00:00:00.000000000 Z
+date: 2014-05-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -225,7 +225,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: jira-ruby
-rubygems_version: 2.2.2
+rubygems_version: 2.0.5
 signing_key: 
 specification_version: 4
 summary: Ruby Gem for use with the Atlassian JIRA REST API