jira-ruby 0.0.4 → 0.1.0

data/lib/jira/request_client.rb

@@ -0,0 +1,18 @@
+require 'oauth'
+require 'json'
+require 'net/https'
+
+module JIRA
+  class RequestClient
+
+    # Returns the response if the request was successful (HTTP::2xx) and
+    # raises a JIRA::HTTPError if it was not successful, with the response
+    # attached.
+
+    def request(*args)
+      response = make_request(*args)
+      raise HTTPError.new(response) unless response.kind_of?(Net::HTTPSuccess)
+      response
+    end
+  end
+end

data/lib/jira/version.rb

@@ -1,3 +1,3 @@
 module JIRA
-  VERSION = "0.0.4"
+  VERSION = "0.1.0"
 end

data/spec/integration/attachment_spec.rb

@@ -2,25 +2,22 @@ require 'spec_helper'
 
 describe JIRA::Resource::Attachment do
 
+  with_each_client do |site_url, client|
+    let(:client) { client }
+    let(:site_url) { site_url }
 
-  let(:client) do
-    client = JIRA::Client.new('foo', 'bar')
-    client.set_access_token('abc', '123')
-    client
-  end
+    let(:key) { "10000" }
 
-  let(:key) { "10000" }
+    let(:expected_attributes) do
+      {
+        'self' => "http://localhost:2990/jira/rest/api/2/attachment/10000",
+        'size' => 15360,
+        'filename' => "ballmer.png"
+      }
+    end
 
-  let(:expected_attributes) do
-    {
-      'self' => "http://localhost:2990/jira/rest/api/2/attachment/10000",
-      'size' => 15360,
-      'filename' => "ballmer.png"
-    }
+    it_should_behave_like "a resource"
+    it_should_behave_like "a resource with a singular GET endpoint"
+    it_should_behave_like "a resource with a DELETE endpoint"
   end
-
-  it_should_behave_like "a resource"
-  it_should_behave_like "a resource with a singular GET endpoint"
-  it_should_behave_like "a resource with a DELETE endpoint"
-
 end

data/spec/integration/comment_spec.rb

@@ -2,54 +2,53 @@ require 'spec_helper'
 
 describe JIRA::Resource::Comment do
 
+  with_each_client do |site_url, client|
+    let(:client) { client }
+    let(:site_url) { site_url }
 
-  let(:client) do
-    client = JIRA::Client.new('foo', 'bar')
-    client.set_access_token('abc', '123')
-    client
-  end
+    let(:key) { "10000" }
 
-  let(:key) { "10000" }
+    let(:target) { JIRA::Resource::Comment.new(client, :attrs => {'id' => '99999'}, :issue_id => '54321') }
 
-  let(:target) { JIRA::Resource::Comment.new(client, :attrs => {'id' => '99999'}, :issue_id => '54321') }
+    let(:expected_collection_length) { 2 }
 
-  let(:expected_collection_length) { 2 }
+    let(:belongs_to) {
+      JIRA::Resource::Issue.new(client, :attrs => {
+        'id' => '10002', 'fields' => {
+          'comment' => {'comments' => []}
+        }
+      })
+    }
 
-  let(:belongs_to) {
-    JIRA::Resource::Issue.new(client, :attrs => {
-      'id' => '10002', 'fields' => {
-        'comment' => {'comments' => []}
+    let(:expected_attributes) do
+      {
+        'self' => "http://localhost:2990/jira/rest/api/2/issue/10002/comment/10000",
+        'id'   => key,
+        'body' => "This is a comment. Creative."
       }
-    })
-  }
-
-  let(:expected_attributes) do
-    {
-      'self' => "http://localhost:2990/jira/rest/api/2/issue/10002/comment/10000",
-      'id'   => key,
-      'body' => "This is a comment. Creative."
+    end
+
+    let(:attributes_for_post) {
+      {"body" => "new comment"}
+    }
+    let(:expected_attributes_from_post) {
+      { "id" => "10001", "body" => "new comment"}
     }
-  end
 
-  let(:attributes_for_post) {
-    {"body" => "new comment"}
-  }
-  let(:expected_attributes_from_post) {
-    { "id" => "10001", "body" => "new comment"}
-  }
-
-  let(:attributes_for_put) {
-    {"body" => "new body"}
-  }
-  let(:expected_attributes_from_put) {
-    { "id" => "10000", "body" => "new body" }
-  }
-
-  it_should_behave_like "a resource"
-  it_should_behave_like "a resource with a collection GET endpoint"
-  it_should_behave_like "a resource with a singular GET endpoint"
-  it_should_behave_like "a resource with a DELETE endpoint"
-  it_should_behave_like "a resource with a POST endpoint"
-  it_should_behave_like "a resource with a PUT endpoint"
+    let(:attributes_for_put) {
+      {"body" => "new body"}
+    }
+    let(:expected_attributes_from_put) {
+      { "id" => "10000", "body" => "new body" }
+    }
+
+    it_should_behave_like "a resource"
+    it_should_behave_like "a resource with a collection GET endpoint"
+    it_should_behave_like "a resource with a singular GET endpoint"
+    it_should_behave_like "a resource with a DELETE endpoint"
+    it_should_behave_like "a resource with a POST endpoint"
+    it_should_behave_like "a resource with a PUT endpoint"
+
+  end
 
 end

data/spec/integration/component_spec.rb

@@ -3,41 +3,40 @@ require 'spec_helper'
 describe JIRA::Resource::Component do
 
 
-  let(:client) do
-    client = JIRA::Client.new('foo', 'bar')
-    client.set_access_token('abc', '123')
-    client
-  end
-
-  let(:key) { "10000" }
+  with_each_client do |site_url, client|
+    let(:client) { client }
+    let(:site_url) { site_url }
+
+    let(:key) { "10000" }
+
+    let(:expected_attributes) do
+      {
+        'self' => "http://localhost:2990/jira/rest/api/2/component/10000",
+        'id'   => key,
+        'name' => "Cheesecake"
+      }
+    end
+
+    let(:attributes_for_post) {
+      {"name" => "Test component", "project" => "SAMPLEPROJECT" }
+    }
+    let(:expected_attributes_from_post) {
+      { "id" => "10001", "name" => "Test component" }
+    }
 
-  let(:expected_attributes) do
-    {
-      'self' => "http://localhost:2990/jira/rest/api/2/component/10000",
-      'id'   => key,
-      'name' => "Cheesecake"
+    let(:attributes_for_put) {
+      {"name" => "Jammy", "project" => "SAMPLEPROJECT" }
+    }
+    let(:expected_attributes_from_put) {
+      { "id" => "10000", "name" => "Jammy" }
     }
-  end
 
-  let(:attributes_for_post) {
-    {"name" => "Test component", "project" => "SAMPLEPROJECT" }
-  }
-  let(:expected_attributes_from_post) {
-    { "id" => "10001", "name" => "Test component" }
-  }
-
-  let(:attributes_for_put) {
-    {"name" => "Jammy", "project" => "SAMPLEPROJECT" }
-  }
-  let(:expected_attributes_from_put) {
-    { "id" => "10000", "name" => "Jammy" }
-  }
-
-  it_should_behave_like "a resource"
-  it_should_behave_like "a resource with a singular GET endpoint"
-  it_should_behave_like "a resource with a DELETE endpoint"
-  it_should_behave_like "a resource with a POST endpoint"
-  it_should_behave_like "a resource with a PUT endpoint"
-  it_should_behave_like "a resource with a PUT endpoint that rejects invalid fields"
+    it_should_behave_like "a resource"
+    it_should_behave_like "a resource with a singular GET endpoint"
+    it_should_behave_like "a resource with a DELETE endpoint"
+    it_should_behave_like "a resource with a POST endpoint"
+    it_should_behave_like "a resource with a PUT endpoint"
+    it_should_behave_like "a resource with a PUT endpoint that rejects invalid fields"
 
+  end
 end

data/spec/integration/issue_spec.rb

@@ -2,74 +2,77 @@ require 'spec_helper'
 
 describe JIRA::Resource::Issue do
 
-  let(:client) do
-    client = JIRA::Client.new('foo', 'bar')
-    client.set_access_token('abc', '123')
-    client
-  end
+  with_each_client do |site_url, client|
+    let(:client) { client }
+    let(:site_url) { site_url }
+
 
-  let(:key) { "10002" }
+    let(:key) { "10002" }
+
+    let(:expected_attributes) do
+      {
+        'self'   => "http://localhost:2990/jira/rest/api/2/issue/10002",
+        'key'    => "SAMPLEPROJECT-1",
+        'expand' => "renderedFields,names,schema,transitions,editmeta,changelog"
+      }
+    end
 
-  let(:expected_attributes) do
-    {
-      'self'   => "http://localhost:2990/jira/rest/api/2/issue/10002",
-      'key'    => "SAMPLEPROJECT-1",
-      'expand' => "renderedFields,names,schema,transitions,editmeta,changelog"
+    let(:attributes_for_post) {
+      { 'foo' => 'bar' }
+    }
+    let(:expected_attributes_from_post) {
+      { "id" => "10005", "key" => "SAMPLEPROJECT-4" }
     }
-  end
 
-  let(:attributes_for_post) {
-    { 'foo' => 'bar' }
-  }
-  let(:expected_attributes_from_post) {
-    { "id" => "10005", "key" => "SAMPLEPROJECT-4" }
-  }
+    let(:attributes_for_put) {
+      { 'foo' => 'bar' }
+    }
+    let(:expected_attributes_from_put) {
+      { 'foo' => 'bar' }
+    }
+    let(:expected_collection_length) { 11 }
 
-  let(:attributes_for_put) {
-    { 'foo' => 'bar' }
-  }
-  let(:expected_attributes_from_put) {
-    { 'foo' => 'bar' }
-  }
-  let(:expected_collection_length) { 11 }
+    it_should_behave_like "a resource"
+    it_should_behave_like "a resource with a singular GET endpoint"
+    describe "GET all issues" do # JIRA::Resource::Issue.all uses the search endpoint
+      let(:client) { client }
+      let(:site_url) { site_url }
 
-  it_should_behave_like "a resource"
-  it_should_behave_like "a resource with a singular GET endpoint"
-  describe "GET all issues" do # JIRA::Resource::Issue.all uses the search endpoint
-    let(:expected_attributes) {
-      {
-        "id"=>"10014",
-        "self"=>"http://localhost:2990/jira/rest/api/2/issue/10014",
-        "key"=>"SAMPLEPROJECT-13"
+      let(:expected_attributes) {
+        {
+          "id"=>"10014",
+          "self"=>"http://localhost:2990/jira/rest/api/2/issue/10014",
+          "key"=>"SAMPLEPROJECT-13"
+        }
       }
-    }
-    before(:each) do
-      stub_request(:get, "http://localhost:2990/jira/rest/api/2/search").
-                  to_return(:status => 200, :body => get_mock_response('issue.json'))
+      before(:each) do
+        stub_request(:get, site_url + "/jira/rest/api/2/search").
+                    to_return(:status => 200, :body => get_mock_response('issue.json'))
+      end
+      it_should_behave_like "a resource with a collection GET endpoint"
     end
-    it_should_behave_like "a resource with a collection GET endpoint"
-  end
-  it_should_behave_like "a resource with a DELETE endpoint"
-  it_should_behave_like "a resource with a POST endpoint"
-  it_should_behave_like "a resource with a PUT endpoint"
-  it_should_behave_like "a resource with a PUT endpoint that rejects invalid fields"
+    it_should_behave_like "a resource with a DELETE endpoint"
+    it_should_behave_like "a resource with a POST endpoint"
+    it_should_behave_like "a resource with a PUT endpoint"
+    it_should_behave_like "a resource with a PUT endpoint that rejects invalid fields"
 
-  describe "errors" do
-    before(:each) do
-      stub_request(:get,
-                  "http://localhost:2990/jira/rest/api/2/issue/10002").
-                  to_return(:status => 200, :body => get_mock_response('issue/10002.json'))
-      stub_request(:put, "http://localhost:2990/jira/rest/api/2/issue/10002").
-                  with(:body => '{"missing":"fields and update"}').
-                  to_return(:status => 400, :body => get_mock_response('issue/10002.put.missing_field_update.json'))
-    end
+    describe "errors" do
+      before(:each) do
+        stub_request(:get,
+                    site_url + "/jira/rest/api/2/issue/10002").
+                    to_return(:status => 200, :body => get_mock_response('issue/10002.json'))
+        stub_request(:put, site_url + "/jira/rest/api/2/issue/10002").
+                    with(:body => '{"missing":"fields and update"}').
+                    to_return(:status => 400, :body => get_mock_response('issue/10002.put.missing_field_update.json'))
+      end
+
+      it "fails to save when fields and update are missing" do
+        subject = client.Issue.build('id' => '10002')
+        subject.fetch
+        subject.save('missing' => 'fields and update').should be_false
+      end
 
-    it "fails to save when fields and update are missing" do
-      subject = client.Issue.build('id' => '10002')
-      subject.fetch
-      subject.save('missing' => 'fields and update').should be_false
     end
 
   end
-
 end

data/spec/integration/issuetype_spec.rb

@@ -2,26 +2,25 @@ require 'spec_helper'
 
 describe JIRA::Resource::Issuetype do
 
-  let(:client) do
-    client = JIRA::Client.new('foo', 'bar')
-    client.set_access_token('abc', '123')
-    client
-  end
+  with_each_client do |site_url, client|
+    let(:client) { client }
+    let(:site_url) { site_url }
 
-  let(:key) { "5" }
+    let(:key) { "5" }
 
-  let(:expected_attributes) do
-    {
-      'self' => "http://localhost:2990/jira/rest/api/2/issuetype/5",
-      'id' => key,
-      'name' => 'Sub-task'
-    }
-  end
+    let(:expected_attributes) do
+      {
+        'self' => "http://localhost:2990/jira/rest/api/2/issuetype/5",
+        'id' => key,
+        'name' => 'Sub-task'
+      }
+    end
 
-  let(:expected_collection_length) { 5 }
+    let(:expected_collection_length) { 5 }
 
-  it_should_behave_like "a resource"
-  it_should_behave_like "a resource with a collection GET endpoint"
-  it_should_behave_like "a resource with a singular GET endpoint"
+    it_should_behave_like "a resource"
+    it_should_behave_like "a resource with a collection GET endpoint"
+    it_should_behave_like "a resource with a singular GET endpoint"
 
+  end
 end

data/spec/integration/priority_spec.rb

@@ -2,26 +2,26 @@ require 'spec_helper'
 
 describe JIRA::Resource::Priority do
 
-  let(:client) do
-    client = JIRA::Client.new('foo', 'bar')
-    client.set_access_token('abc', '123')
-    client
-  end
+  with_each_client do |site_url, client|
+    let(:client) { client }
+    let(:site_url) { site_url }
 
-  let(:key) { "1" }
 
-  let(:expected_attributes) do
-    {
-      'self' => "http://localhost:2990/jira/rest/api/2/priority/1",
-      'id' => key,
-      'name' => 'Blocker'
-    }
-  end
+    let(:key) { "1" }
 
-  let(:expected_collection_length) { 5 }
+    let(:expected_attributes) do
+      {
+        'self' => "http://localhost:2990/jira/rest/api/2/priority/1",
+        'id' => key,
+        'name' => 'Blocker'
+      }
+    end
 
-  it_should_behave_like "a resource"
-  it_should_behave_like "a resource with a collection GET endpoint"
-  it_should_behave_like "a resource with a singular GET endpoint"
+    let(:expected_collection_length) { 5 }
 
+    it_should_behave_like "a resource"
+    it_should_behave_like "a resource with a collection GET endpoint"
+    it_should_behave_like "a resource with a singular GET endpoint"
+
+  end
 end